Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2009-11-25 | Fix crash due to uninitialized pointer (not a problem in 3.4.x or below). | Jeremy Allison | 1 | -2/+1 | |
Jeremy. | |||||
2009-11-25 | s3 setfileinfo: Open with FILE_WRITE_DATA when setting the file size | Tim Prouty | 1 | -1/+1 | |
This matches what is outlined here: http://msdn.microsoft.com/en-us/library/ms804363.aspx This is also inline with how winXP/win7 handle this. See RAW-SFILEINFO-END-OF-FILE* in smbtorture4. | |||||
2009-11-24 | Remove call into reduce_name if case sensitive. This allows us to pass | Jeremy Allison | 1 | -2/+1 | |
RAW-CHKPATH when case sensitive = yes, but isn't the correct way to do it. I'm testing a larger patch to smbd/filename.c that should fix this correctly, and will add a torture test to ensure RAW-CHKPATH is run against a case sensitive share once this is done. Jeremy. | |||||
2009-11-24 | Allow us to pass RAW-CHKPATH with FILE_FLAG_POSIX_SEMANTICS set or with | Jeremy Allison | 2 | -4/+13 | |
wide links = no. Jeremy. | |||||
2009-11-24 | Fix make test. Only do POSIX case conversion if FILE_FLAG_POSIX_SEMANTICS ↵ | Jeremy Allison | 1 | -8/+12 | |
set. Doh ! Jeremy. | |||||
2009-11-23 | Restore NtCreateX case handling with FILE_FLAG_POSIX_SEMANTICS to the way | Jeremy Allison | 1 | -5/+68 | |
it worked in 3.3.x and 3.2.x. UCF_POSIX_PATHNAMES may no longer be needed, as lp_posix_pathnames() being set isn't the same as case handling from NtCreateX (lp_posix_pathnames() changes the STAT calls to LSTAT, not the case semantics). Jeremy. | |||||
2009-11-23 | Remove unused code. | Jeremy Allison | 1 | -46/+0 | |
Jeremy. | |||||
2009-11-23 | Proper fix for #6898 - Samba duplicates file content on appending. Pointed ↵ | Jeremy Allison | 2 | -13/+20 | |
out by Volker.Restores the pathname handling for FILE_FLAG_POSIX_SEMANTICS but still prevents the O_APPEND problems. Jeremy. | |||||
2009-11-23 | Fix bug #6898 - Samba duplicates file content on appending | Jeremy Allison | 1 | -0/+10 | |
Clients using a Windows open call should not be able to set FILE_FLAG_POSIX_SEMANTICS in an open. Jeremy. | |||||
2009-11-23 | Revert "s3: Make the implicit reference to Protocol in mask_match() explicit" | Volker Lendecke | 2 | -6/+4 | |
This reverts commit e23d8a3d1f558a7e98ef2afd71e1d15c5b3a71bc. | |||||
2009-11-23 | Revert "s3: Make the implicit reference to Protocol in is_in_path() explicit" | Volker Lendecke | 5 | -13/+7 | |
This reverts commit f7b4151a64d8c6851e62255a7139fd00a5fc63a3. | |||||
2009-11-23 | Revert "s3: Make the implicit reference to get_Protocol in lp_use_sendfile() ↵ | Volker Lendecke | 1 | -4/+2 | |
explicit" This reverts commit 6a149022976fe6a5579ec9afc7a4d2dcb44dc8af. | |||||
2009-11-23 | Revert "s3: Move the global variable Protocol to struct smbd_server_connection" | Volker Lendecke | 13 | -59/+35 | |
This reverts commit c85a4c9ba4a7de65a7850f6f9708df66bd24deea. | |||||
2009-11-23 | s3: Move a variable declaration to its only use | Volker Lendecke | 1 | -1/+1 | |
2009-11-23 | s3-printing: use spoolss types and structs while getting and deleting drivers. | Günther Deschner | 1 | -33/+28 | |
Guenther | |||||
2009-11-21 | s3: Move the global variable Protocol to struct smbd_server_connection | Volker Lendecke | 13 | -35/+59 | |
2009-11-21 | s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit | Volker Lendecke | 1 | -2/+4 | |
2009-11-21 | s3: Make the implicit reference to Protocol in is_in_path() explicit | Volker Lendecke | 5 | -7/+13 | |
2009-11-21 | s3: Make the implicit reference to Protocol in mask_match() explicit | Volker Lendecke | 2 | -4/+6 | |
2009-11-21 | s3: Tune if-conditions in a very hot codepath | Volker Lendecke | 1 | -1/+1 | |
This looks innocent, but it is visible in a netbench run. Due to boolean short-circuiting we don't have to execute the conditions on the right-hand side of the &&. So putting the less likely condition left gains a bit. | |||||
2009-11-20 | Fix logic bug where high bits tests was being | Jeremy Allison | 1 | -1/+1 | |
done on both Windows and POSIX mkdirs instead of only on Windows mkdir (as intended). The variable "file_attributes" had already had FILE_FLAG_POSIX_SEMANTICS removed above in the function if it had already been set. Jeremy. | |||||
2009-11-18 | s3: Replace some create_synthetic_smb_fname() calls | Volker Lendecke | 6 | -104/+56 | |
In very hot codepaths like the statcache copy_smb_filename and the subsequent recursive talloc_free is noticable in the CPU load. | |||||
2009-11-18 | s3: Do not talloc in readdir | Volker Lendecke | 5 | -105/+145 | |
This is a hot codepath (called from the stat cache) | |||||
2009-11-17 | Start removing SMB_STRUCT_STAT variables except for | Jeremy Allison | 1 | -15/+13 | |
the directory enumeration code (which needs it). Jeremy. | |||||
2009-11-17 | Remove "store create time" code, cause create time to be stored | Jeremy Allison | 6 | -139/+188 | |
in the "user.DOSATTRIB" EA. From the docs: In Samba 3.5.0 and above the "user.DOSATTRIB" extended attribute has been extended to store the create time for a file as well as the DOS attributes. This is done in a backwards compatible way so files created by Samba 3.5.0 and above can still have the DOS attribute read from this extended attribute by earlier versions of Samba, but they will not be able to read the create time stored there. Storing the create time separately from the normal filesystem meta-data allows Samba to faithfully reproduce NTFS semantics on top of a POSIX filesystem. Passes make test but will need more testing. Jeremy. | |||||
2009-11-16 | Don't overwrite a dynamic pointer with the address of a stack | Jeremy Allison | 2 | -16/+11 | |
variable. Jeremy. | |||||
2009-11-12 | Fix bug 6891 - using windows explorer to change ownership on a folder fails ↵ | Jeremy Allison | 1 | -1/+11 | |
with Bad File Descriptor. Jeremy. | |||||
2009-11-12 | s3: Fix debug messages in check_reduced_name | Volker Lendecke | 1 | -13/+24 | |
2009-11-11 | Fix bug 6878 - Cannot change ACL's inherit flag. | Jeremy Allison | 1 | -44/+108 | |
Based on a patch submitted by Tsukasa Hamano <hamano@osstech.co.jp>, this is a change in the POSIX ACL mapping to deal with the lossy mapping for directory ACE entries: We have a lossy mapping: directory ACE entries CREATOR_OWNER ------\ (map to) +---> SMB_ACL_USER_OBJ owning sid ------/ CREATOR_GROUP ------\ (map to) +---> SMB_ACL_GROUP_OBJ primary group sid --/ on set. And on read of a directory ACL SMB_ACL_USER_OBJ ----> CREATOR_OWNER SMB_ACL_GROUP_OBJ ---> CREATOR_GROUP. Deal with this on set by duplicating owning sid and primary group sid ACE entries into the directory ACL. Jeremy. | |||||
2009-11-10 | s3-chgpasswd: split out a check_password_complexity() function. | Günther Deschner | 1 | -22/+42 | |
Guenther | |||||
2009-11-06 | Fix bug 6841 - "map acl inherit = yes" not working. | Jeremy Allison | 1 | -8/+29 | |
The code to read the new V2 SAMBA_PAI entries had two errors. Jeremy. | |||||
2009-11-05 | Got the logic simplification worked out so we still pass | Jeremy Allison | 4 | -30/+45 | |
BASE-DELAYWRITE and also RAW-CLOSE. Jeremy. | |||||
2009-11-05 | Revert commit "0551284dc08eb93ef7b2b2227a45e5ec21d482fb" - simplify | Jeremy Allison | 3 | -11/+31 | |
the logic. This was incorrect (I'll revisit this tomorrow). Jeremy. | |||||
2009-11-05 | Simplify the logic - remove extraneous argument and calls to ↵ | Jeremy Allison | 3 | -31/+11 | |
set_close_write_time(). We were treating a file time set on close as a sticky write time set, and I don't think it is. I will add a torture test later to RAW-CLOSE to confirm this. Jeremy. | |||||
2009-11-05 | Fix explicit set of write time on close. | Jeremy Allison | 1 | -1/+5 | |
Jeremy. | |||||
2009-11-05 | Get closer to an accurate model of Windows timestamp changes. | Jeremy Allison | 5 | -30/+53 | |
"Normal" non truncate writes always cause the timestamp to be set on close. Once a close is done on a handle this can reset the sticky write time to current time also. Updated smbtorture4 confirms this. Jeremy. | |||||
2009-11-05 | s3: Fix a crash in notify_remove_onelevel when "change notify = no" | Volker Lendecke | 1 | -0/+4 | |
2009-11-05 | s3: Fix the talloc hierarchy in notify_remove_onelevel | Volker Lendecke | 1 | -1/+1 | |
We want to free the record early, not when talloc_tos() is free'ed. | |||||
2009-11-04 | Fix debug comment (brain wasn't working...). | Jeremy Allison | 1 | -2/+2 | |
Jeremy. | |||||
2009-11-04 | Filter the returned DOS attributes by 0xFF for clients | Jeremy Allison | 1 | -0/+12 | |
using older protocols (LANMAN2 or below). Jeremy. | |||||
2009-11-04 | Remove "Protocol" as an extern, and add accessor functions. | Jeremy Allison | 6 | -27/+17 | |
Jeremy. | |||||
2009-11-03 | Fix debug statements to use correct function name. | Jeremy Allison | 1 | -13/+13 | |
Jeremy. | |||||
2009-11-03 | requires_resume_key is a bool not int. | Jeremy Allison | 1 | -7/+2 | |
Jeremy. | |||||
2009-11-03 | Fix more of the RAW-SEARCH test. Older info levels are | Jeremy Allison | 1 | -2/+9 | |
not 4 byte aligned (levels 1 - 3). Jeremy. | |||||
2009-11-03 | s3: Remove debug_ctx() | Volker Lendecke | 4 | -13/+13 | |
smbd just crashed on me: In a debug message I called a routine preparing a string that itself used debug_ctx. The outer routine also used it after the inner routine had returned. It was still referencing the talloc context that the outer debug_ctx() had given us, which the inner DEBUG had already freed. | |||||
2009-11-02 | Fix bug 6867 - trans2findnext returns reply_nterror(req, ntstatus) In a ↵ | Jeremy Allison | 1 | -12/+16 | |
directory with a lot of files. Jeremy. | |||||
2009-10-29 | Start fixing the RAW-STREAMS test - ensure that the xattr | Jeremy Allison | 1 | -0/+1 | |
used to store the stream info in streams_depot.so is not seen in when enumerating EAs. Jeremy. | |||||
2009-10-26 | Second part of the fix for bug 6828 - infinite timeout occurs when byte lock ↵ | Jeremy Allison | 1 | -6/+9 | |
held outside of samba. Fixes case where a connection with a pending lock can me marked "idle", and ensures that the lock queue timeout is always recalculated. Jeremy. | |||||
2009-10-20 | Fix bug 6828 - infinite timeout occurs when byte lock held outside of samba | Jeremy Allison | 1 | -8/+18 | |
Jeremy. | |||||
2009-10-13 | Remove use of "int ret" when we already have errcode. | Jeremy Allison | 1 | -13/+8 | |
Jeremy. |