summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2011-07-08Fix bug #8293 - SMB2 doesn't rotate the log files often enough.Jeremy Allison3-3/+21
Move the num_requests field out of the smb1 struct into the generic struct smbd_server_connection struct. Use it to count SMB2 requests as well as SMB1 and ensure that check_log_size() is called every 50 SMB2 requests. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Jul 8 01:14:53 CEST 2011 on sn-devel-104
2011-07-07s3:smb2_server: call change_to_root_user() or smbd_smb2_request_check_tcon()Stefan Metzmacher1-3/+26
For all requests which don't operate on a tcon, we should call change_to_root_user(), to match the SMB1 behavior. For SMB1 we do the following operations without AS_USER: /* 0x70 */ { "SMBtcon",reply_tcon,0}, /* 0x71 */ { "SMBtdis",reply_tdis,DO_CHDIR}, /* 0x72 */ { "SMBnegprot",reply_negprot,0}, /* 0x73 */ { "SMBsesssetupX",reply_sesssetup_and_X,0}, /* 0x74 */ { "SMBulogoffX",reply_ulogoffX, 0}, /* ulogoff doesn't give a valid TID */ /* 0x75 */ { "SMBtconX",reply_tcon_and_X,0}, ... /* 0x2b */ { "SMBecho",reply_echo,0}, ... /* 0xa4 */ { "SMBntcancel",reply_ntcancel, 0 }, For SMB2tdis we still call smbd_smb2_request_check_tcon() as close_cnum() calls change_to_root_user() when needed. metze Signed-off-by: Jeremy Allison <jra@samba.org>
2011-07-05s3:smbd fix a compile warning on AIX 5.3Christian Ambach1-1/+1
use the correct alias instead of FD directly Autobuild-User: Christian Ambach <ambi@samba.org> Autobuild-Date: Tue Jul 5 19:51:42 CEST 2011 on sn-devel-104
2011-07-05s3: Fix bug 8102Volker Lendecke1-0/+8
We can't allow open with access that has been denied via the share security descriptor Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Tue Jul 5 16:21:54 CEST 2011 on sn-devel-104
2011-07-05s3: Calculate&store the maximum share access maskVolker Lendecke1-22/+15
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-05s3: Return "granted" from share_access_checkVolker Lendecke2-10/+14
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-04s3:smb2 fix smbd crash on premature end of smb2 conn (Bug 8286)Christian Ambach1-3/+3
when smbd tries to clean up locks after a premature end of a smb2 connection, lock_db has already been freed and so it crashes this patch changes the order in which items are freed so that lock_db is still around when it is needed Jeremy, Metze, please check Autobuild-User: Christian Ambach <ambi@samba.org> Autobuild-Date: Mon Jul 4 20:00:26 CEST 2011 on sn-devel-104
2011-07-04s3:smb2_server: there's no reason to check the session id twice on a ↵Stefan Metzmacher1-5/+0
smb2_tcon request metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Mon Jul 4 17:34:13 CEST 2011 on sn-devel-104
2011-07-04s3:smb2_create: call 'return' after smbd_server_connection_terminate()Stefan Metzmacher1-0/+1
This is not strictly needed in the fork process model, but we hopefully support other models in future. metze
2011-07-04s3-lib Move event_add_idle() to source3/lib/events.cAndrew Bartlett2-87/+0
This allows libauth not to depend on smbd_base. Andrew Bartlett
2011-07-04s3-smbd: Remove client_address from smbd_server_connection struct.Andreas Schneider1-1/+0
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-smbd: Remove obsolete smbd_set_server_fd().Andreas Schneider2-36/+6
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-smbd: Replace client_id in smbd session setup.Andreas Schneider2-2/+3
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-smbd: Replace client_id in smbd session.Andreas Schneider1-7/+9
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-smbd: Replace client_id in smbd service.Andreas Schneider1-6/+21
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-smbd: Replace client_id in smbd reply.Andreas Schneider1-1/+10
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-smbd: Exit cleanly if we can't create an address string.Andreas Schneider1-1/+3
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-smbd: Replace client_id in smbd connection.Andreas Schneider1-1/+9
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-smbd: Replace client_id in smbd process.Andreas Schneider2-6/+33
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-auth: Pass the remote_address down to user_info.Andreas Schneider2-8/+20
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-auth: Added remote_address to ntlmssp server.Andreas Schneider3-17/+51
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04s3-rpc_server: Migrate rpc function to tsocket_address.Andreas Schneider3-20/+19
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-06-30s3:smbd do not panic when CTDB is unhealthy (Bug #8278)Christian Ambach1-0/+9
when CTDB is unhealthy, log a message and exit cleanly instead of creating a core file Autobuild-User: Christian Ambach <ambi@samba.org> Autobuild-Date: Thu Jun 30 13:18:12 CEST 2011 on sn-devel-104
2011-06-29Second part of fix for bug #8219 - SMB Panic from Windows 7 Client.Jeremy Allison1-1/+1
Pass in the correct vector to the signing algorithm in an async response - we must start with vector[1] which has the SMB2_HDR_BODY length, not vector[0] which is the 4 byte packet length. Also note we're passing in 2 vectors not 3. Metze please review. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Jun 29 20:09:21 CEST 2011 on sn-devel-104
2011-06-29param: Merge param headers into lib/param/loadparm.hAndrew Bartlett4-0/+4
This defines a common table format, so we can in future define a common table. Andrew Bartlett
2011-06-29Fix bug #8219 - SMB Panic from Windows 7 ClientJeremy Allison1-0/+8
Caused by referencing an uninitialized variable in the duplicated struct smbd_smb2_request when sending a signed intermediate reply. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Jun 29 04:37:28 CEST 2011 on sn-devel-104
2011-06-28s3-smbd Remove set but unused variablesAndrew Bartlett1-9/+0
Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Tue Jun 28 10:43:26 CEST 2011 on sn-devel-104
2011-06-24s3:smb2_ioctl/FSCTL_PIPE_TRANSCEIVE: generate STATUS_BUFFER_OVERFLOW if ↵Stefan Metzmacher2-0/+10
needed (bug #8260) This should fix DCERPC responses with fragments larger than 1024 bytes. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Jun 24 11:25:36 CEST 2011 on sn-devel-104
2011-06-24Fix bug #8254 - "acl check permissions = no" does not work in all casesJeremy Allison2-2/+16
Move lp_acl_check_permissions() into can_delete_file_in_directory() where it makes sense. Remove ACL check when requesting DELETE_ACCESS when lp_acl_check_permissions is false. Thanks to John Janosik @ IBM for noticing this. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Jun 24 01:18:11 CEST 2011 on sn-devel-104
2011-06-23s3-param Remove 'announce version' parameterAndrew Bartlett1-2/+2
The only users I can find of this on the internet involve confused users, and our own documentation recommends never setting this. Don't confuse our users any longer. Andrew Bartlett
2011-06-21s3-build: Provide a run-time shim to work around duplicate symbolsAndrew Bartlett7-12/+42
The become_root() and similar 'smbd' functions that are used widely in Samba libraries had 'dummy' copies in dummysmbd.c and dummyroot.c. These have been replaced by a runtime plugin mechanim, which ensures that standlone binaries still do nothing, while in smbd the correct function is used. This avoids having these as duplicate symbols in the smbd binary, which can cause unpredictable behaviour. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-06-20tdb_compat: Higher level API fixes.Rusty Russell1-1/+1
My previous patches fixed up all direct TDB callers, but there are a few utility functions and the db_context functions which are still using the old -1 / 0 return codes. It's clearer to fix up all the callers of these too, so everywhere is consistent: non-zero means an error. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20tdb_compat: use tdb_open_compat.Rusty Russell1-0/+5
This is a helper for the common case of opening a tdb with a logging function, but it doesn't do all the work, since TDB1 and TDB2's log functions are different types. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20ldb: replace 'struct TDB_DATA' with 'TDB_DATA'Rusty Russell2-1/+6
The typedef is TDB2 compatible, the struct isn't. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20tdb_traverse/tdb_traverse_read: check returns for negative, not -1.Rusty Russell2-2/+2
TDB2 returns a negative error number on failure. This is compatible if we always check for < 0 instead of == -1. Also, there's no tdb_traverse_read in TDB2: we don't try to make traverse reliable any more, so there are no write locks anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20tdb_compat.h: divert every tdb build and includes to tdb_compatRusty Russell2-2/+2
We change all the headers and wscript files to use tdb_compat; this means we have one place to decide whether to use TDB1 or TDB2. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20source3/smdb/files.c: file_name_hash to use Jenkins hash from CCAN.Rusty Russell1-3/+2
Rather than tdb's internal one.
2011-06-19s3: Fix Coverity ID 2582: FORWARD_NULLVolker Lendecke1-0/+5
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Jun 19 20:46:43 CEST 2011 on sn-devel-104
2011-06-14s3: Fix connecting to ctdb as non-rootVolker Lendecke1-0/+7
This is at least one instance which I could identify Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue Jun 14 19:06:39 CEST 2011 on sn-devel-104
2011-06-14s3: Fix count_current_connectionsVolker Lendecke1-2/+4
"False" is not really a valid return value for "int"..
2011-06-14s3:smbd/quotas: add #include "system/filesys.h" (bug #8224)Stefan Metzmacher1-0/+1
This should fix the build on FreeBSD metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Tue Jun 14 09:38:49 CEST 2011 on sn-devel-104
2011-06-09s3-param Remove special case for global_myname(), rename to lp_netbios_name()Andrew Bartlett7-13/+13
There is no reason this can't be a normal constant string in the loadparm system, now that we have lp_set_cmdline() to handle overrides correctly. Andrew Bartlett
2011-06-09lib/util Bring procid_str() into lib/util as server_id_string()Andrew Bartlett2-6/+6
This is needed for OpenChange, which prints Samba struct server_id values in debug messages. Andrew Bartlett
2011-06-09s3-talloc Change TALLOC_MEMDUP() to talloc_memdup()Andrew Bartlett2-2/+2
Using the standard macro makes it easier to move code into common, as TALLOC_MEMDUP isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_ZERO_ARRAY() to talloc_zero_array()Andrew Bartlett3-3/+3
Using the standard macro makes it easier to move code into common, as TALLOC_ZERO_ARRAY isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_ZERO_P() to talloc_zero()Andrew Bartlett14-25/+25
Using the standard macro makes it easier to move code into common, as TALLOC_ZERO_P isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_P() to talloc()Andrew Bartlett10-14/+14
Using the standard macro makes it easier to move code into common, as TALLOC_P isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_ARRAY() to talloc_array()Andrew Bartlett7-15/+15
Using the standard macro makes it easier to move code into common, as TALLOC_ARRAY isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_REALLOC_ARRAY() to talloc_realloc()Andrew Bartlett9-14/+14
Using the standard macro makes it easier to move code into common, as TALLOC_REALLOC_ARRAY isn't standard talloc. Andrew Bartlett
2011-06-09Ensure when creating a directory, if we make any changes due to inheritance ↵Jeremy Allison1-0/+12
parameters, we update the stat returned. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Jun 9 00:46:39 CEST 2011 on sn-devel-104