Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2010-09-28 | s3: Attempt to fix bug 7518 | Volker Lendecke | 1 | -6/+6 | |
If select returns -1, we can't rely on the fd sets. The current code might loop endlessly because when putting an invalid fd (the closed socket?) on the read set, a select implementation might choose not to touch it but directly return with EINVAL. Thus run_events will see the socket readable, which leads to a "return true", and thus a NT_STATUS_RETRY -> same game again. We should never get into this situation, but to me the logfiles given in bug 7518 do not reveal enough information to understand how this can happen. | |||||
2010-09-28 | s3: Increase the debuglevel for connection termination msgs | Volker Lendecke | 1 | -2/+2 | |
2010-09-28 | s3: Lift smbd_messaging_context() from open_sockets_smbd() | Volker Lendecke | 1 | -16/+14 | |
2010-09-28 | s3: Remove two calls to procid_self() | Volker Lendecke | 1 | -2/+4 | |
2010-09-28 | s3: Remove some remaining files.c globals to sconn | Volker Lendecke | 3 | -53/+49 | |
2010-09-28 | s3: Remove talloc_autofree_context() from files.c | Volker Lendecke | 2 | -6/+9 | |
2010-09-28 | s3: Lift smbd_server_conn from file_find_fd | Volker Lendecke | 2 | -4/+4 | |
2010-09-28 | s3: Remove smbd_server_conn from file_fsp | Volker Lendecke | 1 | -1/+1 | |
2010-09-28 | s3: Slightly simplify file_fnum | Volker Lendecke | 1 | -2/+15 | |
req==NULL should never happen, see the comment | |||||
2010-09-28 | s3: Remove smbd_server_conn from file_sync_all | Volker Lendecke | 1 | -1/+1 | |
2010-09-28 | s3: Remove smbd_server_conn from file_find_subpath | Volker Lendecke | 1 | -1/+1 | |
2010-09-28 | s3: Lift smbd_server_conn from file_find_di_first | Volker Lendecke | 4 | -8/+11 | |
2010-09-28 | s3: Lift smbd_server_conn from file_find_dif | Volker Lendecke | 4 | -6/+7 | |
2010-09-28 | s3: Remove smbd_server_conn from files_forall | Volker Lendecke | 2 | -6/+6 | |
2010-09-28 | s3: Remove smbd_server_conn from file_close_user | Volker Lendecke | 2 | -3/+3 | |
2010-09-28 | s3: Remove smbd_server_conn from file_close_pid | Volker Lendecke | 2 | -3/+4 | |
2010-09-28 | s3: Remove smbd_server_conn from file_close_conn | Volker Lendecke | 1 | -1/+1 | |
2010-09-28 | s3: Remove smbd_server_conn from file_new and file_free | Volker Lendecke | 1 | -2/+2 | |
2010-09-28 | s3: Lift smbd_server_conn from file_fnum | Volker Lendecke | 1 | -4/+5 | |
2010-09-28 | s3: Move "Files" to smbd_server_connection | Volker Lendecke | 3 | -17/+16 | |
2010-09-28 | s3: Remove "server_fd" global variable | Volker Lendecke | 3 | -9/+4 | |
2010-09-27 | Small tweak to bugfix for 7698 - Assert causes smbd to panic on invalid ↵ | Jeremy Allison | 1 | -3/+3 | |
NetBIOS session request. Don't just fail to reply on a bad NBT name, just don't do the internal action. Jeremy. | |||||
2010-09-27 | Change to using TDB_INCOMPATIBLE_HASH (the jenkins hash) on all | Jeremy Allison | 1 | -4/+4 | |
TDB_CLEAR_IF_FIRST tdb's. For tdb's like gencache where we open without CLEAR_IF_FIRST and then with CLEAR_IF_FIRST if corrupt this is still safe to use as if opening an existing tdb the new hash will be ignored - it's only used on creating a new tdb not opening an old one. Jeremy. | |||||
2010-09-27 | s3: Make file_fnum static | Volker Lendecke | 1 | -1/+1 | |
2010-09-27 | s3: Remove some unused code | Volker Lendecke | 1 | -50/+0 | |
2010-09-27 | s3: Fix some comments | Volker Lendecke | 1 | -2/+2 | |
2010-09-26 | s3: Remove talloc_autofree_context() from notify_internal_parent_init() | Volker Lendecke | 2 | -5/+4 | |
2010-09-26 | Fix bug #7698 - Assert causes smbd to panic on invalid NetBIOS session request. | Jeremy Allison | 2 | -12/+31 | |
Found by the CodeNomicon test suites at the SNIA plugfest. http://www.codenomicon.com/ If an invalid NetBIOS session request is received the code in name_len() in libsmb/nmblib.c can hit an assert. Re-write name_len() and name_extract() to use "buf/len" pairs and always limit reads. Jeremy. | |||||
2010-09-26 | s3: Remove talloc_autofree_context() from change_to_guest() | Volker Lendecke | 1 | -1/+1 | |
pass is freed at the exit of this routine | |||||
2010-09-26 | s3: Remove talloc_autofree_context() from serverid_parent_init() | Volker Lendecke | 1 | -1/+1 | |
2010-09-26 | s3: Remove talloc_autofree_context() from messaging_tdb_parent_init() | Volker Lendecke | 1 | -1/+1 | |
2010-09-26 | s3: Avoid an explicit ZERO_STRUCT | Volker Lendecke | 1 | -3/+1 | |
2010-09-26 | s3: Lift talloc_autofree_context() from make_auth_context_fixed() | Volker Lendecke | 1 | -2/+2 | |
2010-09-26 | s3: Lift talloc_autofree_context() from make_auth_context_subsystem() | Volker Lendecke | 2 | -2/+2 | |
2010-09-23 | Fix bug 7694 - Crash bug with invalid SPNEGO token. | Jeremy Allison | 1 | -1/+2 | |
Found by the CodeNomicon test suites at the SNIA plugfest. http://www.codenomicon.com/ If an invalid SPNEGO packet contains no OIDs we crash in the SMB1/SMB2 server as we indirect the first returned value OIDs[0], which is returned as NULL. Jeremy. | |||||
2010-09-22 | Thank goodness for code reviews. Volker caught - this should be ↵ | Jeremy Allison | 1 | -1/+1 | |
lp_posix_pathnames() not lp_unix_extensions(). Jeremy. | |||||
2010-09-22 | Fix bug #7693 - smbd changing mode of files on rename | Jeremy Allison | 2 | -8/+10 | |
When using "map archive", don't change the archive bit on renames or writes with UNIX extensions turned on. Jeremy. | |||||
2010-09-21 | s3:registry: move prototype from reg_init_full.c to its own header. | Michael Adam | 1 | -0/+1 | |
2010-09-20 | s3-util_sid: use shared dom_sid_compare_auth and dom_sid_equal_X functions. | Günther Deschner | 1 | -17/+18 | |
Guenther | |||||
2010-09-20 | s3-build: only include ctdbd_conn.h where needed. | Günther Deschner | 2 | -0/+2 | |
Guenther | |||||
2010-09-20 | s3-build: only include async headers where needed. | Günther Deschner | 1 | -0/+1 | |
Guenther | |||||
2010-09-16 | libcli/auth/ntlmssp Be clear about talloc parents for session keys | Andrew Bartlett | 1 | -0/+1 | |
The previous API was not clear as to who owned the returned session key. This fixes a valgrind-found use-after-free in the NTLMSSP key derivation code, and avoids making allocations - we steal and zero instead. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org> | |||||
2010-09-15 | Fix all sid_parse returns to be checked. Tidy up some checks and error | Jeremy Allison | 1 | -5/+12 | |
messages. Jeremy. | |||||
2010-09-16 | s3-smbd: prevent call_nt_transact_ioctl() crash in FSCTL_FIND_FILES_BY_SID case. | Günther Deschner | 1 | -1/+4 | |
Jeremy, please check. Guenther | |||||
2010-09-15 | Add check for invalid data size. | Jeremy Allison | 1 | -1/+8 | |
Jeremy. | |||||
2010-09-15 | s3-rpc_server: Moved ncacn_np declarations in common header file. | Simo Sorce | 2 | -0/+2 | |
Signed-off-by: Andreas Schneider <asn@samba.org> | |||||
2010-09-15 | s3-rpc_server: Convert rpc_connect_spoolss_pipe into a generic interface. | Simo Sorce | 2 | -10/+60 | |
This way we have one common way to open internal pipes whether they are shortcircuited or piped to an external process. | |||||
2010-09-13 | Fix bug 7409 - Thousands of reduce_name: couldn't get realpath. | Jeremy Allison | 1 | -1/+1 | |
Don't log this at level 1 - every EACCES will generate one. Thanks to muehlfeld@medizinische-genetik.de for pointing this out. Jeremy. | |||||
2010-09-11 | s3-privs Convert from user_has_privileges() -> security_token_has_privilege() | Andrew Bartlett | 1 | -4/+2 | |
This new call is available in the merged privileges code, and takes an enum as the parameter, rather than a bitmask. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org> | |||||
2010-09-11 | s3:auth Remove NT_USER_TOKEN | Andrew Bartlett | 4 | -4/+4 | |
The all UPPER case typedef is no longer the preferred Samba style and this makes it easier to see that this is the IDL-derivied structure Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org> |