Age | Commit message (Collapse) | Author | Files | Lines |
|
The really pure bugfix would have replaced pparam by *pparam, but we pulled
the fid anyway.
Metze, in line 2421 the FSP_BELONGS_CONN is commented out, is that intended?
The FSCTL_CREATE_OR_GET_OBJECT_ID ioctl did not have it.
Volker
(This used to be commit 2c1376225b98a9325dfc2d00bad1722e63cf522b)
|
|
----------------------------------------------------------
In rare cases, Samba 3.0.25b shows directory contents at the wrong
position in the file tree when displaying a subdirectory of a DFS link.
The problem occurs whenever Windows XP asks for a DFS referral for a
subdirectory of a DFS link with a trailing backslash.
Windows does not do this very often, but we saw it several times per day
on our central DFS server.
smbd/msdfs.c, dfs_path_lookup() does the following with the requested
path:
- in line 390, the local copy 'localpath' is 'unix_convert'ed; the
trailing backslash is removed inside unix_convert
- in lines 417-20, 'dfspath' (another copy of the requested path) is
mangled another way without removing trailing backslashes
That's why the following loop (lines 435-461) that is meant to
synchronously cut off the last path component from both strings until it
comes to a DFS link, does not handle both strings the same. When the
original path ended with a backslash, 'canon_dfspath' has always one
component more than 'localpath', so that *consumedcntp gets too big in
line 446. This value is reported to the client.
----------------------------------------------------------
Bug #4860.
Jeremy.
(This used to be commit 42d1c6713a56197ca8dfebf74eb0d483102148f7)
|
|
Remove reply_prep/post_legacy from send_trans_replies
(This used to be commit c08366f840ead5aba7199cf0b058587055b4d98e)
|
|
(This used to be commit b01664b43b0bd94bb59dec57480d2be954a7298a)
|
|
(This used to be commit 160f65946af9b3e1609b0efb211edc81514fb36f)
|
|
(This used to be commit 8702450e91943b1097ae3c8979d60b6962a69632)
|
|
(This used to be commit 0bb95639d6b49b18f2a7f1131f54239355097119)
|
|
(This used to be commit e2a96497928ab959e36639fef2d493640bb6e951)
|
|
(This used to be commit a6a2d97facf95c7997f3d12457f2811b3b7bde1b)
|
|
(This used to be commit f0598b3ca0ee04e31855c3e54f3198e6fd968737)
|
|
(This used to be commit b38f9347e81364d224e5ca00609099a74410e99c)
|
|
(This used to be commit 06d0c74b74754c55f4c8ef0899bda08476e7dd4b)
|
|
(This used to be commit 040d6d5db6d929f1612b1b0dc762b7f55c956740)
|
|
(This used to be commit dc27c3c668f86d008c27b8a749f5726287ba54a5)
|
|
(This used to be commit 511f8bc030a9a16c2e793ce5d06577608e101de4)
|
|
(This used to be commit 74ae19cca6dd15b65deffbf464cfd0e485da8611)
|
|
The last checkin was for reply_trans, not reply_transs
(This used to be commit 50a2bfd9e04d51aa5e3ae9d6620a98eeb158b6ea)
|
|
(This used to be commit 39a7809aa4c34bb26178589245c419df44796e22)
|
|
(This used to be commit f843c02f0794964eba02ab983f9c0701801f415c)
|
|
(This used to be commit fc8759e63ccec7f1cfb9f1d0ecd0f19a496e4153)
|
|
(This used to be commit 4863ff2899419e791ed0e340821072d004fb1d17)
|
|
Panisset <panisset@A52.com>.
Awaiting confirmation from reporter.
Jeremy.
(This used to be commit 7bd65060bd965bd17a5d79639cf561b8b578cb36)
|
|
This changes send_trans2_replies to not depend on large buffers anymore
and finishes the trans2 conversion.
(This used to be commit b1d133e4ffa8c9b8219ba6e7b83e23ca4bdd1616)
|
|
(This used to be commit 47261fb6fecc036cb1605f46bbe24e9b3661ff8c)
|
|
reply_transs2
(This used to be commit ca26b43e02f25d75e7439c6130f32dc322acd327)
|
|
Fake a struct smb_request here.
Volker
(This used to be commit f712d1c92bee024a165b5facabdac1e2c866d9b1)
|
|
(This used to be commit a55a4d71ffe9ff1395e02f8bb3ad88fe5132fe99)
|
|
(This used to be commit a9c2d75b42be8b0d89ed1e1a2ce2c6ab4284f5ea)
|
|
(This used to be commit e0a708c79b4db4aab84022d568b5e7bf519e4b5a)
|
|
(This used to be commit 8eb016a91e3ec8d1d9d5ae1ec6f92e1e0657d593)
|
|
This *might* break the transport encryption stuff. I need to check that.
(This used to be commit 82b34d7bdbe5c5038810c11540b6b7bc04290653)
|
|
(This used to be commit db4e6781c4d1a9755a3ec45556be8dd935f15bae)
|
|
(This used to be commit 642c58648b2468544e9488cbffe1a8b236949bcc)
|
|
(This used to be commit cdd86497b9830ba5fbc5b4511ed39ca44167faab)
|
|
(This used to be commit 50aa149cefc1da587f110eb0bf0344c737500f5b)
|
|
(This used to be commit 09ed6537b39f72e61043a93fadea33562b07c6c6)
|
|
(This used to be commit a13c42be7548fc0de3e1f6f1eaacbad3046af0d0)
|
|
(This used to be commit 34a00d8aa9af167c65baf7fc24de3c8e192f5ec0)
|
|
In a function returning void the "return;" needs to stand alone on some
compilers
(This used to be commit 28affcca8e22b9a147876a60fec28551256bcaa8)
|
|
(This used to be commit 0b84e29120b87bf6fc86df10102f1c4d4f98cdb6)
|
|
(This used to be commit c9c0133d5512e68fcaf22b2abd3343ae944ddb9d)
|
|
(This used to be commit a3d77a576f863c4d9f95a1a898f70ae5b5bbc471)
|
|
(This used to be commit 46d9c51631d099af0f8696d3942eb51b0cb09865)
|
|
(This used to be commit d0b7f409e1ec88bcd695474aa77e75cb50dce013)
|
|
(This used to be commit af1855e4cebb6df3415ca5389b10aaa5a956adc2)
|
|
(This used to be commit 238edebab71ed1596af82f4c8611432f9156bd18)
|
|
It did not use inbuf anyway. Outbuf was used for alignment and to the
flags2. The alignment works ok if we align relative to base_data because this
and outbuf are both malloc'ed, and we put send_trans2_replies aligns out_data
properly relative to the start of the outbuf.
I don't know if the explicit align_string() calls in get_lanman2_dir_entry are
really necessary. I think that srvstr_push also does the same.
Please also note that this changes dst_len in srvstr_push from -1 to the real
length remaining.
Volker
(This used to be commit 9b1614f8cb415c15032e6a34f2da5df026f92e6e)
|
|
This itself won't help much, because send_trans2_replies_new still allocates
the big buffers, but stay tuned :-)
Also add/update my copyright on stuff I recently touched.
Volker
(This used to be commit 248f15ff143474db2493cef89ba446892342a361)
|
|
When starting to convert the individual trans2 subcalls, I need the new
API conventions to be present there. This means that those calls fill in
req->outbuf when there's something to ship
(This used to be commit d9eef977dc80d6ee71898efc1ff736afb75eba0c)
|
|
This needs a bit closer review, it also touches the client libs
(This used to be commit 824eb26738d64af1798d319d339582cf047521f0)
|