summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2003-03-17Fix memory leaks and add parinoioa code to our stat() cache.Andrew Bartlett1-2/+23
Andrew Bartlett (This used to be commit 3fd07bd25eefdb2a7a6891fa1169ab2425607249)
2003-03-16Missed one when I move 'share_sanity_checks' to use an fstring for 'dev'.Andrew Bartlett1-1/+1
Andrew Bartlett (This used to be commit a0208a4f74f9c61eb1e346d9cb62dbe00ef4c24a)
2003-03-16Make sure we mark the assumption of a fstring parameter for 'devicetype'Andrew Bartlett2-8/+8
in the function prototype, and change callers to respect this. Andrew Bartlett (This used to be commit 9f3d3c380120f16d76d68f346799282d61eec892)
2003-03-16Add const.Andrew Bartlett1-7/+7
(This used to be commit 5371720971bc60a4cfba0460614306f322aa10b8)
2003-03-16 - Make ReadDirName return a const char*.Andrew Bartlett5-27/+34
- Consequential changes from that - mark our fstring/pstring assumptions in function prototypes Andrew Bartlett (This used to be commit fe2bc64bc439b27387b8f326b0f4f3bfcc3d04a1)
2003-03-16Try to avoid dereferencing a null pointer.Andrew Bartlett1-9/+13
Andrew Bartlett (This used to be commit 4e96585b60512905776c2c6692c76d45241f089d)
2003-03-16New statcache internals - this time it's actually possible to follow what'sAndrew Bartlett1-54/+82
going on. In particular, add doxygen documentation. Andrew Bartlett (This used to be commit 7ff77ab46c63eca3b6edf18f39024eadb83a1a90)
2003-03-15Minor fixes.Andrew Bartlett1-4/+4
- signed/unsigned - quieten warning about assignment as truth value - whitespace Andrew Bartlett (This used to be commit a13ce0df4b4a776fa635a1fb804dd00d195f58d0)
2003-03-15String handling parinoia fixes.Andrew Bartlett2-47/+6
This patch enables the compile-time checking of strings assable by means of sizeof(). (Original code had the configure check reversed). This is extended to all safe_strcpy() users, push_string and pull_string, as well as the cli and srv derivitives. There is an attempt to cap strings at the end of the cli buffer, and clobber_region() of the speified length (when not -1 :-). Becouse of the way they are declared, the 'overmalloc a string' users of safe_strcpy() have been changed to use overmalloc_safe_strcpy() (which skips some of the checks). This whole ball of mud worked fine, until I pulled out my 'fix' for our statcache. When jeremy fixes that, we should be able to get back to testing this stuff. This patch also includes a 'marker' of the last caller to clobber_region (ie, the function that called pstrcpy() that called clobber_region) to assist in debugging problems that may have smashed the stack. This is printed at smb_panic() time. (Original idea and patch by metze). It also removes some unsused functions, and #if 0's some others that are unused but probably should be used in the near future. For now, this patch gives us some confidence on one class of trivial parsing error in our code. Andrew Bartlett (This used to be commit 31f4827acc2a2f00399a5528fc83a0dae5cebaf4)
2003-03-15Clean up the VFS module loading logic by making the parameter an P_LIST,Andrew Bartlett1-40/+34
rather than a runtime-parsed string. Andrew Bartlett (This used to be commit 3465cd6cd92c39c018979b5a82acbddca0927623)
2003-03-15Found by my new checking code (yet to be commited):Andrew Bartlett1-1/+1
Allow a service longer than 4 characters in CORE tcon. Andrew Bartlett (This used to be commit b56613c1cc13ebd5c9ba11a35d2f96c4c3eb0628)
2003-03-14fix WinXP & Win2K3 remote_arch and check pointer in ntlmssp code before ↵Gerald Carter1-17/+18
dereferencing (This used to be commit 2487480228b99183cab9e34ab497997e0c144ed6)
2003-03-12Ensure we count the length correctly in mangle_map.Jeremy Allison1-6/+15
Jeremy. (This used to be commit 596705198c555568da208f59008ab87c5164bfb4)
2003-03-12adding some initiaial code to sert %a to Win2K3 (using Native LanMan string ↵Gerald Carter1-0/+2
from .NET RC2) (This used to be commit 4c823e61d14a33344deb887043b60b2e3c83416f)
2003-03-11We use unsigned now, so use %u.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 01727b0296ee407e49444b9d9c4e7993892cb537)
2003-03-11Fix up zero termination. Spotted by Sebastian Krahmer <krahmer@suse.de>.Jeremy Allison1-1/+2
Jeremy. (This used to be commit 69becdb563b2620513931811a6695481bebcceed)
2003-03-10Don't segfault on make_server_info_guest() failure - instead return theAndrew Bartlett1-4/+2
error code. make_server_info_guest() requires an entry in the SAM at the moment, but this will change before release. Andrew Bartlett (This used to be commit 6a956390fa253e87e38b3f1909f13595fbf2767a)
2003-03-08Make sure that the 'remote' machine name can only be set once. For some weirdAndrew Bartlett2-4/+4
reason, during a Win2003 installation, when you select 'domain join' it sends one machine name in the name exchange, and litraly 'machinename' during the NTLMSSP login. Also fix up winbindd's logfile handling, so that it matches smbd and nmbd. (This helps me, by seperating the logs by pid). Andrew Bartlett (This used to be commit afe5a3832f79131fb74461577f1db0e5e8bf4b6d)
2003-03-08Fix typo in earlier fix, caught by Ranjit @ HP.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 13ab94fa73dbaf54da0169bbcf4d027d5c07d207)
2003-03-07Use ERROR_NT, not ERROR_DOS as Andrew Bartlett pointed out.Jeremy Allison3-3/+3
Jeremy. (This used to be commit c0930e6d15eb68f06453d9b67142ccd7fb1370a0)
2003-03-07Missed parentheses around complex logic.Jeremy Allison1-1/+2
Jeremy. (This used to be commit e81427c2d69be166afad94bc083e750e8f48fba7)
2003-03-07Patch from Michael Steffens. In his own words :Jeremy Allison1-78/+199
------------------------------------------------------------------------- I think there are basically two problem: 1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, and SMB_ACL_OTHER. The function ensure_canon_entry_valid() is prepared for that, but tries to "guess" values from group or other permissions, respectively, otherwise falling back to minimum r-- for the owner. Even if the owner had full permissions before setting ACL. This is the problem with W2k clients. 2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs. This is ok in a take-ownership situation, but must fail if the file is to be given away. This is the problem with XP clients, trying to transfer ownership of the original file to the temp file. The problem with NT4 clients (no ACEs are transferred to the temp file, thus are lost after moving the temp file to the original name) is a client problem. It simply doesn't attempt to. I have played around with that using posic_acls.c from 3.0 merged into 2.2. As a result I can now present two patches, one for each branch. They basically modify: 1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER as "preserve current value" instead of attempting to build one ourself. The original code is still in, but only as fallback in case current values can't be retrieved. 2. Rearrange set_nt_acl() such that chown is only done before setting ACLs if there is either no change of owning user, or change of owning user is towards the current user. Otherwise chown is done after setting ACLs. It now seems to produce reasonable results. (Well, as far as it can. If NT4 doesn't even try to transfer ACEs, only deliberate use of named default ACEs and/or "force group" or the crystal ball can help :) ------------------------------------------------------------------------- Jeremy. (This used to be commit 8ec20cbae7ca7e685b1a4186d8482c7405915dc3)
2003-03-07Fix noticed by Corny.Bondad@hp.com. Ensure we free up memory on error exit.Jeremy Allison1-0/+3
Jeremy. (This used to be commit 1cbd53dc3cd2d56f5e62d42fed5d589efcecb8f8)
2003-03-07Found at Connectathon, .NET RC1 arranges trans/trans2/nttrans parametersJeremy Allison3-69/+227
differently to W2K, cope with this. Jeremy. (This used to be commit 172f415c9eaa4d310a52794e3dc1a6bc92206ce4)
2003-03-06more off-by-one safe_strcpy()Andrew Bartlett1-3/+3
(This used to be commit d8d2d5e75503ae2b6532a25e4c9bbcdf20cc60af)
2003-03-03Another pstrcpy() into malloc()ed buffer fix.Andrew Bartlett1-2/+2
Andrew Bartlett (This used to be commit bd0c84d60b703e89081838a7cfa1eb1b4f45ad0a)
2003-03-03Const warning fixes.Jeremy Allison1-2/+2
Jeremy. (This used to be commit 3ad62ebe26d8c6b82f8618eea11d104b3ab0ec18)
2003-03-01i forgot to commit the privilege db init callAndrew Tridgell1-0/+4
(This used to be commit e8ec2b118071ce1d8cbfbcebce3781ac753c5c22)
2003-02-27 don't forget the NULLGerald Carter1-3/+3
(This used to be commit f80610120483c929afbec83d2b8649cb3e5111b0)
2003-02-27and the winner of "i should have just written it in assemblyGerald Carter1-3/+3
is..." don't use pstrcpy() when you are not dealing with pstrings. (This used to be commit 7d547f50f914747291acc71fd3544ad92ce91f0e)
2003-02-27don't pass NULL pointers to strcmp()Gerald Carter1-2/+2
(This used to be commit 6631984b12a3f74b93f7031c433dd81d6586a5df)
2003-02-27additional fix for CR 601Gerald Carter1-1/+16
* distinguish WinXP from Win2k * add a 1/3 of a second delay in OpenPrinter in order to trigger a LAN/WAN optimization in 2k clients. (This used to be commit 96570699d1b715f47c35aa211da6ec18f6fc4109)
2003-02-27- Rename 'modules = ' to 'preload modules = 'Jelmer Vernooij1-2/+1
- Add smb_probe_module() - Add init_modules() - Call these functions (This used to be commit f8f21653225792c0001d183c6efe8b7d89a0785d)
2003-02-27Fix to allow blocking lock notification to be done rapidly (no waitJeremy Allison3-10/+82
for smb -> smb lock release). Adds new PENDING_LOCK type to lockdb (does not interfere with existing locks). Jeremy. (This used to be commit 22fc0d48ff2052b4274c65f85050c58b235bf4e4)
2003-02-25Progress on CR 601Gerald Carter1-3/+3
cache the printer_info_2 with the open printer handle. cache is invalidated on a mod_a_printer() call **on that smbd**. Yes, this means that the window for admins to step on each other from different clients just got larger, but since handles a generally short lived this is probably ok. (This used to be commit 33c7b7522504fb15989f32add8e9a087c8d9d0fa)
2003-02-24Patch from Luke Howard to add mutual kerberos authentication, and SMB sessionAndrew Bartlett1-13/+39
keys for kerberos authentication. Andrew Bartlett (This used to be commit 8b798f03dbbdd670ff9af4eb46f7b0845c611e0f)
2003-02-22More signed/unsigned fixes (yes, I run with funny compiler options) andAndrew Bartlett2-5/+5
make x_fwrite() match fwrite() in returning a size_t. Andrew Bartlett (This used to be commit 2943c695787b742e9a96b2eefe2d75f681bacf7c)
2003-02-21Added comments to make it clearer when we're assigning a pointer that itJeremy Allison1-0/+12
must not be freed afterwards. Jeremy. (This used to be commit 80bad908c0235a57446c70b9632d3415c9d2fcf5)
2003-02-21Fixed compiler warning.Tim Potter1-1/+0
(This used to be commit b3f9cf8c1c293e905a536dfa5bb6a827627b7024)
2003-02-20Like for NTLM logins, lookup the 'winbind' user first, then the 'local' user.Andrew Bartlett1-18/+14
This needs to change, to be a SID->UID lookup from the PAC. Andrew Bartlett (This used to be commit 4071ed06a051f87f27e10510427a69fcdf45ddac)
2003-02-19Fix inspired by Stefan (metze) Metzmacher - cache the sidtype also.Jeremy Allison1-19/+27
Jeremy. (This used to be commit 634f20dff63d255c317f9dcc9f4caf4e8e79123c)
2003-02-19Fix logfile formatting, we were missing a "\n"Andrew Bartlett1-2/+2
(This used to be commit 53b8f8a44141a9f6d36ed1b237ff65c67119edd0)
2003-02-19Fix from Corny.Bondad@hp.com for missing if (setting_acls) on defaultJeremy Allison1-3/+3
perms. Jeremy. (This used to be commit ac96fa173cc3bd1c3226634154d6f99e4034179f)
2003-02-17This patch fixes one of my longest-standing pet hates with Samba :-).Andrew Bartlett4-21/+21
When we look see if a user is in a list, and we try to 'expand' an @group, we should lookup the user's own list of groups, rather than looking for all the members of a group. I'm sure this will fix some nasty performance issues, particularly on large domains etc. In particular, this avoids contacting winbind at all, if the group is not a winbind group. (This caused a deadlock on my winbind-on-PDC setup). The groups list always includes the user's primary group, as per the getgrouplist manpage, and my recent changes to our implementation. Andrew Bartlett (This used to be commit 9be21976f7662ebe6eb92fff7cecbdb352eca334)
2003-02-12Added code based on Michael Steffens <michael.steffens@hp.com> uid/gidJeremy Allison1-1/+205
caching code. Reduces load on winbindd. Probably should be moved to use gencache at some future date. Jeremy. (This used to be commit 19f577e23ba3dd9101fb3e77a729906fdb8f5df7)
2003-02-12Correctly return access denied on share mode deny when we can't open theJeremy Allison1-3/+19
file. This is a regression that was damaged by other code. Jeremy. (This used to be commit 5cdc957ea6335d8bb4248065a3b60a0a26e766a8)
2003-02-12add a note about relative opens with blank paths - its a re-open!Andrew Tridgell1-0/+10
(not implemented yet) (This used to be commit bceac9cdde04a57d661b6a7ece329fa6d5a169bd)
2003-02-11Fix delete on close semantics to match W2K. I (think:-) I understand it now :-).Jeremy Allison2-45/+46
Thanks to Nir Livni <nirl@cyber-ark.com> for giving me the test case to track it down. Jeremy. (This used to be commit c98ebb3031649203e607264ecb15722adf55af58)
2003-02-10Some cleanups:Andrew Bartlett4-29/+45
- Don't use pstrcpy into an allocated string - use safe_strcpy() directly instead. - Keep a copy of the 'server_info' attached to the vuid. In future use this for things like the session key, homedir and full name instead of current copies. - Try to avoid memory leak/segfault on Realloc failure - clear up #endif comments Andrew Bartlett (This used to be commit 162477bb086827950b6cb71afa9bef62c2753c2e)
2003-02-07check pointer before dereferencing itGerald Carter1-1/+1
(This used to be commit 786d91d75c909f6d407b8466c89181f26e62e68f)
generated by cgit (git 2.34.1) at 2024-12-28 22:08:02 +0000