summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2007-11-06Move some access check functions that are not posix-acl specificMichael Adam2-212/+239
to a new source file of their own. Michael (This used to be commit 9dd18bb534bca6b5de6cad9580b48681b36c0832)
2007-11-06Don't repeat fast-pathing...Michael Adam1-1/+1
Michael (This used to be commit c61b4222d30288add216fac4da3cfaa537f5cd01)
2007-11-06This is a proposed patch for Bug #5023.Michael Adam1-300/+70
The three can_* access check functions in smbd/posix_acls.c that are used in smbd/open.c and smbd/nttrans.c explicitly called check_posix_acl_group_access() This lead to errors with nfsv4 acls (ZFS and GPFS). This changes the can_* functions to get the nt_acl via VFS layer and call se_access_check on that. It also removes check_posix_acl_group_access() which has no more callers. NOTE: The can_* functions should really not be in smbd/posix_acls.c but in a separate file (I propose smbd/access.c). Michael (This used to be commit 6f961a23de745aba5dcd4585b731e651b8cbeef4)
2007-11-06Add a const.Michael Adam1-1/+1
Michael (This used to be commit 7b582af2107bed3b864bb408b5c9bcce4b8e4c72)
2007-11-05Add two const's.Michael Adam1-2/+2
Michael (This used to be commit bf23c4ddff617dd3cd1e2d5cedb1b5c023356dc3)
2007-11-05Remove the horror that was the global smb_rw_error.Jeremy Allison3-24/+42
Each cli struct has it's own local copy of this variable, so use that in client code. In the smbd server, add one static to smbd/proccess.c and use that inside smbd. Fix a bunch of places where smb_rw_error could be set by calling read_data() in places where we weren't reading from the SMB client socket (ie. winbindd). Jeremy. (This used to be commit 255c2adf7b6ef30932b5bb9f142ccef4a5d3d0db)
2007-11-05Fix a debug messageVolker Lendecke1-1/+1
(This used to be commit a86849e4f9512b680f26010c297cec14251dafdd)
2007-11-05Make load_registry_service return the share numberVolker Lendecke1-1/+0
(This used to be commit 934964c90f39d588d2399f10e3738ab1b4e01290)
2007-11-04Forgot arg type.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 46f3b04ddea4c63c6b37c7038d4bbd2ee1c9ca0c)
2007-11-04Don't believe len returned from read_smb_length_return_keepalive(),Jeremy Allison1-1/+1
it may be a UNIX large writeX (which wraps len in that case). Stevef this should fix your 128k write bug. Jeremy. (This used to be commit de2ebffa3c99ed28a3868fd956ef45629ca855b6)
2007-11-03Remove most of the remaining globals out of lib/util_sock.c.Jeremy Allison6-11/+17
I have a plan for dealing with the remaining..... Watch this space. Jeremy. (This used to be commit 963fc7685212689f02b3adcc05b4273ee5c382d4)
2007-11-03I can't get away without a 'length' arg. :-).Jeremy Allison6-9/+15
Jeremy. (This used to be commit 95d01279a5def709d0a5d5ae7224d6286006d120)
2007-11-03Stop get_peer_addr() and client_addr() from using globalJeremy Allison6-8/+19
statics. Part of my library cleanups. Jeremy. (This used to be commit e848506c858bd16706c1d7f6b4b032005512b8ac)
2007-11-03Remove the smb_read_error global variable and replaceJeremy Allison5-38/+21
it with accessor functions. "One global or pstring a day...." :-). Jeremy. (This used to be commit d50d14c300abc83b7015718ec48acc8b3227a273)
2007-11-02Change the client library to write directly out ofJeremy Allison1-5/+10
the incoming buffer in the non-signed case. Speeds up writes by over 10% or so. Complete the server recvfile implementation. Jeremy. (This used to be commit 81ca5853b2475f123faab3b550f0a7b24ae3c208)
2007-11-02Argggh. smblen doesn't include the +4, so my smb_doff calculationsJeremy Allison1-4/+4
shouldn't either :-). Jeremy. (This used to be commit c3de44b6b063e126095b30536fdcb643c70e395e)
2007-11-01Ensure we can't accidently do a pipe write withJeremy Allison1-0/+5
unread bytes in the socket buffer. Jeremy (This used to be commit 84d22f7747126608b9460f9591bb5967d871b82d)
2007-11-01Be careful and take care of the correct lengths in largeJeremy Allison1-9/+7
writeX calls. Jeremy. (This used to be commit 2d3ff9c502105f92720131355b41e48be8d656c2)
2007-11-01Ensure we detect a large writeX when using recvfile.Jeremy Allison1-1/+2
More changes needed to make the UNIX_LARGE_WRITEX_CAP writes work (I'll add these tomorrow). Jeremy. (This used to be commit 1c71546b6152d2930b98f766311bbd161ee0ee4e)
2007-11-01Add brackets so as not to break the POSIX caps return.Jeremy Allison1-2/+2
Jeremy. (This used to be commit 47dbddcb5361caa30ee60cf4e15bb50d557d1191)
2007-10-31Note when we're setting change time, not write time, and sendJeremy Allison3-16/+32
message accordingly. Apart from not supporting create time we now pass the S4 RAW-NOTIFY torture. Jeremy. (This used to be commit 8a77f520fa03afa60eac2aaeab4babe7dd8db4f0)
2007-10-31Fix some cases where file_set_dosmode was being passedJeremy Allison6-12/+28
False instead of NULL. Fix more of the notifications to be correct for Samba4 RAW-NOTIFY torture (we had missed one when calling set_ea_dos_attribute(). Jeremy. (This used to be commit 39d265375cf55eedddef2c4faa65398df73d5ed2)
2007-10-31Fix vfstest link - move socket calls into smbd/process.cJeremy Allison2-288/+288
not smbd/server.c Jeremy (This used to be commit 8fbefe18a2dc23adb0ebe488cfb37ab4a382207d)
2007-10-31Make explicit draining the socket on RECVFILE. AddJeremy Allison3-12/+17
capability for large UNIX write if not signing and recvfile set. Cope with large UNIX write length on incoming processing. Stevef - we can now test 1-16Mb writes from CIFFS. Jeremy. (This used to be commit 8cf78776b0a44bd026cef3d74eb11cfb415f8303)
2007-10-30Handle the disk full error case correctly.Jeremy Allison1-1/+1
Jeremy. (This used to be commit b7088bb9c2a00d4717b9a7efa4bddc0c005f4efb)
2007-10-30Ensure we don't prematurely clean out the bytes read.Jeremy Allison1-4/+10
Jeremy. (This used to be commit 247675695dfbff503b5792de62f8bb1567ea2327)
2007-10-30Add new parameter, "min receivefile size" (by default setJeremy Allison7-53/+482
to zero). If non-zero, writeX calls greater than this value will be left in the socket buffer for later handling with recvfile (or userspace equivalent). Definition of recvfile for your system is left as an exercise for the reader (I'm working on getting splice working :-). Jeremy. (This used to be commit 11c03b75ddbcb6e36b231bb40a1773d1c550621c)
2007-10-30start smbd, nmbd and winbindd with the same startup messageStefan Metzmacher1-2/+2
at debug level 0. metze (This used to be commit 95f76ae7a52c6b22db22d03fed6b0848d2a61bee)
2007-10-28Enable vfs objects = /full/path/to/object.soVolker Lendecke1-10/+36
Right now I'm testing a vfs object. I can't right now in make test, because "vfs objects" assumes the .so files to be in $libdir/vfs. This patch parses the module name out of the object name in case it starts with "/". The module name is assumed to be the last path component's basename. (This used to be commit 95cc019af775a6ab28ea602ad767fa54d7c86197)
2007-10-27Two patchesVolker Lendecke1-1/+1
Hi! Can you check and push them? Thanks, Volker From b488af5905e2dee12a1a72a3b40801ae5c26f24f Mon Sep 17 00:00:00 2001 From: Volker Lendecke <vl@sernet.de> Date: Sat, 27 Oct 2007 14:20:09 +0200 Subject: [PATCH] Fix some warnings and errors (This used to be commit e17d3e10e860c96b6d5208e5fe51e43b8e58c174)
2007-10-25Ensure we don't terminate if we fail to bind to a socket,Jeremy Allison1-1/+6
only fail if we can't bind to any socket. Jeremy. (This used to be commit 2ec6224b552ef86fa1739c9e396c39c7ec6c76c6)
2007-10-24Don't terminate on an invalid address family.Jeremy Allison1-1/+1
Jeremy. (This used to be commit d04a8a6cdcc505e0244882a9abb7174eadbf81a7)
2007-10-24This is a large patch (sorry). Migrate from struct in_addrJeremy Allison2-74/+101
to struct sockaddr_storage in most places that matter (ie. not the nmbd and NetBIOS lookups). This passes make test on an IPv4 box, but I'll have to do more work/testing on IPv6 enabled boxes. This should now give us a framework for testing and finishing the IPv6 migration. It's at the state where someone with a working IPv6 setup should (theorecically) be able to type : smbclient //ipv6-address/share and have it work. Jeremy. (This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)
2007-10-19Add test for "struct in6_addr" to the HAVE_IPV6 configure test.Gerald (Jerry) Carter1-1/+1
Also make use of "if defined(HAVE_IPV6)" rather than testing for AF_INET6 since this is not sufficient on HP-UX 11.11 to ensure a working IPv6 implementation. (This used to be commit 620785df4e57b72471ff0315e22e0d2f28a2b1a5)
2007-10-19Fix the popt / bool issues. Some places we used BOOLJeremy Allison1-11/+32
where we meant int. Fix this. Thanks to metze for pointing this out. Jeremy. (This used to be commit 793a9d24a163cb6cf5a3a0aa5ae30e9f8cf4744a)
2007-10-19fix startup of smbd, nmbd, winbinddStefan Metzmacher1-5/+5
jra: POPT_ARG_VAL arguments need int values. I assume there're more places like this in the cmdline tools. Please fix this properly, as my commit is just a hack to get make test working again. in samba4 we have a workaround for this see smbd/server.c metze (This used to be commit 9cb1937fe8601e526b5c924930500e0a3b52abd5)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison47-574/+574
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-11Add const to the get_peer_addr() and get_socket_addr()Jeremy Allison2-2/+3
calls. Use the IPv6 varient for get_peer_addr(). Jeremy. (This used to be commit baf1f52e34ae2465a7a34be1065da29ed97e7bea)
2007-10-10Add start of IPv6 implementation. Currently most of this is avoidingJeremy Allison1-2/+11
IPv6 in winbindd, but moves most of the socket functions that were wrongly in lib/util.c into lib/util_sock.c and provides generic IPv4/6 independent versions of most things. Still lots of work to do, but now I can see how I'll fix the access check code. Nasty part that remains is the name resolution code which is used to returning arrays of in_addr structs. Jeremy. (This used to be commit 3f6bd0e1ec5cc6670f3d08f76fc2cd94c9cd1a08)
2007-10-10Fix valgrind-found memory overwrite.Jeremy Allison1-2/+2
(This used to be commit 183df4754b5f18419f4d8fca2c0fa19919174556)
2007-10-10[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter20-1164/+389
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10r25534: Apply some constVolker Lendecke2-2/+2
Why? It moves these structs from the data into the text segment, so they will never been copy-on-write copied. Not much, but as in German you say "Kleinvieh macht auch Mist...." (This used to be commit 0141e64ad4972232de867137064d0dae62da22ee)
2007-10-10r25502: Fix bug 5006Volker Lendecke1-1/+1
Thanks to Joerg.Bernau at web.de (This used to be commit 492977016fa66ce0e98a5bdd1c0f00eacdf13f0c)
2007-10-10r25498: Remove checks that are always true.Jelmer Vernooij1-2/+2
(This used to be commit 2f2bdfa0df758104a9a2fcafe49d6215d8753536)
2007-10-10r25492: Start adding IPv6 compatible code to lib/util_sock.c and deal withJeremy Allison3-66/+85
the ripple effects this causes. utmp has to change etc. Remove some global varables and store address/port in the unexpected db. Jeremy. (This used to be commit 18c6a2211d9e25233d01715b3f78977edcd6d869)
2007-10-10r25391: Fix bug #4978 : Store DOS Attributes fails when copying folders.Jeremy Allison1-0/+10
Jeremy. (This used to be commit 713277391ae7f81f8545723c919865ff8c07ed86)
2007-10-10r25327: Normalize the path we return for 'msdfs proxy'Volker Lendecke1-1/+11
We now accept both \\server\tmp and \server\tmp. There are other places where this might be necessary, but at least the functionality is a bit easier now. (This used to be commit 25cc27df97e9eecb470f99ea934de12f2a0f4df9)
2007-10-10r25324: Fix "msdfs proxy"Volker Lendecke1-1/+1
Jeremy, please check! (This used to be commit d4eddf88d20b09c450d4358d2ef1bc35736501ff)
2007-10-10r25311: Patch from Heinrich Mislik <Heinrich.Mislik@univie.ac.at> to fix AIXVolker Lendecke1-0/+3
quotas. Heinrich, I trust you on that, I don't even have compiled this :-) Volker (This used to be commit a8312a1d7b7e3ad00265279dd0640261beaa287d)
2007-10-10r25309: Volker's fix for bug #4984 - samba4 torture testJeremy Allison1-41/+71
to follow. Ensure we don't prepend "./" as a root directory - this is an invalid pathname for unix_convert(). Jeremy. (This used to be commit f70ac2e25847e41ecf54ae9d66e3247e1996b152)