summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2007-10-27Two patchesVolker Lendecke1-1/+1
Hi! Can you check and push them? Thanks, Volker From b488af5905e2dee12a1a72a3b40801ae5c26f24f Mon Sep 17 00:00:00 2001 From: Volker Lendecke <vl@sernet.de> Date: Sat, 27 Oct 2007 14:20:09 +0200 Subject: [PATCH] Fix some warnings and errors (This used to be commit e17d3e10e860c96b6d5208e5fe51e43b8e58c174)
2007-10-25Ensure we don't terminate if we fail to bind to a socket,Jeremy Allison1-1/+6
only fail if we can't bind to any socket. Jeremy. (This used to be commit 2ec6224b552ef86fa1739c9e396c39c7ec6c76c6)
2007-10-24Don't terminate on an invalid address family.Jeremy Allison1-1/+1
Jeremy. (This used to be commit d04a8a6cdcc505e0244882a9abb7174eadbf81a7)
2007-10-24This is a large patch (sorry). Migrate from struct in_addrJeremy Allison2-74/+101
to struct sockaddr_storage in most places that matter (ie. not the nmbd and NetBIOS lookups). This passes make test on an IPv4 box, but I'll have to do more work/testing on IPv6 enabled boxes. This should now give us a framework for testing and finishing the IPv6 migration. It's at the state where someone with a working IPv6 setup should (theorecically) be able to type : smbclient //ipv6-address/share and have it work. Jeremy. (This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)
2007-10-19Add test for "struct in6_addr" to the HAVE_IPV6 configure test.Gerald (Jerry) Carter1-1/+1
Also make use of "if defined(HAVE_IPV6)" rather than testing for AF_INET6 since this is not sufficient on HP-UX 11.11 to ensure a working IPv6 implementation. (This used to be commit 620785df4e57b72471ff0315e22e0d2f28a2b1a5)
2007-10-19Fix the popt / bool issues. Some places we used BOOLJeremy Allison1-11/+32
where we meant int. Fix this. Thanks to metze for pointing this out. Jeremy. (This used to be commit 793a9d24a163cb6cf5a3a0aa5ae30e9f8cf4744a)
2007-10-19fix startup of smbd, nmbd, winbinddStefan Metzmacher1-5/+5
jra: POPT_ARG_VAL arguments need int values. I assume there're more places like this in the cmdline tools. Please fix this properly, as my commit is just a hack to get make test working again. in samba4 we have a workaround for this see smbd/server.c metze (This used to be commit 9cb1937fe8601e526b5c924930500e0a3b52abd5)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison47-574/+574
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-11Add const to the get_peer_addr() and get_socket_addr()Jeremy Allison2-2/+3
calls. Use the IPv6 varient for get_peer_addr(). Jeremy. (This used to be commit baf1f52e34ae2465a7a34be1065da29ed97e7bea)
2007-10-10Add start of IPv6 implementation. Currently most of this is avoidingJeremy Allison1-2/+11
IPv6 in winbindd, but moves most of the socket functions that were wrongly in lib/util.c into lib/util_sock.c and provides generic IPv4/6 independent versions of most things. Still lots of work to do, but now I can see how I'll fix the access check code. Nasty part that remains is the name resolution code which is used to returning arrays of in_addr structs. Jeremy. (This used to be commit 3f6bd0e1ec5cc6670f3d08f76fc2cd94c9cd1a08)
2007-10-10Fix valgrind-found memory overwrite.Jeremy Allison1-2/+2
(This used to be commit 183df4754b5f18419f4d8fca2c0fa19919174556)
2007-10-10[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter20-1164/+389
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10r25534: Apply some constVolker Lendecke2-2/+2
Why? It moves these structs from the data into the text segment, so they will never been copy-on-write copied. Not much, but as in German you say "Kleinvieh macht auch Mist...." (This used to be commit 0141e64ad4972232de867137064d0dae62da22ee)
2007-10-10r25502: Fix bug 5006Volker Lendecke1-1/+1
Thanks to Joerg.Bernau at web.de (This used to be commit 492977016fa66ce0e98a5bdd1c0f00eacdf13f0c)
2007-10-10r25498: Remove checks that are always true.Jelmer Vernooij1-2/+2
(This used to be commit 2f2bdfa0df758104a9a2fcafe49d6215d8753536)
2007-10-10r25492: Start adding IPv6 compatible code to lib/util_sock.c and deal withJeremy Allison3-66/+85
the ripple effects this causes. utmp has to change etc. Remove some global varables and store address/port in the unexpected db. Jeremy. (This used to be commit 18c6a2211d9e25233d01715b3f78977edcd6d869)
2007-10-10r25391: Fix bug #4978 : Store DOS Attributes fails when copying folders.Jeremy Allison1-0/+10
Jeremy. (This used to be commit 713277391ae7f81f8545723c919865ff8c07ed86)
2007-10-10r25327: Normalize the path we return for 'msdfs proxy'Volker Lendecke1-1/+11
We now accept both \\server\tmp and \server\tmp. There are other places where this might be necessary, but at least the functionality is a bit easier now. (This used to be commit 25cc27df97e9eecb470f99ea934de12f2a0f4df9)
2007-10-10r25324: Fix "msdfs proxy"Volker Lendecke1-1/+1
Jeremy, please check! (This used to be commit d4eddf88d20b09c450d4358d2ef1bc35736501ff)
2007-10-10r25311: Patch from Heinrich Mislik <Heinrich.Mislik@univie.ac.at> to fix AIXVolker Lendecke1-0/+3
quotas. Heinrich, I trust you on that, I don't even have compiled this :-) Volker (This used to be commit a8312a1d7b7e3ad00265279dd0640261beaa287d)
2007-10-10r25309: Volker's fix for bug #4984 - samba4 torture testJeremy Allison1-41/+71
to follow. Ensure we don't prepend "./" as a root directory - this is an invalid pathname for unix_convert(). Jeremy. (This used to be commit f70ac2e25847e41ecf54ae9d66e3247e1996b152)
2007-10-10r25286: Fix one more caller of unistr2_to_ascii() that passedMichael Adam1-1/+1
in -1 for maxlen. Michael (This used to be commit cd3d652d0d7609fc369ed0743c1fc54c87558438)
2007-10-10r25184: Fix some C++ warnings and an uninitialized variableVolker Lendecke3-4/+4
(This used to be commit b64df8a3c504ab7749c21ffb26e4771a9a0a328f)
2007-10-10r25173: Use the append_buffer version in a loop.Jeremy Allison1-2/+2
Jeremy. (This used to be commit 37cf2c272751065245dd46708af0a78f1f0c47df)
2007-10-10r25167: Fix breakage from mangling rewrite. Use theJeremy Allison1-1/+2
new name if unmangling succeeded, not if it failed. Jerry - please re-test, this should fix your bug. Jeremy. (This used to be commit c215d6e84929b70e4472e19f32ec4f1db7449d90)
2007-10-10r25163: Fix wrong ctx passed to talloc_asprintf_append().Jeremy Allison1-1/+1
Found by Metze's code review (thanks Metze !). Jeremy. (This used to be commit a7370eea6be29c0e2adf5ae62aa6182b9165e744)
2007-10-10r25161: Don't panic if setgroups fails in non-root mode.James Peach1-2/+2
(This used to be commit ea226c5ed97d47649833546d5499213093d1925e)
2007-10-10r25142: Panic if setting the group list fails while switching securityJames Peach1-1/+4
contexts. Patch from Tim Prouty <tim.prouty@isilon.com>. (This used to be commit a136de663f122603e8d34e06027896ff39b35e11)
2007-10-10r25141: More pstring removal.Jeremy Allison1-3/+14
Jeremy. (This used to be commit cfcf7cf03e1be34e6839c1a659c4e8c1b5358c37)
2007-10-10r25138: More pstring elimination. Add a TALLOC_CTX parameterJeremy Allison6-42/+49
to unix_convert(). Jeremy. (This used to be commit 39c211a702e91c34c1a5a689e1b0c4530ea8a1ac)
2007-10-10r25135: Remove one END_PROFILE(SMBntcreateX) from call_nt_transact_create() ↵Günther Deschner1-1/+0
which appears to be a leftover. Should fix the build with profiling enabled. Jeremy, please check. Guenther (This used to be commit 98f2e10e3f7a86b1b30619a25ee15a489ad10d43)
2007-10-10r25118: More pstring elimination.Jeremy Allison3-53/+80
Jeremy. (This used to be commit 7632f8fb4003657591778d2b55f546d1737859d1)
2007-10-10r25117: The mega-patch Jerry was waiting for. Remove all pstrings fromJeremy Allison11-468/+731
the main server code paths. We should now be able to cope with paths up to PATH_MAX length now. Final job will be to add the TALLOC_CTX * parameter to unix_convert to make it explicit (for Volker). Jeremy. (This used to be commit 7f0db75fb0f24873577dcb758a2ecee74fdc4297)
2007-10-10r25111: Move to talloced pathnames on most code paths.Jeremy Allison6-340/+423
There are now ony 17 pstrings left in reply.c, and these will be easy to remove (and I'll be doing that shortly). Had to fix an interesting bug in pull_ucs2_base_talloc() when a source string is not null terminated :-). Jeremy. (This used to be commit 0c9a8c4dff10974dbffd2a302ae982896122fcc0)
2007-10-10r25103: Ensure we don't return unwritten memory (valgrind caught).Jeremy Allison2-64/+83
Jeremy. (This used to be commit b3f0d39d11fa18b7bfef6cec88efaf4a2be2d6e0)
2007-10-10r25102: Rewrite msdfs code to use talloced filenames. Passes make testJeremy Allison5-395/+811
and make valgrindtest. Final step will be to change srvstr_get_path() to return talloced memory in the major codepaths. Jeremy. (This used to be commit cf6b6f9c3a38b68d2671c753f412772344506742)
2007-10-10r25055: Add file_id_string_tosVolker Lendecke7-29/+29
This removes file_id_string_static and file_id_string_static2 (This used to be commit 638c848c9afe374feb30e34c494f89b2a6c64f7b)
2007-10-10r25011: We don't use mangle_map any more.Jeremy Allison1-211/+0
Jeremy. (This used to be commit 2e0999c1df33c192fee5f739070a0e4c3d22dff8)
2007-10-10r25009: Large patch discussed with Volker. Move unix_convert to a talloc-basedJeremy Allison10-639/+947
interface. More development will come on top of this. Remove the "mangled map" parameter. Jeremy. (This used to be commit dee8beba7a92b8a3f68bbcc59fd0a827f68c7736)
2007-10-10r24949: Remove some static buffersVolker Lendecke1-7/+5
(This used to be commit df648d47ff3c4e24f439fda839653bda98323100)
2007-10-10r24813: Reformat to 80 columns.Jeremy Allison1-19/+32
Jeremy. (This used to be commit c6c8f5a897602d53876fe75e86283d97a394037d)
2007-10-10r24811: Simple reformatting to fit the 80 columns rule.Jeremy Allison1-63/+96
Jeremy. (This used to be commit 0cdf046dae8ba0741bb7786aa4e85c34fc35dade)
2007-10-10r24809: Consolidate the use of temporary talloc contexts.Volker Lendecke10-21/+16
This adds the two functions talloc_stackframe() and talloc_tos(). * When a new talloc stackframe is allocated with talloc_stackframe(), then * the TALLOC_CTX returned with talloc_tos() is reset to that new * frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse * happens: The previous talloc_tos() is restored. * * This API is designed to be robust in the sense that if someone forgets to * TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and * resets the talloc_tos(). The original motivation for this patch was to get rid of the sid_string_static & friends buffers. Explicitly passing talloc context everywhere clutters code too much for my taste, so an implicit talloc_tos() is introduced here. Many of these static buffers are replaced by a single static pointer. The intended use would thus be that low-level functions can rather freely push stuff to talloc_tos, the upper layers clean up by freeing the stackframe. The more of these stackframes are used and correctly freed the more exact the memory cleanup happens. This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and lp_talloc_ctx (did I forget any?) So, never do a tmp_ctx = talloc_init("foo"); anymore, instead, use tmp_ctx = talloc_stackframe() :-) Volker (This used to be commit 6585ea2cb7f417e14540495b9c7380fe9c8c717b)
2007-10-10r24791: Fix logic error in timeout of blocking lock processing found byJeremy Allison1-22/+29
Ronnie. If a lock timeout expires, we must check we can get the lock before responding with failure. Volker is writing a torture test. Jeremy. (This used to be commit 45380f356b99d575645873b05af17c504b091dc8)
2007-10-10r24702: Remove the old API pointersVolker Lendecke8-537/+337
(This used to be commit 17df313db42199e26d7d2044f6a1d845aacd1a90)
2007-10-10r24699: Actually write 24 zeros instead of zero 24's...Volker Lendecke1-1/+1
Jeremy, please check ;-) (This used to be commit 85b64bde7df10ade5ba0abd493d433a7688f0979)
2007-10-10r24661: Fix some obvious diffs between 3_2 and 3_2_0Volker Lendecke1-3/+5
Jeremy, there are two remaining diffs in sesssetup.c which I don't really know which one is right. Can you take a look? Thanks, Volker (This used to be commit d82f35448763eacd564836f34c9aa450b15ea582)
2007-10-10r24659: Some formatting changes helping to minimize the 3_2_0 diffVolker Lendecke3-16/+15
(This used to be commit c5caea43af154671448df82881efe09a5c982386)
2007-10-10r24639: Add parameter "directory name cache size" - parameterizeJeremy Allison1-20/+33
use of directory name cache, 100 by default. Will be needed to turn this off for *BSD systems. Jeremy. (This used to be commit bea8e9840fd65268e649f813eba10502b0c4d721)
2007-10-10r24638: Remove redundent setting of vuid.Jeremy Allison1-3/+1
Jeremy (This used to be commit fd682c3f397714ebdaf4af3f6d1cbcbab6a2f572)