Age | Commit message (Collapse) | Author | Files | Lines |
|
Jeremy.
(This used to be commit 5a2fd8e76587a572cdb97fa87a99cda3e450ce0e)
|
|
to make it generic. Remove the mb-codepage "blacklist". Alexander, please
check this fix as it reverts your blacklist changes, but I'm hoping it
fixes the problem in a more generic way for all charsets. I'm not trying
to trample on your (excellent!) work here, just make things more generic
without special cases.
Jeremy.
(This used to be commit ca344a784da870965684e41c93ef8bfc5e86d28f)
|
|
bytes in the mb character at a pointer. Will be useful in fixing check_path_syntax()
to not use a "blacklist". Also re-added my (C) to reply.c. I mean, really - I've
been adding code to the file for over 10 years and I recognise many of the
fuctions as mine ! :-).
Jeremy.
(This used to be commit 5a804dbe0f3ddbd6f3fbdd6b2c5510e143607541)
|
|
(Heinrich Mislik)
(This used to be commit 8f9bedaeb1b3b102fa6b23da1f6b03eb0e015359)
|
|
byte.
This is intermediate fix as discussed with Jeremy until we move check_path_syntax() to UCS2 internally where all
ambiguity is resolved. Please add other encodings into charcnv.c with such property.
(This used to be commit c8c66337494c63173a6aba4286a843875302da63)
|
|
use default domain = yes
(This used to be commit ca971cf76e5fbb33d51b1fdfa92e4d13b2e150b6)
|
|
(MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.
Jeremy.
(This used to be commit 128dec9ae68fd357550de2649d54056ca4fc65cf)
|
|
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c
so it's readable.
Jeremy.
(This used to be commit beca3829d1140bf7c2e394993a02dff1f2cf7bbd)
|
|
when mangled names are turned off.
Jeremy.
(This used to be commit 11487e24666c7b3dd4b37f4ef8aec8f8a5bd5a6f)
|
|
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.
(This used to be commit cc70a548f3c48a9503fd54d01896cc2499f5bbcd)
|
|
"allow_bad_conv"
boolean parameter that allows broken iconv conversions to work. Gets rid of the
nasty errno checks in mangle_hash2 and check_path_syntax and allows correct
return code checking.
Jeremy.
(This used to be commit 3b4fca7b7f410cb0f11322e22c8f26a662eff941)
|
|
character set. Because of the allowing of "broken conversions" for people
who have broken iconv libraries we can't rely on the return from convert_string()
to be valid - we must check errno instead. This is ripe for revisiting at
some stage. I prefer adding a bool parameter to all convert_string_XX varients
to specify if we will allow broken conversions or not. With "allow_broken_conversions"
set to false we could then rely on the return from convert_string rather than
checking errno.
Jeremy.
(This used to be commit 30c30c5ac53ec8f32a44d0b1b39cc99fe9844467)
|
|
dfs code.
Jeremy.
(This used to be commit 70670841028aaeb72267ac41ca30af8dba412998)
|
|
rafal
(This used to be commit 6c8e39b7ccc1ad8e7f39c2a51fa13423e5d6e227)
|
|
(This used to be commit 45b2efd60a3c3c9f01b1ccaa828904a70d70d67d)
|
|
This code implements 'opportunistic signing' in our client (when the
server supports it, we will use it), and correct downgrading on both
the client and server for the 'enabled' (rather than required) signing
level.
This means that we can actually set 'server signing = yes' and not
have the world fall apart. We had a number of bugs in that code, and
it certainly looks like most of the testing was with the 'requried'
setting.
While the changes are reasonable, I'm putting this into HEAD rather
than 3.0 for the timebeing. SMB signing, like NTLMSSP, tends to have
gotchas in it :-)
(I also need to give it a workout with more than smbclient before I
move it across).
Andrew Bartlett
(This used to be commit 6bad895462cf076a7e917c909e2a461d1b360bf1)
|
|
(should fix the mb service name problem, can't remember the bugid).
Jeremy.
(This used to be commit 93c2d50f1adbf257c0c0185b420a1d73d56be2f9)
|
|
need to try and convert 1 byte, then 2 bytes if that fails. Fixes bug
reported by Simo.
Jeremy.
(This used to be commit 0f84801ff3ed5acfcf8e0c4a825f90b9b4823da5)
|
|
1 fix for a memleak
(This used to be commit 9f3b0295fe7bd6c0c3a6061e5d00e7b88f702b21)
|
|
(This used to be commit 92f6895dd11189ce966b8b5a3f9ace54f478a375)
|
|
Jeremy.
(This used to be commit 13edba472a0a5eb56586458a2432d53f495d0129)
|
|
so breaks when substitution '/' and '\'). It's used by unix_clean_name(),
which is used by reduce_name, which is used by check_name() (phew!).
Now that we know all filenames passed to check_name() are in a "good"
format (no double slashes, all '\\' chars translated to '/' etc.) due
to the new check_path_syntax() we can avoid calling reduce_name unless
widelinks are denied. After this check-in I can fix all_string_sub() to
handle mb chars correctly as it won't be in the direct path in the
main path handling code.
Jeremy.
(This used to be commit bce0678331aa4746181389e0f91f11fb2a6dadcb)
|
|
original srvstr_pull_buf() function to get the pipename not srvstr_get_path().
Jeremy.
(This used to be commit ac5e0c4bb686e2aaccc9b70f240f79747fd48cd8)
|
|
right in the middle of the code.
I just love catching jra on stuff like this, after all the crap
I've done. :-)
(This used to be commit 217791cab21b79fdbe2ddb96079fb9abb8545dd7)
|
|
Added hardlink_internals() code - UNIX extensions now use this too.
Jeremy.
(This used to be commit 3f2b9f10dec58d3e3ae463e3804d96052fb27a4d)
|
|
much closer emulation of Win2k3 error return codes.
Jeremy.
(This used to be commit 883f89a0184e37bff4f5877a25d31b994996ab08)
|
|
This patch add privilege support for samba
Currently it is implemented only for tdbsam backend but estending it to
other sam backends is straightforward.
I must make a big thank to JFM for his teachings on the matter and the
functions at the base of this work.
At thye moment only samr_create_user honours SeAddUsersPrivilege and
SeMachineAccountPrivilege to permit any user to add machines and/or users to
the server.
The command "net priv" has been provided to manipulate the privileges
database.
There are still many things to do (like support in "net rpc vampire") but
the working core is here.
Feel free to comment/extend on this work.
Of course I will deny that any bug may affect this code :-)
Simo.
This patch adds also my patch about add share command enhancements.
(This used to be commit 7a78c3605e203bd8e0d7ae244605f076a5d0b0bc)
|
|
fail if file exists and target is a directory. gentest.
Jeremy.
(This used to be commit 4b1262322995c8794cd73d84712f82d8c91abdc6)
|
|
Jeremy.
(This used to be commit 2a457e2e28cd1f78778cb41fbb381883ced99592)
|
|
Even if it's our own lock context, we need to wait here as
there may be an unlock on the way.
So I removed a "&& !my_lock_ctx" from the following
if statement.
if ((lock_timeout != 0) && lp_blocking_locks(SNUM(conn)) && ERROR_WAS_LOCK_DENIED(status)) {
Jeremy.
(This used to be commit 17c88758ae82b20bc7260d5d927325f3f73ba33c)
|
|
Jeremy.
(This used to be commit e46aaffe97919afb1c92f56376f9578825012b92)
|
|
Jeremy.
(This used to be commit 755b66303d04b73a855fa8db5fe3ae920a901bf3)
|
|
at what W2K3 accepts here it's COMPLETELY BROKEN ! :-).
Jeremy.
(This used to be commit 9aa37cb84090260b33d32ad123ddc4d211e3913b)
|
|
Jeremy.
(This used to be commit fc9811693933327a15b7dbe4893219c7ef44d1e8)
|
|
Jeremy.
(This used to be commit c85b617aa03c1524f659100030a8e96cef38fb62)
|
|
Jeremy.
(This used to be commit f353cafa9d9e6142b4aec45cfbc567dc4ab20d7e)
|
|
Jeremy.
(This used to be commit 55f13d743e78ed8f48bf209e838ea77df3121047)
|
|
Jeremy.
(This used to be commit d236372876918be2a886a89383cf843b82d4c8db)
|
|
by Herb).
Jeremy.
(This used to be commit 6356b792683100122500db9cf222b7e8518d834e)
|
|
Jeremy.
(This used to be commit a6cb7af9bad1610e802fa5cddbf68fb887bc2974)
|
|
on an initial open the desired_access field *must* contain DELETE_ACCESS,
simply having it map from a GENERIC_ALL won't do. Fixes delete on close test.
Jeremy.
(This used to be commit fb4249e7d12bee4589edff40f1e76f1a19a6ffaa)
|
|
(This used to be commit cd48827418d8be15470e833ea19ab9830e160e12)
|
|
I've now tested this in daemon mode and also on xinetd and I'm pretty
sure it's working.
Jeremy.
(This used to be commit f3e51dbc21c616d261f0a65b9fa69dbb8b5a9a0f)
|
|
Jeremy.
(This used to be commit a7d4a6d1167f7657113148cdf68ea3c491b51b14)
|
|
HEAD PDC tomorrow)
(This used to be commit c57b24ee49aee0f0687742da7f8d741c62f6effe)
|
|
nsswitch/winbindd_util.c:
add static
smbd/uid.c:
remove unused function
Andrew Bartlett
(This used to be commit 4822a3f73610f6e468c447f1282246f13a378cde)
|
|
More 'static' work.
Andrew Bartlett
(This used to be commit 620f909eed3d994d01ca53068a33856d25917144)
|
|
Make more functions static, and remove duplication in the use of functions
in lib/smbpasswd.c that were exact duplicates of functions in passdb/passdb.c
(These should perhaps be pulled back out to smbpasswd.c, but that can occour
later).
This also includes some >14 character password changes, and the start
of a move away from using 'admin user' to determine if the user is
root (as root can login without setting 'admin user').
Andrew Bartlett
(This used to be commit be0704abb919152c359a735023283acbf9be3076)
|
|
Samba hasn't used this function for ages - it's now handled deep in the
auth subsystem.
Andrew Bartlett
(This used to be commit bb505ca696427f105d05a0b9aab6d5eee043ede6)
|
|
* don't set the unix_ERR_XX code in mkdir_internal, let the error mapping
handle it.
(This used to be commit 758bbfb5f133c3c85e3092ad88294ae4abbbbc6f)
|