summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2010-10-08Fix bug 7716 - acl_xattr and acl_tdb modules don't store unmodified copies ↵Jeremy Allison1-1/+13
of security descriptors. As pointed out by an OEM, the code within smbd/posix_acl.c, even though passed a const pointer to a security descriptor, still modifies the ACE entries within it (which are not const pointers). This means ACLs stored in the extended attribute by the acl_xattr module have already been modified by the POSIX acl layer, and are not the original intent of storing the "unmodified" ACL from the client. Use dup_sec_desc to make a copy of the incoming ACL on talloc_tos() - that is what is then modified inside smbd/posix_acl.c, leaving the original ACL to be correctly stored in the xattr. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Oct 8 00:37:53 UTC 2010 on sn-devel-104
2010-10-07s3: Fix the async echo responder for netbios keepalivesVolker Lendecke1-10/+23
This fixes a crash in the echo responder when the client started to send the NetBIOS-Level 0x85-style keepalive packets. We did not correctly check the packet length, so the code writing the signing seqnum overwrote memory after the malloc'ed area for the 4 byte keepalive packet. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Oct 7 19:47:35 UTC 2010 on sn-devel-104
2010-10-06Fix crash in SMB2 rename found by gentest. We must always have an lcompJeremy Allison1-1/+1
in the destination struct for a rename, so set the flag appropriately. Jeremy.
2010-10-06s3: Make the write end of the echo responder pipe non-blockingVolker Lendecke1-0/+1
Without this, we can get a writable pipe end, but the writev call on the pipe will block. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Oct 6 13:57:30 UTC 2010 on sn-devel-104
2010-10-06Fix crash in SMB2 rename found by gentest. We must always have an lcompJeremy Allison1-1/+1
in the destination struct for a rename, so set the flag appropriately. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Oct 6 00:29:51 UTC 2010 on sn-devel-104
2010-10-05s3: Stop using the write cache after an oplock breakVolker Lendecke1-0/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue Oct 5 10:09:38 UTC 2010 on sn-devel-104
2010-10-03s3: Remove smbd_server_conn from msg_force_tdisVolker Lendecke1-1/+7
2010-10-03s3: Remove smbd_server_conn from process_blocking_lock_cancel_messageVolker Lendecke1-1/+7
2010-10-03s3: Remove smbd_server_conn from smb1 receive_unlock_msgVolker Lendecke1-1/+9
2010-10-03s3: Remove smbd_server_conn from msg_file_was_renamedVolker Lendecke1-1/+8
2010-10-03s3: Remove smbd_server_conn from validate_my_share_entriesVolker Lendecke1-3/+5
2010-10-03s3: Remove smbd_server_conn from msg_close_fileVolker Lendecke1-1/+8
2010-10-03s3: Remove smbd_server_conn from smb2 receive_unlock_msgVolker Lendecke1-1/+9
2010-10-03s3: Remove smbd_server_conn from process_kernel_oplock_breakVolker Lendecke1-2/+8
2010-10-03s3: Remove smbd_server_conn from process_oplock_break_messageVolker Lendecke1-3/+8
2010-10-03s3: Remove smbd_server_conn from process_oplock_async_level2_break_messageVolker Lendecke1-2/+8
2010-10-03s3: Lift smbd_server_conn from initial_break_processingVolker Lendecke1-5/+9
2010-10-03s3: Add msg_ctx_to_sconnVolker Lendecke2-0/+15
2010-10-03s3: I thought I had compiled this....Volker Lendecke1-1/+1
2010-10-03s3: Attempt to fix the IRIX buildVolker Lendecke1-1/+1
2010-10-03s3: Attempt to fix a ton of warnings on the build farmVolker Lendecke1-0/+1
2010-10-03s3: Remove talloc_autofree_context() from dmapi.cVolker Lendecke1-2/+1
This is a place where an explicit dmapi_destroy_session would be needed. But we don't use a destructor for this.
2010-10-01s3:smbd: Increase unsupported IOCTL debug message to 2Steven Danneman1-2/+4
Even printing once per connection, level 0 was too spammy with Windows clients frequently sending FSCTL_GET_OBJECT_ID which is unsupported.
2010-10-01s3:events: Call all ready fd event handlers on each iteration of the main loopSteven Danneman1-19/+16
Previously, only one fd handler was being called per main message loop in all smbd child processes. In the case where multiple fds are available for reading the fd corresponding to the event closest to the beginning of the event list would be run. Obviously this is arbitrary and could cause unfairness. Usually, the first event fd is the network socket, meaning heavy load of client requests can starve out other fd events such as oplock or notify upcalls from the kernel. In this patch, I have changed the behavior of run_events() to unset any fd that it has already called a handler function, as well as decrement the number of fds that were returned from select(). This allows the caller of run_events() to iterate it, until all available fds have been handled. I then changed the main loop in smbd child processes to iterate run_events(). This way, all available fds are handled on each wake of select, while still checking for timed or signalled events between each handler function call. I also added an explicit check for EINTR from select(), which previously was masked by the fact that run_events() would handle any signal event before the return code was checked. This required a signature change to run_events() but all other callers should have no change in their behavior. I also fixed a bug in run_events() where it could be called with a selrtn value of -1, doing unecessary looping through the fd_event list when no fds were available. Also, remove the temporary echo handler hack, as all fds should be treated fairly now.
2010-10-01samba: share select wrappers.Günther Deschner1-0/+1
Guenther
2010-09-28s3: Attempt to fix bug 7518Volker Lendecke1-6/+6
If select returns -1, we can't rely on the fd sets. The current code might loop endlessly because when putting an invalid fd (the closed socket?) on the read set, a select implementation might choose not to touch it but directly return with EINVAL. Thus run_events will see the socket readable, which leads to a "return true", and thus a NT_STATUS_RETRY -> same game again. We should never get into this situation, but to me the logfiles given in bug 7518 do not reveal enough information to understand how this can happen.
2010-09-28s3: Increase the debuglevel for connection termination msgsVolker Lendecke1-2/+2
2010-09-28s3: Lift smbd_messaging_context() from open_sockets_smbd()Volker Lendecke1-16/+14
2010-09-28s3: Remove two calls to procid_self()Volker Lendecke1-2/+4
2010-09-28s3: Remove some remaining files.c globals to sconnVolker Lendecke3-53/+49
2010-09-28s3: Remove talloc_autofree_context() from files.cVolker Lendecke2-6/+9
2010-09-28s3: Lift smbd_server_conn from file_find_fdVolker Lendecke2-4/+4
2010-09-28s3: Remove smbd_server_conn from file_fspVolker Lendecke1-1/+1
2010-09-28s3: Slightly simplify file_fnumVolker Lendecke1-2/+15
req==NULL should never happen, see the comment
2010-09-28s3: Remove smbd_server_conn from file_sync_allVolker Lendecke1-1/+1
2010-09-28s3: Remove smbd_server_conn from file_find_subpathVolker Lendecke1-1/+1
2010-09-28s3: Lift smbd_server_conn from file_find_di_firstVolker Lendecke4-8/+11
2010-09-28s3: Lift smbd_server_conn from file_find_difVolker Lendecke4-6/+7
2010-09-28s3: Remove smbd_server_conn from files_forallVolker Lendecke2-6/+6
2010-09-28s3: Remove smbd_server_conn from file_close_userVolker Lendecke2-3/+3
2010-09-28s3: Remove smbd_server_conn from file_close_pidVolker Lendecke2-3/+4
2010-09-28s3: Remove smbd_server_conn from file_close_connVolker Lendecke1-1/+1
2010-09-28s3: Remove smbd_server_conn from file_new and file_freeVolker Lendecke1-2/+2
2010-09-28s3: Lift smbd_server_conn from file_fnumVolker Lendecke1-4/+5
2010-09-28s3: Move "Files" to smbd_server_connectionVolker Lendecke3-17/+16
2010-09-28s3: Remove "server_fd" global variableVolker Lendecke3-9/+4
2010-09-27Small tweak to bugfix for 7698 - Assert causes smbd to panic on invalid ↵Jeremy Allison1-3/+3
NetBIOS session request. Don't just fail to reply on a bad NBT name, just don't do the internal action. Jeremy.
2010-09-27Change to using TDB_INCOMPATIBLE_HASH (the jenkins hash) on allJeremy Allison1-4/+4
TDB_CLEAR_IF_FIRST tdb's. For tdb's like gencache where we open without CLEAR_IF_FIRST and then with CLEAR_IF_FIRST if corrupt this is still safe to use as if opening an existing tdb the new hash will be ignored - it's only used on creating a new tdb not opening an old one. Jeremy.
2010-09-27s3: Make file_fnum staticVolker Lendecke1-1/+1
2010-09-27s3: Remove some unused codeVolker Lendecke1-50/+0
generated by cgit (git 2.34.1) at 2024-11-10 11:05:52 +0000