summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2008-11-28Remove "conn" parameter from np_open, smb_request contains itVolker Lendecke2-2/+2
2008-11-28Remove inbuf references from the trans2ioctl codeVolker Lendecke1-4/+4
2008-11-28Consolidate the buffer checks for the reply_trans style functionsVolker Lendecke3-169/+54
This is the one where I found the problem that led to 3.2.5. So if there is one checkin in the last year that I would like others to review and *understand*, it is this one :-) Volker
2008-11-28Remove the variable "size" from reply_nttransVolker Lendecke1-10/+13
This converts the range checks for the setup[] array to rely on req->wct being set correctly in init_smb_request. As that already verifies the vwv array to be in the range of the smb_request inbuf, we don't have to do overflow checks here anymore. Jeremy, please check thoroughly! :-) Thanks, Volker
2008-11-28Remove the variable "size" from reply_transVolker Lendecke1-12/+16
This converts the range checks for the setup[] array to rely on req->wct being set correctly in init_smb_request. As that already verifies the vwv array to be in the range of the smb_request inbuf, we don't have to do overflow checks here anymore. Jeremy, please check thoroughly! :-) Thanks, Volker
2008-11-28Remove an unused variableVolker Lendecke1-2/+0
2008-11-28Remove two direct inbuf references from reply_sesssetup_and_X_spnego()Volker Lendecke1-2/+2
2008-11-27Fix the offset checks in the trans routinesVolker Lendecke3-9/+9
This fixes a potential crash bug, a client can make us read memory we should not read. Luckily I got the disp checks right... Volker (cherry picked from commit 64a1d80851da5b05e70ec6c96f6e9bd473748369) (cherry picked from commit f04c5650a3aeca23591ddc781c4b297caaf9bb3f)
2008-11-24Fix bug #5873 - ACL inheritance cannot be broken. This regresses #4308, but ↵Jeremy Allison1-0/+8
that will have to be fixed another way. Jeremy.
2008-11-24Get rid of pipes_struct->pipe_user, we have server_info now --- YESSS!Volker Lendecke1-3/+3
2008-11-24Remove unused make_connection_with_chdir()Volker Lendecke1-32/+0
2008-11-23Fix to allow setting of NULL DACL/SACLSteven Danneman1-11/+2
This is a modification of Jeremy's 7522ef15aca2429ef57c75d8297dd8121e79c9da commit. If no DACL/SACL is present in the packet, the SEC_INFO field should still be passed down as is to the VFS layer to signal the creation of a NULL DACL/SACL. As seen in metze RAW-ACL test_nttrans_create_null_dacl(), a NULL DACL is set regardless of the SEC_DESC_DACL_PRESENT bit being set.
2008-11-23Add auth_serversupplied_info to create_conn_structVolker Lendecke1-4/+15
srvsvc needs it, as will printing
2008-11-21Rever 83ff6979f504d50caf725ee62549604630b69be7 - "Fix the logic bug that ↵Jeremy Allison1-7/+1
caused us to run into kernel oplocks on an open for a stream inside a file with stream_xattr module. On opening the base_fsp we must break existing oplocks." as it broke make test. Jeremy.
2008-11-21Fix the logic bug that caused us to run into kernel oplocks on an open for a ↵Jeremy Allison1-1/+7
stream inside a file with stream_xattr module. On opening the base_fsp we must break existing oplocks. Jeremy.
2008-11-21Second part of the fix for bug #5903 - vfs_streams_xattr breaks contents of ↵Jeremy Allison1-15/+46
the file (also fix a bad merge of the previous patch from 3.3). Jeremy.
2008-11-21First part of fix for bug #5903 - vfs_streams_xattr breaks contents of the file.Jeremy Allison5-109/+126
Restructures parts of open code so that fsp must be allocated before calling open_file_ntcreate(_internal). Also fix up file ref-counting inside files.c. Jeremy.
2008-11-20Fix bug #5909 - MS-DFS does not work on Vista, if link name includes ↵Yasuma Takeda1-6/+6
multibyte character.
2008-11-18Fix bug #5908 - Samba 3.0.32 - internal change notify on share directory fails"Dina Fine1-0/+3
2008-11-18Re-structure Volker's patch to "Fix trans2findfirst for the large directory ↵Jeremy Allison1-26/+21
optimization". Makes the change clearer. Jeremy.
2008-11-18Fix trans2findfirst for the large directory optimizationVolker Lendecke1-0/+5
With case sensitive = yes preserve case = no short preserve case = no default case = upper a "dir FOO.txt" would not find "FOO.TXT" because FOO.txt ends up unconverted in the mask for mask_match. Jeremy, please check! Volker
2008-11-17Fix bug #5900 reported by monyo@samba.gr.jp - vfs_readonly.so does not work.Jeremy Allison2-3/+6
Jeremy.
2008-11-12Fix build breakTim Prouty1-1/+1
2008-11-12Pretty print out SD's on get/set.Jeremy Allison1-0/+10
Jeremy.
2008-11-12s3: Add support for storing dos attributes as st_flags in the stat struct.Tim Prouty1-13/+147
Some filesystems have support for storing dos attributes directly in the inode's st_flags and accessing them through the stat struct. This patch: - Adds a configure check to see if the special flags are available. - Implements getting and setting dos attributes in the stat struct and inode, respectively. This will not change the existing functionality of any system that doesn't have the special flags available.
2008-11-11Fix bug 5889. "delete veto files = no" seems to break.Jeremy Allison1-4/+11
Jeremy.
2008-11-08Make "construct_reply_common" staticVolker Lendecke1-1/+3
2008-11-08Do not write into inbuf for the transs requestVolker Lendecke4-19/+23
Instead, fix up the outbuf in send_xx_reply. In those routines, we know what we are returning.
2008-11-08Remove direct inbuf refs from send_trans_replyVolker Lendecke1-37/+35
2008-11-08change CHECK_READ to use smb_request instead of inbufVolker Lendecke1-3/+3
2008-11-08Remove a direct inbuf reference from reply_nttrans()Volker Lendecke1-2/+1
2008-11-08Remove a direct inbuf reference (should have been removed with 8987641d...)Volker Lendecke1-1/+1
2008-11-08Remove the change to the user context in process_blocking_lock_queue()Volker Lendecke1-76/+8
2008-11-08Converting notify.c to store a request, not an inbufVolker Lendecke2-56/+30
2008-11-06Make us clean under valgrind --leak-check=full by using ↵Jeremy Allison2-4/+4
talloc_autofree_context() instead of NULL. Remove the code in memcache that does a TALLOC_FREE on stored pointers. That's a disaster waiting to happen. If you're storing talloc'ed pointers, you can't know their lifecycle and they should be deleted when their parent context is deleted, so freeing them at some arbitrary point later will be a double-free. Jeremy.
2008-11-06Convert to use VFS layer.Herb Lewis1-1/+1
2008-11-06Add wrapper str_list_make_v3() to replace the old S3 behavior ofJeremy Allison2-2/+2
str_list_make(). From Dan Sledz <dan.sledz@isilon.com>: In samba 3.2 passing NULL or an empty string returned NULL. In master, it now returns a list of length 1 with the first string set to NULL (an empty list). Jeremy.
2008-11-06Final fix to make us pass NULL SD test in RAW-ACLs. Not sure if this is 100% ↵Jeremy Allison1-0/+3
right. Only inheritance left to fix. Jeremy.
2008-11-06Don't call FSET_NT_ACL on file create if there's no SD to set. Leave the ↵Jeremy Allison1-1/+6
default ACL in place. Jeremy.
2008-11-05Add reference to bug #4308 to remind me to add regression test to smbtorture.Jeremy Allison1-1/+1
Jeremy.
2008-11-05Fix the buildVolker Lendecke1-1/+1
2008-11-04Fix a const warningVolker Lendecke1-1/+1
2008-11-04Convert blocking.c to store a smb_request instead of just inbufVolker Lendecke1-88/+54
2008-11-04Simplify logic of cancel_pending_lock_requests_by_fid()Volker Lendecke1-20/+18
The only caller of this function is locking_close_file(). This checks itself if brl_lock != NULL. The additional check is not necessary here.
2008-11-04Slightly simplify logic in process_lockingX()Volker Lendecke1-7/+8
The "else" is pointless here, we did a "return True" in the if branch.
2008-11-04Slightly simplify logic in remove_pending_lock_requests_by_mid()Volker Lendecke1-13/+21
Use "continue" for (SVAL(blr->inbuf,smb_mid) != mid)
2008-11-04Slightly simplify logic in cancel_pending_lock_requests_by_fid()Volker Lendecke1-20/+24
Use a "continue" for (blr->fsp->fnum != fsp->fnum)
2008-11-04Convert blocking.c to use tallocVolker Lendecke1-23/+15
2008-11-04Rewrite aio.c to keep the whole smb_request structure, not just the inbufVolker Lendecke1-75/+41
2008-11-04Make "inbuf" a talloc child of "smb_request" for normal smb requestsVolker Lendecke3-3/+5
This is necessary if we want to keep the whole smb_request for deferred ops. The explicit settings of req->inbuf will be removed once all those deferring operations are converted to store the whole request and not just the inbuf.
generated by cgit (git 2.34.1) at 2024-11-18 19:22:11 +0000