| Age | Commit message (Collapse) | Author | Files | Lines | |
|---|---|---|---|---|---|
| 2010-10-01 | s3:smbd: Increase unsupported IOCTL debug message to 2 | Steven Danneman | 1 | -2/+4 | |
| Even printing once per connection, level 0 was too spammy with Windows clients frequently sending FSCTL_GET_OBJECT_ID which is unsupported. | |||||
| 2010-10-01 | s3:events: Call all ready fd event handlers on each iteration of the main loop | Steven Danneman | 1 | -19/+16 | |
| Previously, only one fd handler was being called per main message loop in all smbd child processes. In the case where multiple fds are available for reading the fd corresponding to the event closest to the beginning of the event list would be run. Obviously this is arbitrary and could cause unfairness. Usually, the first event fd is the network socket, meaning heavy load of client requests can starve out other fd events such as oplock or notify upcalls from the kernel. In this patch, I have changed the behavior of run_events() to unset any fd that it has already called a handler function, as well as decrement the number of fds that were returned from select(). This allows the caller of run_events() to iterate it, until all available fds have been handled. I then changed the main loop in smbd child processes to iterate run_events(). This way, all available fds are handled on each wake of select, while still checking for timed or signalled events between each handler function call. I also added an explicit check for EINTR from select(), which previously was masked by the fact that run_events() would handle any signal event before the return code was checked. This required a signature change to run_events() but all other callers should have no change in their behavior. I also fixed a bug in run_events() where it could be called with a selrtn value of -1, doing unecessary looping through the fd_event list when no fds were available. Also, remove the temporary echo handler hack, as all fds should be treated fairly now. | |||||
| 2010-10-01 | samba: share select wrappers. | Günther Deschner | 1 | -0/+1 | |
| Guenther | |||||
| 2010-09-28 | s3: Attempt to fix bug 7518 | Volker Lendecke | 1 | -6/+6 | |
| If select returns -1, we can't rely on the fd sets. The current code might loop endlessly because when putting an invalid fd (the closed socket?) on the read set, a select implementation might choose not to touch it but directly return with EINVAL. Thus run_events will see the socket readable, which leads to a "return true", and thus a NT_STATUS_RETRY -> same game again. We should never get into this situation, but to me the logfiles given in bug 7518 do not reveal enough information to understand how this can happen. | |||||
| 2010-09-28 | s3: Increase the debuglevel for connection termination msgs | Volker Lendecke | 1 | -2/+2 | |
| 2010-09-28 | s3: Lift smbd_messaging_context() from open_sockets_smbd() | Volker Lendecke | 1 | -16/+14 | |
| 2010-09-28 | s3: Remove two calls to procid_self() | Volker Lendecke | 1 | -2/+4 | |
| 2010-09-28 | s3: Remove some remaining files.c globals to sconn | Volker Lendecke | 3 | -53/+49 | |
| 2010-09-28 | s3: Remove talloc_autofree_context() from files.c | Volker Lendecke | 2 | -6/+9 | |
| 2010-09-28 | s3: Lift smbd_server_conn from file_find_fd | Volker Lendecke | 2 | -4/+4 | |
| 2010-09-28 | s3: Remove smbd_server_conn from file_fsp | Volker Lendecke | 1 | -1/+1 | |
| 2010-09-28 | s3: Slightly simplify file_fnum | Volker Lendecke | 1 | -2/+15 | |
| req==NULL should never happen, see the comment | |||||
| 2010-09-28 | s3: Remove smbd_server_conn from file_sync_all | Volker Lendecke | 1 | -1/+1 | |
| 2010-09-28 | s3: Remove smbd_server_conn from file_find_subpath | Volker Lendecke | 1 | -1/+1 | |
| 2010-09-28 | s3: Lift smbd_server_conn from file_find_di_first | Volker Lendecke | 4 | -8/+11 | |
| 2010-09-28 | s3: Lift smbd_server_conn from file_find_dif | Volker Lendecke | 4 | -6/+7 | |
| 2010-09-28 | s3: Remove smbd_server_conn from files_forall | Volker Lendecke | 2 | -6/+6 | |
| 2010-09-28 | s3: Remove smbd_server_conn from file_close_user | Volker Lendecke | 2 | -3/+3 | |
| 2010-09-28 | s3: Remove smbd_server_conn from file_close_pid | Volker Lendecke | 2 | -3/+4 | |
| 2010-09-28 | s3: Remove smbd_server_conn from file_close_conn | Volker Lendecke | 1 | -1/+1 | |
| 2010-09-28 | s3: Remove smbd_server_conn from file_new and file_free | Volker Lendecke | 1 | -2/+2 | |
| 2010-09-28 | s3: Lift smbd_server_conn from file_fnum | Volker Lendecke | 1 | -4/+5 | |
| 2010-09-28 | s3: Move "Files" to smbd_server_connection | Volker Lendecke | 3 | -17/+16 | |
| 2010-09-28 | s3: Remove "server_fd" global variable | Volker Lendecke | 3 | -9/+4 | |
| 2010-09-27 | Small tweak to bugfix for 7698 - Assert causes smbd to panic on invalid ↵ | Jeremy Allison | 1 | -3/+3 | |
| NetBIOS session request. Don't just fail to reply on a bad NBT name, just don't do the internal action. Jeremy. | |||||
| 2010-09-27 | Change to using TDB_INCOMPATIBLE_HASH (the jenkins hash) on all | Jeremy Allison | 1 | -4/+4 | |
| TDB_CLEAR_IF_FIRST tdb's. For tdb's like gencache where we open without CLEAR_IF_FIRST and then with CLEAR_IF_FIRST if corrupt this is still safe to use as if opening an existing tdb the new hash will be ignored - it's only used on creating a new tdb not opening an old one. Jeremy. | |||||
| 2010-09-27 | s3: Make file_fnum static | Volker Lendecke | 1 | -1/+1 | |
| 2010-09-27 | s3: Remove some unused code | Volker Lendecke | 1 | -50/+0 | |
| 2010-09-27 | s3: Fix some comments | Volker Lendecke | 1 | -2/+2 | |
| 2010-09-26 | s3: Remove talloc_autofree_context() from notify_internal_parent_init() | Volker Lendecke | 2 | -5/+4 | |
| 2010-09-26 | Fix bug #7698 - Assert causes smbd to panic on invalid NetBIOS session request. | Jeremy Allison | 2 | -12/+31 | |
| Found by the CodeNomicon test suites at the SNIA plugfest. http://www.codenomicon.com/ If an invalid NetBIOS session request is received the code in name_len() in libsmb/nmblib.c can hit an assert. Re-write name_len() and name_extract() to use "buf/len" pairs and always limit reads. Jeremy. | |||||
| 2010-09-26 | s3: Remove talloc_autofree_context() from change_to_guest() | Volker Lendecke | 1 | -1/+1 | |
| pass is freed at the exit of this routine | |||||
| 2010-09-26 | s3: Remove talloc_autofree_context() from serverid_parent_init() | Volker Lendecke | 1 | -1/+1 | |
| 2010-09-26 | s3: Remove talloc_autofree_context() from messaging_tdb_parent_init() | Volker Lendecke | 1 | -1/+1 | |
| 2010-09-26 | s3: Avoid an explicit ZERO_STRUCT | Volker Lendecke | 1 | -3/+1 | |
| 2010-09-26 | s3: Lift talloc_autofree_context() from make_auth_context_fixed() | Volker Lendecke | 1 | -2/+2 | |
| 2010-09-26 | s3: Lift talloc_autofree_context() from make_auth_context_subsystem() | Volker Lendecke | 2 | -2/+2 | |
| 2010-09-23 | Fix bug 7694 - Crash bug with invalid SPNEGO token. | Jeremy Allison | 1 | -1/+2 | |
| Found by the CodeNomicon test suites at the SNIA plugfest. http://www.codenomicon.com/ If an invalid SPNEGO packet contains no OIDs we crash in the SMB1/SMB2 server as we indirect the first returned value OIDs[0], which is returned as NULL. Jeremy. | |||||
| 2010-09-22 | Thank goodness for code reviews. Volker caught - this should be ↵ | Jeremy Allison | 1 | -1/+1 | |
| lp_posix_pathnames() not lp_unix_extensions(). Jeremy. | |||||
| 2010-09-22 | Fix bug #7693 - smbd changing mode of files on rename | Jeremy Allison | 2 | -8/+10 | |
| When using "map archive", don't change the archive bit on renames or writes with UNIX extensions turned on. Jeremy. | |||||
| 2010-09-21 | s3:registry: move prototype from reg_init_full.c to its own header. | Michael Adam | 1 | -0/+1 | |
| 2010-09-20 | s3-util_sid: use shared dom_sid_compare_auth and dom_sid_equal_X functions. | Günther Deschner | 1 | -17/+18 | |
| Guenther | |||||
| 2010-09-20 | s3-build: only include ctdbd_conn.h where needed. | Günther Deschner | 2 | -0/+2 | |
| Guenther | |||||
| 2010-09-20 | s3-build: only include async headers where needed. | Günther Deschner | 1 | -0/+1 | |
| Guenther | |||||
| 2010-09-16 | libcli/auth/ntlmssp Be clear about talloc parents for session keys | Andrew Bartlett | 1 | -0/+1 | |
| The previous API was not clear as to who owned the returned session key. This fixes a valgrind-found use-after-free in the NTLMSSP key derivation code, and avoids making allocations - we steal and zero instead. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org> | |||||
| 2010-09-15 | Fix all sid_parse returns to be checked. Tidy up some checks and error | Jeremy Allison | 1 | -5/+12 | |
| messages. Jeremy. | |||||
| 2010-09-16 | s3-smbd: prevent call_nt_transact_ioctl() crash in FSCTL_FIND_FILES_BY_SID case. | Günther Deschner | 1 | -1/+4 | |
| Jeremy, please check. Guenther | |||||
| 2010-09-15 | Add check for invalid data size. | Jeremy Allison | 1 | -1/+8 | |
| Jeremy. | |||||
| 2010-09-15 | s3-rpc_server: Moved ncacn_np declarations in common header file. | Simo Sorce | 2 | -0/+2 | |
| Signed-off-by: Andreas Schneider <asn@samba.org> | |||||
| 2010-09-15 | s3-rpc_server: Convert rpc_connect_spoolss_pipe into a generic interface. | Simo Sorce | 2 | -10/+60 | |
| This way we have one common way to open internal pipes whether they are shortcircuited or piped to an external process. | |||||
 |
index : samba | |
| Unnamed repository; edit this file 'description' to name the repository. | ben |
| summaryrefslogtreecommitdiff |