summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r25111: Move to talloced pathnames on most code paths.Jeremy Allison6-340/+423
There are now ony 17 pstrings left in reply.c, and these will be easy to remove (and I'll be doing that shortly). Had to fix an interesting bug in pull_ucs2_base_talloc() when a source string is not null terminated :-). Jeremy. (This used to be commit 0c9a8c4dff10974dbffd2a302ae982896122fcc0)
2007-10-10r25103: Ensure we don't return unwritten memory (valgrind caught).Jeremy Allison2-64/+83
Jeremy. (This used to be commit b3f0d39d11fa18b7bfef6cec88efaf4a2be2d6e0)
2007-10-10r25102: Rewrite msdfs code to use talloced filenames. Passes make testJeremy Allison5-395/+811
and make valgrindtest. Final step will be to change srvstr_get_path() to return talloced memory in the major codepaths. Jeremy. (This used to be commit cf6b6f9c3a38b68d2671c753f412772344506742)
2007-10-10r25055: Add file_id_string_tosVolker Lendecke7-29/+29
This removes file_id_string_static and file_id_string_static2 (This used to be commit 638c848c9afe374feb30e34c494f89b2a6c64f7b)
2007-10-10r25011: We don't use mangle_map any more.Jeremy Allison1-211/+0
Jeremy. (This used to be commit 2e0999c1df33c192fee5f739070a0e4c3d22dff8)
2007-10-10r25009: Large patch discussed with Volker. Move unix_convert to a talloc-basedJeremy Allison10-639/+947
interface. More development will come on top of this. Remove the "mangled map" parameter. Jeremy. (This used to be commit dee8beba7a92b8a3f68bbcc59fd0a827f68c7736)
2007-10-10r24949: Remove some static buffersVolker Lendecke1-7/+5
(This used to be commit df648d47ff3c4e24f439fda839653bda98323100)
2007-10-10r24813: Reformat to 80 columns.Jeremy Allison1-19/+32
Jeremy. (This used to be commit c6c8f5a897602d53876fe75e86283d97a394037d)
2007-10-10r24811: Simple reformatting to fit the 80 columns rule.Jeremy Allison1-63/+96
Jeremy. (This used to be commit 0cdf046dae8ba0741bb7786aa4e85c34fc35dade)
2007-10-10r24809: Consolidate the use of temporary talloc contexts.Volker Lendecke10-21/+16
This adds the two functions talloc_stackframe() and talloc_tos(). * When a new talloc stackframe is allocated with talloc_stackframe(), then * the TALLOC_CTX returned with talloc_tos() is reset to that new * frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse * happens: The previous talloc_tos() is restored. * * This API is designed to be robust in the sense that if someone forgets to * TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and * resets the talloc_tos(). The original motivation for this patch was to get rid of the sid_string_static & friends buffers. Explicitly passing talloc context everywhere clutters code too much for my taste, so an implicit talloc_tos() is introduced here. Many of these static buffers are replaced by a single static pointer. The intended use would thus be that low-level functions can rather freely push stuff to talloc_tos, the upper layers clean up by freeing the stackframe. The more of these stackframes are used and correctly freed the more exact the memory cleanup happens. This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and lp_talloc_ctx (did I forget any?) So, never do a tmp_ctx = talloc_init("foo"); anymore, instead, use tmp_ctx = talloc_stackframe() :-) Volker (This used to be commit 6585ea2cb7f417e14540495b9c7380fe9c8c717b)
2007-10-10r24791: Fix logic error in timeout of blocking lock processing found byJeremy Allison1-22/+29
Ronnie. If a lock timeout expires, we must check we can get the lock before responding with failure. Volker is writing a torture test. Jeremy. (This used to be commit 45380f356b99d575645873b05af17c504b091dc8)
2007-10-10r24702: Remove the old API pointersVolker Lendecke8-537/+337
(This used to be commit 17df313db42199e26d7d2044f6a1d845aacd1a90)
2007-10-10r24699: Actually write 24 zeros instead of zero 24's...Volker Lendecke1-1/+1
Jeremy, please check ;-) (This used to be commit 85b64bde7df10ade5ba0abd493d433a7688f0979)
2007-10-10r24661: Fix some obvious diffs between 3_2 and 3_2_0Volker Lendecke1-3/+5
Jeremy, there are two remaining diffs in sesssetup.c which I don't really know which one is right. Can you take a look? Thanks, Volker (This used to be commit d82f35448763eacd564836f34c9aa450b15ea582)
2007-10-10r24659: Some formatting changes helping to minimize the 3_2_0 diffVolker Lendecke3-16/+15
(This used to be commit c5caea43af154671448df82881efe09a5c982386)
2007-10-10r24639: Add parameter "directory name cache size" - parameterizeJeremy Allison1-20/+33
use of directory name cache, 100 by default. Will be needed to turn this off for *BSD systems. Jeremy. (This used to be commit bea8e9840fd65268e649f813eba10502b0c4d721)
2007-10-10r24638: Remove redundent setting of vuid.Jeremy Allison1-3/+1
Jeremy (This used to be commit fd682c3f397714ebdaf4af3f6d1cbcbab6a2f572)
2007-10-10r24621: - deferr calling build_options();exit(0);Stefan Metzmacher1-5/+10
- use poptPrintUsage() to give the user more info metze (This used to be commit a95d9d1ef99d6a2f77a289f8d2011cae482821b1)
2007-10-10r24603: In case of error we need to free prefix_cache otherwise on re-init ↵Simo Sorce1-0/+1
the first statement will return positively but prefix_cache_hashes would be NULL (This used to be commit fdc20894a0deb3c68b834e5d9d466873ca634bed)
2007-10-10r24599: patch from Karolin Seeger <ks@sernet.de>:Stefan Metzmacher1-1/+4
smbd, nmbd and winbindd can be started with invalid options currently. The first patch attached would be a possible solution. It contains an exit if an invalid option has been used. The main problem is, that existing setups with wrong options or missing arguments in start scripts will break (which is the right behaviour from my point of view). metze (This used to be commit 8532e3182ab44d4ac84823e9798293f156192aaf)
2007-10-10r24595: Fix Coverity ID 393Volker Lendecke1-2/+1
In this error case we would have used "start" not having it initialized (This used to be commit 751834fff92e85a424152c1642b238daa3060dbd)
2007-10-10r24590: Reformatting to coding standards. Added my (C) in places it already ↵Jeremy Allison2-191/+271
should have been :-). Jeremy. (This used to be commit 41611a22ed852bb74e2ef3f45766c0580ffd3a18)
2007-10-10r24589: Refactor our vuid code so that we keep the sameJeremy Allison2-175/+244
vuid that was allocated whilst the connection is being constructed and after the connection has been set up. This is what Windows does and at least one client (and HP printer) depends on this behaviour. As it depends on the req struct not yet ported to SAMBA_3_2_0 (Volker, hint hint.... :-) I am not yet adding this to that branch, but will investigate that tomorrow. Jeremy. (This used to be commit a54f2805df92c67e74a6764568eedebe394fd500)
2007-10-10r24549: Fix unix_convert to return the already converted partVolker Lendecke1-4/+10
This API will change anyway when moving away from pstrings. It took so long to fix, because that rename bug I just fixed gave make test failures that had nothing to do with this one. I have samba4 tests for both bugs, will check them in when the build farm has caught up (This used to be commit d4f442ed9b145990af4db26859663954ddd70926)
2007-10-10r24548: Fix the case-changing renamesVolker Lendecke2-15/+29
This was broken when I changed reply_mv to wrap in a open_file_ntcreate call, unix_convert on the destination was called twice (This used to be commit fddc9db91175bdb0b7ac6a636f8bef918bd7c1b4)
2007-10-10r24512: Fix RAW-NOTIFYVolker Lendecke1-2/+10
With the inbuf consistency checks we have to more correctly fake the inbuf (This used to be commit 2b8ecda30fc57bb4027b7208d22d85d213074158)
2007-10-10r24501: Added bcc test for reply_tcon & removed Vl's comment :-).Jeremy Allison1-6/+5
Jeremy. (This used to be commit 9d9ed41f2139051578c35f80112640cffb5f7608)
2007-10-10r24500: Add check that bcc is correct in an incoming packet.Jeremy Allison1-1/+10
Jeremy. (This used to be commit 267a0ac48d358e1bd10d92238352ca3d867a58d4)
2007-10-10r24498: More extra code into a function, reply_openerror.Jeremy Allison4-155/+96
Jeremy. (This used to be commit 43ddfb8c918bd27e2efd3b54077db815da80a53a)
2007-10-10r24497: Revert r24485 -- this needs more thoughtVolker Lendecke1-1/+1
(This used to be commit 01f701ba1ea9859b090aaf8f4ae9722c5502316c)
2007-10-10r24485: Even in the failure case unix_convert must pass the already convertedVolker Lendecke1-1/+1
part of the string to the caller. (This used to be commit 301ae3d68bc64c9526eb7d4458584a5ebb151137)
2007-10-10r24476: Fix the mappings in reply_opeXXX calls. Now to test renames.Jeremy Allison2-8/+27
Jeremy. (This used to be commit 74d10b09a68f5c06d6b3ceffe0a40818dc84106e)
2007-10-10r24475: Fix the error mapping for SMB_POSIX_PATH_OPEN.Jeremy Allison1-0/+12
Jeremy. (This used to be commit 6dac315ba1d9b9582c2b573e0785b2f6d627f846)
2007-10-10r24474: Map error value NT_STATUS_OBJECT_NAME_COLLISIONJeremy Allison1-34/+24
to ERRDOS, ERRfilexists for NTCreateX and NTTransCreate. Jeremy. (This used to be commit 5b2316d1734765ef6c31ff09beea974d9629d17f)
2007-10-10r24470: Start fixing up the mapping of OBJECT_NAME_COLLISIONJeremy Allison1-1/+12
to DOS error ERRDOS, ERRfilexists on open calls. Jeremy. (This used to be commit 4674486450bbe79ec9b22bcbc23c534365d6798a)
2007-10-10r24468: Don't forget the +4 for length :-).Jeremy Allison1-2/+2
Jeremy. (This used to be commit 4d01e0b7443aa4e4d450d705df5762d801172809)
2007-10-10r24467: Do range checking on incoming smb request.Jeremy Allison1-0/+14
Jeremy. (This used to be commit dbd58dd647279def1681d88701e41d8a738c680a)
2007-10-10r24464: Now Volker removed the readbmpx we don't need cached errors any more.Jeremy Allison2-17/+0
Jeremy. (This used to be commit 9256ec0a20f532c7dd7ddc2d3534336a47e6c2d2)
2007-10-10r24461: Fix Bug 4852, thank to anto <sistemac@prosoft.ba> for reporting it.Volker Lendecke1-0/+14
(This used to be commit 0fecd8a0c3aaa64e137d2efd3f9cc7705837ea2a)
2007-10-10r24457: Convert reply_tcon to the new APIVolker Lendecke2-30/+26
Jeremy, I really apologize for doing this, but I just wanted to enjoy converting the last SMB call :-) I've left one little task for you there, I'm not certain that checking the inbuf length is correct here. Volker (This used to be commit 1e08fddafda11961f8855423b29c1f8a9a6b4457)
2007-10-10r24453: Remove the read and write bmpx callsVolker Lendecke2-260/+32
Talked to both Tridge and Jeremy about this, Tridge said that there is a special error message persuading OS/2 to fall back to other methods. The calls now checked in always return the error message we used to return when "read bmpx = False" was set (the default): ERRSRV, ERRuseSTD. If someone has a reproducable test case where this is really needed, we can always dig it up from version control and convert it to the new API. But that time without that silly parameter, and with a torture test case for "make test" please :-) Volker (This used to be commit d941aae2dfd11609e807bf4ce712571a2e354627)
2007-10-10r24445: Convert SMBwritebraw. No test suite unfortunately.... I need to ↵Jeremy Allison2-62/+151
write one for this. Jeremy (This used to be commit edc17dfcbd21cccaffb76f4ae67fe4b06520f1a9)
2007-10-10r24444: Convert reply_find[n]close to the new APIVolker Lendecke2-15/+27
(This used to be commit 6af85953465789594342f2d199ef5d29462cf34f)
2007-10-10r24443: Convert reply_search/fclose to the new APIVolker Lendecke2-61/+99
(This used to be commit a8a33c377e38046b4103cf1d59032b97ab6bac9a)
2007-10-10r24442: Convert reply_copy to the new APIVolker Lendecke2-39/+85
(This used to be commit 0cb00c54750837ab2d2dc12e4947fedb7d38e878)
2007-10-10r24441: Convert reply_ioctl to the new APIVolker Lendecke2-21/+37
(This used to be commit a5af7ebb7f1d869659fbab187652e68ec4fafbb8)
2007-10-10r24440: Convert the reply_sendXX functions to the new APIVolker Lendecke2-35/+35
(This used to be commit a64bc31098de8694b79eeafd3a226cf519700707)
2007-10-10r24439: Convert reply_get/setattrE to the new APIVolker Lendecke2-27/+52
(This used to be commit 6b0ad071d85ddd8fbf24386db11688bde49baf81)
2007-10-10r24436: Convert reply_lockread/writeunlock to the new APIVolker Lendecke2-42/+80
(This used to be commit 1b6add251ca1db565a03407db30884132dd93e7d)
2007-10-10r24433: Convert reply_ntrename to the new APIVolker Lendecke2-31/+52
(This used to be commit 42b07a52b9f4fe147426e9156958cb4d33691678)