summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2011-03-27s3: Fix Coverity ID 2329: RESOURCE_LEAKVolker Lendecke1-0/+1
2011-03-27s3: Fix Coverity ID 2330: RESOURCE_LEAKVolker Lendecke1-0/+1
2011-03-26Revert "Fix bug 8021 - Incorrect string termination in volume/volume_name ↵Jeremy Allison1-1/+1
for TRANS2-QUERY_FS_INFO/Info Volume." This reverts commit 042aafb87df6c05877b8fc7ef0d44877689d860a. I need to test against OS/2 to see if this is something Win28K breaks for older clients before allowing this. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Mar 26 01:19:55 CET 2011 on sn-devel-104
2011-03-24Fix bug 8021 - Incorrect string termination in volume/volume_name for ↵Volodymyr Khomenko1-1/+1
TRANS2-QUERY_FS_INFO/Info Volume. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Mar 24 23:07:09 CET 2011 on sn-devel-104
2011-03-24charcnv: removed the allow_badcharcnv and allow_bad_conv options to ↵Andrew Tridgell6-6/+6
convert_string*() we shouldn't accept bad multi-byte strings, it just hides problems Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
2011-03-23s3-globals: silence build warning in smbd_messaging_context().Günther Deschner1-0/+1
Guenther
2011-03-23s3-safe_string: Add checked_strlcpy()Andrew Bartlett1-1/+1
This is strlcpy, just with an extra check of the parameters with sizeof(), use only where that works. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Wed Mar 23 03:39:35 CET 2011 on sn-devel-104
2011-03-23s3-lib Remove the clobber_region() code.Andrew Bartlett1-3/+2
This code wrote to the full buffer in fstrcpy(), pstrcpy() and other fixed-length string manipulation functions. The hope of this code was to find out at run time if we were mixing up pstring and fstring etc, and to record where this came from. It has a runtime performance impact (particularly if compiled with --enable-developer). It is being removed because of the complexity it adds, and the distinct lack of bugs that this complexity has been credited in finding. The macro-based compile-time checking of string sizes remains. Andrew Bartlett
2011-03-23s3-config: say which config file we failed to openAndrew Tridgell1-1/+1
saves having to strace it to work that out
2011-03-23fault: get fault.c ready for use by s4Andrew Tridgell1-1/+1
this moves the s3 specific dumpcore code into source3/lib/dumpcore.c, and uses a function pointer to setup which smb_panic call to use
2011-03-22s3-fault: removed the cont_fn from fault_setup()Andrew Tridgell2-6/+1
cont_fn() was supposed to be a way to continue after a seg fault. It could never be called however, as smb_panic() from fault_report() could never return, as dump_core() never returns at the end of smb_panic() Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Tue Mar 22 05:07:58 CET 2011 on sn-devel-104
2011-03-21s3:smbd: access checks should not depend on share mode flagsStefan Metzmacher1-1/+0
metze
2011-03-19s3:smbd: remove uses of "./" in unlink_internals()Stefan Metzmacher1-4/+0
Commit 78b931ce6c840ade646c1c6030fa2d6acb77208b tried to do that, but didn't have any effect. metze
2011-03-18SMB2 renames return SHARING_VIOLATION if there is any existing oplock on a file.Jeremy Allison1-0/+6
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Mar 18 23:39:49 CET 2011 on sn-devel-104
2011-03-18The searches struct is still being used and idled in SMB2 - move it to the ↵Jeremy Allison2-31/+33
global section until we decide if we want to idle SMB2 directory handles. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Mar 18 01:13:53 CET 2011 on sn-devel-104
2011-03-17Fix crash bug on smbd shutdown when using FOPENDIR() found by Volker.Jeremy Allison1-1/+13
The key was allowing the dptr_idle code to be triggered. We were closing the dirp->dir handle without updating the underlying fd in the open fsp. Jeremy.
2011-03-17s3: Expose num_opens via api_RNetSessionEnumVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Thu Mar 17 22:05:10 CET 2011 on sn-devel-104
2011-03-16s3-build: only include asn1 headers where actually needed.Günther Deschner3-0/+3
Guenther
2011-03-16s3: Fix Coverity ID 2140, DEADCODEVolker Lendecke1-1/+1
This routine was never executed after f0dcc90f because "netname" was always NULL. Jeremy, please check!
2011-03-16s3-msdfs: avoid global inclusion of msdfs.h.Günther Deschner1-0/+1
Guenther
2011-03-16s3-libsmb: move smb encryption structs into own header.Günther Deschner1-0/+1
Guenther
2011-03-09s3-smbd: Increase debug level von context messages.Andreas Schneider2-7/+7
2011-03-08s3-rpc_server: Start the Endpoint Mapper Dameon if enabled.Andreas Schneider1-0/+15
Endpoint Mapper is still disabled by default! Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-04s3-printing: follow force user/group for driver IODavid Disseldorp1-56/+71
Configuring force user/group settings for the print$ share currently has unexpected results, this is explained by how the driver upload/add process takes place. Consider the following example: [print$] path = /print-drv write list = $DRIVER_UPLOAD_USER force group = ntadmin - the client connects to the [print$] share and uploads all driver files to the /print-drv/W32X86 directory. - This is permitted, as /print-drv/W32X86 is owned by group ntadmin, and the "force group = ntadmin" takes effect for the [print$] session. - Once all files are uploaded, the client connects to the [ipc$] share and issues an AddPrinterDriverEx spoolss request. - In handling this request move_driver_to_download_area() is called, which attempts to create the directory /print-drv/W32X86/3 - The create directory fails, as it is done as the user connected to the [ipc$] share which does not have permission to write to the driver directory. The [print$] "force group = ntadmin" has no effect. This is a regression from previous behaviour prior to the commit: 783ab04 Convert move_driver_to_download_area to use create_conn_struct. https://bugzilla.samba.org/show_bug.cgi?id=7921 Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-02s3: Pass smb_filename through the set_offline vfs opVolker Lendecke2-3/+3
2011-03-02s3: Pass smb_filename through the is_offline vfs opVolker Lendecke2-3/+4
2011-03-02s3-sessionid: avoid global include of sessionid.hGünther Deschner1-0/+1
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 2 12:58:12 CET 2011 on sn-devel-104
2011-03-02s3-lanman: talk to srvsvc dcerpc server in api_RNetSessionEnum().Günther Deschner1-10/+63
Guenther
2011-03-02s3-server_id: only include server_id where needed.Günther Deschner3-0/+3
Guenther
2011-03-02s3-printing: vfs_connect prior to driver/dfs IODavid Disseldorp1-10/+24
samba3.posix_s3.rpc.spoolss.driver fails with the xattr_tdb vfs module loaded as a part of make test. The (now checked) create_directory() call in move_driver_to_download_area() fails, uncovering another bug in the printer driver upload code path. move_driver_to_download_area() creates a new conn_struct for manipulating files in [print$]. The VFS layer is plumbed through with the call to create_conn_struct(), however SMB_VFS_CONNECT() is never called. Many vfs modules expect state stored at connect time with SMB_VFS_HANDLE_SET_DATA() to be available on any IO operation and fail if this is not the case. This fix adds a call to SMB_VFS_CONNECT() in create_conn_struct() prior to IO. https://bugzilla.samba.org/show_bug.cgi?id=7976 Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Mar 2 01:16:30 CET 2011 on sn-devel-104
2011-03-02s3: remove superfluous debug messages from msg_idmapGregor Beck1-4/+0
Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Wed Mar 2 00:30:41 CET 2011 on sn-devel-104
2011-03-01s3-auth struct security_unix_token replaces UNIX_USER_TOKENAndrew Bartlett6-8/+8
2011-02-28Fix warning introduced by changing the size of UNIX_USER_TOKEN->ngroups from ↵Jeremy Allison1-1/+1
size_t to uint32_t.
2011-02-28s3-smbd: Pass tevent context to messaging functions.Andreas Schneider1-4/+11
Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Mon Feb 28 19:00:08 CET 2011 on sn-devel-104
2011-02-28s3: Eliminate sys_select from fd_is_readableVolker Lendecke1-10/+4
2011-02-28s3: Use poll in smbdVolker Lendecke2-20/+23
2011-02-28s3:msg_idmap: The solaris cc compiler does not like unnamed unions as struct ↵Michael Adam1-13/+13
members - fix the build Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Mon Feb 28 16:39:15 CET 2011 on sn-devel-104
2011-02-28s3: smbcontrol to notify smbd about idmap changesGregor Beck2-0/+207
Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Mon Feb 28 14:07:23 CET 2011 on sn-devel-104
2011-02-27s3: Fix some nonempty blank linesVolker Lendecke1-10/+9
2011-02-26dirfd doesn't exist in some platforms.Jeremy Allison1-0/+6
Hack that should get the buildfarm back to green. Ensure dirfd() needs to be defined before we properly return fdopendir. This will do until we get a proper dirfd() defined in libreplace. From http://www.gnu.org/software/hello/manual/gnulib/dirfd.html This function is missing on some platforms: AIX 7.1, HP-UX 11, OSF/1 5.1, Solaris 10, mingw. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Feb 26 04:19:55 CET 2011 on sn-devel-104
2011-02-25Detect Mac OS X as a separate client type.Justin Maggard1-0/+4
2011-02-25Ensure we don't return an incorrect access mask.Jeremy Allison1-1/+2
From the Microsoft test suite @ Connectathon: Test Case: TestSuite_ScenarioNo009GrantedAccessTestS0 File created with access = 0x7 (Read, Write, Delete) Query Info on file returns 0x87 (Read, Write, Delete, Read Attributes) Jeremy.
2011-02-25Implement the SMB2 close flag SMB2_CLOSE_FLAGS_FULL_INFORMATION (and move ↵Jeremy Allison1-20/+75
definition to correct place). Thanks to Nick Meier @ Microsoft for finding this @ Connectathon. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Feb 25 00:40:52 CET 2011 on sn-devel-104
2011-02-24Batch oplocks conflict with exclusive as well as themselves.Jeremy Allison1-1/+1
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Feb 24 21:44:50 CET 2011 on sn-devel-104
2011-02-24Remember to free the second temporary string.Jeremy Allison1-0/+1
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Feb 24 04:17:49 CET 2011 on sn-devel-104
2011-02-23Fix bug 7950 - Samba 3.5.x fails BASE-CREATEX_SHAREMODES_DIR smbtorture4 testJeremy Allison1-6/+16
We need to revalidate the pathname once re-constructed from a root fsp. Jeremy.
2011-02-23Fix bug found against the new Mac client @ Connectathon. Mac clientsJeremy Allison1-1/+9
don't open with FILE_WRITE_ATTRIBUTES when just doing a write, so updating the write time on close fails as smb_set_file_time() now (correctly) checks for FILE_WRITE_ATTRIBUTES in the access_mask before allowing client time update. This is an internal time update being done on a close, not a handle-based client request.
2011-02-22s3-printing: only include printing where really needed.Günther Deschner4-0/+4
Guenther
2011-02-22s3-printing: fix pcacp prototypes and includes.Günther Deschner3-0/+3
Guenther
2011-02-22s3-printing: isolate print notification prototypes better.Günther Deschner1-0/+1
Guenther