summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2009-08-06s3: Fix a bug in renames of directoriesTim Prouty1-6/+19
Recently code was added to match windows semantics of denying the rename of a directory if there are open files underneath it. This does partly match windows semantics, but it turns out the rename should be allowed if the open file handle is for the directory being renamed, or for a stream on the directory being renamed. This patch refines the check to better follow these rename semantics.
2009-08-06Remove a const warning.Jeremy Allison1-1/+1
Jeremy.
2009-08-06Put SMB_INFO_STANDARD back into setfileinfo, but do it rightJeremy Allison1-0/+45
this time :-). Jeremy.
2009-07-31We're not changing last write, but setting this to be ↵Jeremy Allison1-1/+1
FILE_NOTIFY_CHANGE_CREATION doesn't work. So use FILE_NOTIFY_CHANGE_LAST_WRITE (now seems to reliably fix bug #6529 - Offline files conflict with Vista and Office 2003. Jeremy.
2009-07-30Tidy up treatment of ctime.Jeremy Allison2-5/+9
Jeremy.
2009-07-30Fix bug #6529 - Offline files conflict with Vista and Office 2003.Jeremy Allison1-0/+16
We need to send a notify message when a timestamp is changed that can't be reflected in the underlying POSIX filesystem. Jeremy.
2009-07-30Remove the extraneous logic in smb_set_info_standard - weJeremy Allison1-26/+8
do the time twiddling logic at the smb_set_file_time level. Jeremy.
2009-07-30SMB_INFO_STANDARD is not a valid info level on set,Jeremy Allison1-42/+0
and was being read incorrectly anyway. Remove. Jeremy.
2009-07-28Added prefer_ipv4 bool parameter to resolve_name().Jeremy Allison1-1/+1
W2K3 DC's can have IPv6 addresses but won't serve krb5/ldap or cldap on those addresses. Make sure when we're asking for DC's we prefer IPv4. If you have an IPv6-only network this prioritizing code will be a no-op. And if you have a mixed network then you need to prioritize IPv4 due to W2K3 DC's. Jeremy.
2009-07-27Fix a valgrind error in chain_replyVolker Lendecke1-3/+10
construct_reply() references the request after chain_reply has freed it.
2009-07-25Move 16 bytes from data to r/o text segmentVolker Lendecke1-1/+1
2009-07-25First patch for "new VFS" portabilityVolker Lendecke1-5/+5
2009-07-24s3: Convert a few callers of unix_convert() over to filename_convert()Tim Prouty5-105/+63
This patch also changes the unix convert flags to make sure the correct semantics are preservered for allowing/disallowing wildcards in the last component of the path.
2009-07-24s3: Remove a few callers of get_full_smb_filename()Tim Prouty2-45/+81
2009-07-24s3 onefs: Fix the onefs modules after the big refactoringTim Prouty1-12/+12
2009-07-24s3: Simplify rename_internals() by passing in smb_filename structsTim Prouty3-155/+125
2009-07-24s3: Allow filename_convert() to pass through unix_convert_flags and let the ↵Tim Prouty6-42/+82
caller know if the path has a wildcard This also eliminates the need for resolve_dfspath().
2009-07-24add my copyright after the VFS rewriteVolker Lendecke1-0/+1
2009-07-24Make the smbd VFS typesafeVolker Lendecke1-32/+838
2009-07-24In chain_reply, copy the subrequests' error to the main requestVolker Lendecke1-0/+15
2009-07-24Fix a few uninitialized variable warningsVolker Lendecke10-20/+20
I know those warnings are bogus, but both Coverity and gcc don't get it.
2009-07-24Fix some nonempty blank linesVolker Lendecke1-4/+4
2009-07-22s3: Change unix_convert to use an smb_filename struct internallyTim Prouty2-138/+168
This allows SMB_VFS_[L]STAT to be called directly. Additionally, I changed NTSTATUS result to be named status for consistency. I also removed the stat_cache_add() from build_stream_path() because stat_cache_lookup() is never actually called on a file with a stream. There is no reason why the stat cache couldn't be consulted for streams in the future. Jeremy/Volker, please take a look at this one when you get a chance.
2009-07-22s3: Convert some callers of vfs_lstat_smb_fname to SMB_VFS_LSTAT()Tim Prouty2-9/+30
2009-07-22s3: Convert some callers of vfs_stat_smb_fname to SMB_VFS_STAT()Tim Prouty4-26/+37
2009-07-21s3: plumb smb_filename through some of the trans2 posix_* functionsTim Prouty1-60/+38
2009-07-21s3: Remove unnecessary callers of get_full_smb_filenameTim Prouty4-119/+63
This often times means explicitly denying certain operations on a stream as they are not supported or don't make sense at a particular level. At some point in the future these can be enabled, but for now it's better to remove ambiguity
2009-07-21s3: Remove the now unused fname parameter from filename_convert()Tim Prouty5-50/+23
2009-07-21s3: Fix RENAME_FLAG_RENAME path to stop calling unix_convert twiceTim Prouty1-50/+75
2009-07-21s3: Remove unnecessary fname argument from callers of filename_convertTim Prouty1-9/+14
2009-07-21s3: Plumb smb_filename through map_open_params_to_ntcreateTim Prouty3-19/+20
2009-07-21do not log chdir with level 0 if reason is access deniedChristian Ambach1-2/+2
this changes the level of logs caused by users trying to access shares or subdirectories for which they do not have access to in the ACL this can fill up the samba log even with log level 0 and is more an expected kind of logs that IMHO should not be logged with such a high level. All other errors while chdir() will still be logged with level 0 Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2009-07-20s3: Add some asserts to the filename util functionsTim Prouty1-0/+12
In the smb_filename struct stream_name must equal NULL if there is no stream name. These asserts should catch any future offenders of this invariant early.
2009-07-20s3: Plumb smb_filename through open_fake_fileTim Prouty2-18/+24
2009-07-20s3: Separate out a new file: filename_utils.cTim Prouty4-228/+249
This is to ease the linking pain of everything that links LOCKING_OBJ
2009-07-20s3: Move is_ntfs_stream*() to filename.cTim Prouty2-24/+24
2009-07-20s3: Change fsp->fsp_name to be an smb_filename struct!Tim Prouty27-559/+539
2009-07-20s3 onefs oplocks: Replace static fstring with talloc'd dbg_ctx()Tim Prouty1-16/+16
2009-07-20s3: Change file_structs to be allocated with talloc instead of mallocTim Prouty1-10/+15
2009-07-17Fix Coverity CID 928. Removed check as this can never be null.Jeremy Allison1-1/+1
Jeremy.
2009-07-17Fix Coverity CID 929. Potential NULL deref after code refactoring.Jeremy Allison1-0/+5
Jeremy.
2009-07-17Fix coverity CID 930. Pointer check can never be null here.Jeremy Allison1-1/+1
Jeremy
2009-07-17Fix coverity CID 931. This check is redundent as smb_fname canJeremy Allison1-1/+1
never be null in this function. Jeremy.
2009-07-17Move the initialization of smbd_server_conn from smbd/process,Jeremy Allison2-5/+5
after the accept and fork, to smbd_init_globals(), so it's done immediately on server startup. This is needed as some messages are sent to all active smbd processes (including the master listening daemon). If it gets a message that forces it to scan it's current connections (ie. conn_find()) then it discovers that sconn->smb1.tcons.Connections dereferences null (as sconn == NULL in the parent) and crashes. Yes, I could fix all cases where sconn is used and explicitly check for NULL but this fix is easier. It means that the smbd_event_context() is initialized in the master daemon and then re-initialized after fork, but that should be being done correctly in every fork call anyway. Without this change the previous fix 6a9e0039100b57f9626e87defec6720c476b9789 still panics in the reproducible test case for bug 6564, as this is one case where such a message (MSG_SMB_CONF_UPDATED) is sent to the parent. Metze please check. This change passes valgrind. Jeremy.
2009-07-17Fix bug #6564 - SetPrinter fails (panics) as non root.Jeremy Allison1-0/+1
Missing become_root()/unbecome_root() around reload_services. Jeremy.
2009-07-15Fix bug #6551 - win98 clients cannot connect after server upgrade to ↵Jeremy Allison2-0/+3
samba-3.4.0. The values of vuid and tid were not being correctly updated in the struct smb_request when passed to chain_reply inside sessionsetupX and tconX. Jeremy.
2009-07-15s3:smbd: try to fix a compiler warning on i386 : left shift count >= width ↵Stefan Metzmacher1-1/+1
of type metze
2009-07-15s3:smbd: add support for SMB2 SetInfo File*InformationStefan Metzmacher1-1/+128
metze
2009-07-15s3:smbd: implement SMB2 GetInfo with Fs*InformationStefan Metzmacher1-0/+47
metze
2009-07-15s3:smbd: return NT_STATUS_INVALID_INFO_CLASS in SMB2 GetInfoStefan Metzmacher1-3/+7
metze