Age | Commit message (Collapse) | Author | Files | Lines |
|
added srvstr_push_ascii() and srvstr_pull_ascii() as convenience
routines to replace the current usage of strncpy() like fns
for packet pull/push. We need to do this in *lots* of places
in Samba in order to get our codepage handling right
(This used to be commit 8b0e3679a6dc479c0e3177707dff386559779b69)
|
|
smbd/notify_kernel.c: This code was wrong I believe. It was structured to only
return a changenotify event on being called from timeout processing (t != 0).
The kernel changenotify events should fire on *asynchronous* processing (EINTR
return from select caused by the realtime signal delivery) with t == 0.
Reported by Juergen Hasch (Hasch@t-online.de).
ANDREW PLEASE CHECK THIS !
Currently the hash style changenotify is done on async processing as well
as timeout processing. As this is expensive we may want to revisit doing this
and maybe set it to fire only on timeout processing.
Jeremy.
(This used to be commit f952380c5d0cfbbec1e7de98b712952f302cddfd)
|
|
Jeremy.
(This used to be commit fe38692643ad7c163c30d9c031a8bd3dec81ffee)
|
|
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
|
|
Jeremy.
(This used to be commit 3f9cf2e07bb6d429858e47ab6989ea8cf30d0217)
|
|
reporting imaginary "default" inheritable ACLs on directories, otherwise,
when you add an entry and click on apply without noticing there's no
default entry associated with it, it applies a null acl on the files
within the directory (hey, that's what you told NT you wanted, right ! :-).
Also ensure that minimum permissions for a directory are r-x for owner,
not just r--.
Jeremy.
(This used to be commit 4fa8cf68c3921f93a27d290d6dd1ed4423dfcf1c)
|
|
Jeremy.
(This used to be commit 13c9823eb19baa4b1262ad0fd416d9ecbc92b160)
|
|
sun1.samba.org is down at the moment so I can't test the compile on this. I'm
sure Solaris people using quotas will scream if I've meesed anything up :-).
Jeremy.
(This used to be commit 3d2c59bfe0bc30d8cecf0af81b74d4232b09bdb2)
|
|
Jeremy.
(This used to be commit 7c718fc85e3dbfaf0195e352d06a8c682a6036fc)
|
|
connection fail.
Jeremy.
(This used to be commit 07cee46d1de1caaf6f9f1b6139dd21bcc5d67e8e)
|
|
any code that could modify errno is called.
Jeremy.
(This used to be commit 109a174de9e23ccc89ae17d6b5b425b5947c8565)
|
|
to the places where [f]chmod_acl is called instead.
Jeremy.
(This used to be commit 641ada44ae6429761c1fd0dbcafabc69f897fac7)
|
|
Jeremy.
(This used to be commit d43d907c38008bb02042cb4bc2d899f62bdc115b)
|
|
smbd/vfs.c: Don't call [f]chmod_acl if no acl support.
Jeremy.
(This used to be commit 83f52394e688b4be3ac4cef67d8980a5b8ed3192)
|
|
Jeremy.
(This used to be commit 38b19fad2851a65268b31c7e0240ed36a8407be4)
|
|
Jeremy.
(This used to be commit 1391aa6a6fbe8391a4421f5770da40556f011bb8)
|
|
First one adds a new info level into the lanman printing and an ioctl to the trans2 code.
Andrew - this uses ASCII only. It looks ok to me but please check !
Second one adds a parameter "os2 driver map" that allows OS/2 driver names to be mapped.
Jeremy.
(This used to be commit da79b519e0b6b4317d7fb5260d74e0e74a7e0b46)
|
|
include/proto.h: Fix missing (void) in proto.
rpc_server/srv_samr_nt.c: Fix user private group problem by filtering out groups that
clash with users.
smbd/posix_acls.c: Ensure default ACE's are sensible.
utils/pdbedit.c: Fix from Simo Sorce.
Jeremy.
(This used to be commit 29414fe0d6665642d9b5f88a35e712426376c47f)
|
|
Jeremy.
(This used to be commit 5b9a88c2d0da3479f91131f66ff741e88f9760ee)
|
|
J.F.
(This used to be commit 7154deb026d53cb0cd503562174c3332a372be63)
|
|
with real ACLs...
Jeremy.
(This used to be commit 852b9e15ac245a593460cfff3f629d0333372e41)
|
|
lookup_name was expecting to be able to write to the string. Changed
lookup_name to use const.
Jeremy.
(This used to be commit 80c18d88491f1148ade623e81c33f84ba4f952f3)
|
|
Jeremy.
(This used to be commit 49f0e7e7143f82bce9dfd8b06e9e515bc0869ab7)
|
|
(This used to be commit e430ded56e9c15a462a171e6350f1eddefa8dd11)
|
|
(This used to be commit 0ea62800edd618091fde81e8de4347f612f98a18)
|
|
can't
stop libc routines from calling getpwXXX functions, so caching a pointer to them
is impossible. This new code now makes two copies of the returned struct passwd
struct - one used as a cache, one returned to allow the caller to modify. When
doing a lookup we compare against the cached copy. Code is now easier to understand
also.
smbd/posix_acls.c: If we move the head of the linked list, remember to pass a
reference to that pointer.....
Jeremy.
(This used to be commit af364b93d92f70aa52195c46d3cc516830752609)
|
|
Jeremy.
(This used to be commit 7b97ac289ed472e03b2a6e9c51a568478a93562d)
|
|
(This used to be commit 899ca6e832c72ea68b0ac76205d18a80c87b34d9)
|
|
(This used to be commit 1d145a37860f7256a081c893e3640f5e18943518)
|
|
(This used to be commit ecc2c35ca011a635729063cbc58e7fe687cf148a)
|
|
(This used to be commit 70d6b09ac9fbd612960fa02fad5adbf6d87c24ce)
|
|
(This used to be commit 0331f93a8117d4c295cda327c3a290296ff621d0)
|
|
the unicode support isn't complete, but it is good enough to be usable
for a test server.
(This used to be commit e787fc1daf4a46c182e87bf0697eec80ff0ce87a)
|
|
Jeremy.
(This used to be commit 0d6c7dedd261c15697a7781678fe6bed877b61f6)
|
|
member but can't get the domain sid.
Jeremy.
(This used to be commit 45e96777d0eeafbbf40759f02cd3f5e15b12c288)
|
|
(This used to be commit d5b39a1d435f7fe79eb556f7e6b55276ac68a73d)
|
|
(This used to be commit 54bde1b3aec829ba55b8a6c946424fdaf38803a9)
|
|
(This used to be commit ddee55087756db2a2ac0ee92471d9fea53f38bee)
|
|
(This used to be commit dca433d035dfb6e94ee659477c71edaa4549644d)
|
|
(This used to be commit fbb3bf12df5c79cac9445be21f1997234479b472)
|
|
Jeremy.
(This used to be commit f1839d469e1fc6054b407bd8c4d7c505d4212b45)
|
|
it now uses outbuf not inbuf for the unicode flag, which
allows for some server fns to be ascii and means one less
parameter in push calls
(This used to be commit a6dd6662267eeddf368ff0ffba76b45761bf4eeb)
|
|
(This used to be commit 1e92d340ceb5be8e7d50cc7c889b2053ed67bad3)
|
|
(This used to be commit a074600a09387c2034ffb6651abad69bdc14145e)
|
|
(This used to be commit e54d37903013df1c799ab3aaa10f10df24e3de61)
|
|
- devicename in tconx is always ascii
(This used to be commit 242a6a96d10beeb54e93226ae50bd361486e1c0d)
|
|
(This used to be commit 84fc5a7795fe6e3b993649ecc05f6685f8295c02)
|
|
- removes SMB_ALIGNMENT. That macro caused all sorts of problems with
getting unicode aligned right in sub-protocols (such as SMBtrans and
SMBtrans2). I believe the performance reasons for having
SMB_ALIGNMENT has gone away with the new variants of the SMB
protocol anyway, as newer commands tend to have their own internal
alignment.
- fix the locations where we set smb_flg2 to absolute values. We must
never do this if we want a hope of coping with unicode.
- add initial support for unicode on the wire in smbd. Currently
enabled using SMBD_USE_UNICODE environment variable.
(This used to be commit b98b1435e9d8f8622444c9ff33082977e661f16b)
|
|
to do RPC calls down this treeid.
Jeremy.
(This used to be commit 83133bab0ed59e303a183fd91812165f08e88484)
|
|
now in pipe struct (where used) rather than user_struct.
Secured machine account password changing in srv_netlog_nt.c - ensure
that only the given machine can change its own password. May need to
free this up later for NT admin tools, but this is a fail-safe secure
position for now.
Jeremy.
(This used to be commit 46b12f2275dcd4b3114085160cd456441f9e921e)
|