summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2009-01-11s3: Differentiate between posix files with colons and actual streamsTim Prouty1-2/+34
It is possible for a posix file created locally or over nfs to have a ":" in the name. Since ":" is a reserved character in windows, filenames containing a colon must be mangled in a directory listing. Right now files containing colons will not even be displayed in directory listings if streams modules are in use. During the directory listing the file will be detected as a stream because of the colon, but the streams module will fail to find the stream since it doesn't exist. This fix adds a step to is_ntfs_stream_name that stats the filename to differentiate between actual streams and files containing colons. While this is an improvement, it isn't perfect. Consider the case where there is a file on disk called "a.txt:s1" and also a file called "a.txt" that has a stream called "s1". This patch will always preference "a.txt:s1" over a.txt's s1 stream. The real issue is that at the vfs level, the vfs modules have no way to tell between a demangled name with a colon and an actual stream. A more invasive, but better, long-term fix would be to add all paths that come over the wire into a struct containing metadata about the path. This metadata could include a flag to indicate whether the path came over the wire with a colon ":" (guaranteeing that the client is requesting a stream). Passing this struct down to the lower levels, including all path-based vfs calls, would allow the above case to be handled correctly in all cases.
2009-01-10Fix a type-punned errorVolker Lendecke1-1/+1
2009-01-10Fix a C++ warningVolker Lendecke1-2/+2
2009-01-09s3: Fix open path to delete streams depending on the create dispositionTim Prouty1-0/+14
The new create disposition test in smbtorture RAW-STREAMS verifies this fix.
2009-01-09s3: Add delete_all_streams to proto.hTim Prouty1-1/+1
2009-01-09s3:smbd: handle incoming smb requests via event handlersStefan Metzmacher3-108/+163
We use a fd event and receive incoming smb requests when the fd becomes readable. It's not completely nonblocking yet, but it should behave like the old code. We use timed events to trigger retries for deferred open calls. metze
2009-01-08s3:smbd: fix the build with dmapi supportStefan Metzmacher1-2/+0
struct smbd_dmapi_context *dmapi_ctx; is in globals.c metze
2009-01-08Attempt to fix the buildVolker Lendecke1-1/+1
2009-01-08s3:smbd: move all globals and static variables in globals.[ch]Stefan Metzmacher38-305/+553
The goal is to move all this variables into a big context structure. metze
2009-01-08s3:smbd: variables in a main() don't need to be staticStefan Metzmacher1-7/+7
metze
2009-01-08s3:smbd: open_sockets_smbd() don't need a static variable arrount atexit()Stefan Metzmacher1-7/+1
open_sockets_smbd() is only called once. metze
2009-01-08s3:smbd: keep dmapi globals in one context structStefan Metzmacher1-28/+44
metze
2009-01-08s3:smbd: remove stupid static variables for the nfs quota codeStefan Metzmacher1-16/+20
metze
2009-01-08s3:smbd: remove pointless static variable in uid.cStefan Metzmacher1-7/+4
We always free the value at the end of the function, so we don't need a static variable to hold just NULL for the time the function isn't executed. metze
2009-01-08s3:smbd: make static const in mangle_hash2.c really static constStefan Metzmacher1-1/+1
const char *foo, means a non-const pointer to a const char. const char * const foo, means a const pointer to a const char. char * const foo, would mean a const pointer to a non-const char. metze
2009-01-08s3:smbd: make const globals in mangle_hash2.c really static constStefan Metzmacher1-2/+2
const char *foo, means a non-const pointer to a const char. const char * const foo, means a const pointer to a const char. char * const foo, would mean a const pointer to a non-const char. metze
2009-01-08s3:smbd: make globals in utmp.c static constStefan Metzmacher1-4/+4
const char *foo, means a non-const pointer to a const char. const char * const foo, means a const pointer to a const char. char * const foo, would mean a const pointer to a non-const char. metze
2009-01-08s3:smbd: it's pointless to have a global magic_charStefan Metzmacher1-4/+7
We call magic_char = lp_magicchar(p) each time it's used. metze
2009-01-08s3:smbd: remove pointless static variables in chgpasswd.cStefan Metzmacher1-9/+10
metze
2009-01-08s3:smbd: make fake_files[] static constStefan Metzmacher1-1/+1
metze
2009-01-08s3:smbd: make mangle_fns constStefan Metzmacher3-10/+10
metze
2009-01-07Fix bug #6016 - Alternate Data Streams / Extended Attributes seem to conflict.Jeremy Allison1-3/+8
Jeremy.
2009-01-06Fix bug #6017, - magic script does not work. based on a patch from ↵Jeremy Allison1-3/+13
monyo@samba.gr.jp. Jeremy.
2009-01-05Fix call to ndr_size_dom_sid, missing parameter.Jeremy Allison1-1/+1
Jeremy.
2009-01-05Merge branch 'master' of ssh://git.samba.org/data/git/sambaJelmer Vernooij6-19/+26
2009-01-05Attempt to fix the build with dnssdVolker Lendecke1-1/+0
2009-01-05s3:events: change event_add_timed() prototype to match samba4Stefan Metzmacher4-16/+21
metze
2009-01-05clean event context after child is forked.Bo Yang1-2/+5
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-01-05Merge branch 'master' of ssh://git.samba.org/data/git/sambaJelmer Vernooij3-17/+26
2009-01-05smbd: prevent access to root filesystem when connecting with empty service nameMichael Adam1-0/+4
This only applies to a setup with "registry shares = yes" Michael (cherry picked from commit 288fa94ac7cfdf7457b5098c33fc840bed3d5410) (cherry picked from commit e85526b184e66f86b7faa9d0a37288a09c12c19e)
2009-01-04s3: Allow renames of streams via NTRENAME and fix stream error codes on renameTim Prouty2-17/+22
The test_streams_rename2 test in RAW-STREAMS verifies these changes
2009-01-04Merge branch 'master' of ssh://git.samba.org/data/git/sambaJelmer Vernooij1-1/+1
2009-01-04Fix bug #6009 - Setting "min receivefile size = 1" breaks writes.Jeremy Allison1-1/+1
Jeremy.
2009-01-01Add iconv_convenience argument to size functions.Jelmer Vernooij2-1/+3
2008-12-31Replace "goto again" by "return NT_STATUS_RETRY" in receive_message_or_smbVolker Lendecke1-11/+13
This gives lower-level routines the chance to indicate a retry condition
2008-12-31Fix a "nested extern" warningVolker Lendecke1-1/+1
2008-12-31Rename parent_dirname_talloc() to parent_dirname()Volker Lendecke6-17/+8
2008-12-31Use parent_dirname_talloc instead of parent_dirname in smb_unix_mknodVolker Lendecke1-3/+7
2008-12-31Use parent_dirname_talloc instead of parent_dirname in copy_internalsVolker Lendecke1-2/+6
2008-12-31recvfile can't be used for printing so farVolker Lendecke1-0/+4
2008-12-31Fix an ancient uninitialized variable readVolker Lendecke2-2/+3
The callers of open_file_ntcreate expect *psbuf to be filled correctly
2008-12-30s3 build: Fix warningTim Prouty1-0/+2
2008-12-30s3:cluster: register the client connection via CTDB_CONTROL_TCP_ADDStefan Metzmacher1-3/+6
This means we correctly pass IPv6 addresses too. (CTDB_CONTROL_TCP_CLIENT was IPv4 only) metze
2008-12-30Second part of the bugfix for #5933Volker Lendecke1-7/+13
Incrementing the next vuid did not correctly overflow Now we survive BENCH-SESSSETUP with -o 100000. Takes a while though :-) Thanks a lot to Ofer Tal <otsmb@shmoop.org> for reporting #5933
2008-12-30First part of bugfix for #5933Volker Lendecke1-3/+0
Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing num_validated_vuids twice per session setup, but decrement it only once. Looking at sesssetup.c we always call register_initial_vuid() before register_existing_vuid(), so there's no point in incrementing it in register_existing_vuid(). Jeremy, please check!
2008-12-30Move a comment to its placeVolker Lendecke1-5/+5
2008-12-30Simplify invalidate_vuid slightlyVolker Lendecke1-4/+0
get_valid_user_struct_internal() checks for UID_FIELD_INVALID itself
2008-12-30Simplify is_partial_auth_vuid slightlyVolker Lendecke1-5/+1
2008-12-30Simplify invalidate_all_vuids() slightlyVolker Lendecke1-5/+2
invalidate_vuid takes care of removing the user_struct from validated_users
2008-12-23Fix more asprintf warnings and some error path errors.Jeremy Allison2-5/+7
Jeremy.