summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2012-06-03s3:smbd/close: call del_share_mode() directly before TALLOC_FREE(lck)Stefan Metzmacher1-5/+15
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Sun Jun 3 21:08:19 CEST 2012 on sn-devel-104
2012-06-03s3:smbd/close: remove unused goto out from close_directory()Stefan Metzmacher1-3/+1
metze
2012-06-03s3:smbd/close: do an early return in close_directory()Stefan Metzmacher1-2/+1
metze
2012-06-03s3: Fix an assert to trigger in close_remove_share_modeStefan Metzmacher1-6/+17
In case we have a left-over entry in the share mode entry array, the SMB_ASSERT(got_tokens) is likely to kick in. It happens when we are about to delete a file with initial delete on close. We don't have a delete on close token set in the locking.tdb record. We see the fsp->initial_delete_on_close set, add the delete_on_close token to lck. Then "delete_file" is being set to true. Then later on we do the notify_deferred_opens. This walks the list, also checking for share_mode_stale_pid. We have already deleted our own share mode entry, share_mode_stale_pid() sees the left-over entry. It not also deletes that one but also the delete on close token. This leads to a different view of "delete_file" a.k.a. "got_tokens" further down in close_remove_share_mode, leading the SMB_ASSERT to fire. This patch attempts to fix the issue by keeping around our own share mode entry for almost the whole routine, preventing share_mode_stale_pid() from removing the delete tokens. Pair-Programmed-With: Volker Lendecke <vl@samba.org>
2012-06-03s3: Do an early return in close_remove_share_modeVolker Lendecke1-2/+1
Without "lck" we don't have much to clean up Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-03s3: Make close_remove_share_mode a bit more readableVolker Lendecke1-2/+4
by introducing a variable simplifying a boolean expression Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-03s3: Slightly simplify close_remove_share_modeVolker Lendecke1-10/+15
Remove a level of indentation by more use of "continue;" Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-03s3:smbd/close: avoid procid_is_me()Stefan Metzmacher1-1/+2
metze
2012-06-03s3:smbd/open: avoid procid_is_me()Stefan Metzmacher1-4/+5
metze
2012-06-03s3:smbd/oplock: avoid procid_is_me()Stefan Metzmacher1-2/+4
metze
2012-05-31Forward port of Richard Sharpe's <realrichardsharpe@gmail.com> fix for bug ↵Jeremy Allison1-0/+1
#8970 - Possible memory leaks in the samba master process.
2012-05-31We are triggering the cleanup_timeout_fn() too often, on exiting when an ↵Jeremy Allison1-11/+4
smbd is idle. Calls to exit_server_cleanly() should be treated as a "clean" shutdown, and not trigger the master smbd to call cleanup_timeout_fn.
2012-05-31s3:smbd: use server_messaging_context() instead of sconn->msg_ctx in ↵Stefan Metzmacher1-2/+3
exit_server_common() sconn is not available in the parent anymore. Thanks to Volker Lendecke <vl@samba.org> for finding this! metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu May 31 18:08:06 CEST 2012 on sn-devel-104
2012-05-31s3: Fix some 64-bit warningsVolker Lendecke2-4/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu May 31 10:06:56 CEST 2012 on sn-devel-104
2012-05-31Stop spamming the logs with "Could not remove pid XX from serverid.tdb" ↵Jeremy Allison1-15/+18
messages and initiating the cleanup function on every process death. We now have many sub-processes from smbd that don't serve SMB1/SMB2 requests and don't register themselves in the serverid.tdb. Only initiate the cleanup from processes that were explicitly in the child list. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu May 31 04:44:09 CEST 2012 on sn-devel-104
2012-05-30s3-param: Use same function name for "max xmit" as lib/paramAndrew Bartlett1-1/+1
Again, this helps with merging the FN_ list. Andrew Bartlett
2012-05-29s3:smb2_ioctl: verify credit chargeStefan Metzmacher1-0/+25
Based on a patch from Christian Ambach <ambi@samba.org>. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Tue May 29 18:55:29 CEST 2012 on sn-devel-104
2012-05-29s3:smb2_ioctl: add more validation checksStefan Metzmacher1-6/+67
metze
2012-05-29s3:smb2_ioctl: add some more validation checksStefan Metzmacher1-7/+36
Based on a patch from Christian Ambach <ambi@samba.org>. metze
2012-05-29s3:smbd/smb2_find add a debug messageChristian Ambach1-0/+4
like the ones in the other calls that check for max sizes Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-29s3:smbd/smb2_getinfo add a debug messageChristian Ambach1-0/+8
like the ones in the other calls that check for max sizes Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-29s3:smbd/smb2_setinfo add a debug messageChristian Ambach1-0/+4
similar to the ones present in other paths Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-29s3:smbd/smb2_read improve debug messageChristian Ambach1-1/+2
make the message similar to the ones in other paths Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-28s3:smbd: fix reply_open_pipe_and_X() to behave like windows (2008 R2)Stefan Metzmacher1-11/+15
See rpc.samba3.smb1-pipe-name. metze
2012-05-28s3:smbd: only strip \\ off the name if present (for ntcreatex)Stefan Metzmacher1-2/+4
metze
2012-05-28s3:smb2_create: do not remove leading backslash from pipe namesStefan Metzmacher1-5/+0
metze
2012-05-25Ensure we only return NT_STATUS_DELETE_PENDING if the share modes are valid.Jeremy Allison1-3/+20
Ensure we only return *file_existed = true if there were valid share modes. Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-25s3: Check for serverid_exists in close_directoryVolker Lendecke1-0/+3
Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-25s3: Check for serverid_exists in close_remove_share_modeVolker Lendecke1-0/+3
Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-25s3: Check for serverid_exists in find_oplock_typesVolker Lendecke1-0/+18
Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-25s3: Check for serverid_exists in smb_posix_unlinkVolker Lendecke1-0/+3
Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-25s3: Check for serverid_exists in open_mode_checkVolker Lendecke1-0/+5
Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-25s3: Check for serverid_exists in notify_deferred_opensVolker Lendecke1-2/+8
We will remove the check in parse_share_modes soon Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-25s3:smbd: move global smbd_msg_state to smbXsrv_connectionStefan Metzmacher3-18/+21
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri May 25 11:01:27 CEST 2012 on sn-devel-104
2012-05-25s3:smbd: move global koplocks to smbd_server_connectionStefan Metzmacher3-4/+20
metze
2012-05-25s3:smbd: pass smbd_server_connection to should_notify_deferred_opens()Stefan Metzmacher3-3/+3
metze
2012-05-25s3:smbd: move global oplocks vars to smbd_server_connectionStefan Metzmacher3-16/+21
metze
2012-05-25s3:smbd: remove unused get_number_of_exclusive_open_oplocks()Stefan Metzmacher2-10/+0
metze
2012-05-25s3:smbd/signing: use smbd_server_connection as talloc parent for its smb1 ↵Stefan Metzmacher1-2/+2
signing state metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri May 25 00:23:53 CEST 2012 on sn-devel-104
2012-05-24s3:smbd: remove global 'smbd_server_conn' !!!Stefan Metzmacher6-42/+63
For now we still use a global 'global_smbXsrv_connection' in order to pass the connection state to exit_server*(). metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu May 24 20:07:20 CEST 2012 on sn-devel-104
2012-05-24s3:smbd: only call file_init_global() in the parent smbdStefan Metzmacher2-2/+6
metze
2012-05-24s3:smbd/files: split file_init_global() out of file_init()Stefan Metzmacher2-13/+35
metze
2012-05-24s3:smbd: remove unused var in smbXsrv_connection_init_tables()Stefan Metzmacher1-2/+0
metze
2012-05-24s3:smbd/msdfs: pass allow_broken_path to resolve_dfspath_wcard()Stefan Metzmacher4-1/+6
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu May 24 16:14:01 CEST 2012 on sn-devel-104
2012-05-24s3:smbd/msdfs: pass 'allow_broken_path' to get_referred_path()Stefan Metzmacher2-3/+3
Note the DCERPC code should not be smb2 specific! I wonder why this is at all smb2 specific... metze
2012-05-24s3:smbd/msdfs: let create_conn_struct() also fake the 'smbd_server_connection'Stefan Metzmacher2-18/+43
metze
2012-05-24s3:smbd/files: work without sconn->file_bmap and assign fsp->fnum = -1Stefan Metzmacher1-23/+39
For faked connection_structs we do not need valid fnum values, e.g. in the dfs and printing code. metze
2012-05-24s3:smbd/files: fix error path and correctly cleanupStefan Metzmacher1-7/+7
metze
2012-05-23s3:smbd/proto.h: remove unused resolve_dfspath() prototypeStefan Metzmacher1-5/+0
metze
2012-05-23s3:smbd/files: remove unused VALID_FNUM()Stefan Metzmacher1-2/+0
metze
generated by cgit (git 2.34.1) at 2024-11-12 17:51:58 +0000