summaryrefslogtreecommitdiff
path: root/source3/smbd
AgeCommit message (Collapse)AuthorFilesLines
2009-11-06Fix bug 6841 - "map acl inherit = yes" not working.Jeremy Allison1-8/+29
The code to read the new V2 SAMBA_PAI entries had two errors. Jeremy.
2009-11-05Got the logic simplification worked out so we still passJeremy Allison4-30/+45
BASE-DELAYWRITE and also RAW-CLOSE. Jeremy.
2009-11-05Revert commit "0551284dc08eb93ef7b2b2227a45e5ec21d482fb" - simplifyJeremy Allison3-11/+31
the logic. This was incorrect (I'll revisit this tomorrow). Jeremy.
2009-11-05Simplify the logic - remove extraneous argument and calls to ↵Jeremy Allison3-31/+11
set_close_write_time(). We were treating a file time set on close as a sticky write time set, and I don't think it is. I will add a torture test later to RAW-CLOSE to confirm this. Jeremy.
2009-11-05Fix explicit set of write time on close.Jeremy Allison1-1/+5
Jeremy.
2009-11-05Get closer to an accurate model of Windows timestamp changes.Jeremy Allison5-30/+53
"Normal" non truncate writes always cause the timestamp to be set on close. Once a close is done on a handle this can reset the sticky write time to current time also. Updated smbtorture4 confirms this. Jeremy.
2009-11-05s3: Fix a crash in notify_remove_onelevel when "change notify = no"Volker Lendecke1-0/+4
2009-11-05s3: Fix the talloc hierarchy in notify_remove_onelevelVolker Lendecke1-1/+1
We want to free the record early, not when talloc_tos() is free'ed.
2009-11-04Fix debug comment (brain wasn't working...).Jeremy Allison1-2/+2
Jeremy.
2009-11-04Filter the returned DOS attributes by 0xFF for clientsJeremy Allison1-0/+12
using older protocols (LANMAN2 or below). Jeremy.
2009-11-04Remove "Protocol" as an extern, and add accessor functions.Jeremy Allison6-27/+17
Jeremy.
2009-11-03Fix debug statements to use correct function name.Jeremy Allison1-13/+13
Jeremy.
2009-11-03requires_resume_key is a bool not int.Jeremy Allison1-7/+2
Jeremy.
2009-11-03Fix more of the RAW-SEARCH test. Older info levels areJeremy Allison1-2/+9
not 4 byte aligned (levels 1 - 3). Jeremy.
2009-11-03s3: Remove debug_ctx()Volker Lendecke4-13/+13
smbd just crashed on me: In a debug message I called a routine preparing a string that itself used debug_ctx. The outer routine also used it after the inner routine had returned. It was still referencing the talloc context that the outer debug_ctx() had given us, which the inner DEBUG had already freed.
2009-11-02Fix bug 6867 - trans2findnext returns reply_nterror(req, ntstatus) In a ↵Jeremy Allison1-12/+16
directory with a lot of files. Jeremy.
2009-10-29Start fixing the RAW-STREAMS test - ensure that the xattrJeremy Allison1-0/+1
used to store the stream info in streams_depot.so is not seen in when enumerating EAs. Jeremy.
2009-10-26Second part of the fix for bug 6828 - infinite timeout occurs when byte lock ↵Jeremy Allison1-6/+9
held outside of samba. Fixes case where a connection with a pending lock can me marked "idle", and ensures that the lock queue timeout is always recalculated. Jeremy.
2009-10-20Fix bug 6828 - infinite timeout occurs when byte lock held outside of sambaJeremy Allison1-8/+18
Jeremy.
2009-10-13Remove use of "int ret" when we already have errcode.Jeremy Allison1-13/+8
Jeremy.
2009-10-13Catch one more erroneous use of errno.Jeremy Allison1-1/+1
Jeremy.
2009-10-13correctly handle aio_error() and errnoOlaf Flebbe1-29/+24
2009-10-08Cope with old CIFSFS clients that use SMBunlink to removeJeremy Allison1-2/+11
symlinks instead of trans2:posix_unlink. Jeremy.
2009-10-08s3: Fix shadow copy display on Windows 7Volker Lendecke1-1/+1
Windows 7 is a bit more picky on our NT_STATUS_BUFFER_TOO_SMALL. Announce the right buffer size, the same amount we later check for.
2009-10-08s3/s4 - Adapt the IDL changes on various locationsMatthias Dieter Wallnöfer1-9/+9
2009-10-07Oops. Don't break the build..Jeremy Allison1-3/+2
Jeremy.
2009-10-07Make the logic a lot clearer and fix the comment to match.Jeremy Allison1-15/+10
Jeremy
2009-10-07Correct fix for bug 6781 - Cannot rename subfolders in Explorer view with ↵Jeremy Allison1-3/+1
recent versions of Samba. Without this fix, renaming a directory ./a to ./b, whilst a directory ./aa was already open would fail. Jeremy.
2009-10-06s3: Add access_mask to the flock VFS callAbhidnya P Chirmule2-3/+5
2009-10-02Remove lots of duplicate code and move it into oneJeremy Allison4-108/+59
function vfs_stat_fsp(). Stops code looking at fsp->posix_open except for exceptional circumstances. Jeremy.
2009-10-02Missed one VFS_STAT -> VFS_LSTATJeremy Allison1-1/+1
Jeremy.
2009-10-02Fix more use of VFS_STAT when posix pathnames selected.Jeremy Allison2-19/+50
Jeremy.
2009-10-01Fix for CVE-2009-2813.Jeremy Allison1-1/+5
=========================================================== == Subject: Misconfigured /etc/passwd file may share folders unexpectedly == == CVE ID#: CVE-2009-2813 == == Versions: All versions of Samba later than 3.0.11 == == Summary: If a user in /etc/passwd is misconfigured to have == an empty home directory then connecting to the home == share of this user will use the root of the filesystem == as the home directory. ===========================================================
2009-10-01Fix for CVE-2009-2906.Jeremy Allison1-5/+25
Summary: Specially crafted SMB requests on authenticated SMB connections can send smbd into a 100% CPU loop, causing a DoS on the Samba server.
2009-09-30allow for outstanding_aio_calls to be decrementedOlaf Flebbe1-2/+4
2009-09-28Don't defer a talloc_move'd pointer.Jeremy Allison1-1/+1
Jeremy.
2009-09-25s3:smbd/password - move list pointers into blocksMatthias Dieter Wallnöfer1-6/+6
2009-09-24s3 onefs: Add some debugging/asserts to give more info when there is bad ↵Zack Kirsch1-0/+2
deferred open state. Signed-off-by: Tim Prouty <tprouty@samba.org>
2009-09-24s3: Add more helpful debugging to some of the streams codeTim Prouty1-1/+1
2009-09-24vfs catia: Fix the double translation that was happening with createfile and ↵Aravind Srinivasan1-3/+5
open. Since the catia translation is implemented for open, it should not also be done in createfile. By removing createfile from catia, translation is now done correctly for the primary open path. In order to support systems that have custom createfile implementations that don't eventually call SMB_VFS_OPEN, SMB_VFS_TRANSLATE_NAME has been expanded to take an additional argument that specifies direction. Signed-off-by: Tim Prouty <tprouty@samba.org>
2009-09-18s3-smbd: fix get_ea_names_from_file() and check for pnames pointer.Günther Deschner1-1/+3
This fixes smbd from crashing all the time. Jeremy, Volker, please check. Guenther
2009-09-18s3:smbd: Fix an inappropriate pointer return in a bool fnVolker Lendecke1-1/+1
2009-09-17We now pass the Microsoft SMB2 fileio test with EA's and streams...Jeremy Allison4-5/+68
Jeremy.
2009-09-17spnego: share spnego_parse.Günther Deschner4-0/+4
Guenther
2009-09-14Fix bug 6494 - Incorrect FileStatus returned in NT_CREATE_ANDX.Jeremy Allison2-3/+27
Lookup the EA and Stream status on CreateX. Jeremy.
2009-09-09s3:smbd: Add a "hidden" parameter "share:fake_fscaps"Volker Lendecke1-0/+3
This is needed to support some special app I've just come across where I had to set the SPARSE_FILES bit (0x40) to make it work against Samba at all. There might be others to fake. This is definitely a "Don't touch if you don't know what you're doing" thing, so I decided to make this an undocumented parametric parameter. I know this sucks, so feel free to beat me up on this. But I don't think it will hurt.
2009-09-06Fix bug 6673 - smbpasswd does not work with "unix password sync = yes".Jeremy Allison2-3/+3
Revert change from 3.3 -> 3.4 with read_socket_with_timeout changed from sys_read() to sys_recv(). read_socket_with_timeout() is called with non-fd's (with a pty in chgpasswd.c and with a disk file in lib/dbwrap_file.c via read_data()). recv works for the disk file, but not the pty. Change the name of read_socket_with_timeout() to read_fd_with_timeout() to make this clear (and add comments). Jeremy.
2009-09-05Check we read off the compelte event from inotifySimo Sorce1-2/+8
The kernel may return a short read, so we must use read_data() to make sure we read off the full buffer. If somethign bad happens we also need to kill the inotify watch because the filedescriptor will return out of sync structures if we read only part of the data.
2009-09-04s3:smbd: Fix Coverity ID 937, REVERSE_INULLVolker Lendecke1-2/+2
2009-09-03Hopefully last part of the fix for bug 6651 - smbd SIGSEGV when breaking ↵Jeremy Allison1-2/+2
oplocks. This one is subtle. There is a race condition where a signal can be queued for oplock break, and then the file can be closed by the client before the signal can be processed. Currently if this occurs we panic (we can't match an incoming signal fd with a fsp pointer). Simply log the error (at debug level 10 right now, might be too much) and then return without processing the break request. It looks like there is another race condition with this fix, but here's why it won't happen. If the signal was pending (caused by a kernel oplock break from a local file open), and the client closed the file and then re-opened another file which happened to use the same file descriptor as the file just closed, then theoretically the oplock break requests could be processed on the wrong fd. Here's why this should be very rare.. Processing a pending signal always take precedence over an incoming network request, so as long as the client close request is non-chained then the break signal should always be harmlessly processed *before* the open can be called. If the open is chained onto the close, and the fd on the new open is the same as the old closed fd, then it's possible this race will occur. However, all that will happen is that we'll lose the oplock on this file. A shame, but not a fatal event. Jeremy.