summaryrefslogtreecommitdiff
path: root/source3/tdb/tdbutil.c
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r17315: Make talloc and tdb C++-warning-free. Would this also be interesting ↵Volker Lendecke1-2/+2
in talloc and tdb "upstream"? Volker (This used to be commit 68c43191c8aa4faa9801e0ab084a216ceaf4379d)
2007-10-10r16945: Sync trunk -> 3.0 for 3.0.24 code. Still needJeremy Allison1-133/+53
to do the upper layer directories but this is what everyone is waiting for.... Jeremy. (This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)
2007-10-10r15104: Implement Samba4's tdb_name().Volker Lendecke1-0/+8
Volker (This used to be commit d52002c1c9d28e637ca4d1553e800b0b97790f36)
2007-10-10r15101: Little step towards getting Samba4 tdb into 3: tdb_lock_bystring ↵Volker Lendecke1-5/+13
does not have the timeout argument in Samba4. Add a new routine tdb_lock_bystring_with_timeout. Volker (This used to be commit b9c6e3f55602fa505859a4b2cd137b74105d685f)
2007-10-10r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison1-4/+7
realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy. (This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2007-10-10r12713: Remove use of uint8_t -> uint8.Jeremy Allison1-3/+3
Jeremy. (This used to be commit 4473ac4ef9c86574fc49b1e67089b59b14b6d10d)
2007-10-10r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4Jeremy Allison1-1/+1
x86_64 box. Jeremy. (This used to be commit d720867a788c735e56d53d63265255830ec21208)
2007-10-10r10656: BIG merge from trunk. Features not copied overGerald Carter1-1/+6
* \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck) (This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)
2007-10-10r7139: trying to reduce the number of diffs between trunk and 3.0; changing ↵Gerald Carter1-7/+44
version to 3.0.20pre1 (This used to be commit 9727d05241574042dd3aa8844ae5c701d22e2da1)
2007-10-10r6149: Fixes bugs #2498 and 2484.Derrell Lipman1-2/+2
1. using smbc_getxattr() et al, one may now request all access control entities in the ACL without getting all other NT attributes. 2. added the ability to exclude specified attributes from the result set provided by smbc_getxattr() et al, when requesting all attributes, all NT attributes, or all DOS attributes. 3. eliminated all compiler warnings, including when --enable-developer compiler flags are in use. removed -Wcast-qual flag from list, as that is specifically to force warnings in the case of casting away qualifiers. Note: In the process of eliminating compiler warnings, a few nasties were discovered. In the file libads/sasl.c, PRIVATE kerberos interfaces are being used; and in libsmb/clikrb5.c, both PRIAVE and DEPRECATED kerberos interfaces are being used. Someone who knows kerberos should look at these and determine if there is an alternate method of accomplishing the task. (This used to be commit 994694f7f26da5099f071e1381271a70407f33bb)
2007-10-10r6127: Eliminated all compiler warnings pertaining to mismatched ↵Derrell Lipman1-2/+2
"qualifiers". The whole of samba comiles warning-free with the default compiler flags. Temporarily defined -Wall to locate other potential problems. Found an unused static function (#ifdefed out rather than deleted, in case it's needed for something in progress). There are also a number of uses of undeclared functions, mostly krb5_*. Files with these problems need to have appropriate header files included, but they are not fixed in this update. oplock_linux.c.c has undefined functions capget() and capset(), which need to have "#undef _POSIX_SOURCE" specified before including <sys/capability.h>, but that could potentially have other side effects, so that remains uncorrected as well. The flag -Wall should be added permanently to CFLAGS, and all warnings then generated should be eliminated. (This used to be commit 5b19ede88ed80318e392f8017f4573fbb2ecbe0f)
2007-10-10r5767: Get rid of some compiler warningsVolker Lendecke1-1/+6
(This used to be commit 66471de977a56cbe58921f61da28cc7dcbc6e93e)
2007-10-10r4088: Get medieval on our ass about malloc.... :-). Take control of all our ↵Jeremy Allison1-3/+3
allocation functions so we can funnel through some well known functions. Should help greatly with malloc checking. HEAD patch to follow. Jeremy. (This used to be commit 620f2e608f70ba92f032720c031283d295c5c06a)
2007-10-10r2032: If you're selecting a hash algorithm for tdb, you need to do it at ↵Jeremy Allison1-1/+1
open time, it doesn't make sense anywhere else. Jeremy. (This used to be commit d7ea1ea8fb3420ca1ad8d95acdc43313898200ff)
2004-02-27Added copyrights I forgot about looong ago...Rafal Szczesniak1-1/+2
rafal (This used to be commit 33d1e2dd63e3dbf592a666ae48bc013a8198d008)
2004-02-19Fix the "too many fcntl locks" scalability problem raised by tridge.Jeremy Allison1-2/+0
I've now tested this in daemon mode and also on xinetd and I'm pretty sure it's working. Jeremy. (This used to be commit 14dee038019b11300466b148c53515fc76e5e870)
2003-09-22fix some warnings found by the Sun C compilerGerald Carter1-2/+2
(This used to be commit e1fac713e25692a5790c3261ba323732930f5249)
2003-07-10i guess i'm the only one this ever annyoed...Gerald Carter1-3/+3
fix the confusion when we tdb_lock_bystring() but we retrieve an entry using tdb_fetch_by_string. It's now always tdb.*bystring() (This used to be commit 66359531b89368939f0e8f584a45844b5f2f99e7)
2003-07-01Different fix for memleak just committed. This belongs intoVolker Lendecke1-0/+1
tdb_search_list_free. Volker (This used to be commit 0f3822c8e71426983b960ad49511efa8707159f9)
2003-05-14spellingTim Potter1-2/+2
(This used to be commit 865c11275685c85124b506c9bbd2a8bde2e760b9)
2003-04-22Start merging mimir's trusted domain code from HEAD to 3.0. (for HEAD trustingAndrew Bartlett1-6/+145
NT). (This used to be commit 76cd4a8901a8ac1c3691bc89e496bbb493e5c234)
2003-04-10Fix from Andrew Esh to ensure tdb_pack can't segfault.Jeremy Allison1-7/+10
Jeremy. (This used to be commit 9783929d4ed51e63bddde4b890caa01b737abe85)
2003-01-30Add 3 second timeout when terminating server and sending print notifyJeremy Allison1-4/+13
messages. Stops build-up of large numbers of smbd's waiting to terminate on large print throughput. Jeremy. (This used to be commit 07efebb98473cb3d4adc6b2e0afef3f06dcc99b8)
2003-01-15*lots of small merges form HEADGerald Carter1-5/+9
*sync up configure.in *don't build torture tools in make all *make sure to remove torture tools as part of make clean (This used to be commit 0fb724b3216eeeb97e61ff12755ca3a31bcad6ef)
2003-01-14Merge from HEAD:Andrew Bartlett1-40/+27
Keep all the const warnings in one place, by adding a utility function to make the TDB_DATA. (This used to be commit 7d52f011e7191f54004341a646b049d373504c02)
2003-01-03Merge from HEAD - make Samba compile with -Wwrite-strings without additionalAndrew Bartlett1-21/+21
warnings. (Adds a lot of const). Andrew Bartlett (This used to be commit 3a7458f9472432ef12c43008414925fd1ce8ea0c)
2002-11-23Lots of fixes for error paths where tdb_fetch() data need freeing.Jeremy Allison1-4/+8
Found via a post from Arcady Chernyak <Arcady.Chernyak@efi.com>. Jeremy. (This used to be commit 5d5762d1787db4392d2dff16024097c638b2d494)
2002-11-09Add chainlock_read functions to get a read lock. Used in *massively*Jeremy Allison1-4/+39
contended tdb's (and I've got one :-). Jeremy. (This used to be commit d4b795e6a451d9abaa4a928cf5d34e12b2babc2d)
2002-11-07Merge of scalable printing code fix... Needs testing.Jeremy Allison1-11/+8
Jeremy. (This used to be commit d030df76439c72825d68410211e62090438cef54)
2002-10-04Add a timeout to tdb_lock_bystring(). Ensure we never have more thanJeremy Allison1-5/+44
MAX_PRINT_JOBS in a queue. Jeremy. (This used to be commit 9fe3c0b90d4bff2217e3cb5a34b4683ca314c06e)
2002-07-15updated the 3.0 branch from the head branch - ready for alpha18Andrew Tridgell1-5/+106
(This used to be commit 03ac082dcb375b6f3ca3d810a6a6367542bc23ce)
2002-04-09When printing a tdb log message display "unnamed" instead of "unknown" ifTim Potter1-1/+1
the tdb has not been named. (This used to be commit 3e7985c60ee9888285769f1eb0ec81f764c26d91)
2002-04-07uint32 store and fectch functions, a signed int is not enough sometimesSimo Sorce1-0/+96
(This used to be commit f07b2b3d5295202e0c8e530c43fae6d458b2cf2a)
2002-03-21Make winbindd_idmap tdb endian independent. This is very important forJeremy Allison1-93/+0
sharing between machines with rsync. Finally removed tdb_store_int/tdb_fetch_int. Now only tdb_store_int32/tdb_fetch_int32 which are endian independent are allowed. Jeremy. (This used to be commit 1c4a00dcc13f4a7c5876a5cf63ca730190d1132e)
2002-01-30Removed version number from file header.Tim Potter1-2/+1
Changed "SMB/Netbios" to "SMB/CIFS" in file header. (This used to be commit 6a58c9bd06d0d7502a24bf5ce5a2faf0a146edfa)
2002-01-22Display tdb name of "unknown" in logging debug when tdb has not been named.Tim Potter1-1/+1
(This used to be commit 96c36e51ee4df4c46e5e9e611844dfa83260f606)
2002-01-20This is another *BIG* change...Andrew Bartlett1-1/+1
Samba now features a pluggable passdb interface, along the same lines as the one in use in the auth subsystem. In this case, only one backend may be active at a time by the 'normal' interface, and only one backend per passdb_context is permitted outside that. This pluggable interface is designed to allow any number of passdb backends to be compiled in, with the selection at runtime. The 'passdb backend' paramater has been created (and documented!) to support this. As such, configure has been modfied to allow (for example) --with-ldap and the old smbpasswd to be selected at the same time. This patch also introduces two new backends: smbpasswd_nua and tdbsam_nua. These two backends accept 'non unix accounts', where the user does *not* exist in /etc/passwd. These accounts' don't have UIDs in the unix sense, but to avoid conflicts in the algroitmic mapping of RIDs, they use the values specified in the 'non unix account range' paramter - in the same way as the winbind ranges are specifed. While I was at it, I cleaned up some of the code in pdb_tdb (code copied directly from smbpasswd and not really considered properly). Most of this was to do with % macro expansion on stored data. It isn't easy to get the macros into the tdb, and the first password change will 'expand' them. tdbsam needs to use a similar system to pdb_ldap in this regard. This patch only makes minor adjustments to pdb_nisplus and pdb_ldap, becouse I don't have the test facilities for these. I plan to incoroprate at least pdb_ldap into this scheme after consultation with Jerry. Each (converted) passdb module now no longer has any 'static' variables, and only exports 1 init function outside its .c file. The non-unix-account support in this patch has been proven! It is now possible to join a win2k machine to a Samba PDC without an account in /etc/passwd! Other changes: Minor interface adjustments: pdb_delete_sam_account() now takes a SAM_ACCOUNT, not a char*. pdb_update_sam_account() no longer takes the 'override' argument that was being ignored so often (every other passdb backend). Extra checks have been added in some places. Minor code changes: smbpasswd no longer attempts to initialise the passdb at startup, this is now done on first use. pdbedit has lost some of its 'machine account' logic, as this behaviour is now controlled by the passdb subsystem directly. The samr subsystem no longer calls 'local password change', but does the pdb interactions directly. This allow the ACB_ flags specifed to be transferred direct to the backend, without interference. Doco: I've updated the doco to reflect some of the changes, and removed some paramters no longer applicable to HEAD. (This used to be commit ff354c99c585068af6dc1ff35a1f109a806b326b)
2002-01-18Ensure we log tdb open fails. Patch from Alexander Bokovoy ↵Jeremy Allison1-4/+2
<a.bokovoy@sam-solutions.net> Jeremy. (This used to be commit eb99e7f29c2d6041054331425cb245da86bedaa4)
2002-01-09Added int32 version of "atomic" update.Jeremy Allison1-0/+35
Jeremy. (This used to be commit 1233b553e78b8d7580b9ea4f1bba62c78b4cd186)
2002-01-09Added int32 versions of the endian-dependent code.Jeremy Allison1-2/+66
Jeremy. (This used to be commit d57fb9a8c25a95e434cb5fb3d63a87d98abeefef)
2002-01-03Fixed nasty cast of tdb_delete in traversals.Jeremy Allison1-0/+11
Jeremy. (This used to be commit a0cdec3acc82d1ce0292fadd4b8dac23638450f3)
2001-12-05changed the DEBUG level of tdb_pack and tdb_unpack. Instead of 8, it's nowJean-François Micouleau1-2/+2
18. when you're looking at a level 10, and it's all clutered with tdb_pack/unpack, it's getting .... And anyway most of our code using tdb_pack/unpack have DEBUG around the call if there is a problem. J.F. (This used to be commit 7e20fad5ed00be4594bfc45603db89d600f46c55)
2001-12-04Tidup.Jeremy Allison1-43/+80
Jeremy. (This used to be commit 837f2b961b1e7dcd6998f36d58d2059290e89e18)
2001-12-04undoMartin Pool1-1/+3
(This used to be commit fc176f15f27686049453552219b56b9de33ceffa)
2001-12-04Better error handling:Martin Pool1-3/+1
- tdb_open api changed so that you now pass an error handling callback when opening the file, so that errors detected during opening have somewhere to go. (All calls from the body of Samba to this function go through a wrapper in tdbutil, which has been updated.) - Clean up logic for deciding how to open tdb. Emit log messages if something goes wrong (e.g. bad magic.) - tdbtool now logs errors to stderr. (This used to be commit 0aa800618eab1043d802c04fb1d125cd07936769)
2001-09-06actually obey the "use mmap" smb.conf optionAndrew Tridgell1-1/+5
(This used to be commit b36c98036bcbaa5545c9637cb632361122033cfd)
2001-05-30merged fix for tdb_unpack from 2_2Andrew Tridgell1-1/+4
(This used to be commit 200b682e9bbe79897343422f7c870382ed6de40a)
2001-05-30- fixed an off-by-1 bug in the delayed deletion code that I believeAndrew Tridgell1-0/+1
was the initial cause of the connections database becoming corrupt. Note that this bug only happens when doing deletions within a traversal, which is why it has only showed up now - added delete within traversal testing to tdbtorture - added a lot more logging to tdb (This used to be commit 6e1277df9d964c615a3ad876d3b89ff8132081c1)
2001-05-30added a tdb_open_log() function that opens a tdb and enables loggingAndrew Tridgell1-0/+33
of messages from the tdb code into the Samba DEBUG() system just call tdb_open_log() instead of tdb_open() to enable this on any tdb (This used to be commit 3ab770484c6775df2c1a6f69427ebe656702c96c)
2001-05-25Added tdb_change_int_atomic() to allow atomic updates of a tdb int value.Jeremy Allison1-3/+32
Jeremy. (This used to be commit cf5015f15935605cf69078bc15251db61ddc48c7)
generated by cgit (git 2.34.1) at 2024-11-19 17:20:20 +0000