Age | Commit message (Collapse) | Author | Files | Lines |
|
This patch makes Samba compile cleanly with -Wwrite-strings.
- That is, all string literals are marked as 'const'. These strings are
always read only, this just marks them as such for passing to other functions.
What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables). The rest
is just adding a lot of 'const'.
As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).
Andrew Bartlett
(This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
|
|
(This used to be commit 5be3c37f50eac35cad3eadf0d24e7a4ee04c075e)
|
|
know that 'make proto' will ignore them there. The debugparse.h header
file is included in includes.h, and includes.h is included in debugparse.c,
so all of the pieces "see" each other. I've compiled and tested this,
and it does seem to work. It's the same compromise model I used when
adding the ubiqx modules into the system, which is why I put it all into
the same directory.
Chris -)-----
(This used to be commit b6888faacdba035e1b608a404a71d93791de2d52)
|