summaryrefslogtreecommitdiff
path: root/source3/utils/net_conf.c
AgeCommit message (Collapse)AuthorFilesLines
2013-09-24s3:net conf: add the same parameter checks to "setparm" as in "net rpc conf".Michael Adam1-0/+5
In "net rpc conf" these checks are necessary, since the that command uses the plain rpc-registry interface at this moment, and so unfortunately it has to duplicate the checks from the smbconf library. Since "net conf" uses the registry, these checks are not necessary in this command. I add them nonetheless to make the output more similar to "net rpc conf". It is also a little more user friendy than just printing "INVALID_PARAMETER" as handed back from libsmbconf. Implement these checks by calling the new net_conf_param_valid() function. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-05-28net: use smbconf_create_set_share() in "net conf import"Michael Adam1-47/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue May 28 20:01:12 CEST 2013 on sn-devel-104
2012-07-18source3/utils/net_conf.c: fix stackframe leakRusty Russell1-0/+2
net_conf_wrap_function() doesn't free its stackframe. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-08-08s3-net: Fixed a small typo in net conf function tableVicentiu Ciorbaru1-1/+1
The description of the function net conf delincludes had a wrong usage message: "net conf setincludes" instead of "net conf delincludes". Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-08s3-net: Fixed typo in net confVicentiu Ciorbaru1-1/+1
There was a missing ']' in net conf addshare usage message. Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Mon Aug 8 16:44:08 CEST 2011 on sn-devel-104
2011-06-29param: Merge param headers into lib/param/loadparm.hAndrew Bartlett1-0/+1
This defines a common table format, so we can in future define a common table. Andrew Bartlett
2011-06-10s3:net conf addshare: do not stat-check the share path.Michael Adam1-17/+0
Allow paths with % macros and paths that do not (yet...) exist. Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Fri Jun 10 17:38:07 CEST 2011 on sn-devel-104
2011-06-09s3-talloc Change TALLOC_REALLOC_ARRAY() to talloc_realloc()Andrew Bartlett1-1/+1
Using the standard macro makes it easier to move code into common, as TALLOC_REALLOC_ARRAY isn't standard talloc. Andrew Bartlett
2011-05-18s3-lib Replace StrCaseCmp() with strcasecmp_m()Andrew Bartlett1-1/+1
strcasecmp_m() never needs to call to talloc, and via next_codepoint() still has an ASCII fast-path bypassing iconv() calls. Andrew Bartlett
2011-05-10libsmbconf: Convert smbconf_get_config() to sbcErr.Andreas Schneider1-25/+18
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_transaction_*() to sbcErr.Andreas Schneider1-37/+35
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_delete_includes() to sbcErr.Andreas Schneider1-4/+4
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_set_includes() to sbcErr.Andreas Schneider1-6/+11
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_get_includes() to sbcErr.Andreas Schneider1-4/+4
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_delete_parameter() to sbcErr.Andreas Schneider1-7/+6
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_get_parameter() to sbcErr.Andreas Schneider1-7/+6
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_set_parameter() to sbcErr.Andreas Schneider1-21/+21
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_delete_share() to sbcErr.Andreas Schneider1-6/+7
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_get_share() to sbcErr.Andreas Schneider1-8/+8
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_create_share() to smbErr.Andreas Schneider1-8/+12
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_get_share_names() to sbcErr.Andreas Schneider1-4/+4
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_drop() to sbcErr.Andreas Schneider1-6/+5
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10libsmbconf: Convert smbconf_init() to sbcErr.Andreas Schneider1-7/+8
Signed-off-by: Michael Adam <obnox@samba.org>
2011-03-30s3-includes: only include system/filesys.h when needed.Günther Deschner1-0/+1
Guenther
2011-02-07s3:net conf: fix a comment typoMichael Adam1-1/+1
2010-05-18smbconf: only include smbconf headers where needed.Günther Deschner1-0/+3
Guenther
2010-04-20Fix i18n of net conf import error message.Jim McDonough1-3/+4
Thanks gd
2010-04-20Display an error on net conf import failures.Jim McDonough1-0/+3
When something goes wrong, such as a typo in a parameter name, we'll now display the failure instead of just returning with -1 and no message.
2010-02-12s3:make "net conf addshare" atomic by wrapping all writes in one transactionMichael Adam1-6/+36
Michael
2010-01-19s3 net: Fix compile warningsKai Blin1-13/+33
2010-01-19s3 net/i18n: Use only one spelling for "Usage:"Kai Blin1-1/+1
2010-01-18s3/net: split up some printable stings to ease i18nBjörn Jacke1-13/+13
If we put strings like "Usage:" into separate _() macros and not the whole "Usage:..." string we can cover much more messages by only one single translation. The drawback is that the message in the sources looks less pretty.
2009-11-29s3: "net_conf_addshare" only looks at the modeVolker Lendecke1-1/+1
2009-11-29s3: Pass the "fake dir create times" parameter to sys_*statVolker Lendecke1-1/+1
Step 0 to restore it as a per-share paramter
2009-07-30s3 net: i18n support for net confKai Blin1-120/+123
2009-05-26Introduce "struct stat_ex" as a replacement for SMB_STRUCT_STATVolker Lendecke1-1/+1
This patch introduces struct stat_ex { dev_t st_ex_dev; ino_t st_ex_ino; mode_t st_ex_mode; nlink_t st_ex_nlink; uid_t st_ex_uid; gid_t st_ex_gid; dev_t st_ex_rdev; off_t st_ex_size; struct timespec st_ex_atime; struct timespec st_ex_mtime; struct timespec st_ex_ctime; struct timespec st_ex_btime; /* birthtime */ blksize_t st_ex_blksize; blkcnt_t st_ex_blocks; }; typedef struct stat_ex SMB_STRUCT_STAT; It is really large because due to the friendly libc headers playing macro tricks with fields like st_ino, so I renamed them to st_ex_xxx. Why this change? To support birthtime, we already have quite a few #ifdef's at places where it does not really belong. With a stat struct that we control, we can consolidate the nanosecond timestamps and the birthtime deep in the VFS stat calls. At this moment it is triggered by a request to support the birthtime field for GPFS. GPFS does not extend the system level struct stat, but instead has a separate call that gets us the additional information beyond posix. Without being able to do that within the VFS stat calls, that support would have to be scattered around the main smbd code. It will very likely break all the onefs modules, but I think the changes will be reasonably easy to do.
2009-05-17s3:fix bug #6371, unsuccessful net conf setparm leaves empty shareMichael Adam1-3/+25
Wrap creation of share and setting of parameter into a transaction. Michael
2009-04-27s3:net conf: support dangling parameters by specifying "" as the section name.Michael Adam1-12/+30
for {get,set,del}parm Michael
2009-04-16In net_conf_import, start a transaction when importing a single share.Martin Schwenke1-0/+8
Commit d69c3db9d44ad5d9fd1f5d7a9499f3bd79ecfb47 caused the transaction start to be conditional but the commit is still unconditional, so an error occurs when importing a single share. An alternate fix would be to return the transaction start to be unconditional but then it would occur before other error checking. Signed-off-by: Martin Schwenke <martin@meltin.net> Signed-off-by: Michael Adam <obnox@samba.org>
2009-04-14Convert Samba3 to use the common lib/util/charset APIAndrew Bartlett1-3/+3
This removes calls to push_*_allocate() and pull_*_allocate(), as well as convert_string_allocate, as they are not in the common API To allow transition to a common charcnv in future, provide Samba4-like strupper functions in source3/lib/charcnv.c (the actual implementation remains distinct, but the API is now shared) Andrew Bartlett
2009-04-02s3:net conf: don't store share names as lower case, but as given.Michael Adam1-11/+11
Michael
2009-03-04s3:net conf: reduce memory usage of "net conf import".Michael Adam1-6/+33
"net conf import" was wrapped in one big transaction. This lead to MAX_TALLOC_SIZE being exceeded at roughly 1500 shares. This patch resolves that problem by limiting the top level transactions in "net conf import" to 100 shares. Michael
2009-02-26s3:net: wrap net conf import into one big transactionMichael Adam1-6/+27
This speeds up "net conf import" of a file with 2000 shares from 11 minutest to 1m50s on my box. Michael
2009-02-06s3:net conf: remove check for sharename being a usernam in "net conf addshare"Michael Adam1-6/+0
This is useless and can be overriden by "net conf setparm" anyways. Michael
2008-11-01Rename dos_errstr() to win_errstr() for consistency with Samba 4.Jelmer Vernooij1-17/+17
2008-06-10net: Rename functable3 to functable, get rid of old functablesKai Blin1-1/+1
(This used to be commit bb7c5fc4ec77db4073d3beccf12af12910b6bd07)
2008-06-10net: Make "net conf" use a functable similar to functable3Kai Blin1-43/+139
(This used to be commit b8382bc3af318226a1160c6c39627e7a32e050ab)
2008-05-10net: Remove globalsKai Blin1-61/+86
(This used to be commit 1e9319cf88b65a2a8d4f5099a1fe5297e405ed2e)
2008-04-23libsmbconf: rewrite API to use smbconf_service structMichael Adam1-59/+37
instead of lists of strings and counters directly... Michael (This used to be commit 17415e2dc457ce41793a7e28e71f72c538c19c61)
2008-04-15net conf: adapt output of NULL share params in net conf list.Michael Adam1-2/+7
don't list NULL share name and don't indent these parameters Michael (This used to be commit 0212b38913945ce3c8b14734804d81f1cd315621)
generated by cgit (git 2.34.1) at 2024-11-18 17:32:31 +0000