summaryrefslogtreecommitdiff
path: root/source3/utils/pdbedit.c
AgeCommit message (Collapse)AuthorFilesLines
2009-06-19Fix coverity #920. Possible NULL deref.Jeremy Allison1-0/+4
Jeremy.
2009-05-30Make it possible to change machine account sidsSimo Sorce1-40/+171
Fixes bug #6081
2009-05-30Remove trailing whitespacesSimo Sorce1-20/+20
2009-05-29s3:pdbedit: fix "format not a string literal and no format arguments" warningsMichael Adam1-2/+2
Michael
2009-05-29Consolidate create/delete account paths in pdbeditSimo Sorce1-257/+319
Use common paths like for smbpasswd, so that all utilities behave the same way. As for smbpasswd this changes the behavior of pdbedit to create/delete unix users is the add/delete user scripts are provided, or ldapsam:editposix is configured. Signed-off-by: Günther Deschner <gd@samba.org>
2009-04-05Remove a silly checkVolker Lendecke1-7/+0
This does not increase security, and if later error messages suck, we have to fix those.
2009-03-07Shape up pdb_search a bit by making it a talloc ctx with a destructorVolker Lendecke1-10/+10
2008-11-06Make us clean under valgrind --leak-check=full by using ↵Jeremy Allison1-2/+2
talloc_autofree_context() instead of NULL. Remove the code in memcache that does a TALLOC_FREE on stored pointers. That's a disaster waiting to happen. If you're storing talloc'ed pointers, you can't know their lifecycle and they should be deleted when their parent context is deleted, so freeing them at some arbitrary point later will be a double-free. Jeremy.
2008-10-27[s3]pdbedit: remove unused variable.Michael Adam1-4/+0
Note: The change of commit r21962 (or fe962d2e48, aka f540c18b2) that was partly lost in the SVN->git glue commit e5a951325a6 (aka 5c6c8e1fe93f34) is not needed any more since the handler for option "-s" calls set_dyn_CONFIGFILE(). Michael
2008-10-11Cope with changed signature of http_timestring().Jelmer Vernooij1-8/+15
2007-12-26Convert pdbedit to use pdb_search_usersVolker Lendecke1-78/+123
(This used to be commit 8a8f2583b8bda22f65c7483dea54ac823ed1c0c3)
2007-12-15Replace sid_string_static with sid_string_tosVolker Lendecke1-2/+2
In utils/ I was a bit lazy... (This used to be commit 60e830b0f4571bd5d9039f2edd199534f2a4c341)
2007-12-10Remove the char[1024] strings from dynconfig. ReplaceJeremy Allison1-2/+2
them with malloc'ing accessor functions. Should save a lot of static space :-). Jeremy. (This used to be commit 52dc5eaef2106015b3a8b659e818bdb15ad94b05)
2007-12-03Getting to the home stretch for elimination of pstrings...Jeremy Allison1-13/+13
Jeremy. (This used to be commit 041163551194102ca67fef52c57d87020a1d09bc)
2007-10-19Fix the popt / bool issues. Some places we used BOOLJeremy Allison1-14/+14
where we meant int. Fix this. Thanks to metze for pointing this out. Jeremy. (This used to be commit 793a9d24a163cb6cf5a3a0aa5ae30e9f8cf4744a)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison1-25/+25
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-10[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter1-2/+1
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10r24943: Some stackframesVolker Lendecke1-0/+3
(This used to be commit cddb9f11d5fafcd3797cb242775c37f0c04d4f15)
2007-10-10r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell1-2/+1
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23407: While verifying a bug I found out that for some reasonSimo Sorce1-17/+14
the code to add a machine was different then the one used to add a user, the old code led to the machine SID not being built out correctly allocationg a new RID out of the passdb but instead by using the old algorithmic method. This may easily end up in creating duplicated SID when the RID counter get close to the values built by the algorithmic method. Simo. (This used to be commit e077142aa39ad927a16e0d04874857bbc171ce07)
2007-10-10r23005: If we're running on a system where time_t is 8 bytesJeremy Allison1-2/+2
we have to take care to preserve the "special" values for Windows of 0x80000000 and 0x7FFFFFFF when casting between time_t and uint32. Add conversion functions (and use them). Jeremy. (This used to be commit 4e1a0b2549f7c11326deed2801de19564af0f16a)
2007-10-10r22828: Fix typo. Bugzilla #4589.James Peach1-1/+1
(This used to be commit b8959b172090eef6b40ff1fb012d6ff0d3d732ef)
2007-10-10r21962: Make pdbedit use the configfile specified by -sVolker Lendecke1-1/+6
(This used to be commit f540c18b2bbf1d3138aea6938c5313ca2e100215)
2007-10-10r21784: Replace smb_register_idle_event() with event_add_timed(). This fixes ↵Volker Lendecke1-1/+1
winbind who did not run the idle events to drop ldap connections. Volker (This used to be commit af3308ce5a21220ff4c510de356dbaa6cf9ff997)
2007-10-10r21755: Memory leak fixes from Zack Kirsch <zack.kirsch@isilon.com>.Jeremy Allison1-0/+1
Jeremy. (This used to be commit 02d08ca0be8c374e30c3c0e665853fa9e57f043a)
2007-10-10r19978: More "net sam policy" improvements. Thanks to Karolin Seeger ↵Volker Lendecke1-5/+11
<ks@sernet.de> Volker (This used to be commit fde042f29e9e9ac19ed3380e8fbe45fa8441e705)
2007-10-10r19127: Fix bug 4152Volker Lendecke1-0/+6
(This used to be commit 70038e8f7b3042c2732e7f8267cab0499972a819)
2007-10-10r18748: Eliminate set of computed time valuesJim McDonough1-76/+3
(This used to be commit c53d4a8151f3105efa4c0bc340f35ee5c9c97aaf)
2007-10-10r18313: Nobody said "no" (yet.... gd?), so commit it:Volker Lendecke1-12/+0
Remove the account_policy_migrated() thingy, and make cache_account_policy_set use gencache. Account policies are now handled like groups and users are with respect to "passdb backend". Volker (This used to be commit fa8b2e2a585ab0c00a5fbde7aa790043261caf2e)
2007-10-10r16252: Fix Klocwork ID 1119, 1121.Volker Lendecke1-0/+10
Volker (This used to be commit 678bbcf06109b276d3e4514c3788a9fb31348de0)
2007-10-10r14577: BUG Fixes:Gerald Carter1-13/+199
* Add back in the import/export support to pdbedit * Fix segv in pam_smbpass * Cleanup some error paths in pdb_tdb and pdb_interface (This used to be commit df53d64910fbb96eb810102e986b3c337d54c463)
2007-10-10r14062: Forgot those in the uint16/32 acb_info switch.Günther Deschner1-2/+2
Guenther (This used to be commit 0167b6cca80492d8a076da0497d24089f78587dc)
2007-10-10r13679: Commiting the rm_primary_group.patch posted on samba-technicalGerald Carter1-59/+24
* ignore the primary group SID attribute from struct samu* * generate the primary group SID strictlky from the Unix primary group when dealing with passdb users * Fix memory leak in original patch caused by failing to free a talloc * * add wrapper around samu_set_unix() to prevent exposing the create BOOL to callers. Wrappers are samu_set_unix() and samu-allic_rid_unix() (This used to be commit bcf269e2ec6630b78d909010fabd3b69dd6dda84)
2007-10-10r13607: Fix compile - don't ref auto variable in a structure initialization.Jeremy Allison1-1/+1
Fix from Richard Bollinger <rabollinger@gmail.com>. Jeremy. (This used to be commit 02da5189f1c2a07a7ac02cf51e23782f70829f34)
2007-10-10r13590: * replace all pdb_init_sam[_talloc]() calls with samu_new()Gerald Carter1-12/+33
* replace all pdb_{init,fill}_sam_pw() calls with samu_set_unix() (This used to be commit 6f1afa4acc93a07d0ee9940822d7715acaae634f)
2007-10-10r13576: This is the beginnings of moving the SAM_ACCOUNT data structureGerald Carter1-25/+25
to make full use of the new talloc() interface. Discussed with Volker and Jeremy. * remove the internal mem_ctx and simply use the talloc() structure as the context. * replace the internal free_fn() with a talloc_destructor() function * remove the unnecessary private nested structure * rename SAM_ACCOUNT to 'struct samu' to indicate the current an upcoming changes. Groups will most likely be replaced with a 'struct samg' in the future. Note that there are now passbd API changes. And for the most part, the wrapper functions remain the same. While this code has been tested on tdb and ldap based Samba PDC's as well as Samba member servers, there are probably still some bugs. The code also needs more testing under valgrind to ensure it's not leaking memory. But it's a start...... (This used to be commit 19b7593972480540283c5bf02c02e5ecd8d2c3f0)
2007-10-10r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter1-2/+2
macro which sets the freed pointer to NULL. (This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10r13525: This is only a cleanup to have the memset() and SAFE_FREE() only oneLars Müller1-8/+9
time in the code. Even if we now have an additional if statement after the free I prefer this solution in opposite to the duplicated code we had before. (This used to be commit 4272419b1146b1c03e070655f3a31d027c00ad20)
2007-10-10r13524: Add -t|--password-from-stdin option to pdbedit as we had with Samba 2.2.Lars Müller1-10/+10
This fixes bug #1386. The initial changes had been made by Carsten Höger <choeger at open-xhange dot com> for Samba 2.2 while being at SuSE. *sigh* To not duplicate code from smbpasswd in pdbedit stdin_new_passwd() and get_pass() are moved from smbpasswd to utils/passwd_util.c. (This used to be commit dbdc5ba497c6010dbad47c9d77fc8bec5557a328)
2007-10-10r13517: Fix typo -- thanks to Karolin Seeger <ks@sernet.de>Volker Lendecke1-1/+1
(This used to be commit d0efb435e51ee4d5454b55aee1596355ecc4a2c6)
2007-10-10r13460: by popular demand....Gerald Carter1-159/+26
* remove pdb_context data structure * set default group for DOMAIN_RID_GUEST user as RID 513 (just like Windows) * Allow RID 513 to resolve to always resolve to a name * Remove auto mapping of guest account primary group given the previous 2 changes (This used to be commit 7a2da5f0cc05c1920c664c9a690a23bdf854e285)
2007-10-10r13316: Let the carnage begin....Gerald Carter1-5/+5
Sync with trunk as off r13315 (This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)
2007-10-10r13212: r12414@cabra: derrell | 2006-01-28 17:52:17 -0500Derrell Lipman1-1/+1
lp_load() could not be called multiple times to modify parameter settings based on reading from multiple configuration settings. Each time, it initialized all of the settings back to their defaults before reading the specified configuration file. This patch adds a parameter to lp_load() specifying whether the settings should be initialized. It does, however, still force the settings to be initialized the first time, even if the request was to not initialize them. (Not doing so could wreak havoc due to uninitialized values.) (This used to be commit f2a24de769d1b2266e576597c57a8e3b1e2a2b51)
2007-10-10r13136: Fix handling user sid and user gidSimo Sorce1-2/+4
(This used to be commit 65d5abda68fa0cacbff489ea1e4bfeffd58c83cb)
2007-10-10r12555: Fix more load_case_table swegfaults. Arggg.Jeremy Allison1-0/+2
What I'd give for a global constructor... Jeremy. (This used to be commit c970d7d0a5ba225465dfb0980989b8817b17c643)
2007-10-10r12398: adding Guenther's account policy migration fixGerald Carter1-1/+50
(This used to be commit be32f10609f2274903cb3b2c6b84c9aa62962151)
2007-10-10r11327: Make user domain settable by pdbeditVolker Lendecke1-2/+9
(This used to be commit 37267d5ab018bb6df9e297ea68e57deb9a908f28)
2007-10-10r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4Jeremy Allison1-1/+1
x86_64 box. Jeremy. (This used to be commit d720867a788c735e56d53d63265255830ec21208)
2007-10-10r10656: BIG merge from trunk. Features not copied overGerald Carter1-9/+37
* \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck) (This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)