summaryrefslogtreecommitdiff
path: root/source3/utils/smbpasswd.c
AgeCommit message (Collapse)AuthorFilesLines
2010-09-26s3: Remove talloc_autofree_context() from smbpasswdVolker Lendecke1-2/+2
In both cases, pwd is freed immediately
2010-08-06s3-passdb: include samr.h where needed.Günther Deschner1-0/+1
Guenther
2010-08-05s3-secrets: only include secrets.h when needed.Günther Deschner1-0/+1
Guenther
2009-06-19Fix coverity #900. Resource leak.Jeremy Allison1-0/+5
Jeremy.
2009-05-29Consolidate user create/delete paths in smbpasswdSimo Sorce1-27/+15
This patch changes the way smbpasswd behaves when adding/deleting users. smbpasswd now calls pdb_create_user/pdb_delete_user, this means that if add/delete user scripts are configured then they are used to create or delete unix users as well. If the scripts are not defined the behavioris unchanged. This also allow to use smbpasswd -a/-x with ldapsam:editposix to allow automatic creation/deletion of users. Signed-off-by: Günther Deschner <gd@samba.org>
2009-04-16Don't look up local user for remote changes, even when root.Jim McDonough1-6/+10
2009-01-09Minor tidyup of unix account missing code.Jeremy Allison1-5/+5
Jeremy.
2009-01-09s3/smbpasswd: Check if Unix account exists before asking for the password.Karolin Seeger1-0/+9
Admins shouldn't have to type in the password twice when the passdb account cannot be created because the Unix account is missing. Karolin
2008-11-06Make us clean under valgrind --leak-check=full by using ↵Jeremy Allison1-2/+2
talloc_autofree_context() instead of NULL. Remove the code in memcache that does a TALLOC_FREE on stored pointers. That's a disaster waiting to happen. If you're storing talloc'ed pointers, you can't know their lifecycle and they should be deleted when their parent context is deleted, so freeing them at some arbitrary point later will be a double-free. Jeremy.
2008-09-01Fix some nonempty blank linesVolker Lendecke1-21/+21
(This used to be commit 9336cd1c5e5b5d113cd4912d4479dfe609fe261e)
2007-12-12Developer doesn't cut it - need #define test for NSS_WRAPPER.Jeremy Allison1-1/+1
Hopefully this should fix the buildfarm. Jeremy. (This used to be commit 087489b7f2a8cd5868b54dbed3f3eed5d0709ba7)
2007-12-12Only add the non-root escape on !developer.Jeremy Allison1-1/+1
Jeremy. (This used to be commit a50c2d159c754c6ff88649ed859f2b3f9c24f6a1)
2007-12-12Fix the buildfarm until I figure out how to allowJeremy Allison1-0/+2
smbpasswd -L for non-root on the buildfarm only. Jeremy. (This used to be commit 1bb5ce824f800d967e2a92e946dd6ce7c4580b93)
2007-12-12Fix bug #3727 with patch from Steve Langasek <vorlon@debian.org>Jeremy Allison1-0/+4
Jeremy. (This used to be commit 0723760ba47a465d2ff5a22a680f1b5196eca7d8)
2007-12-10Remove the char[1024] strings from dynconfig. ReplaceJeremy Allison1-1/+1
them with malloc'ing accessor functions. Should save a lot of static space :-). Jeremy. (This used to be commit 52dc5eaef2106015b3a8b659e818bdb15ad94b05)
2007-12-03Getting to the home stretch for elimination of pstrings...Jeremy Allison1-4/+3
Jeremy. (This used to be commit 041163551194102ca67fef52c57d87020a1d09bc)
2007-11-23Make remote_password_change return malloced error stringsVolker Lendecke1-2/+3
This fixes a segfault in smbpasswd -r (This used to be commit 49949f0b85007c7c2b3c340c12f3d18909862135)
2007-11-21Remove pstrings from pam_smbpass - make local_password_changeJeremy Allison1-5/+7
return malloced strings. Jeremy. (This used to be commit f652fe2bdb7a3a36e83dcf4b08347543fdffb9f0)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison1-5/+5
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-10r24943: Some stackframesVolker Lendecke1-1/+5
(This used to be commit cddb9f11d5fafcd3797cb242775c37f0c04d4f15)
2007-10-10r23801: The FSF has moved around a lot. This fixes their Mass Ave address.Andrew Tridgell1-2/+1
(This used to be commit 87c91e4362c51819032bfbebbb273c52e203b227)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r22071: Make the error message for incorrect use of '-c' show the parameter ↵Andrew Bartlett1-1/+1
as used. This means that smbpasswd -c user (which in htpasswd creates a new file) and smbpasswd -c /not/my/smb.conf should give errors an admin will think to chase down. Andrew Bartlett (This used to be commit 721375e14cfcef88061c9e4d4a1f3ca2f33fa9aa)
2007-10-10r21784: Replace smb_register_idle_event() with event_add_timed(). This fixes ↵Volker Lendecke1-1/+1
winbind who did not run the idle events to drop ldap connections. Volker (This used to be commit af3308ce5a21220ff4c510de356dbaa6cf9ff997)
2007-10-10r16247: Fix Coverity ID 296Volker Lendecke1-1/+1
(This used to be commit b82c95cb438b57bb8910e26657f8ffb590fe02df)
2007-10-10r16241: Fix Klocwork #106 and others like it.Jeremy Allison1-8/+25
Make 2 important changes. pdb_get_methods() returning NULL is a *fatal* error. Don't try and cope with it just call smb_panic. This removes a *lot* of pointless "if (!pdb)" handling code. Secondly, ensure that if samu_init() fails we *always* back out of a function. That way we are never in a situation where the pdb_XXX() functions need to start with a "if (sampass)" test - this was just bad design, not defensive programming. Jeremy. (This used to be commit a0d368197d6ae6777b7c2c3c6e970ab8ae7ca2ae)
2007-10-10r15906: smbpasswd help text for -W option (patch from Aruna Prabakar ↵Gerald Carter1-0/+1
<aruna.prabakar@hp.com> (This used to be commit 0a81af4fef5b794fea257d9e3e11b16c3a4de12f)
2007-10-10r15311: look at the NT password (not lanman one) when determining if ↵Gerald Carter1-1/+1
smbpasswd -e should probably for a password (This used to be commit 3522b53aecb5293747b66250279417f9edf876f1)
2007-10-10r13590: * replace all pdb_init_sam[_talloc]() calls with samu_new()Gerald Carter1-2/+2
* replace all pdb_{init,fill}_sam_pw() calls with samu_set_unix() (This used to be commit 6f1afa4acc93a07d0ee9940822d7715acaae634f)
2007-10-10r13576: This is the beginnings of moving the SAM_ACCOUNT data structureGerald Carter1-4/+4
to make full use of the new talloc() interface. Discussed with Volker and Jeremy. * remove the internal mem_ctx and simply use the talloc() structure as the context. * replace the internal free_fn() with a talloc_destructor() function * remove the unnecessary private nested structure * rename SAM_ACCOUNT to 'struct samu' to indicate the current an upcoming changes. Groups will most likely be replaced with a 'struct samg' in the future. Note that there are now passbd API changes. And for the most part, the wrapper functions remain the same. While this code has been tested on tdb and ldap based Samba PDC's as well as Samba member servers, there are probably still some bugs. The code also needs more testing under valgrind to ensure it's not leaking memory. But it's a start...... (This used to be commit 19b7593972480540283c5bf02c02e5ecd8d2c3f0)
2007-10-10r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter1-2/+2
macro which sets the freed pointer to NULL. (This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10r13524: Add -t|--password-from-stdin option to pdbedit as we had with Samba 2.2.Lars Müller1-42/+0
This fixes bug #1386. The initial changes had been made by Carsten Höger <choeger at open-xhange dot com> for Samba 2.2 while being at SuSE. *sigh* To not duplicate code from smbpasswd in pdbedit stdin_new_passwd() and get_pass() are moved from smbpasswd to utils/passwd_util.c. (This used to be commit dbdc5ba497c6010dbad47c9d77fc8bec5557a328)
2007-10-10r13316: Let the carnage begin....Gerald Carter1-10/+14
Sync with trunk as off r13315 (This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)
2007-10-10r13212: r12414@cabra: derrell | 2006-01-28 17:52:17 -0500Derrell Lipman1-1/+1
lp_load() could not be called multiple times to modify parameter settings based on reading from multiple configuration settings. Each time, it initialized all of the settings back to their defaults before reading the specified configuration file. This patch adds a parameter to lp_load() specifying whether the settings should be initialized. It does, however, still force the settings to be initialized the first time, even if the request was to not initialize them. (Not doing so could wreak havoc due to uninitialized values.) (This used to be commit f2a24de769d1b2266e576597c57a8e3b1e2a2b51)
2007-10-10r13148: Fix bug: #3413Simo Sorce1-3/+9
Check that ldap admin dn is defined in smb.conf before setting the ldap password in secrets.tdb Based on patch by William Jojo <jojowil@hvcc.edu> Simo. (This used to be commit c2c004a620ecbd895786dc6f16fb6a616f354a0a)
2007-10-10r12840: Add -W to smbpasswd. Thanks to William Jojo <jojowil@hvcc.edu>.Volker Lendecke1-1/+9
Volker (This used to be commit 2942f3594ba39748dca0238f1e1a5c744a7afffb)
2007-10-10r12544: Fix segfaults in winbind, smbpasswd and netVolker Lendecke1-0/+2
(This used to be commit 9ca8edc26e66887d6333943bc6a9776352c657fc)
2007-10-10r6261: Tidyup message str printf. Ensure tvs struct is zeroed.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 6c9f227ef400f32def85268f411691b569d29889)
2007-10-10r6256: Fix fprintf errors in smbpasswd. Fix for bug #2585 Ulf Härnhammar ↵Jeremy Allison1-3/+3
<metaur@telia.com> Jeremy. (This used to be commit 3dfa6c40fc726ddf38d4cfc6e0604ceed0035d18)
2007-10-10r3882: Fix bug 2069 -- thanks to jason@ncac.gwu.eduVolker Lendecke1-1/+2
(This used to be commit 5c9fd4d8963130829684469be172e859b3799e27)
2007-10-10r1504: Remove insane use of "user password" on the COMMAND LINE !Jeremy Allison1-25/+6
in smbpasswd. Use -s if you want to script this. Jeremy. (This used to be commit a3589a18b6898e2b51570112c5acb2826ef6ba4a)
2004-02-25I *hate* global variables...Andrew Bartlett1-0/+6
OK, what was happening here was that we would invalidate global_sam_sid when we set the sid into secrets.tdb, to force a re-read. The problem was, we would do *two* writes into the TDB, and the second one (in the PDC/BDC case) would be of a NULL pointer. This caused smbd startups to fail, on a blank TDB. By using a local variable in the pdb_generate_sam_sid() code, we avoid this particular trap. I've also added better debugging for the case where this all matters, which is particularly for LDAP, where it finds out a domain SID from the sambaDomain object. Andrew Bartlett (This used to be commit 86ad04d26d3065a99b08afaaf2914968a9e701c5)
2004-02-23Fix "unable to initialize" bug when smbd hasn't been run withJeremy Allison1-2/+4
new system and a user is being added via pdbedit/smbpasswd. Found at Connectathon setup. Jeremy. (This used to be commit f9c7a42e895f50e15d2f5079bfb2cb389fdf2df4)
2004-02-04This should be the correct fix for the lack of a prototype forAndrew Bartlett1-6/+0
remote_password_change(). Sorry for the original bug. Andrew Bartlett (This used to be commit 955436a6f6d7c2f580b2c4e1edbb7ee2fe5df858)
2004-02-02fix problems with proto.hGerald Carter1-1/+1
(This used to be commit 5a32f9568f128374df98491b43e6f5b299cb656c)
2004-02-02remerge andrew's cracklib patch from HEAD and fix a compile warningsGerald Carter1-0/+7
(This used to be commit b60f6ec30d05e4e5bba9934a416ddc8bc089824f)
2003-09-15fix online helpSimo Sorce1-1/+1
-w option need the password on the command line (This used to be commit fa7dea1710bac38f5f68be2e56a24ef5cca09ff5)
2003-07-22Replace the eight (!) copies of dummy become/unbecome root with a single one.Tim Potter1-15/+0
(This used to be commit 8b818ce381595cdcb36631a2440d6aa0038805f1)
2003-07-15Jim, could you please look at this? smbpasswd -a <username> was brokenVolker Lendecke1-2/+2
for me without this patch. I'm not sure if I interpreted your patch to this code right. Thanks, Volker (This used to be commit 46ec022f873416d2258fc8d84430b17319dce70f)
2003-07-11Doesn't re-prompt for password when it is specified on the cmdlineJim McDonough1-2/+2
(This used to be commit 6ebe87d318658f28ad9b9f8169fc4400856d5812)