summaryrefslogtreecommitdiff
path: root/source3/web
AgeCommit message (Collapse)AuthorFilesLines
2008-07-15Fix swat. Bug #5613.Jeremy Allison1-13/+18
Jeremy (This used to be commit 15920f838835f5dbbac8712202267c2a99237686)
2008-06-03Fix empty input fields in SWAT; [#5515].Andreas Schneider1-4/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org> (This used to be commit e1579c90fb27c07f95889dd8778daeef53e2ac16)
2008-06-03Fix saving of the config file in SWAT; [#5516].Andreas Schneider1-2/+2
The strlen of the source string passed to convert_string_allocate was too short :) Signed-off-by: Stefan Metzmacher <metze@samba.org> (This used to be commit ac3597ef8b7781499ab55f1039670ec82202e32c)
2008-05-20Cleanup size_t return values in callers of convert_string_allocateTim Prouty2-7/+10
This patch is the second iteration of an inside-out conversion to cleanup functions in charcnv.c returning size_t == -1 to indicate failure. (This used to be commit 6b189dabc562d86dcaa685419d0cb6ea276f100d)
2008-05-18swat: freeze swat_proto.h from "make proto"Michael Adam1-0/+70
Michael (This used to be commit 372c58cc220efc01af4b90b82b75191296a62e81)
2008-04-11Cleanup size_t return values in convert_string_allocateTim Prouty1-4/+4
This patch is the first iteration of an inside-out conversion to cleanup functions in charcnv.c returning size_t == -1 to indicate failure. (This used to be commit 59124382d2894a1b194b48dd82bc5f956959eb48)
2008-03-28Add a talloc context parameter to current_timestring() to fix memleaks.Michael Adam1-1/+5
current_timestring used to return a string talloced to talloc_tos(). When called by DEBUG from a TALLOC_FREE, this produced messages "no talloc stackframe around, leaking memory". For example when used from net conf. This also adds a temporary talloc context to alloc_sub_basic(). For this purpose, the exit strategy is slightly altered: a common exit point is used for success and failure. Michael (This used to be commit 16b5800d4e3a8b88bac67b2550d14e0aaaa302a9)
2008-03-12loadparm: add convenience wrapper lp_kill_all_services()Michael Adam1-1/+1
Michael (This used to be commit 32bfd131e33d06be9dfaef02b57f5401d2bc7639)
2008-02-04Always pass a TALLOC_CTX to str_list_make and str_list_copyVolker Lendecke1-2/+2
(This used to be commit e2c9fc4cf5f0ff725330fa44f53782db65fca37e)
2008-01-23strtok -> strtok_rVolker Lendecke1-1/+3
(This used to be commit fd34ce437057bb34cdc37f4b066e424000d36789)
2007-12-10Remove the char[1024] strings from dynconfig. ReplaceJeremy Allison2-12/+12
them with malloc'ing accessor functions. Should save a lot of static space :-). Jeremy. (This used to be commit 52dc5eaef2106015b3a8b659e818bdb15ad94b05)
2007-12-10Tiny simplificationsVolker Lendecke1-1/+1
locking.c:open_read_only was unused don't export the silly boolean flag locking_init(bool read_only) (This used to be commit 2f3c865707010bc7c463a02782dbee3dc2479da1)
2007-12-07We don't need P_GSTRING or P_UGSTRING anymore.Jeremy Allison1-15/+0
Jeremy. (This used to be commit 78dc75600099b5b3b5a8ecffec747a227ff51d70)
2007-12-05Remove some globalsVolker Lendecke1-5/+12
(This used to be commit 31d0a846db08d845e6cdfd85def4ac1c34031e02)
2007-12-03Make strhex_to_str clear on string limits. Remove pstring from web/*.cJeremy Allison4-89/+123
Jeremy. (This used to be commit f9c8d62389f8cb47837e5360209936176537df13)
2007-11-23Make remote_password_change return malloced error stringsVolker Lendecke1-3/+4
This fixes a segfault in smbpasswd -r (This used to be commit 49949f0b85007c7c2b3c340c12f3d18909862135)
2007-11-21Remove pstrings from pam_smbpass - make local_password_changeJeremy Allison1-6/+8
return malloced strings. Jeremy. (This used to be commit f652fe2bdb7a3a36e83dcf4b08347543fdffb9f0)
2007-11-15More pstring removal. This one was tricky. I had to addJeremy Allison1-0/+3
one horror (pstring_clean_name()) which will have to remain until I've removed all pstrings from the client code. Jeremy. (This used to be commit 1ea3ac80146b83c2522b69e7747c823366a2b47d)
2007-11-03I can't get away without a 'length' arg. :-).Jeremy Allison1-1/+1
Jeremy. (This used to be commit 95d01279a5def709d0a5d5ae7224d6286006d120)
2007-11-03Stop get_peer_addr() and client_addr() from using globalJeremy Allison1-1/+2
statics. Part of my library cleanups. Jeremy. (This used to be commit e848506c858bd16706c1d7f6b4b032005512b8ac)
2007-10-24This is a large patch (sorry). Migrate from struct in_addrJeremy Allison1-6/+10
to struct sockaddr_storage in most places that matter (ie. not the nmbd and NetBIOS lookups). This passes make test on an IPv4 box, but I'll have to do more work/testing on IPv6 enabled boxes. This should now give us a framework for testing and finishing the IPv6 migration. It's at the state where someone with a working IPv6 setup should (theorecically) be able to type : smbclient //ipv6-address/share and have it work. Jeremy. (This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)
2007-10-19Fix the popt / bool issues. Some places we used BOOLJeremy Allison1-2/+2
where we meant int. Fix this. Thanks to metze for pointing this out. Jeremy. (This used to be commit 793a9d24a163cb6cf5a3a0aa5ae30e9f8cf4744a)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison4-25/+25
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-11Add const to the get_peer_addr() and get_socket_addr()Jeremy Allison1-2/+2
calls. Use the IPv6 varient for get_peer_addr(). Jeremy. (This used to be commit baf1f52e34ae2465a7a34be1065da29ed97e7bea)
2007-10-10Add start of IPv6 implementation. Currently most of this is avoidingJeremy Allison1-2/+6
IPv6 in winbindd, but moves most of the socket functions that were wrongly in lib/util.c into lib/util_sock.c and provides generic IPv4/6 independent versions of most things. Still lots of work to do, but now I can see how I'll fix the access check code. Nasty part that remains is the name resolution code which is used to returning arrays of in_addr structs. Jeremy. (This used to be commit 3f6bd0e1ec5cc6670f3d08f76fc2cd94c9cd1a08)
2007-10-10r24781: Fix build warning.Günther Deschner1-1/+1
Guenther (This used to be commit 71307c371fea917b91214df7a24cd91170d40dd9)
2007-10-10r24701: Fix the swat buildVolker Lendecke2-0/+27
Swat has not been built by default for a while, so I did not notice that the _ macro is actually used. Re-add the lang_msg_rotate function, this time only to swat so that this is the only binary that has to take the 16k penalty. (This used to be commit 191e1ef840c293f8575cc0a3f3ffba2080431fae)
2007-10-10r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell6-12/+6
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison6-6/+6
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.Jeremy Allison1-1/+3
Long overdue fix.... Jeremy. (This used to be commit 073fdc5a58139796dbaa7ea9833dca5308f11282)
2007-10-10r23171: Convert connections.tdb to dbwrapVolker Lendecke1-12/+11
(This used to be commit 80a1f43825063bbbda896175d99700ede5a4757a)
2007-10-10r22761: This introduces lib/conn_tdb.c with two main functions: ↵Volker Lendecke1-52/+31
connections_traverse and connections_forall. This centralizes all the routines that did individual tdb_open("connections.tdb") and direct tdb_traverse. Volker (This used to be commit e43e94cda1ad8876b3cb5d1129080b57fa6ec214)
2007-10-10r22736: Start to merge the low-hanging fruit from the now 7000-line cluster ↵Volker Lendecke2-5/+5
patch. This changes "struct process_id" to "struct server_id", keeping both is just too much hassle. No functional change (I hope ;-)) Volker (This used to be commit 0ad4b1226c9d91b72136310d3bbb640d2c5d67b8)
2007-10-10r22282: Fix last few name -> servicename changes.Jeremy Allison1-1/+1
Jeremy. (This used to be commit f5c22f26f7ec7e8139fbf11a75820336db3d55c0)
2007-10-10r21784: Replace smb_register_idle_event() with event_add_timed(). This fixes ↵Volker Lendecke1-1/+1
winbind who did not run the idle events to drop ldap connections. Volker (This used to be commit af3308ce5a21220ff4c510de356dbaa6cf9ff997)
2007-10-10r21714: Change the VFS interface to use struct timespecJeremy Allison1-1/+1
for utimes - change the call to ntimes. This preserves nsec timestamps we get from stat (if the system supports it) and only maps back down to usec or sec resolution on time set. Looks bigger than it is as I had to move lots of internal code from using time_t and struct utimebuf to struct timespec. Jeremy. (This used to be commit 8f3d530c5a748ea90f42ed8fbe68ae92178d4875)
2007-10-10r17873: Fix possible null deref found by Stanford checker.Jeremy Allison1-2/+3
Jeremy. (This used to be commit 1adb3b2432187e9a19b78cfa5762c3e05a357392)
2007-10-10r17177: Get rid of a global variable by adding a private data pointer toVolker Lendecke1-2/+5
share_mode_forall(). Volker (This used to be commit f97f6cedffdc4d10afcac90a163b93a801acf514)
2007-10-10r16945: Sync trunk -> 3.0 for 3.0.24 code. Still needJeremy Allison3-8/+8
to do the upper layer directories but this is what everyone is waiting for.... Jeremy. (This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)
2007-10-10r16597: Klocwork #2006. Fix possible null deref.Jeremy Allison1-0/+4
Jeremy. (This used to be commit 9b73385d6b90c7806d8ccfc1f2354ede761fad61)
2007-10-10r16435: Add in the uid info that Jerry needs into theJeremy Allison1-0/+1
share_mode struct. Allows us to know the unix uid of the opener of the file/directory. Needed for info level queries on open files. Jeremy. (This used to be commit d929323d6f513902381369d77bcd7b714346d713)
2007-10-10r16426: Klocwork #1544, #1545, #1546, #1549, #1550, #1552, #1553, #1554Jeremy Allison2-20/+35
Jeremy. (This used to be commit e71cc6647a2eaba0eac95b6abb40745e45db72a4)
2007-10-10r16230: Fix Klocwork #861 and others. localtime and asctimeJeremy Allison1-1/+1
can return NULL. Ensure we check all returns correctly. Jeremy. (This used to be commit 6c61dc8ed6d84f310ef391fb7700e93ef42c4afc)
2007-10-10r15465: Fix segfault in SWAT.Deryck Hodge1-0/+2
Fixes bug #3702. deryck (This used to be commit 4ad7276cef02b28308446c0eb76ea1190ffe9b05)
2007-10-10r14618: add --no-process-group to all server programmsStefan Metzmacher1-3/+3
to make the following possible: timelimit 20000 bin/nmbd -F -S --no-process-group timelimit 20000 bin/smbd -F -S --no-process-group this is needed to 'make test' working without losing child processes metze (This used to be commit c3a9f30e2a12cc852c9fa3a7d161f5c6ee0694ce)
2007-10-10r14255: Revert r14204 which was horribly broken.James Peach1-0/+15
(This used to be commit 950ed28f9f3f57dc449bd3bd6e7be7acb1e3d26d)
2007-10-10r14204: Remove the basically unused P_GSTRING and P_UGSTRINGJames Peach1-15/+0
parameter types. (This used to be commit 23328fe6fc5e3b4ed3dc35e1475d661a8593eb1a)
2007-10-10r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison1-1/+1
realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy. (This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2007-10-10r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter1-3/+3
macro which sets the freed pointer to NULL. (This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10r13383: pulling in swat-welcome patch from SuSE packagingGerald Carter1-1/+5
(This used to be commit 1b955bbf59e5b11014405d888d58fefbc055ad38)
generated by cgit (git 2.34.1) at 2024-11-01 07:46:56 +0000