summaryrefslogtreecommitdiff
path: root/source3/web
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r14255: Revert r14204 which was horribly broken.James Peach1-0/+15
(This used to be commit 950ed28f9f3f57dc449bd3bd6e7be7acb1e3d26d)
2007-10-10r14204: Remove the basically unused P_GSTRING and P_UGSTRINGJames Peach1-15/+0
parameter types. (This used to be commit 23328fe6fc5e3b4ed3dc35e1475d661a8593eb1a)
2007-10-10r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison1-1/+1
realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy. (This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2007-10-10r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter1-3/+3
macro which sets the freed pointer to NULL. (This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10r13383: pulling in swat-welcome patch from SuSE packagingGerald Carter1-1/+5
(This used to be commit 1b955bbf59e5b11014405d888d58fefbc055ad38)
2007-10-10r13316: Let the carnage begin....Gerald Carter2-8/+8
Sync with trunk as off r13315 (This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)
2007-10-10r13262: Arrgggg. Fix smbstatus and swat status to ignoreJeremy Allison1-1/+7
bloody placeholder share mode entries (I hate these - I've had to add this filter code now to too many places :-). Jeremy. (This used to be commit 815340e1a413f98c1c36aacc1c34041e9160d0e3)
2007-10-10r13212: r12414@cabra: derrell | 2006-01-28 17:52:17 -0500Derrell Lipman1-1/+1
lp_load() could not be called multiple times to modify parameter settings based on reading from multiple configuration settings. Each time, it initialized all of the settings back to their defaults before reading the specified configuration file. This patch adds a parameter to lp_load() specifying whether the settings should be initialized. It does, however, still force the settings to be initialized the first time, even if the request was to not initialize them. (Not doing so could wreak havoc due to uninitialized values.) (This used to be commit f2a24de769d1b2266e576597c57a8e3b1e2a2b51)
2007-10-10r13140: Fix swat - make sure it can list running services (ensure loopback_ip)Jeremy Allison1-0/+1
is defined. Jerry - this needs to be in 3.0.21b. Jeremy. (This used to be commit 417ef5bffaefee698cbea4b06aff691f01ac56d1)
2007-10-10r12522: Try and fix bug #2926 by removing setlocale(LC_ALL, "C")Jeremy Allison1-1/+1
and replace calls to isupper/islower/toupper/tolower with ASCII equivalents (mapping into _w variants). Jeremy. (This used to be commit c2752347eb2deeb2798c580ec7fc751a847717e9)
2007-10-10r12393: cleaning up swat bugs. *no one* tests swat it seems. This has been ↵Gerald Carter2-102/+44
broken since r10656 (This used to be commit 85ea7afd8bd30e0a2bcbc7181f75fde63b016a34)
2007-10-10r12203: Add the share path into the sharemode db. This involvesJeremy Allison1-1/+1
revving the minor version number for libsmbsharemodes (we now have a new _ex interface that takes the share path as well as the filename). Needed for #3303. Some code written by SATOH Fumiyasu <fumiya@samba.gr.jp> included in the changes to locking/locking.c. The smbstatus output is a bit of a mess and needs overhauling... Jeremy. (This used to be commit 9d93af713f8520ca506730dd32aa2b994937eaba)
2007-10-10r11511: A classic "friday night check-in" :-). This moves muchJeremy Allison1-1/+1
of the Samba4 timezone handling code back into Samba3. Gets rid of "kludge-gmt" and removes the effectiveness of the parameter "time offset" (I can add this back in very easily if needed) - it's no longer being looked at. I'm hoping this will fix the problems people have been having with DST transitions. I'll start comprehensive testing tomorrow, but for now all modifications are done. Splits time get/set functions into srv_XXX and cli_XXX as they need to look at different timezone offsets. Get rid of much of the "efficiency" cruft that was added to Samba back in the day when the C library timezone handling functions were slow. Jeremy. (This used to be commit 414303bc0272f207046b471a0364fa296b67c1f8)
2007-10-10r10656: BIG merge from trunk. Features not copied overGerald Carter5-65/+125
* \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck) (This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)
2007-10-10r9790: remove 'set but not used' variables (reported by Jason Mader)Gerald Carter1-3/+2
(This used to be commit 9c78f3b0d6c36854e082a89cb1ee5b80fcc9fe35)
2007-10-10r9266: fix help links in swat editor after doc layout changesGerald Carter1-2/+2
(This used to be commit 4d50671602def039034fa03615cc9a205eba89c5)
2007-10-10r8219: Merge the new open code from HEAD to 3.0. Haven't yet run the tortureJeremy Allison2-5/+14
tests on this as it's very late NY time (just wanted to get this work into the tree). I'll test this over the weekend.... Jerry - in looking at the difference between the two trees there seem to be some printing/ntprinting.c and registry changes we might want to examine to try keep in sync. Jeremy. (This used to be commit c7fe18761e2c753afbffd3a78abff46472a9b8eb)
2007-10-10r7882: Looks like a large patch - but what it actually does is make SambaJeremy Allison2-9/+5
safe for using our headers and linking with C++ modules. Stops us from using C++ reserved keywords in our code. Jeremy (This used to be commit 9506b8e145982b1160a2f0aee5c9b7a54980940a)
2007-10-10r6959: Meant to fix this before commiting, just to be consistent.Deryck Hodge1-1/+1
deryck (This used to be commit 3732705605c757d8647efa2731070025f79ab302)
2007-10-10r6958: Properly display quotes in SWAT. Thanks to JayDeryck Hodge1-2/+22
Fenlason <fenlason@redhat.com> for spotting this issue. deryck (This used to be commit cd12641383c50020104142cad0e705e2b58c50f4)
2007-10-10r6395: Fix for Bug 2137, from Jay Fenlason <fenlason@redhat.com>Deryck Hodge1-4/+4
Encode quotes for display in HTML. deryck (This used to be commit b9b18a09ea3bf3edba15dc073dd20b195bc6082b)
2007-10-10r6281: Fix the build for FreeBSD 4 -- no winbindVolker Lendecke1-2/+2
(This used to be commit 1ce9a0159d36c2e4f154fb60c86cebcfbc2038dc)
2007-10-10r6225: get rid of warnings from my compiler about nested externsHerb Lewis1-2/+2
(This used to be commit efea76ac71412f8622cd233912309e91b9ea52da)
2007-10-10r6149: Fixes bugs #2498 and 2484.Derrell Lipman1-2/+2
1. using smbc_getxattr() et al, one may now request all access control entities in the ACL without getting all other NT attributes. 2. added the ability to exclude specified attributes from the result set provided by smbc_getxattr() et al, when requesting all attributes, all NT attributes, or all DOS attributes. 3. eliminated all compiler warnings, including when --enable-developer compiler flags are in use. removed -Wcast-qual flag from list, as that is specifically to force warnings in the case of casting away qualifiers. Note: In the process of eliminating compiler warnings, a few nasties were discovered. In the file libads/sasl.c, PRIVATE kerberos interfaces are being used; and in libsmb/clikrb5.c, both PRIAVE and DEPRECATED kerberos interfaces are being used. Someone who knows kerberos should look at these and determine if there is an alternate method of accomplishing the task. (This used to be commit 994694f7f26da5099f071e1381271a70407f33bb)
2007-10-10r5179: Add -P (password-menu-only) option to swat. Admins can allow usersDeryck Hodge1-1/+4
to use swat to change their password without allowing them to see the "View" and "Status" buttons. deryck (This used to be commit c9cacd553f8e7aa2db011cb7b22dd791b7460ea0)
2007-10-10r4577: Fix from William Jojo <jojowil@hvcc.edu> for AIX 5.3 compile.Jeremy Allison1-2/+2
Jeremy. (This used to be commit 80e7c6c312eb0bdb93fe381e7ce3a24a21dd9cf0)
2007-10-10r4369: Patch for bug #2190 (SWAT displaying parameters in UNIX charset)Jeremy Allison1-6/+18
not utf8. Fixed by Shiro Yamada <shiro@miraclelinux.com>. Jeremy. (This used to be commit 8de04888097b3e125845340ba1a9a1bb79892e22)
2007-10-10r4088: Get medieval on our ass about malloc.... :-). Take control of all our ↵Jeremy Allison3-14/+14
allocation functions so we can funnel through some well known functions. Should help greatly with malloc checking. HEAD patch to follow. Jeremy. (This used to be commit 620f2e608f70ba92f032720c031283d295c5c06a)
2007-10-10r2835: Since we always have -I. and -I$(srcdir) in CFLAGS, we can get rid ofTim Potter6-6/+6
'..' from all #include preprocessor commands. This fixes bugzilla #1880 where OpenVMS gets confused about the '.' characters. (This used to be commit 7f161702fa4916979602cc0295919b541912acd6)
2007-10-10r2771: Second (and last) part of Swat-i18n-Patch from Björn JackeGünther Deschner3-311/+318
<bjacke@sernet.de> "Do not use display charset for swat output. In HTML we do not care about the "locale charmap" because HTML code is UTF-8 only now. Additionally take care that we convert files from statuspage from unix charset to UTF-8. Thus we have correct HTML output under all circumstances. We now also convert the share names correctly from unix encoding to web encoding and vice vera. " Guenther (This used to be commit 6d9f77c2bb95db4939b8ef375e22b188168b70ab)
2007-10-10r1833: patch from James Peach to get swat to look for index.html by default ↵Gerald Carter1-4/+24
when given a trailing directory/ (This used to be commit 980740da784ce00ad1b388872297b82d4d368044)
2007-10-10r492: BUG 483: patch from Michel Gravey <michel.gravey@optogone.com> to fix ↵Gerald Carter1-1/+4
password hash creation in SWAT (This used to be commit 08fc16d7e694213fa1abf81f1e10989888508697)
2007-10-10r39: * importing .cvsignore filesGerald Carter1-1/+0
* updateing WHATSNEW with vl's change (This used to be commit a7e2730ec4389e0c249886a8bfe1ee14c5abac41)
2004-03-11Restore the contract on all convert_stringXX() interfaces. Add a ↵Jeremy Allison1-4/+4
"allow_bad_conv" boolean parameter that allows broken iconv conversions to work. Gets rid of the nasty errno checks in mangle_hash2 and check_path_syntax and allows correct return code checking. Jeremy. (This used to be commit 7b96765c23637613f079d37566d95d5edd511f05)
2004-03-05BUG 488: fix the 'show client in col 1' button and corrctely enumerate ↵Gerald Carter1-1/+1
active connections (This used to be commit d77d38560d1bdc10a58408f449fbc320275bcacc)
2004-02-21printf -> d_printfTim Potter1-1/+1
Bugzilla #1066. (This used to be commit 2285ec9737d7d1767e60cf43c3a55f10643371be)
2004-02-08Make more functions static, and remove duplication in the use of functionsAndrew Bartlett1-1/+1
in lib/smbpasswd.c that were exact duplicates of functions in passdb/passdb.c (These should perhaps be pulled back out to smbpasswd.c, but that can occour later). Andrew Bartlett (This used to be commit fcdc5efb1e245c8fa95cd031f67ec56093b9056e)
2004-02-04This should be the correct fix for the lack of a prototype forAndrew Bartlett1-6/+0
remote_password_change(). Sorry for the original bug. Andrew Bartlett (This used to be commit 955436a6f6d7c2f580b2c4e1edbb7ee2fe5df858)
2004-02-02fix problems with proto.hGerald Carter1-1/+1
(This used to be commit 5a32f9568f128374df98491b43e6f5b299cb656c)
2004-02-02remerge andrew's cracklib patch from HEAD and fix a compile warningsGerald Carter1-0/+7
(This used to be commit b60f6ec30d05e4e5bba9934a416ddc8bc089824f)
2003-12-25Fix bug 916 - do not perform a + -> space substitution for squid URL encodedAndrew Bartlett1-0/+18
strings, only form input in SWAT. Andrew Bartlett (This used to be commit 8d54f5fe0c5689660f37788916b37014754ce23e)
2003-11-22include WWW-Authenticate field in 401 response for bad auth attempt; bug 629Gerald Carter1-1/+2
(This used to be commit 879d0f15ea260d61c56c5b841065ecb2f5ec26ca)
2003-11-22fix winbind ping call so that SWAT correctly determines if winbindd is ↵Gerald Carter1-5/+1
running; bug 398 (This used to be commit 04e37283f230b28f3019bfab3a71dde5e4ae4e23)
2003-11-22Ensure that items in a list of strings containing whitespaceGerald Carter1-2/+10
are written out surrounded by single quotes. This means that both double and single quotes are now used to surround strings in smb.conf. This is a slight change from the previous behavior but needed or else things like printer admin = +ntadmin, 'VALE\Domain, Admin' get written to smb.conf by SWAT. (This used to be commit 5bf91c79d620e34ac71d72c80f74e47754d49dcb)
2003-11-07Simple rename of get_socket_addr to get_peer_addr and get_socket_name toVolker Lendecke1-2/+2
get_peer_name. This is to get closer to the getsockname/getpeername system functions. Next step will be the %i macro for the local IP address. I still want to play %L-games in times of port 445. Volker (This used to be commit d7162122eaf5d897e5de51604e431bfbaa20e905)
2003-10-22Put strcasecmp/strncasecmp on the banned list (except for needed callsJeremy Allison1-11/+11
in iconv.c and nsswitch/). Using them means you're not thinking about multibyte at all and I really want to discourage that. Jeremy. (This used to be commit d7e35dfb9283d560d0ed2ab231f36ed92767dace)
2003-10-21call initgroups before becomming the user; patch from Fabio CecchiGerald Carter1-0/+3
(This used to be commit 5a8dbccd66911642fabb6b8b38fff4477b76c3a1)
2003-10-03Moving towards better i18n support in SWAT. This commit contains aTim Potter2-76/+85
bunch of updates to bug 413 from Monyo: 1) pick up proper strings to call msg strings for example to add strings in wizard menu in web/swat.c, web/statuspage.c and param/loadparm.c. 2) define N_() macro in include/intl.h to pick up some strings in param/loadparm.c 3) quote all name and value tag with '"' For example in swat.c:720 the "Edit Parameter Values" string is displayd only as "Edit" because value tag is not quoted like: value=Edit Parameter Values These tags should be quoted though it sometimes works well without quotation. 4) modify the msg strings not to contain HTML tags or other non-message strings. For example dprintf(_("test\n")); is modified to dprintf("%s\n", _("test")); (This used to be commit 351d16956d8125bc689ca84adcb71e0a57d6b7cc)
2003-09-26More bug #413. Fix bad html table row termination in SWAT wizard code found byTim Potter1-4/+3
Monyo. Also remove debugging d_printf() which snuck in the last commit. (This used to be commit 0192f41003af0f8e8c117cf7eb8ad886b8b03749)
2003-09-26Change title of SWAT globals page from 'Global Variables' to 'GlobalTim Potter1-1/+3
Parameters' to be more consistent with the other pages. (This used to be commit 02725d4a3cff5bf0b676c363200795d4cadecca1)
generated by cgit (git 2.34.1) at 2024-11-06 09:40:56 +0000