summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2010-03-15s3: Fix an uninitialized variable readVolker Lendecke1-1/+1
Found by Laurent Gaffie <laurent.gaffie@gmail.com> Thanks for that, Volker
2010-03-15Remove the bool admin_user from conn struct. We no longer look at this to ↵Jeremy Allison4-9/+5
make access decisions. Jeremy.
2010-03-15Fix bug #7188 - Logic error in check of total_data for call_trans2mkdir()Jeremy Allison1-16/+13
Make ea data checks identical for trans2open and trans2mkdir. Jeremy.
2010-03-15Remove reference to conn->admin_user in preparation for removal.Jeremy Allison1-9/+13
We use (uid_t)0 here not sec_initial_uid() as make test uses a single user context. I will revisit this when all the uid check changes are complete. Jeremy.
2010-03-15Simplify processing of "admin user". If a user is an admin_user ensure their ↵Jeremy Allison1-15/+14
conn token is uid 0. This simplifies change_to_user() and removes special processing of the assignments we pass to set_sec_ctx(). Jeremy.
2010-03-15Switch over to using get_currect_XXX() accessor functions.Jeremy Allison5-33/+38
Jeremy.
2010-03-15Pass "connection_struct *conn" into functions that currently use ↵Jeremy Allison3-20/+22
"current_user.XXX" Will allow me to replace them with accessor functions. Jeremy.
2010-03-15Add accessor functions for current uid, gid, unix token, NT token and vuid.Jeremy Allison2-0/+48
Jeremy.
2010-03-15We don't need to treat the token differently in the conn->admin_user case, ↵Jeremy Allison1-11/+0
it should already be pointing to a token with uid == 0. Jeremy.
2010-03-15Rever e80ceb1d7355c8c46a2ed90d5721cf367640f4e8 "Remove more uses of "extern ↵Jeremy Allison10-129/+78
struct current_user current_user;"." As requested by Volker, split this into smaller commits. Jeremy.
2010-03-15s3:smbd: make sure we always have a valid talloc stackframeStefan Metzmacher1-0/+3
metze
2010-03-15s3-spoolss: Fix _spoolss_EnumPrinterData.Günther Deschner1-3/+5
Guenther
2010-03-14s3: Remove some unused #definesVolker Lendecke1-8/+0
2010-03-14s3: Use a switch to implement map_nt_error_from_tdbVolker Lendecke1-30/+47
First, this immediately gave me the warning that TDB_ERR_NESTING was not covered and second, this saved 48 bytes in the .o :-)
2010-03-14s3: Remove some unused codeVolker Lendecke2-24/+0
2010-03-14s3: Fix some nonempty blank linesVolker Lendecke5-30/+27
2010-03-13s3: Convert unexpected.tdb to use tdb_wrap_openVolker Lendecke1-10/+12
2010-03-13s3: Make tdb_wrap_open more robustVolker Lendecke2-43/+87
This hides the use of talloc_reference from the caller, making it impossible to wrongly call talloc_free() on the result.
2010-03-13s3-spoolss: wrap _spoolss_EnumPrinterData() around _spoolss_EnumPrinterDataEx().Günther Deschner1-64/+40
This removes some dependencies to registry code. Guenther
2010-03-12Missed a couple more uses of conn->server_info->ptok that need to be ↵Jeremy Allison3-30/+36
get_current_nttok(conn) Centralize the root check into smb1_file_se_access_check() so this is used by modules/vfs_acl_common.c also. Jeremy.
2010-03-12Remove more uses of "extern struct current_user current_user;".Jeremy Allison10-79/+130
Use accessor functions to get to this value. Tidies up much of the user context code. Volker, please look at the changes in smbd/uid.c to familiarize yourself with these changes as I think they make the logic in there cleaner. Cause smbd/posix_acls.c code to look at current user context, not stored context on the conn struct - allows correct use of these function calls under a become_root()/unbecome_root() pair. Jeremy.
2010-03-12s3: Add "net registry increment"Volker Lendecke1-0/+105
A convenience function to increment a DWORD value under a (cluster-wide) lock
2010-03-12s3: Add "g_lock_do" as a convenience wrapper functionVolker Lendecke3-27/+90
2010-03-12s3: Actually use mem_ctx in net_g_lock_init()Volker Lendecke1-3/+3
2010-03-12s3: Fix a commentVolker Lendecke1-1/+1
2010-03-12s3: Fix some "net registry" usage messagesVolker Lendecke1-3/+3
2010-03-12s3-netlogon: Fix bug #7237: _netr_SamLogon segfaults for clients sending ↵Günther Deschner1-6/+12
NULL domain. Thanks to Marc Muehlfeld <muehlfeld@medizinische-genetik.de>. Guenther
2010-03-11Improve symlink delete test. Make sure we don't delete the link target by ↵Jeremy Allison1-7/+19
mistake. Jeremy.
2010-03-11s3-winreg: make QueryValue pass RPC-WINREG test again.Günther Deschner1-0/+4
Guenther
2010-03-11s3-winreg: fix some function names in debug statements.Günther Deschner1-3/+3
Guenther
2010-03-11s3: Make init_smb_request return boolVolker Lendecke1-5/+10
Centralize the exit_server_cleanly()
2010-03-11s3-winreg: Fix _winreg_QueryValue crash bugs and implement windows behavior.Günther Deschner1-11/+8
Found by RPC-WINREG smbtorture test. Guenther
2010-03-10Try and fix bug #7233 - print fails with jobs >4GB from Win7 clients.Jeremy Allison2-4/+4
Remove an arbitrarty 4G B limit that *doesn't need to be there* ! Jeremy.
2010-03-11Move prototype to header of common code for set_sockaddr_portAndrew Bartlett1-1/+0
2010-03-10vfs_netatalk: Segfault if hide files or veto files has no ".AppleDouble"SATOH Fumiyasu1-1/+1
2010-03-10Added regression test for bug #7234 - Symlink delete fails but incorrectly ↵Jeremy Allison2-5/+47
reports success. Ensure we can delete a symlink by path. Jeremy.
2010-03-10Fix bug #7234 - Symlink delete fails but incorrectly reports success to client.Jeremy Allison1-1/+1
Typo called LSTAT instead of STAT in the unlink by pathname path. Jeremy.
2010-03-10s3/drs: DsCrackNames - Propagating IDL changes to source codeKamen Mazdrashki2-4/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10s3/drs: DsGetNCChanges - Propagating IDL changes to source codeKamen Mazdrashki2-9/+9
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-03-10s3-winreg: add some debug statements to _winreg_QueryValue().Günther Deschner1-2/+6
Guenther
2010-03-10s3: Fix a long-standing problem with recycled PIDsVolker Lendecke20-38/+602
When a samba server process dies hard, it has no chance to clean up its entries in locking.tdb, brlock.tdb, connections.tdb and sessionid.tdb. For locking.tdb and brlock.tdb Samba is robust by checking every time we read an entry from the database if the corresponding process still exists. If it does not exist anymore, the entry is deleted. This is not 100% failsafe though: On systems with a limited PID space there is a non-zero chance that between the smbd's death and the fresh access, the PID is recycled by another long-running process. This renders all files that had been locked by the killed smbd potentially unusable until the new process also dies. This patch is supposed to fix the problem the following way: Every process ID in every database is augmented by a random 64-bit number that is stored in a serverid.tdb. Whenever we need to check if a process still exists we know its PID and the 64-bit number. We look up the PID in serverid.tdb and compare the 64-bit number. If it's the same, the process still is a valid smbd holding the lock. If it is different, a new smbd has taken over. I believe this is safe against an smbd that has died hard and the PID has been taken over by a non-samba process. This process would not have registered itself with a fresh 64-bit number in serverid.tdb, so the old one still exists in serverid.tdb. We protect against this case by the parent smbd taking care of deregistering PIDs from serverid.tdb and the fact that serverid.tdb is CLEAR_IF_FIRST. CLEAR_IF_FIRST does not work in a cluster, so the automatic cleanup does not work when all smbds are restarted. For this, "net serverid wipe" has to be run before smbd starts up. As a convenience, "net serverid wipedbs" also cleans up sessionid.tdb and connections.tdb. While there, this also cleans up overloading connections.tdb with all the process entries just for messaging_send_all(). Volker
2010-03-10s3: Make TLDAP_IS_ALPHA and TLDAP_IS_ADH static functionsVolker Lendecke1-5/+12
2010-03-10s3-passdb: Fix typo in debug message.Karolin Seeger1-1/+1
Karolin
2010-03-09Fix the shell script in the root case. When run as root, make test now ↵Jeremy Allison1-4/+4
detects CAP_DAC_OVERRIDE being left on in error. Jeremy.
2010-03-09Add tests which, when run as root, will ensure we can't writeJeremy Allison3-11/+154
into a read-only directory, or read a owner-read-only file. Jeremy.
2010-03-09Fix typoSimo Sorce1-2/+2
2010-03-09Allow "make test" to complete as root. Obviously only safe on tightlyJeremy Allison1-0/+16
controlled developer machines. Jeremy.
2010-03-09s3: Fix a NULL pointer dereferenceVolker Lendecke1-1/+10
Found by Laurent Gaffie <laurent.gaffie@gmail.com>. Thanks! Volker
2010-03-09s3:tldap add own filter parsingSimo Sorce2-114/+614
Also add torture test to check filter parsing.
2010-03-09s3: Fix a typo. Thanks to Christian Ambach for pointing me at it :-)Volker Lendecke20-20/+20