summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2013-05-16auth: Ensure auth_sam is not used on the AD DCAndrew Bartlett1-0/+7
Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu May 16 22:51:26 CEST 2013 on sn-devel-104
2013-05-16pdb_ldap: Do not skip accounts without a sambaAcctFlags valueAndrew Bartlett1-4/+4
We allow this to mean a sambaAcctFlags value of zero in other parts of the code and by allowing these users to show up in a search, we can read and correct them during the classicupgrade, rather than not know they exist at all. Most parts of the code do not look for ACB_NORMAL, which is why these users appear to work. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-05-16s3-rpc_server: Ensure we are root when starting and usiing gensecAndrew Bartlett1-6/+32
This fixes bug 9465. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-05-15source3/utils/ntlm_auth.c: Fix typo in debug message.Karolin Seeger1-1/+1
Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-15source3/modules/vfs_catia.c: Fix typo in comment.Karolin Seeger1-1/+1
Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-15source3/libsmb/ntlmssp.c: Fix typo.Karolin Seeger1-1/+1
Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-14winbind/idmap_ad: be verbose about the user that we fail to mapBjörn Jacke1-2/+3
Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-05-14vfs_gpfs: slightly simplify connect()Volker Lendecke1-7/+7
DISCONNECT can be arbitrarily complex, TALLOC_FREE of a simple struct is easier. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue May 14 18:11:29 CEST 2013 on sn-devel-104
2013-05-14s3:rpc_server/srvsvc check access before doing workShekhar Amlekar1-10/+10
Before doing the (potentially) costly enumerations, check if the user has necessary privileges first Signed-off-by: Shekhar Amlekar <samlekar@in.ibm.com> Reviewed-by: Christian Ambach <ambi@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Tue May 14 16:22:24 CEST 2013 on sn-devel-104
2013-05-14torture: Remove some unused codeVolker Lendecke1-5/+0
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
2013-05-14smbd: Remove a pointless variableVolker Lendecke1-2/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue May 14 13:19:44 CEST 2013 on sn-devel-104
2013-05-14build: Add missing dep from vfs_nfs4acl_xattr to NDR_NFS4ACLAndrew Bartlett1-1/+1
Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue May 14 01:23:17 CEST 2013 on sn-devel-104
2013-05-12lib: Fix CID 241650 Sizeof not portableVolker Lendecke1-1/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ira Cooper <ira@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Sun May 12 17:44:55 CEST 2013 on sn-devel-104
2013-05-12pthreadpool: Fix CID 710828 Sizeof not portableVolker Lendecke1-1/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ira Cooper <ira@samba.org>
2013-05-09s3:modules/vfs_aixacl2 fix compile errorsChristian Ambach1-9/+8
fix various compile errors that were introduced with latest ACL changes Signed-off-by: Christian Ambach <ambi@samba.org> Pair-Programmed-With: Alexander Werth <alexander.werth@de.ibm.com> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09Fix missing TALLOC_FREE of stackframes.Jeremy Allison2-2/+6
Signed-off-by: Jeremy Allison <jra@samba.org>
2013-05-09Tidy up old bool usage. False -> false, True -> true.Jeremy Allison1-13/+13
Signed-off-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Allow CREATOR GROUP to be used with vfs_zfsaclAndrew Bartlett1-1/+1
The solaris acl() code requires that both ACE_GROUP|ACE_IDENTIFIER_GROUP be set to indicate the @group permissions. Otherwise, it would return Invalid Paramter to clients. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s4-smbtorture: Run tests for nfs4:modes simple and special.Alexander Werth1-1/+2
Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Update README.nfs4acls.txtAlexander Werth1-8/+15
Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Use mode bits in some cases in mode simple.Alexander Werth1-0/+46
Non inheriting ACL entries will show mode bits. With this an file owner change does affect the effective ACL because the special owner acl will now refer to the new owner. This could be fixed by updating the ACL on a file owner change. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Add changes that keep nfs4:mode special behavior.Alexander Werth1-1/+41
Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Mapping of cifs creator owner to nfs owner@ ace.Alexander Werth1-0/+24
This is ignored in nfs4mode special for compatibility. Also ensure that we drop non inheriting creator owner aces since these don't contribute to who can access a file. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Mapping of special entries to creator owner in mode simple.Alexander Werth1-6/+60
Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Add params parameter to smbacl4_nfs42win function.Alexander Werth1-12/+27
Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Change smbacl4_get_vfs_params to use connection_struct instead of fsp.Alexander Werth1-5/+6
Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Move up declaration of params struct and related function.Alexander Werth1-49/+49
We need the parameters earlier in the code so we move up the declaration of the params struct. Since reading the parameters is closely related the definition of the function smbacl4_get_vfs_params has also been moved up. Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Add inheritance emulation to vfs_nfs4acl_xattr.Alexander Werth1-29/+263
Recursively inherit ACL from parent directory if no acl xattr is found on the current file. Use a default ACL if a non-inheriting ACL is encountered. With this the nfs4acl_xattr.dynamic test passes. But the nfs4acl_xattr.inheritance test results in an error because of warnings that cause the test to pass a failed result. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09selftest: Run raw.acls test against the nfs4acl_xattr moduleAndrew Bartlett1-0/+4
This is the first time we have tested the NFSv4 ACL mapping code. Sadly most tests fail but these can be fixed from here. This at least shows that the code does not segfault. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09build: Add vfs_nfs4acl to the autoconf buildAndrew Bartlett2-1/+4
Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Add new VFS module vfs_nfs4acl_xattr to use nfs4acl.idlAndrew Bartlett5-2/+430
This uses the xattr format used by the patches at http://users.suse.com/~agruen/nfs4acl/ Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Remove unused security_info argument in vfz_zfsacl.cAndrew Bartlett1-3/+1
Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Fix compile of vfs_gpfs.c.Alexander Werth1-18/+33
Since the smb4acl is now correctly allocated on mem_ctx and not the talloc stack frame we can free the stack frame correctly. And the chmod emulation code now needs the vfs handle since that is now required by the callback function to set the smb4acl. Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Allocate SMB4ACL_T on an explict memory contextAndrew Bartlett5-33/+78
This ensures the caller knows exactly what the memory lifetime of this returned object is. This makes the NFSv4 ACL code consistent with the POSIX and NT ACL code, to avoid supprising developers who have worked on those other parts of the ACL code. Most of this patch is adding a memory context to the callers and passing it in. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Add vfs_handle_struct argument to smb_set_nt_acl_nfs4 and the callbackAndrew Bartlett5-15/+16
This allows the callback to call xattr based storage functions that need this argument. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-07Remove the compound_related_in_progress state from the smb2 global state.Jeremy Allison2-12/+0
And also remove the restriction that we can't read a new request whilst we're in this state. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@samba.org>
2013-05-07The core of the fix to allow opens to go async inside a compound request.Jeremy Allison1-43/+53
This is only allowed for opens that cause an oplock break, otherwise it is not allowed. See [MS-SMB2].pdf note <194> on Section 3.3.5.2.7. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2013-05-07Move a variable into the area of code where it's used.Jeremy Allison1-2/+2
Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2013-05-07Ensure we don't try and cancel anything that is in a compound-related request.Jeremy Allison1-0/+8
Too hard to deal with splitting off the replies. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2013-05-07Only do the 1 second delay for sharing violations for SMB1, not SMB2.Jeremy Allison1-1/+2
Match Windows behavior. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2013-05-07Makefile: Fix bug 9868 - Don't know how to make LIBNDR_PREG_OBJ.Volker Lendecke1-1/+1
Thanks to Lucs for finding the issue Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue May 7 17:57:57 CEST 2013 on sn-devel-104
2013-05-07winbind: Fix bug 9854 -- NULL pointer dereferenceVolker Lendecke1-3/+3
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue May 7 14:49:07 CEST 2013 on sn-devel-104
2013-05-06Allow "store dos attributes" to override the other "map XXX" parameters.Jeremy Allison1-5/+8
Makes us consistent with what is described in the man pages. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-05-06build: default --with-regedit to "auto" instead of "yes"Michael Adam1-1/+1
This means we don't build regedit when there is no ncurses and this is not an error for the overall build. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Kai Blin <kai@samba.org> Autobuild-User(master): Kai Blin <kai@samba.org> Autobuild-Date(master): Mon May 6 20:11:09 CEST 2013 on sn-devel-104
2013-05-06build: fix --with-regedit to properly honour the yes/no/auto schemeMichael Adam2-2/+24
I.e. fail configure when ncurses support is not found but regedit build was requested. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Kai Blin <kai@samba.org>
2013-05-06build: simplify ncurses checks: --with-regedit does not take a path listMichael Adam1-7/+2
--with-regedit is defined using SAMBA3_ADD_OPTION(), and can hence take the values "yes", "no", and "auto". So it is not possible to hand in paths to look for ncurses-config via this option. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Kai Blin <kai@samba.org>
2013-05-06s3:idmap:autorid: add a comment block explaining the calculationsMichael Adam1-0/+51
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
2013-05-06s3:idmap:autorid: simplify the id->sid calculationMichael Adam1-7/+13
To make it more intutive. rid = reduced_rid + domain_range_index * range_size where reduced_rid = (id - id_low) % range_size Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
2013-05-06s3:idmap:autorid: calculate the range's low_id in ↵Michael Adam1-8/+9
idmap_autorid_get_domainrange() This way, the calculation needs to be don only in one central place and the formulas get simpler. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
2013-05-06s3:idmap:autorid: make calculation in idmap_autorid_sid_to_id much more obviousMichael Adam1-3/+6
This is my attempt to make the sid->unix-id calculation much more obvious. Especially with the introduction of the multi-range support an the originally named "multiplier", the calculation id = low_id + range_size * domain_number + rid - range_size * multiplier was rather opaque to me. What really happens here is this: The rid is split into a reduced_rid part that is < rangesize and a multiple of rangesize. This is given by the formula rid = rid % range_size + (rid / range_size) * range_size We define reduced_rid := rid % range_size and domain_range_index := rid / range_size ( == the original multiplier) and the original formula is equivalent to: id = reduced_rid + low_id + range_number * range_size; and reads id = reduced_rid + range_minvalue if we set range_minvalue := low_id + range_number * range_size. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>