summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2009-12-04s3 aclocal.m4: Fix iconv checks, clean up m4 codeKai Blin1-27/+30
The check for iconv requiring giconv.h and libgiconv as well as the check for iconv requiring biconv.h and libbiconv were using the wrong variable to check for previous successful test results. This caused the checks to always fall back to libbiconv on systems where that library was available. In the course of fixing this, I had to clean up the indentation in that piece of code, and I also rewrote/added some comments. Many thanks to Tsurutani Naoki <turutani@scphys.kyoto-u.ac.jp> for the initial patch and diagnosis.
2009-12-03Make sure we're not using the old smb_fname data.Jeremy Allison1-1/+1
Jeremy.
2009-12-03Remove smb_fname duplicates that just keep the same information as in ↵Jeremy Allison3-24/+11
fsp->fsp_name. Moving towards making VFS_OPEN/VFS_MKDIR/VFS_RMDIR handle based... Jeremy.
2009-12-03s3-spoolss: handle SEC_FLAG_MAXIMUM_ALLOWED in spoolss_OpenPrinterEx.Günther Deschner1-0/+4
In case someone (smbtorture4) requests SEC_FLAG_MAXIMUM_ALLOWED, translate it to a request of PRINTER_ACCESS_ADMINISTER. Guenther
2009-12-03Refactor reply_rmdir to use handle based code. AllJeremy Allison3-265/+298
calls are now handle based. Put rmdir into close.c and make it private. Jeremy.
2009-12-03s3: Fix crash in winbindd;(bug#6879).Bo Yang1-2/+8
Signed-off-by: Bo Yang <boyang@samba.org>
2009-12-02Remove unneeded argument from can_set_delete_on_close(). EnsureJeremy Allison6-38/+23
can_set_delete_on_close() is correctly called before any setting of the disposition bit (clean up the do_unlink() call). Jeremy.
2009-12-03ѕ3: remove superfluous option checkBjörn Jacke1-13/+10
this function is only called when strict alloc is set, no reason to check that twice.
2009-12-03s3-selftest: run LOCAL-NDR when running make selftest.Günther Deschner1-1/+1
Guenther
2009-12-03s3:build: remove redundant qnx block size definitionBjörn Jacke1-3/+0
2009-12-02Restructure the ACL code some more, get the internal semanticsJeremy Allison3-169/+151
right. The previous bugs were due to the fact that get_nt_acl_internal() could return an NTSTATUS error if there was no stored ACL blob, but otherwise would return the underlying ACL from the filysystem. Fix this so it always returns a valid acl if it can, and if it does not its an error to be reported back to the client. This then changes the inherit acl code. Previously we were trying to match Windows by setting a minimal ACL on a new file that didn't inherit anything from a parent directory. This is silly - the returned ACL wouldn't match the underlying UNIX permissions. The current code will correctly inherit from a parent if a parent has any inheritable ACE entries that apply to the new object, but will return a mapping from the underlying UNIX permissions if the parent has no inheritable entries. This makes much more sense for new files/directories. Jeremy.
2009-12-03s3:build: fix shared library build on QNXBjörn Jacke1-3/+4
Fixes #6860. Thanks to Matt Kraai!
2009-12-02Ensure check_parent_acl_common() only looks at storedJeremy Allison1-2/+16
blobs - returns NT_STATUS_OK if there aren't any. Jeremy.
2009-12-02s3: prefer posix_fallocate for doing "strict allocate"Björn Jacke4-5/+37
posix_fallocate is more efficient than manual zero'ing the file. When preallocation in kernel space is supported it's extremely fast. Support for preallocation at fs layer via posix_fallocate and fallocate at kernel site can be found in Linux kernel 2.6.23/glibc 2.10 with ext4, XFS and OCFS2. Other systems that I know of which support fast preallocation in kernel space are AIX 6.1 with JFS2 and recent Solaris versions with ZFS maybe UFS2, too. People who have a system with preallocation in kernel space might want to set "strict allocate = yes". This reduces file fragentation and it's also safer for setups with quota being turned on. As of today most systems still don't have preallocation in kernel space, and that's why "strict allocate = no" will stay the default for now.
2009-12-02Ensure get_nt_acl_internal() only looks at the ACL blobs, notJeremy Allison2-19/+23
reads off the underlying filesystem. Ensure that vfs_acl_tdb.c returns NT_STATUS_NOT_FOUND, not NT_STATUS_OBJECT_NAME_NOT_FOUND when it can't find a blob matching the file. Jeremy.
2009-12-02Fix bug #6837 - "Too many open files" when trying to access large number of ↵Jeremy Allison3-3/+35
files from Windows 7. Original patch by me fixed up with the correct open files number by jmaggard10@hotmail.com. Jeremy.
2009-12-02samba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey.Günther Deschner2-21/+5
This should finally resolve the endian issues we were seeing on sparc and is much cleaner for spoolss clients and servers. Guenther
2009-12-02s3-spoolss: move MAXDEVICENAME to spoolss idl.Günther Deschner1-2/+0
Guenther
2009-12-02s3: Cope with older external libtdbVolker Lendecke2-0/+12
2009-12-02Revert "s3-build: taise tdb version when building against system libtdb ↵Günther Deschner1-1/+1
library." This reverts commit ea20678c55fee9f4586630cdb5fe7f35457d309a. Just one new error code does probably not justify raising the required tdb version. Guenther
2009-12-01Ensure we don't see the xattr used to store NT security (visible when xattr_tdbJeremy Allison2-3/+1
is used). Allows make test to pass with acl_xattr.so prepended to the vfs modules. Jeremy.
2009-12-01s3: Fix smbd to correctly return INVALID_LEVEL on set_file_end_of_file_info ↵Tim Prouty1-5/+26
for paths This allows smbd to pass the freshly updated RAW-SFILEINFO-END-OF-FILE torture test.
2009-12-01s3:build: fix detection of CTDB headers on systems without system-libtallocMichael Adam1-1/+1
Michael
2009-12-01s3:build: fix the build when no external talloc and tdb are installed.Michael Adam1-167/+178
The check for the external libs and the addition of the include paths to the CPPFLAGS was too late in configure. This patch moves the whole subsystem/library section up right below the detection of "BLDSHARED". And it updates not only SAMBA_CPPFLAGS but also SAMBA_CONFIGURE_CPPFLAGS so that many tests that use these flags can now succeed. Michael
2009-11-30Fix DEBUG 0 -> DEBUG 10 (left over code).Jeremy Allison1-2/+4
Fix opendir status return if access denied. Jeremy.
2009-11-30Fix bug 6938 : No hook exists to check creation rights when using acl_xattr ↵Jeremy Allison3-7/+104
module Fix ACL modules to test for permissions on open/mkdir/opendir. Ensure that underlying ACLs are returned for directories/files with no Windows xattr or tdb acls stored. Jeremy.
2009-12-01s3-build: taise tdb version when building against system libtdb library.Günther Deschner1-1/+1
Try to fix the build on "buildsamba02". At least fixes the build on fedora12 with libtdb-devel-1.1.5-2.fc12.x86_64 installed. Volker, please check. Guenther
2009-12-01s3:add split_tokens, a cmdline tool to test next_token_talloc()Michael Adam2-0/+92
Michael
2009-12-01s3:fix linking of the t_str* test programsMichael Adam1-4/+4
Michael
2009-12-01s3:fix linking of libbigballofmud (on my box at least)Michael Adam1-3/+3
Michael
2009-12-01s3:torture: make t_stringoverflow.c compile at least (pstring is long gone)Michael Adam1-2/+2
I don't know whether these t_* programs are used at all any more, but this one was using pstrcpy... Michael
2009-11-30Restructure the connect function code to always callJeremy Allison16-37/+117
down to NEXT-> before initializing. This allows us to do cleanup (by calling DISCONNECT) if initialization fails. Also fix vfs_acl_xattr which was failing to call the NEXT connect function. Jeremy.
2009-11-30s3-spoolss: fix fstrings in convert_devicemode() function.Günther Deschner1-2/+5
Guenther
2009-11-30Fix bug 6546: Avoid accessing buf[-1] if NUL byte comes from fgetsVolker Lendecke3-3/+9
2009-11-30s3: Fix crash in free_file_list().Bo Yang1-3/+4
Signed-off-by: Bo Yang <boyang@samba.org>
2009-11-30s3: Fix bug 6288Volker Lendecke1-8/+8
2009-11-29s3: Fix a "not handled in switch" warningVolker Lendecke1-0/+1
2009-11-29s3: Fix an uninitialized variable referenceVolker Lendecke1-1/+2
2009-11-29s3: Fix some nonempty blank linesVolker Lendecke2-37/+36
2009-11-29s3: Add a regression test for bug 6898Volker Lendecke5-2/+107
2009-11-29s3: Factor out torture_setup_unix_extensionsVolker Lendecke2-19/+32
2009-11-29s3: Restore "fake directory create times" as a share parameterVolker Lendecke3-8/+9
2009-11-29s3: "copy_reg" only looks at mode, uid, gid, atime and mtime (no birthtime)Volker Lendecke1-2/+1
2009-11-29s3: Pass up fake_dir_create_times from atalk_build_pathsVolker Lendecke1-15/+24
The callers only look at the mode
2009-11-29s3: Move directory_exist_stat to testparm.c, it only looks at the modeVolker Lendecke3-22/+21
2009-11-29s3: Pass fake_dir_create_times down to file_exist_stat, none of the callers ↵Volker Lendecke4-6/+9
look at the mtime
2009-11-29s3: "startsmbfilepwent" only looks at the inode -- is that enough?Volker Lendecke1-4/+2
2009-11-29s3: "get_file_size" only looks at the sizeVolker Lendecke1-1/+1
2009-11-29s3: "socket_exist" only looks at the modeVolker Lendecke1-1/+1
2009-11-29s3: "sys_path_to_bdev" only looks at the devicenumberVolker Lendecke1-4/+3