Age | Commit message (Collapse) | Author | Files | Lines |
|
Jeremy.
(This used to be commit 09e11dcb2304eec9656e76c24921c82f4a870914)
|
|
being deleted when hide unreadable set to true.
Here's the scoop.
This one is really interesting. The pattern of deleting a directory is to do a
findfirst to get the first part of the list, then for each name returned it
does a open/set delete on close/close -> thus deleting the file. Then it does a
findnext with the last file name THAT IT JUST DELETED ! Now we can handle this
in the findnext in the case where hide unreadable is set to false as we look
back in our cache of names and just seek to the right point. The bug is
actually fixed in the first hunk of this patch - the one that removes the
is_visible_file() check after SearchDir returns false. We don't actually need
it and in this case it's causing the delete to be aborted because it can't find
the name (doh ! it was just deleted). We don't need it as SearchDir is only
ever called from findnext, and findnext should only ever be returning names we
gave it.
The rest of the patch are the debugs I used to find
the problem but they're generically useful.
Phew - that one took a while to track down.....
Jerry, please merge for 3.0.23 final.
Jeremy.
(This used to be commit cd048cb775f0a8525fc19aa463db07c477521f5b)
|
|
the same change 3 times......
Fix pam_winbind compilation again.
(This used to be commit f3d2bbf0d222794bbb39b51a0f19167c6e8add1a)
|
|
(This used to be commit 4490fbdfc27eab02bf0140d3ffb70402858423e1)
|
|
(This used to be commit 8cf364e602eea408fd9cd6acd12f2b72971361ae)
|
|
(This used to be commit 09fb20f4fe26a5ec82e2f296bf033ab0864af669)
|
|
(This used to be commit a22bf28bcab6ef3c4addaf57fdeb2020625ead0e)
|
|
(This used to be commit 2131ddd7a13f078be471d327c8d73300facf8def)
|
|
When trying to login using krb5 with a trusted domain account, we
need to make sure that our and the remote domain are AD.
Guenther
(This used to be commit 5853525f111c0ab6a97b081d5964f778e7c36565)
|
|
cannot put saf_name in the failed conn cache as it's uninitialized.
Store saf_servername (the ip) in that case.
Volker, please check.
Guenther
(This used to be commit 098a87f492f69caeb523478a7ebcd0e3f636497d)
|
|
include directory like other parts of the build files.
(This used to be commit 0fca41efde36d535a274b983e032c1def33f081e)
|
|
messages.
Guenther
(This used to be commit d6b52e818109e6eb5a3df1bbc127c333e819141d)
|
|
offline logons at all.
Guenther
(This used to be commit dfbe555c69b3272bcff1d76a699aae2bdb85bdaf)
|
|
pam_auth login (when using kerberos).
Guenther
(This used to be commit 520777f7946e55b1437df138e529fdc053362d16)
|
|
Add missing automatic add of the Administrators SID in the absence
of winbindd and precense of Domain Admins SID in the user's token.
(This used to be commit ce7846d6f19f63ca99179b75e6f2195cc593795f)
|
|
(This used to be commit 8421d1b080dd65d1459cc66f0bd4e20fed5d0385)
|
|
Guenther
(This used to be commit 840ac23ec007df445892d851144d6458c4e06a6b)
|
|
Guenther
(This used to be commit 49fb1a3ebc44602302c347195752891bf28c7037)
|
|
Guenther
(This used to be commit 479dec68459df606ff566ac86eb3b4bbbd2ca77a)
|
|
share_mode struct. Allows us to know the unix
uid of the opener of the file/directory. Needed
for info level queries on open files.
Jeremy.
(This used to be commit d929323d6f513902381369d77bcd7b714346d713)
|
|
I think). If a alloc fails just return NT_STATUS_NO_MEMORY,
don't go to "done" label and deref pointers.
Jeremy.
(This used to be commit 490c7c84674860ecd9daa24341edb427b9fe0aa5)
|
|
release - #785, #786, #787, #788.
Jeremy.
(This used to be commit 9017547cccadeecb80f3db58a43838dc656fce2f)
|
|
candidate!
Volker
(This used to be commit adf2dcce09ae29a8c1677b25e1cd5f022b804d01)
|
|
Jeremy.
(This used to be commit e71cc6647a2eaba0eac95b6abb40745e45db72a4)
|
|
examining Klockwork #1519. get_printer_subkeys()
could return zero without initializing it's return
pointer arg. Fixed this. Added free of subkey pointer
return in registry/reg_printing.c (interesting that
neithe Coverity or Klocwork found this one).
Jeremy.
(This used to be commit 4fbeae1a3ac3499e5d9f566655cbafccd9d691cb)
|
|
a Klocwork issue (#1844). Remove it
Jeremy.
(This used to be commit e83c3e0a65edeb423d964488e219e30d023b13e8)
|
|
Jeremy.
(This used to be commit f5dddf339ee3a867e21f34a81bd0b33195b7397d)
|
|
Guenther
(This used to be commit 4e1816855a8f86d1228c44b39126fbfb3cb893c0)
|
|
(This used to be commit 601643a4608cdccf33277cef8900c4da61712268)
|
|
1177
In reg_perfcount.c: 1200 1202 1203 1204
In regfio.c: 1243 1245 1246 1247 1251
Jerry, the reg_perfcount and regfio.c ones, can you take a look please? This
is really your code, and I'm not sure I did the right thing to return an
error.
smbcacls.c: 1377
srv_eventlog_nt.c: 1415 1416 1417
srv_lsa_nt.c: 1420 1421
srv_netlog_nt.c: 1429
srv_samr_nt: 1458 1459 1460
Volker
Volker
(This used to be commit d6547d12b1c9f9454876665a5bdb010f46b9f5ff)
|
|
logic in smbd/process.c. All interested (Volker,
Jerry, James etc). PLEASE REVIEW THIS CHANGE.
The logic should be identical but *much* easier
to follow and change (and shouldn't confuse Klockwork :-).
Jeremy.
(This used to be commit d357f8b33594472ffa78d0a112accccc2a8b1fe7)
|
|
Jeremy.
(This used to be commit 220627ab70977a9a26dc0e010f73195c2c87ec96)
|
|
Jeremy.
(This used to be commit c9a4ce51ed85686a35f350f4681b95d68adebbd6)
|
|
Jeremy.
(This used to be commit cab256d72a91f59432e28e9623c10384d9ca2b5e)
|
|
if len != 0.
Jeremy.
(This used to be commit e99cedfb0cabe3863797c8bd4594ee0826022d2e)
|
|
Jeremy.
(This used to be commit ceea8e21006bd6bae9e203a672f82e4d066bba28)
|
|
if handed a NULL pointer, not returns NULL.
Jeremy.
(This used to be commit d47ec4dc25bffa6f605c0f6fa1d9c046dbc520a7)
|
|
Jeremy.
(This used to be commit 7b68a2acfc583d1559c02461cab13419185bcd74)
|
|
related fix.
Jeremy.
(This used to be commit 2e5a88147826113f78ee0d8845c704692942cebf)
|
|
dependentfiles pointer.
Jeremy.
(This used to be commit 05c50d99a4b1d2bc11a83e07902082227d7c074a)
|
|
Jeremy.
(This used to be commit 72709a8465caf5b7d95911250234f203b0ff4675)
|
|
Jeremy.
(This used to be commit 99605ce296663b7697d737fd521f0e4d8436d1f2)
|
|
Jeremy
(This used to be commit 080464b93d965a583b2b5f248a2bb8a7fb516e6f)
|
|
Jeremy.
(This used to be commit 5057e90db32adf4395fc2a3fce26a7f64c780828)
|
|
Jeremy.
(This used to be commit 6924d1cd443e4f7eb7b634c97c92effd6373ff12)
|
|
Jeremy.
(This used to be commit b581fee9824712b9385e9975739a8ddbb297bca8)
|
|
few other problems Klocwork missed.
Jeremy.
(This used to be commit fe05769a1a85f924c67be7e5dcee4871a86948d7)
|
|
Volker
(This used to be commit ce1d8423ef7cd86fc64200002fde707bca621d44)
|
|
altogether. This was essentially a second implementation if string_to_sid.
Klocwork ID 1038
Volker
(This used to be commit e35f901067b702f5e61733a6edabc610a7dd5aab)
|
|
Volker
(This used to be commit 8a5cebc19e4709399976efe9e3ba3bf29249620a)
|