Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2010-02-22 | s3: Explicitly handle inbuf in cli_trans_done | Volker Lendecke | 1 | -2/+9 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_write_andx_done | Volker Lendecke | 1 | -2/+4 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_read_andx_done | Volker Lendecke | 1 | -2/+2 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_message_start_done | Volker Lendecke | 2 | -6/+7 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_dskattr_done | Volker Lendecke | 1 | -2/+4 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_getatr_done | Volker Lendecke | 1 | -2/+4 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_getattrE_done | Volker Lendecke | 1 | -2/+4 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_open_done | Volker Lendecke | 1 | -2/+4 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_ntcreate_done | Volker Lendecke | 1 | -2/+3 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_echo_done | Volker Lendecke | 1 | -1/+2 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_negprot_done | Volker Lendecke | 1 | -2/+3 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_tcon_andx_done | Volker Lendecke | 1 | -3/+6 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_sesssetup_blob_done | Volker Lendecke | 1 | -5/+4 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_session_setup_guest_done | Volker Lendecke | 1 | -5/+4 | |
2010-02-22 | s3: Explicitly handle inbuf in cli_smb_oplock_break_waiter_done | Volker Lendecke | 1 | -2/+3 | |
2010-02-22 | s3: Add a talloc_move for the inbuf to cli_smb_recv | Volker Lendecke | 9 | -38/+53 | |
2010-02-21 | s3: Avoid calling cli_alloc_mid twice in cli_smb_req_iov_send | Volker Lendecke | 1 | -1/+2 | |
I hate macros.... | |||||
2010-02-21 | s3: Use the status from cli_raw_ioctl in torture_ioctl_test | Volker Lendecke | 1 | -2/+2 | |
2010-02-20 | s3: Make string_to_sid survive the LOCAL-string_to_sid test | Volker Lendecke | 1 | -13/+40 | |
2010-02-20 | s3: Rename LOCAL-dom_sid_parse to LOCAL-string_to_sid, add some tests | Volker Lendecke | 2 | -7/+19 | |
2010-02-20 | s3: Add printf why LOCAL-dom_sid_parse failed | Volker Lendecke | 1 | -0/+3 | |
2010-02-20 | s3: Slightly simplify the logic of completion_remote_filter | Volker Lendecke | 1 | -39/+45 | |
2010-02-20 | s3: Fix some nonempty blank lines | Volker Lendecke | 1 | -59/+57 | |
2010-02-20 | s3: Remove a "typedef struct" | Volker Lendecke | 1 | -4/+4 | |
2010-02-20 | s3: Fix a typo | Volker Lendecke | 1 | -1/+1 | |
2010-02-20 | s3: Convert cli_qpathinfo_basic to use cli_trans() | Volker Lendecke | 4 | -44/+37 | |
2010-02-20 | s3: Convert cli_raw_ioctl to use cli_smb() | Volker Lendecke | 1 | -18/+10 | |
2010-02-20 | s3: Add cli_smb() | Volker Lendecke | 2 | -0/+43 | |
This is a sync wrapper around cli_smb_send/cli_smb_recv. This is a hack to speed up converting libsmb/ away from cli_send_smb/cli_receive_smb. Some routines in libsmb/ are only called in one place in smbtorture for example, where making it async right now is not worth it. With cli_smb_send/cli_smb_recv in place, pushing the asynchronosity out one level is "just" boilerplate code that is easy to do should it become necessary. | |||||
2010-02-19 | Second part of fix for bug #7159 - client rpc_transport doesn't cope with ↵ | Jeremy Allison | 1 | -0/+6 | |
bad server data returns. If server returns zero on a NP read. Report pipe broken. Prevents client from looping if it thinks there should be more data. Jeremy. | |||||
2010-02-19 | First part of fix for bug #7159 - client rpc_transport doesn't cope with bad ↵ | Jeremy Allison | 2 | -0/+16 | |
server data returns. Ensure that subreq is *always* talloc_free'd in the _done function, as it has an event timeout attached. If the read requests look longer than the cli->timeout, then the timeout fn is called with already freed data. Jeremy. | |||||
2010-02-18 | More fixes for bug #7146 - Samba miss-parses authenticated RPC packets. | Jeremy Allison | 1 | -16/+31 | |
Alignment space calculations are tricky :-). Jeremy. | |||||
2010-02-19 | s3-spoolss: add support for _spoolss_SetPrinter level 8. | Günther Deschner | 1 | -1/+65 | |
Guenther | |||||
2010-02-18 | More fixes for bug #7146 - Samba miss-parses authenticated RPC packets. | Jeremy Allison | 1 | -14/+16 | |
Ensure we calculate the space correctly (including the ss_padding_len) when constructing reply packets. Jeremy. | |||||
2010-02-18 | s3: optimize strict allocate for XFS on IRIX | Björn Jacke | 1 | -0/+25 | |
2010-02-18 | Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised ↵ | Jeremy Allison | 1 | -0/+1 | |
value(s) error when "mangling method = hash" The charset array allocated in init_chartest() is allocated by MALLOC, but only some elements of it being set after allocation. Fix is to memset to zero after allocation. Jeremy. | |||||
2010-02-18 | Fix bug #7154 - mangling method = hash can crash storing a name not ↵ | Jeremy Allison | 1 | -3/+5 | |
containing a '.' Fix use of uninitialized variable. This can lead to crashes if mangling = hash processes names with no '.'. Jeremy. | |||||
2010-02-18 | s3-spoolss: Fix _spoolss_EnumPrinters servername handling. | Günther Deschner | 1 | -1/+1 | |
Guenther | |||||
2010-02-18 | s3-selftest: fix return code for modprinter.pl -a. | Günther Deschner | 1 | -1/+2 | |
Background is: the SetPrinter level 2 calls "addprinter command" an fails if a share already existed (and the addprinter command returned a non-0 return code). Removing the non-0 return code is fine, as in AddPrinter{Ex}, we have checks to see if a share already exists before calling out the addprinter command. Maybe one day, we need to have a "changeprinter command"... Guenther | |||||
2010-02-18 | s3-selftest: finally enable RPC-SPOOLSS-PRINTER against Samba 3. | Günther Deschner | 1 | -1/+2 | |
Guenther | |||||
2010-02-18 | s3-selftest: include addprinter/deleteprinter command. | Günther Deschner | 2 | -0/+131 | |
Guenther | |||||
2010-02-18 | s3-spoolss: fix return code of spoolss_DeletePrinter. | Günther Deschner | 1 | -1/+1 | |
When the printer has been removed by the "deleteprinter command", we need to check if it is still there and then fail, not fail if we successfully removed it (found by RPC-SPOOLSS-PRINTER). Guenther | |||||
2010-02-18 | s3-spoolss: in spoolss_EnumPrinters r->in.server is a *unique* pointer! | Günther Deschner | 1 | -3/+5 | |
Guenther | |||||
2010-02-18 | s3-spoolss: more AddPrinter{Ex} checks. | Günther Deschner | 1 | -0/+18 | |
Windows will allow to add a non-shared printer that is returned by EnumPrinters. Samba has no notion of non-shared local printers yet, so just make sure to behave like we do elsewhere: a printer autoloaded by samba or added to samba is shared. Guenther | |||||
2010-02-18 | s3-spoolss: add some printer info validation for AddPrinter calls. | Günther Deschner | 1 | -0/+22 | |
Guenther | |||||
2010-02-18 | s3-modules: fix get_acl_blob in the acl_tdb VFS module. | Günther Deschner | 1 | -1/+1 | |
Shuttle-reviewed by jra :) Guenther | |||||
2010-02-18 | s3-rpcclient: fix uninitialized variable in wkssvc_enumerateusers. | Günther Deschner | 1 | -2/+2 | |
Guenther | |||||
2010-02-17 | Fix bug #7146 - Samba miss-parses authenticated RPC packets. | Jeremy Allison | 4 | -138/+363 | |
Parts of the Samba RPC client and server code misinterpret authenticated packets. DCE authenticated packets actually look like this : +--------------------------+ |header | | ... frag_len (packet len)| | ... auth_len | +--------------------------+ | | | Data payload | ... .... | | +--------------------------+ | | | auth_pad_len bytes | +--------------------------+ | | | Auth footer | | auth_pad_len value | +--------------------------+ | | | Auth payload | | (auth_len bytes long) | +--------------------------+ That's right. The pad bytes come *before* the footer specifying how many pad bytes there are. In order to read this you must seek to the end of the packet and subtract the auth_len (in the packet header) and the auth footer length (a known value). The client and server code gets this right (mostly) in 3.0.x -> 3.4.x so long as the pad alignment is on an 8 byte boundary (there are some special cases in the code for this). Tridge discovered there are some (DRS replication) cases where on 64-bit machines where the pad alignment is on a 16-byte boundary. This breaks the existing S3 hand-optimized rpc code. This patch removes all the special cases in client and server code, and allows the pad alignment for generated packets to be specified by changing a constant in include/local.h (this doesn't affect received packets, the new code always handles them correctly whatever pad alignment is used). This patch also works correctly with rpcclient using sign+seal from the 3.4.x and 3.3.x builds (testing with 3.0.x and 3.2.x to follow) so even as a server it should still work with older libsmbclient and winbindd code. Jeremy | |||||
2010-02-17 | Fix bug #6557 - Do not work VFS full_audit | Jeremy Allison | 1 | -51/+34 | |
Re-arrange the operations order so SMB_VFS_CONNECT is done first as root (to allow modules to correctly initialize themselves). Reviewed modules to check if they needed CONNECT invoked as a user (which we previously did) and it turns out any of them that cared needed root permissions anyway. Jeremy. | |||||
2010-02-17 | s3: go straight to winbindd_dual_pam_auth() in case of !NT_STATUS_OK | Lars Müller | 1 | -1/+1 | |
At the formerly used process_result statement we have alone one NT_STATUS_IS_OK() which never could be hit in our case as we only go here if NT_STATUS_EQUAL is not ok. | |||||
2010-02-17 | s3: let the pam_winbind po files reference the correct location | Lars Müller | 20 | -644/+644 | |