Age | Commit message (Collapse) | Author | Files | Lines |
|
(cherry picked from commit 1fd65359f6cd07539cfe43146ac367a48708a678)
(This used to be commit b7f10bd31dec8047ea996c4738a6db5535c9261a)
|
|
(cherry picked from commit dec70fa3c0424c148016cc667a3c159e16d8a944)
(This used to be commit eb4d6dda1091199af7e62fb584525deb382978e2)
|
|
(cherry picked from commit a8b4b773d4647f28e7b92c5968469721d34eb550)
(This used to be commit 7b05e264d58c65af37af457947548611fc77edce)
|
|
- Ensured that all public functions have documentation in libsmbclient.h
- Reformatted for "proper" indentation
- Re-added temporarily-disabled alternate authentication function capability
Derrell
(cherry picked from commit 64b7150d92849a1e1e2416b9dcc12fae8d6bea99)
(This used to be commit dca8a612e94095e38df50f0fe567c75ceb8124fe)
|
|
Given the tacit (if that) approval by some people, and clear disapproval by
others for my proposed clean-up and reorganization of libsmbclient, I've come
up with a slightly different approach. This commit changes back to the
original libsmbclient.h SMBCCTX structure which will maintain ABI
compatibility. I retain, here, the setter and getter functions which all new
code should use. Older programs already compiled should continue to work
fine. Older programs being recompiled will encounter compile-time errors
(intentionally!) so that the code can be corrected to use the setter/getter
interfaces.
Although this doesn't clean up the interface in the way I had wanted, the code
reorganization and requirement for new programs to use the setters and getters
allows future progress to be made on libsmbclient without further muddying up
the interface, while retaining the ABI compatibility that was the big issue
causing disapproval. I hope that this compromise is adequate.
Derrell
(cherry picked from commit 56429a3d60b2a48963342f6340b3c01469a892c6)
(This used to be commit 7bc53f57dcb1c3bb80cb20796ebfc743c22a76e3)
|
|
The libsmbclient interface has suffered from difficulty of improvement and
feature enrichment without causing ABI breakage. Although there were a number
of issues, the primary ones were:
(a) the user of the library would manually manipulate the context structure
members, meaning that nothing in the context structure could change other
than adding stuff at the end;
(b) there were three methods of setting options: setting bits in a flags field
within the context structure, setting explicit options variables within an
options structure in the context structure, and by calling the
smbc_option_set() function;
(c) the authentication callback did not traditionally provide enough
information to the callee which required adding an option for a callback
with a different signature, and now there are requests for even more
information at the callback, requiring yet a third signature and option to
set it (if we implement that feature).
This commit provides a reorganization of the code which fixes (a) and (b).
The context structure is now entirely opaque, and there are setter and getter
functions for manipulating it. This makes maintaining ABI consistency much,
much easier.
Additionally, the options setting/getting has been unified into a single
mechanism using smbc_option_set() and smbc_option_get().
Yet to be completed is a refactoring of the authentication callback (c).
The test programs in examples/libsmbclient have been modified (if necessary;
some applications require no changes at all) for the new API and a few have
been minimally tested.
Derrell
(cherry picked from commit d4b4bae8ded824d06ad5ab0e219f71187ee5c771)
(This used to be commit 59292c0da8880afd7bac82f6a5bba009f3827ea0)
|
|
... after a REALLY long session staring at sniffs we can now join XP to
v3-2-test again...
Apparently not doing this makes XP keep an internal handle to LSA open which
confuses the hell out of it.
Karolin, this needs to be in v3-2-stable :-)
Volker
(cherry picked from commit 2c42fc21d8bede226e411623aecd69038477373b)
(This used to be commit a94313e06a030e1a1afff18c797e700eb6b25248)
|
|
Jeremy, in 3.0 we allowed get_mydnsdomname and get_mydnsfullname to fail
without filling in anything useful. Worked fine. Without this patch and a empty
/etc/hosts and no DNS configured, session setup would return
NT_STATUS_BAD_NETWORK_NAME. This is confusing at best, BAD_NETWORK_NAME afaik
is only ever returned from tcon normally.
This restores the 3.0 behaviour.
Comments?
Volker
(This used to be commit 4170259e5f83c281966a80916e4ece6937e08988)
|
|
This reverts commit ae254cb61f4b9331755848c47ebc34e90dd80390.
(cherry picked from commit 030bef7f22f7a73466204b7860f397dbca9f2ab0)
(This used to be commit 575b829b390f7f07138305adc2988918eda95ce1)
|
|
This reverts commit f5356825698a02df2d400b51dd95d1f857c83e81.
(cherry picked from commit 5f53a62be8a21b8d92ac44b18d202882500356e8)
(This used to be commit 8beead9c936038365f28467e527b2c066e3a5440)
|
|
This reverts commit 844a163458c7585e4306a21ffdae5d08e03d6e4d.
(cherry picked from commit 5ab1cfda500de07ff3c712442ab2fc74eecc8886)
(This used to be commit 7821066d4ff4a8503a596ab342a2a84ed9a9f8b9)
|
|
This reverts commit 719527f55e88f0c5fdceda5c807475aba299c79f.
(cherry picked from commit ac301fada257e2d3b50148109a3d44fa1421b0b4)
(This used to be commit 1bfc4404e7f7314111f979bd09321e39be76bf15)
|
|
Guenther
(cherry picked from commit aa9c0f587718f4d647e87b9662acbedba042b9cb)
(This used to be commit 851b53895807835fc9e6a4a1b3a2b4739ca7c63f)
|
|
Karolin
(This used to be commit efdf6faba161cae9d4a0a2c693ea0b261dc73ce2)
|
|
Jeremy.
(cherry picked from commit fa12667ec284fdda45b79cbf6bf548ab0faae34f)
(This used to be commit 5f00c79ac22ecfa846eebd910e7c25d326595f8e)
|
|
(cherry picked from commit eff3d3bad5a8860b99375cc0be9dc24f3679e416)
(This used to be commit 39f712048d7408ba91301b59752f2e87e894a3f0)
|
|
smbget needs libwbclient.
Michael
(cherry picked from commit 78bc496ecf72b5c2474911302e81a90c488e3070)
(This used to be commit 901936edd33ae710c6f23bea528132ee5e10e097)
|
|
Conflicts:
WHATSNEW.txt
(This used to be commit a390bcf9403df4cf4d5eef42b35ebccbe253882e)
|
|
(This used to be commit 364d87a5e41045808ebd28f46c5c0c93bd13a7da)
|
|
This hopefully fixes the build on HP-UX.
metze
(This used to be commit 5fb7533e37b6c682e019b1c3515dc6befc8bda09)
|
|
It was only used in configure, but lib/replace already
has a much better version of it.
metze
(This used to be commit c9b60b75b4763c37cfa63741b4f055e4ea488e92)
|
|
This is used for two purposes:
First, I'm using it to test the async I/O code. In the forked process it is
pretty easy to delay a reply for a random amount of time. See the
BUILD_FARM_HACKS snippet.
Second, there are systems around that claim to have Posix AIO but which is
broken. This might be some help for those systems.
Also add tests how to pass file descriptors
(This used to be commit b0e52cecf2009d4c7f29412dadf17910e54e4327)
|
|
Forgot to git add Makefile.in before doing git commit --amend
in previous commit...
Michael
(This used to be commit 7cf645cdae8ce17705036951538991b0a9dbefaf)
|
|
Michael
(cherry picked from commit 0aff54a12e20d5e91fcdec7aaec103fb9a371a23)
(This used to be commit 77b7d7c0417e498340d1c9364fbbb8671c175477)
|
|
Michael
(cherry picked from commit 54cc0df4dbf6d63a9b94e1ac6af4ec7f7803bc30)
(This used to be commit 1ff0b616a9cb029040031f797b52112d4973e1eb)
|
|
Michael
(cherry picked from commit 0cbb87453beb52c6b0bc3a48791f49678f4030c5)
(This used to be commit 34d906ef44d1a5c3452097a9cac438d721fe35c1)
|
|
Michael
(cherry picked from commit 523626908d25f974fd1ae6d7306b1d4bc8414162)
(This used to be commit 0906120a6e4fe0eb66f3c3fd99c625b30672cb2b)
|
|
Michael
(cherry picked from commit f8243cfc47c7414bab7f249d0e5d1c85e8ca7d64)
(This used to be commit 3c1843f931b896dd3bb142346ecb44c0fb9202d6)
|
|
Michael
(cherry picked from commit 29818a07de826fd687003ff25865d77939ecaa9a)
(This used to be commit 1d906d346ed90b87895772a64c7613324ef8b682)
|
|
Don't fail when there is no address assigned to the interface.
Put NULL into the ifaddrs structure instead.
Michael
(cherry picked from commit ee170c85e0e76411bd752de5fe51db6940dab929)
(This used to be commit 650cc1da4b4404880389c583dbb07ce86df48576)
|
|
Michael
(cherry picked from commit a2a506ff0eae2a64ebe2ddbb81a6c2a5fa7fe3da)
(This used to be commit c5932414fdf0b568cbfe6cdefaec41c8afc8ca6b)
|
|
Michael
cherry-picked from libreplace-part of 9d2bab09aac22c00fe23f1e1265a2dbd0901e9ce
and adapted replacetort creation
(This used to be commit 52d79ad4872a20cf55f31aba97629c2561bfc16c)
|
|
Guenther
(This used to be commit 405ef74d7e9ef614ea39b7cfd1d57307d9490545)
|
|
Guenther
(This used to be commit bc2d3d51449831146a9faf6e809e7a91d174659c)
|
|
access_desired.
Guenther
(This used to be commit 63894e5c93ef0663fc58bcc191777cd1aca7e21c)
|
|
Thanks metze for the fix.
Guenther
(This used to be commit dcffb885bc5d16e795b71d95e0790d3d7d70cf3c)
|
|
Guenther
(This used to be commit 7d88cb2e8db8789b923d8f9979b5c9f65664d3eb)
|
|
Tested with nt4 and w2k3.
metze
(This used to be commit 490d0c52bb117561227cbc59a15b15b688814fe2)
|
|
We already did this before b994f899b42d294c0418bdc82660a2f7510667d6.
This is needed to handle NULL strings, where strlen() would crash...
Maybe we should add a strlen_a() and strlen_a_term() later...
metze
(This used to be commit c445a17a91827c6c95b3a1cda9b78f5cdd41aa55)
|
|
metze
(This used to be commit d98ac73122d44f3a92531b4ebbe09401652b89c7)
|
|
metze
(This used to be commit bf5da9ea08f28f37aecc0674bd9322f0f0cbd82e)
|
|
metze
(This used to be commit 1937d19623029cc4ac0f2c4b336b6460399fa509)
|
|
Guenther
(This used to be commit 0a012c12d643e627ea1bad2a2ad6214f78918fa7)
|
|
Guenther
(This used to be commit b736c77dc6c36dcdb601903fadf0ef7f163052a3)
|
|
To not conflict with WBFLAG_PAM_INFO3_TEXT.
This should fix pam_winbind.
metze
(This used to be commit 1b8ed6c0ffb2548442bb7e9d848117ce9b1c65c0)
|
|
This can be tested with e.g. "netdom remove SAMBAHOST" from windows.
Guenther
(This used to be commit 53121e62ea32ff3a984533dca044b67cf5b2c55b)
|
|
ready for it.
"netdom join SAMBAHOST" from a windows workstation nicely demonstrates it.
Guenther
(This used to be commit 3bcaa3582a101abc17f7c21128e01024af877577)
|
|
Jerry, I checked this very carefully that nothing got lost. The only thing I need to
re-add still is the normalized DN handling for account precreation in "net ads join".
Guenther
(This used to be commit a5c6347644f2aa138a8e67ffe6c167847df941d0)
|
|
Guenther
(This used to be commit 09e6010159cb9c2a5d86861889b8c2a07bd39a8d)
|
|
Interface detection on Solaris still failing due to items pointed out here:
http://lists.samba.org/archive/samba-technical/2007-November/056701.html
(This used to be commit 37c87acc9d48c1fb5d4806374ca8e992300db1ff)
|