Age | Commit message (Collapse) | Author | Files | Lines |
|
implicit function contract explicit.
Jeremy.
(This used to be commit 6de5e9ae4628d384631db9b66e22d439a303b75c)
|
|
Jeremy.
(This used to be commit 7fc61f5a63c982cfd0fbe1838979ba7be8f69fca)
|
|
marshall a buffer based on an unknown size. Zero out the sec_desc
buffer to prevent this. This is still not getting proper results for
a registry security descriptor (everything gets ACCESS DENIED), but
at least we aren't blowing out memory now...
(This used to be commit cb370cc28ce361628df137c9aef02739aca062db)
|
|
should be done correctly. Fix coverity #37.
Jeremy.
(This used to be commit d241f74e06eac7b61e5b7e09c2b9a955ec560fec)
|
|
(variable definition was missing).
Jeremy.
(This used to be commit 48594f0270502149069fc883096181a9730d76bf)
|
|
group IFF sid_to_gid(S-1-5-32-544) fails and 'winbind nested groups = yes'
* Add a SID domain to the group mapping enumeration passdb call
to fix the checks for local and builtin groups. The SID can be
NULL if you want the old semantics for internal maintenance.
I only updated the tdb group mapping code.
* remove any group mapping from the tdb that have a
gid of -1 for better consistency with pdb_ldap.c.
The fixes the problem with calling add_group_map() in
the tdb code for unmapped groups which might have had
a record present.
* Ensure that we distinguish between groups in the
BUILTIN and local machine domains via getgrnam()
Other wise BUILTIN\Administrators & SERVER\Administrators
would resolve to the same gid.
* Doesn't strip the global_sam_name() from groups in the
local machine's domain (this is required to work with
'winbind default domain' code)
Still todo.
* Fix fallback Administrators membership for root and domain Admins
if nested groups = no or winbindd is not running
* issues with "su - user -c 'groups'" command
* There are a few outstanding issues with BUILTIN\Users that
Windows apparently tends to assume. I worked around this
presently with a manual group mapping but I do not think
this is a good solution. So I'll probably add some similar
as I did for Administrators.
(This used to be commit 612979476aef62e8e8eef632fa6be7d30282bb83)
|
|
Jeremy.
(This used to be commit 3799f18b356934592206679310e6e409c0d1ca0f)
|
|
Jeremy.
(This used to be commit 4a4953c4d27cd1e925c9afe24fa49b015ce033ec)
|
|
Jeremy.
(This used to be commit cd3ad3f1a6f622b4bad5cb21b132de4cc476e03f)
|
|
Jeremy.
(This used to be commit 8444c997bd3e18b1d04ebe85f06c8c6e34d7373f)
|
|
Guenther
(This used to be commit 4cfd737cc1d8840888f80e360119eeb627acb381)
|
|
sink by ensuring all uses of rpcstr_push are consistent
with a size_t dest size arg.
Jeremy.
(This used to be commit f65d7afe1977d9d85046732842f9643716c15088)
|
|
(This used to be commit aa26642ee19dcf7cfa3cb36032eadc823b01966b)
|
|
Guenther
(This used to be commit 8d4290cb8ed75cf12fa45bcf3e93cfe1a5567919)
|
|
was here
was clearly buggy as Coverity showed with bug id #36.
According to samba4 idl the sec_desc_buf is [in,out,ref], so we _have_ to ship
it in the request.
Volker
(This used to be commit 075e784491e6f2b491bd063db08ff1267f9cabbb)
|
|
the correct malloc-macros.
Jeremy.
(This used to be commit 412dc6f5dbc796126b94f3809fe660afac5d3c2a)
|
|
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit a3b8bee3ff8211d78f793877c877ccd2e15825dd)
|
|
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
line, and those below, will be ignored--
M source/smbd/posix_acls.c
(This used to be commit b8397c9f33424e0d1ed3ff849e1c99812f978000)
|
|
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit 7ada96a1cfb1e928b7dfde101ca250b20024243f)
|
|
the size of the data table. Clean up the struct a little.
Jeremy.
(This used to be commit 338538410d484a9358b60b05a86180275344ffa4)
|
|
Fix Coverity #59.
Jeremy.
(This used to be commit d793e1550cc8c79a2764609cddec082470d226e4)
|
|
alloc error back up the stack from smbldap_set_mod()
so ensure we abort correctly.
Jeremy.
(This used to be commit 9a1e35079af9404e1775e2a098990277b3771086)
|
|
Jeremy.
(This used to be commit 7520a8d2a10c72d330099c6502848afca60f56ff)
|
|
Jeremy.
(This used to be commit 76c4f2c4dc6fcd91a350985b16f4a6a321ac4bf6)
|
|
Jeremy.
(This used to be commit 1fece52da4d667fa182aa9a87aaee3917860448b)
|
|
we're using -1 as a special size_t case by casting.
Jeremy.
(This used to be commit 415530bd082bf351f5e4c1fd32408f123ed77f85)
|
|
Jeremy.
(This used to be commit 15d78ab1fc83249552476d99144389cfe42a786f)
|
|
(This used to be commit 90eb092083383c2b606e21dc65fb036bb973b032)
|
|
Guenther
(This used to be commit 44fcd3113be970edd01f7f076c4b6cad2d03ebcd)
|
|
Testing pam_smbpass pam_winbind
dlopen() of "./bin/pam_smbpass.so" succeeded.
dlopen() of "./bin/pam_winbind.so" failed: ././bin/pam_winbind.so:
undefined symbol: secrets_fetch_domain_sid
make: *** [test_pam_modules] Error 1
(This used to be commit 4b545e0ce665fe772095c27fe11ce535477f84ce)
|
|
called as part of the all rule (again only if pam modules are requested
by configure).
Add pam_winbind rule.
Ensure proto_exists before we build the pam modules.
Add test_pam_modules rule to test if the built pam modules have any
unresolved symbols. For test_pam_modules we use script/tests/dlopen.sh
which was written by Nalin Dahyabhai <nalin@redhat.com>. Thanks Nalin!
RedHat and SuSE use this script to test nss and pam modules since
several years.
(This used to be commit 71b2eb55adcd28f3796254ea1ce0bcee6098e712)
|
|
nscd caches so that NSS-calls can deliver accurate information.
Guenther
(This used to be commit a32a423a0e9e0d4dd21282fd528bcd3247fddbd1)
|
|
The intention is to have the resulting binaries at one place. This is
also usefull for upcoming changes to provide a test_pammodules rule.
With these changes I even got aware of
testsuite/nsswitch/pam_winbind_syms.exp But this only covers
pam_winbind.
(This used to be commit 9883957b74ddefb5293e4aef0cc2f53ee4d417ac)
|
|
resources on error exit path.
Jeremy.
(This used to be commit f71aa3ab8fdfd08c1bec57b6506ead7c4af7299d)
|
|
resources on error exit path.
Jeremy.
(This used to be commit f1a5e5aefeeb78512c41cc8fc075b240696a3eb7)
|
|
resources on error exit path.
Jeremy.
(This used to be commit 1c0b4ed0acdb7fccb148d714796752fefc6dd78c)
|
|
(This used to be commit b9fb3fc0e3708b4721aaa1dcb7756d3774fb8db8)
|
|
to Samba4 talloc).
Jeremy
- make the snprintf call in talloc portable to older solaris boxes
- fixed an error found sing the beam analyser
(This used to be commit 1e1bae7afd9cd0051878ff1810c8ddfc28129233)
|
|
Jeremy.
(This used to be commit d9e1d6fed099e7651807aa839a743fc7756ee326)
|
|
Jeremy.
(This used to be commit f458596b0edd958321c5d4061f034846348a3fe6)
|
|
not a real issue but this code is easier to read.
Jeremy.
(This used to be commit 6621acc68f9a65540330d5c0d07db2488a3e8678)
|
|
quieten coverity bug #194 (which I think is a
false positive).
Jeremy.
(This used to be commit 07d8b02d3dddf7322e096f3f0a7cc1c8fa709fa3)
|
|
was especially silly as we checked immediately _after_ dereferencing it
:-/
(This used to be commit 7ebfe2cb26b72d7fac397cfe3ceb14f244388224)
|
|
Free grp_sid and owner_sid before returning. Also, only allow one group
or owner.
(This used to be commit 1043e0d90ccb3493417f7bf05b70bdf5513bb1a3)
|
|
specified once in an ACL, so it can be allocated a second time,
overwriting the first
(This used to be commit 1804a8a01ebf3353574a2c5b26a1746b34715737)
|
|
explicit.
Jeremy.
(This used to be commit aeae20a8d9f3658acb8edd373eb601bdf7eab98b)
|
|
Jeremy.
(This used to be commit d2be8163f2cf69681150ed7de720a37ffaa8e937)
|
|
(This used to be commit 1899d8ea283845141b24d91d230248009744fe1a)
|
|
Jeremy.
(This used to be commit 9fa2e1bdedb61557b43f86c2898b7bf8762bbb63)
|
|
Jeremy.
(This used to be commit 5f74e56b865e0bdde0e574cd5f97cf29b06ad155)
|