summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r20694: To get this right we need to do signed 64-bitJeremy Allison1-7/+7
comparisons here, not unsigned as we're eventually casting into what it normall a signed 32 bit value. Guenther please check (but I think I'm right here). Jeremy. (This used to be commit 31f8e0edc0c3e76654728b2c204faa70830e1f1b)
2007-10-10r20692: Fix bug found by Guenther -Jeremy Allison1-1/+1
Just try to log on in offline mode without the fix: all accounts are expired, although they are set to never expire in the PAC/info3. NTTIME "Never" needs to get (time_t) -1. We were casting a uint64 to time_t before comparing, and we should have been doing it the other way around. Guenther please check this fixes things. Jeremy. (This used to be commit f4e898b6224fd82d9805da771ef6040065de7b12)
2007-10-10r20690: fix a bug that causes smbd to 'hang' intermittently.Andrew Tridgell1-32/+13
The problem occurs like this: 1) running smbd as a domain member without winbindd 2) client1 connects, during auth smbd-1 calls update_trustdom_cache() 3) smbd-1 takes the trustdom cache timestamp lock, then starts enumerate_domain_trusts 4) enumerate_domain_trusts hangs for some unknown reason 5) other clients connect, all block waiting for read lock on trustdom cache 6) samba is now hung The problem is the lock, and really its just trying to avoid a race where the cure is worse than the problem. A race in updating the trutdom cache is not a big issue. So I've just removed the lock. It is still an open question why enumerate_domain_trusts() can hang. Unfortunately I've not in a position to get a sniff at the site that is affected. I suspect a full fix will involve ensuring that all the rpc code paths have appropriate timeouts. (This used to be commit ab8d41053347a5b342ed5b59a0b0dd4983ca91e6)
2007-10-10r20687: Implement grace logons for offline authentications in pam_winbind.Günther Deschner3-21/+45
In case a user authenticated sucessfully and his password just expired while beeing disconnected, we should allow a user to logon (given a clear warning). We currently forced the user into a password change dialogue in that scenario; this did not make much sense while offline. Guenther (This used to be commit 668b278653acfc4de7807834988f7af557e608a5)
2007-10-10r20674: Regenerate NDR parsers after pidl changes. This should fix a couple ofJelmer Vernooij8-108/+66
coverity warnings. (This used to be commit 5f86d006debd880ec35db4ebe7db0663c5cb220f)
2007-10-10r20668: Also do not install the smbumount man page if we don't build smbumount.Lars Müller1-1/+1
(This used to be commit 82ce272b2464f06e8bcbed6452621daa05e12b5d)
2007-10-10r20666: Also do not install the smbmnt man page if SMBMOUNT_PROGS is not set.Lars Müller1-1/+1
(This used to be commit aa122be8f7a33ebceeb43e4f0c5362047560b199)
2007-10-10r20664: Set the environment variable _before_ calling the shell.Lars Müller1-1/+1
(This used to be commit 9cecd62654d22b47d938a44a8aed63c558d511ad)
2007-10-10r20663: Do not install smbmount man page if we didn't called configureLars Müller3-3/+6
--with-smbmount. (This used to be commit ee12348cf1e93d0e75714f3883bfea6525797dc1)
2007-10-10r20654: Fix from Karolin Seeger <ks@sernet.de>: Accept "forever", "off" and ↵Volker Lendecke1-7/+15
"never" as key words for -1 as policy values for net sam policy. Volker (This used to be commit b6347751d8f67dcaac5c1bcbc07f03073278f6fb)
2007-10-10r20651: Fix "password expires soon" warning message for pam_winbind.Günther Deschner1-12/+67
We were incorrectly calculating the days until the password expires and we also need to look at the info3 pass_must_change_time for expiry calculation. Guenther (This used to be commit 22d79237127a064a934928d175182adecc6300de)
2007-10-10r20644: Make some functions static, thanks to Michael Adam <ma@sernet.de> ↵Volker Lendecke1-3/+3
for the hint. (This used to be commit f1f5d035db067b85e55b1c4009407b47dedcf975)
2007-10-10r20636: Remove notify leftoverVolker Lendecke1-1/+0
(This used to be commit a174b49173e7185abb89e605e667e64e8dd87454)
2007-10-10r20635: Add placeholder to ensure we don't go into theJeremy Allison1-0/+11
wcard unlink if bad_path was set. The error returned here is almost certainly incorrect and will need testing properly with smbtorture, but I don't want to forget about this path (yes Volker I know this is currently incorrect :-). Jeremy. (This used to be commit 06e20c287898d21e437ab117eb5eeeaf2420ba78)
2007-10-10r20634: A *LOT* more work is necessary before touching notify remotely ↵Volker Lendecke7-621/+38
starts to make sense. Until then, remove it from the tree to keep the diff between 3_0_24 and 3_0 small. Volker (This used to be commit f146a85e74c84e78a11e616a1cbeaeef4693a0e0)
2007-10-10r20632: The extended RAW-SAMBA3BADPATH test led me to some wrong assumptions, inVolker Lendecke1-53/+59
particular the NT_STATUS_INVALID_PARAMETER thing was badly wrong. Remove the changes based on it. Using gentest is much more effective in this respect, but it will take a while to figure out the wildcard error handling of W2k3. Volker (This used to be commit 58b8a242a7f08c1292d24fc73df170dbcd68c10d)
2007-10-10r20630: Fix some trivial memleaks.Günther Deschner1-0/+3
Guenther (This used to be commit 3bb94a081888eca69796b14057b551b078ee9a77)
2007-10-10r20628: Looks bigger than it is. This is just re-indenting the if (dirname) ↵Volker Lendecke1-40/+38
that we've taken care of above. Volker (This used to be commit 5e1da363bb3f2675beb9fd9240301bb432e5239b)
2007-10-10r20627: orig_name is not needed anymore, and slightly simplify logic by ↵Volker Lendecke1-9/+8
doing early returns. Volker (This used to be commit 614651c6a72742173de5fa8723403880acc37c09)
2007-10-10r20626: Fix a memleak found by the IBM checker -- not on 3.0.24Volker Lendecke1-0/+1
(This used to be commit 9d0a789e32e6a6501421edb25bc8197c9e06846d)
2007-10-10r20619: bad_path is handled somewhere else, so can_delete does not need it ↵Volker Lendecke1-11/+3
anymore (This used to be commit 1798987128be579a1a4574294a7c3094040ebaf2)
2007-10-10r20618: Fix a bug in bad_path handling that also exists in 3.0.23: For ↵Volker Lendecke1-0/+5
reply_unlink under Linux we returned NT_STATUS_NOT_A_DIRECTORY. This is because in the bad_path==True condition lstat(2) returns ENOTDIR and not ENOENT. Not sure if we want to necessarily replicate the INVALID_PARAMETER here, but this is what W2k3 does. Jeremy, I tried to call you, but you were not around. So I'll leave it up to you to merge this. Volker (This used to be commit b1edc3d053104204b966eed67d070ad5da40f17b)
2007-10-10r20617: Do not notify if the delete failedVolker Lendecke1-5/+7
(This used to be commit c86fbdf8cc8f6f17b23e647bd1f4714c6095b860)
2007-10-10r20614: Dummy-checkin to trigger the buildVolker Lendecke1-4/+5
(This used to be commit 7e444e1612fa49f7db4de3256e6c67025db28806)
2007-10-10r20612: A checkin I've wanted to do for ages: For bad_path==False ↵Volker Lendecke3-50/+21
set_bad_path_error is equivalent to UNIX_ERROR. Expand the last reference. Lets see if I can kill that as well :-) Volker (This used to be commit 794d5d38f19601bb5b30b965b41b844aacf1caeb)
2007-10-10r20611: All but one callers to set_bad_path_error have had the ↵Volker Lendecke3-15/+29
bad_path==True argument being handled further up. Volker (This used to be commit 358673c36697a16aa87f9cebbace34abf16ed28e)
2007-10-10r20610: Fix a Solaris warningVolker Lendecke1-1/+1
(This used to be commit 60d7b349dbc12288a3da0486b571a1d83401d0b7)
2007-10-10r20608: ENOENT->NT_STATUS_OBJECT_NAME_NOT_FOUND is covered in the standard ↵Volker Lendecke1-6/+2
unix error mapping table (This used to be commit 816c19aaeb812a94fd5669174c9beec60ce1a73f)
2007-10-10r20607: Next micro-step for reply_setatrVolker Lendecke1-8/+6
(This used to be commit cea9a01434490fb8a17c3f12db7a092efda21186)
2007-10-10r20606: bad_path == True has been covered further up in reply_setatr.Volker Lendecke1-1/+2
I'm checking in micro-steps to make them independently checkable. This code just very severely needs cleanup, but I don't want to break anything. So, be patient with me, please :-) Volker (This used to be commit c16775486baa89901f0d5126cb926c9e5a807743)
2007-10-10r20605: Simplify logic in reply_setatr slightlyVolker Lendecke1-4/+2
(This used to be commit f19db8f33ed3749f6b72ae3a4cee83574c606e88)
2007-10-10r20604: Fix two memleaks, Coverity ID 337, merge to 3_0_24Volker Lendecke1-0/+2
(This used to be commit 44f9d25a9026df29fcaae8723ef52b1d3101628b)
2007-10-10r20603: Slightly simplify logicVolker Lendecke1-7/+7
(This used to be commit e4dea0e64747912da899e846b944c24804772259)
2007-10-10r20602: Fix coverity ID 339. SMB_ASSERT does not panic without -DDEVELOPER.Volker Lendecke1-1/+4
Volker (This used to be commit 33b5950bec407e295b2c6139e21d062e376df330)
2007-10-10r20597: Survive some of the notify mask tests.Volker Lendecke3-10/+24
(This used to be commit e4a2e63272dc5b20413597179d06b0185c4a6817)
2007-10-10r20589: Re-add lost bad_path handling, sorry.Volker Lendecke1-0/+4
(This used to be commit 244f96388c843fd629478d0069f68550a2006d06)
2007-10-10r20558: Refactor rmdir_internals to use early termination ratherJeremy Allison1-55/+56
than lots of indented code. Change recursive_rmdir() to return the smbd standards of True on success, False on fail (it was doing the reverse, which was very confusing). Jeremy. (This used to be commit 27dc5bebda7ffbdcb2371638f6132063a953fba2)
2007-10-10r20546: Fix some IBM checker errorsVolker Lendecke1-0/+4
(This used to be commit 8f67efd582655e03fea746eee499f3cab6cbdb4d)
2007-10-10r20544: Change copy_file() to return NTSTATUS. This is in preparation of turningVolker Lendecke2-29/+41
close_file() to NTSTATUS as well. I'm not sure I got all the error codes right, but as I've never come across a smb_copy() call in all my Samba work, I'm leaving it at that. If I'm absolutely bored, I will write a thorough torture test. As far as I can see, Samba4 even does not have a libcli implementation for it... :-) Volker (This used to be commit 5ebdf02ba166df69e210e6f70c01a44e6205ecc1)
2007-10-10r20542: Make close_remove_share_mode retun NTSTATUS. Not that anybody cares ↵Volker Lendecke1-4/+16
yet... (This used to be commit c8995771531caa4ec9bcaef2c29b11ee7d8e49e6)
2007-10-10r20541: Fix some obvious glitches in wait_for_aio_completion. Hmmm. It seemsVolker Lendecke1-6/+5
reply_close() at its heart is going to be an async call :-) Volker (This used to be commit 36f60407ae9b430dc5d7f67dd3e7ed8b1dbc93a8)
2007-10-10r20536: In the offline PAM session close case the attempt to delete aGünther Deschner2-1/+7
non-existing krb5 credential cache should not generate an error. Guenther (This used to be commit 11c6f573af5c1d3387e60f3fc44b00e28cd87813)
2007-10-10r20535: Fix make install to work when root doesn't haveJeremy Allison1-3/+7
write access into the source tree (like when your directory is nfs mounted for example....). Jeremy. (This used to be commit 7dcb61d1b2d08270a8c718328a26ef4866a1c500)
2007-10-10r20532: From Volker...Jeremy Allison1-1/+1
"smbcli_setattr("") always returns ACCESS_DENIED, test extension to follow. Merge to 3.0.24?" Yep (with slight optimization). Jeremy. (This used to be commit dcc7bca1adbc69f348d46291ec2cbfaf5d8486bc)
2007-10-10r20530: Don't want this call to get inadvertently re-added :-).Jeremy Allison1-3/+0
Jeremy. (This used to be commit 68c4fbcf3397d6c43a3e5809b20a23116b1f8a31)
2007-10-10r20525: Closing a dir with del-on-close set requires the same as files: ↵Volker Lendecke1-0/+12
Don't actually unlink/rmdir if another process still has it open. Jeremy, this is a potential merger to 3.0.24. Volker (This used to be commit 8e1e896b02da99b5a48883c5f37fe146ad0fb5ce)
2007-10-10r20524: Simplify logic of close_remove_share_mode().Volker Lendecke1-51/+67
Volker (This used to be commit ade90dbf0c2cbd2cc49a6357f3dd220ea82fd215)
2007-10-10r20512: Fix typo.Günther Deschner1-1/+1
Guenther (This used to be commit 36bd5cb21bdaf35c7dae47f8b8e93822b3f6188c)
2007-10-10r20507: smbcli_setattr("") always returns ACCESS_DENIED, test extension to ↵Volker Lendecke1-0/+9
follow. Merge to 3.0.24? Volker (This used to be commit f2563ac98f8ec7af8083d2b62186753acba7a9dd)
2007-10-10r20503: And one more 64-bit warningVolker Lendecke1-1/+1
(This used to be commit 7bcde1069e38d70808d78c408f16821a0bfadcdd)
generated by cgit (git 2.34.1) at 2024-11-03 15:51:13 +0000