summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2012-06-03s3:smbd/close: remove unused goto out from close_directory()Stefan Metzmacher1-3/+1
metze
2012-06-03s3:smbd/close: do an early return in close_directory()Stefan Metzmacher1-2/+1
metze
2012-06-03s3: Fix an assert to trigger in close_remove_share_modeStefan Metzmacher1-6/+17
In case we have a left-over entry in the share mode entry array, the SMB_ASSERT(got_tokens) is likely to kick in. It happens when we are about to delete a file with initial delete on close. We don't have a delete on close token set in the locking.tdb record. We see the fsp->initial_delete_on_close set, add the delete_on_close token to lck. Then "delete_file" is being set to true. Then later on we do the notify_deferred_opens. This walks the list, also checking for share_mode_stale_pid. We have already deleted our own share mode entry, share_mode_stale_pid() sees the left-over entry. It not also deletes that one but also the delete on close token. This leads to a different view of "delete_file" a.k.a. "got_tokens" further down in close_remove_share_mode, leading the SMB_ASSERT to fire. This patch attempts to fix the issue by keeping around our own share mode entry for almost the whole routine, preventing share_mode_stale_pid() from removing the delete tokens. Pair-Programmed-With: Volker Lendecke <vl@samba.org>
2012-06-03s3: Do an early return in close_remove_share_modeVolker Lendecke1-2/+1
Without "lck" we don't have much to clean up Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-03s3: Make close_remove_share_mode a bit more readableVolker Lendecke1-2/+4
by introducing a variable simplifying a boolean expression Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-03s3: Simplify get_delete_on_close_token moreVolker Lendecke1-6/+2
All remaining callers actually want the token Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-03s3: Simplify get_delete_on_close_token slightlyVolker Lendecke1-19/+32
Introduce find_delete_on_close_token. Thus is_delete_on_close_set does not have to call get_delete_on_close_token anymore. Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-03s3: Slightly simplify close_remove_share_modeVolker Lendecke1-10/+15
Remove a level of indentation by more use of "continue;" Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-03s3:smbd/close: avoid procid_is_me()Stefan Metzmacher1-1/+2
metze
2012-06-03s3:smbd/open: avoid procid_is_me()Stefan Metzmacher1-4/+5
metze
2012-06-03s3:smbd/oplock: avoid procid_is_me()Stefan Metzmacher1-2/+4
metze
2012-06-03build: Match autoconf build and disable ACLs on MacOS (darwin)Andrew Bartlett1-3/+7
Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Sun Jun 3 16:03:59 CEST 2012 on sn-devel-104
2012-06-03s3-libnetapi: Cope with popt versions without POPT_TABLEENDAndrew Bartlett2-0/+8
2012-06-03s3-build: Remove finddeadAndrew Bartlett1-9/+0
This won't work with the new tree structure, and we have the same output at https://build.samba.org/lcov/data/coverage/samba_4_0_test/unused-fns.txt Using the callcatcher framework. Andrew Bartlett
2012-06-03libreplace: Link libreplace against attr when requiredAndrew Bartlett1-1/+1
The autoconf Samba build will return to over-linking with -lattr on systems with both the XFS compat API and native xattrs. Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Sun Jun 3 03:56:05 CEST 2012 on sn-devel-104
2012-06-02build: Remove check for res_ninit (Revert "s3: Check for res_ninit")Andrew Bartlett1-8/+0
This reverts commit 4f6b1e8c81776cf1fa386574e60e54fe6b4fe82e because I cannot find any use of this configure check, and it is one of the differences between the WAF and autoconf builds. Andrew Bartlett
2012-06-02build: Show extra configure results found by WAF as wellAndrew Bartlett1-1/+3
This may assist in debugging a difference in a configure test on the build farm. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Sat Jun 2 09:46:09 CEST 2012 on sn-devel-104
2012-06-02build: Check correctly for sendfile (missing .h in header)Andrew Bartlett1-1/+1
This will hopefully fix the build on SLES8, which does not support 64-bit sendfile. Andrew Bartlett
2012-06-02build: Always attempt to build posix ACLsAndrew Bartlett1-8/+3
These are on more systems than just linux. If the configure test passes then assume it is available. Andrew Bartlett
2012-06-02lib/replace: xattr wrappers in lib/replace rather than source3/lib/system.cAndrew Bartlett5-790/+19
This also moves all the still-used configure tests etc. The unused OSF API is also removed at this time. Andrew Bartlett
2012-06-02s3: Same fix as 8576256, this time for fgetxattrVolker Lendecke1-1/+1
Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Jun 2 02:12:31 CEST 2012 on sn-devel-104
2012-06-01s3: Avoid a lot of calls to serverid_exists()Volker Lendecke1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Jun 1 18:58:30 CEST 2012 on sn-devel-104
2012-06-01waf: check for krb5_create_checksum and krb5_creds.flags for some Heimdal ↵Alexander Bokovoy1-0/+12
versions Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Fri Jun 1 11:23:21 CEST 2012 on sn-devel-104
2012-06-01build: Add automatic compare of config.h files to recursive waf buildAndrew Bartlett1-1/+6
This uses the fact that we have both build systems running at the same time. The krb5 checks are skipped because we typically are comparing internal Heimdal with the system krb5, so they do not make sense. The required checks for krb5 are pretty well understood in any case, as we have a limited set of supported libraries. Andrew Bartlett
2012-05-31Forward port of Richard Sharpe's <realrichardsharpe@gmail.com> fix for bug ↵Jeremy Allison5-4/+16
#8970 - Possible memory leaks in the samba master process.
2012-05-31We are triggering the cleanup_timeout_fn() too often, on exiting when an ↵Jeremy Allison1-11/+4
smbd is idle. Calls to exit_server_cleanly() should be treated as a "clean" shutdown, and not trigger the master smbd to call cleanup_timeout_fn.
2012-05-31s3:smbd: use server_messaging_context() instead of sconn->msg_ctx in ↵Stefan Metzmacher1-2/+3
exit_server_common() sconn is not available in the parent anymore. Thanks to Volker Lendecke <vl@samba.org> for finding this! metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu May 31 18:08:06 CEST 2012 on sn-devel-104
2012-05-31s3:vfs_hpuxacl: remove unused file_find_fd() callsStefan Metzmacher1-18/+2
metze
2012-05-31s3: Fix some 64-bit warningsVolker Lendecke2-4/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu May 31 10:06:56 CEST 2012 on sn-devel-104
2012-05-31build: rename build targets smbclient -> smbclient4 and smbclient3 -> smbclientMichael Adam1-1/+1
Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Thu May 31 06:36:55 CEST 2012 on sn-devel-104
2012-05-31s3:selftest: add a binary mapping for smbclient4Michael Adam1-2/+2
2012-05-31build: rename build targets nmblookup -> nmblookup4 and nmblookup3 -> nmblookupMichael Adam1-1/+1
2012-05-31s3:selftest: add a binary mapping for nmblookup4Michael Adam1-2/+2
2012-05-31s3:selftest: improve strange linebreaks for blackbox tests in tests.py for ↵Michael Adam1-22/+31
readability
2012-05-31s3:selftest: introduce a variable for binpath('dbwrap_tool') in tests.pyMichael Adam1-2/+3
2012-05-31s3:selftest: introduce a variable for binpath('ntlm_auth3') in tests.pyMichael Adam1-4/+5
2012-05-31s3:selftest: introduce a variable for binpath('smbtorture3') in tests.pyMichael Adam1-4/+5
2012-05-31s3:selftest: introduce a variable for binpath('net') in tests.pyMichael Adam1-9/+10
2012-05-31s3:selftest: introduce a variable for binpath('wbinfo') in tests.pyMichael Adam1-5/+6
to remove explicit calls to binpath('wbinfo')
2012-05-31s3:selftest: introduce a variable for binpath('smbclient3') to test.pyMichael Adam1-15/+17
to remove manual calls to binpath("smbclient3")
2012-05-31s3:build: fix some spacing in wscript_buildMichael Adam1-6/+6
2012-05-31Stop spamming the logs with "Could not remove pid XX from serverid.tdb" ↵Jeremy Allison1-15/+18
messages and initiating the cleanup function on every process death. We now have many sub-processes from smbd that don't serve SMB1/SMB2 requests and don't register themselves in the serverid.tdb. Only initiate the cleanup from processes that were explicitly in the child list. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu May 31 04:44:09 CEST 2012 on sn-devel-104
2012-05-30Fix bad bugfix for bug #8910 - resolve_ads() code can return zero addresses ↵Ira Cooper1-1/+1
and miss valid DC IP addresses Original code incorrectly used a while() instead of a for() loop. We need to iterate over the entire array here. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed May 30 23:29:03 CEST 2012 on sn-devel-104
2012-05-30Fix metze's complaint about the bugfix for bug #8953 - winbind can hang as ↵Jeremy Allison1-7/+0
nbt_getdc() has no timeout. This code explicitly isn't needed as the tevent code will take care of this.
2012-05-30s3:libsmb: use nb_connect_send() directly instead of doing a 0 timer for ↵Stefan Metzmacher1-4/+9
port 139 metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Wed May 30 20:51:51 CEST 2012 on sn-devel-104
2012-05-30s3-build: Fix configure checks for HeimdalAndrew Bartlett1-15/+15
A series of small errors meant that all Heimdal versions became unsupported, when for the autoconf build, some versions have what we need. Andrew Bartlett
2012-05-30build: Make gss_wrap_iov mandatory for krb5 buildAndrew Bartlett1-0/+5
This isn't in Heimdal 1.1, so we still fail on that version, but at least we fail for the right reasons. Andrew Bartlett
2012-05-30s3:utils: use cli_tree_connect() instead of cli_tcon_andx()Stefan Metzmacher1-1/+1
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Wed May 30 12:54:05 CEST 2012 on sn-devel-104
2012-05-30s3:libsmb: use cli_tree_connect() instead of cli_tcon_andx()Stefan Metzmacher1-2/+2
cli_tree_connect() is more generic and uses what the server supports metze
2012-05-30s3:libsmb: fallback to SMBtcon for old serversStefan Metzmacher1-1/+15
metze
generated by cgit (git 2.34.1) at 2024-12-22 13:39:40 +0000