Age | Commit message (Collapse) | Author | Files | Lines |
|
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Aug 28 20:29:01 CEST 2011 on sn-devel-104
|
|
metze
|
|
metze
|
|
metze
|
|
metze
|
|
This fixes a race condition that leads to the winbindd_children list becoming
corrupted. It happens when on a busy winbind SIGCHLD is a bit late.
Imagine a winbind with multiple requests in the queue for a single child. Child
dies, and before the SIGCHLD handler is called we find the socket to be dead.
wb_child_request_done is called, receiving an error from wb_simple_trans_recv.
It closes the socket. Then immediately the wb_child_request_trigger will do
another fork_domain_child before the signal handler is called. This means that
we do another fork_domain_child, we have child->sock==-1 at this point.
fork_domain_child will do a DLIST_ADD(winbindd_children, child) a second time
where the child is already part of that list. This corrupts the list. Then the
signal handler kicks in, spinning in
for (child = winbindd_children; child != NULL; child = child->next) {
forever. Not good. This patch makes sure that both conditions (sock==-1 and not
part of the list) for a winbindd_child struct match up.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Aug 26 18:51:24 CEST 2011 on sn-devel-104
|
|
|
|
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
|
|
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
|
|
Counterpart for last checkin. A lot less likely, but not impossible in a child.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Aug 26 13:14:27 CEST 2011 on sn-devel-104
|
|
I've seen
[2011/08/26 01:44:10.872057, 1] winbindd/winbindd_dual.c:1336(fork_domain_child)
fork_domain_child: Could not read child status: nread=-1, error=Interrupted system call
on a customer box. Not good.
|
|
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
|
|
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
|
|
lm_pw and nt_pw are fixed length strings and convert them to python
strings as fixed length strings.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
|
|
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
|
|
in db_tdb_fetch()
|
|
|
|
list security records for the INFO/version key ...
|
|
INFO/version key ...
|
|
INFO/version (and use it)
|
|
This also fixes the earlier faulty handing in of a useless stackframe
memory context via private_data.
|
|
This also fixes broken private_data parameter for the traverse function
(making use of it): Originally a memory context was handed in but was not used.
|
|
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Aug 25 23:06:12 CEST 2011 on sn-devel-104
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Aug 25 15:15:57 CEST 2011 on sn-devel-104
|
|
Guenther
|
|
this makes pdb-samba4 safe for multi-domain setups
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
|
|
talloc_traverse_dict will return with -1 in case of an error and
might return positive values that indicate the count of found
entries
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Wed Aug 24 18:09:11 CEST 2011 on sn-devel-104
|
|
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Aug 24 00:34:04 CEST 2011 on sn-devel-104
|
|
lsasd.c uses basename(3), which according to susv3
requires libgen.h and without which the FreeBSD build breaks.
|
|
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Aug 23 18:21:58 CEST 2011 on sn-devel-104
|
|
|
|
multiple non-scanned files
|
|
procid_is_me() works fine in the clustering case as well
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Aug 22 21:28:13 CEST 2011 on sn-devel-104
|
|
Added comments to most functions of net rpc conf for easier
understanding of the code.
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Aug 22 17:08:15 CEST 2011 on sn-devel-104
|
|
The tests are added as blackbox tests and they can be called with
the wildcard source3.blackbox.net.*.conf with either 'local' or 'rpc'
instead of '*' .
Signed-off-by: Michael Adam <obnox@samba.org>
|
|
The script tests all commands present in the net conf tool.
It is also possible to provide a fourth command line parameter
'rpc' in order to run the tests with the use of rpc.
Signed-off-by: Michael Adam <obnox@samba.org>
|
|
The testsuite makes use of the rpc mode from the registry roundtrip
script to test net rpc conf / net rpc registry
Signed-off-by: Michael Adam <obnox@samba.org>
|
|
The script now supports an rpc mode, which is triggered by the
presence of a fourth command line parameter "rpc"
Signed-off-by: Michael Adam <obnox@samba.org>
|
|
The function takes a local file in smb.conf format,
uses calls to smbconf to create smbconf_service structs,
which are then placed in the remote registry.
The function also provides a test module to only print
the changes that it would make.
Signed-off-by: Michael Adam <obnox@samba.org>
|
|
The function only appears in the commands list usage of net rpc
conf.
Signed-off-by: Michael Adam <obnox@samba.org>
|
|
The function is mostly a wrapper around a series of setparm
commands. It can be used to quickly set up a share with simple
parameters.
Signed-off-by: Michael Adam <obnox@samba.org>
|