summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2013-09-24libsmbconf:registry: add "state directory" to the list of forbidden parametersMichael Adam1-0/+1
At the time when the registry configuration was introduced, the registry database file was placed in the "lock directory". So the "lock directory" was added to the list of parameters that may not be changed in the registry configuration (because the next config reload would then load a different registry and drop all the original seetings). Later, "state directory" and "cache directory" were introduced, both defaulting to "lock directory". And the registry's location was changed to "state directory". It slipped my attention that the forbidden parameters for the should have been adapted at the time. So this patch adds "state directory" to the list. It keeps the lock directory, to catch the case where the state directory is not explicitly set, hence defaulting to the "lock directory". Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24selftest: include "state directory" in invalid parameters in registry ↵Michael Adam1-0/+1
roundtrip test Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24selftest: add "state directory" to the forbidden parameters test in net confMichael Adam1-1/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24selftest: add regression test for setting invalid parameters in registry ↵Michael Adam1-0/+49
config via "net [rpc] conf" Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24selftest: update SED_INVALID_PARAMS in the registry.roundtrip testMichael Adam1-12/+6
and add an explaining comment. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24selftest: remove unused variables (copy'n'paste...) from test_net_conf.shMichael Adam1-19/+0
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24s3:net conf: add the same parameter checks to "setparm" as in "net rpc conf".Michael Adam1-0/+5
In "net rpc conf" these checks are necessary, since the that command uses the plain rpc-registry interface at this moment, and so unfortunately it has to duplicate the checks from the smbconf library. Since "net conf" uses the registry, these checks are not necessary in this command. I add them nonetheless to make the output more similar to "net rpc conf". It is also a little more user friendy than just printing "INVALID_PARAMETER" as handed back from libsmbconf. Implement these checks by calling the new net_conf_param_valid() function. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24s3:net: check for GLOBAL_NAME net_conf_param_valid()Michael Adam1-1/+1
instead of checking for literal "global" Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24s3:net rpc conf: factor validation of parameter out for re-use.Michael Adam4-36/+105
This goes into a new module net_conf_util to be shared between net conf and net rpc conf. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24s3:net rpc conf: rename canon_valname->canon_param_name for clarity in setparm.Michael Adam1-2/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24s3:net rpc conf: setparm: introduce variables service_name, param_name, ↵Michael Adam1-20/+29
valstr for clarity Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24s3:net rpc conf: reorganize the validity check and canonicalization of the ↵Michael Adam1-17/+23
input in "setparm" Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24libsmbconf:registry: clarify the appearance of "includes" in forbidden_namesMichael Adam1-1/+7
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24libsmbconf:registry: reorganize the validity check and canonicalization of ↵Michael Adam1-14/+19
the input in "setparm" - first check that the name is an smbconf parameter - then check that the parameter is allowed in the registry config - then check that a global parameter is not to be set in a service section - then canonicalize the parameter and value name, thereby checking that the value has valid format Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24s3:net rpc conf: print the provided parameter name on error, not the ↵Michael Adam1-1/+1
canonicalized one Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24s3:net rpc conf: remove the (now) unused rpc_conf_reg_valname_forbidden()Michael Adam1-21/+0
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24s3:net rpc conf: use the published smbconf_reg_parameter_is_valid()Michael Adam1-1/+1
Instead of the duplicated rpc_conf_reg_valname_forbidden() Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24libsmbconf:registry: publish smbconf_reg_parameter_is_valid()Michael Adam2-1/+6
So that this does not need to be duplicated.. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24libsmbconf:registry: rework smbconf_reg_parameter_forbidden(), renaming it.Michael Adam1-17/+17
The logic is inverted, the lp_parameter_is_invalid call of smbconf_reg_valname_valid() is included, and the function is renamed to smbconf_reg_parameter_is_valid(). Use the new function everywhere in smbconf registry backend. And remove corresponding reverse function smbconf_reg_valname_valid(). Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23s3:modules: vfs_afsacl has the afs_syscall prototype via proto.hMichael Adam1-2/+0
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2013-09-23s3:include: remove duplicate prototypes from afs functions from proto.hMichael Adam1-3/+0
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23afs: implement afs_syscall() always, returning -1 if FAKE_KASERVER is not ↵Michael Adam1-0/+6
defined. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2013-09-23afs: format afs_syscall() properlyMichael Adam2-10/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: remove remaining occurrences of vars=locals() of source3/wscript_buildMichael Adam1-17/+7
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary split_tokens directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of dbwrap_torture directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary dbwrap_tool directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary rpc_open_tcp directly in dev, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary vlp directly in dev, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list sources of binary ntlm_auth directly in dev, remove vars=locals()Michael Adam1-7/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list sources of library nss_wins directly in devMichael Adam1-3/+1
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary smbfilter directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list sources of binary debug2html directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary sharesec() directly in def, remove vars=locals()Michael Adam1-6/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary eventlogadm directly in def, remove vars=locals()Michael Adam1-7/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary smbcquotas directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary smbcacls directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary locktest2 directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary log2pcap directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list sources of binary vfstest directly in def, remove vars=locals()Michael Adam1-6/+4
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary pdbtest directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary msgtest direcly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list sources of smbtorture(3) directly in dev, remove vars=locals()Michael Adam1-33/+32
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary nmblookup directly in source, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of binary smbspool directly in def, remove vars=locals()Michael Adam1-5/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list sources of binary net directly in def, remove vars=locals()Michael Adam1-33/+48
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list sources of subsys LIBNET_SAMSYNC directly in dev, remove ↵Michael Adam1-9/+6
vars=locals() Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of subsys LIBNET_DSSYNC directly in def, remove vars=locals()Michael Adam1-7/+4
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list source of subsys LIBNET directly in def, remove vars=locals()Michael Adam1-6/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-23build: list sources of binary smbconftort directly in def, remove vars=locals()Michael Adam1-7/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
generated by cgit (git 2.34.1) at 2024-11-19 18:12:17 +0000