Age | Commit message (Collapse) | Author | Files | Lines |
|
Guenther
|
|
No point in checking for !ctx after dereferencing it
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 22:51:52 CET 2011 on sn-devel-104
|
|
No point checking for !cli after dereferencing it
|
|
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425
|
|
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521
|
|
This routine was never executed after f0dcc90f because "netname" was always
NULL.
Jeremy, please check!
|
|
We could never have assigned the real value in line 481.
Andreas, please check!
|
|
How could this ever have worked???
|
|
There's no point in passing GROUP_MAP on the stack
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 21:58:08 CET 2011 on sn-devel-104
|
|
There's little point to pass a copy of this structure on the stack.
Günther, please check!
|
|
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
|
|
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
|
|
Günther, please check!
|
|
|
|
In all other places we check the result of secrets_init.
|
|
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 18:52:18 CET 2011 on sn-devel-104
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
|
|
Guenther
|
|
Guenther
|
|
Guenther
|
|
As found by valgrind, tmp_pcap_cache is not freed following printer list
tdb update.
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Mar 16 16:37:58 CET 2011 on sn-devel-104
|
|
There is currently a lot of duplicate code included for processing
responses to CUPS_GET_PRINTERS and CUPS_GET_CLASSES requests. This
change splits this code into a separate function.
Signed-off-by: Andreas Schneider <asn@samba.org>
|
|
Use printcap IDL for marshalling and unmarshalling messages between cups
child and parent smbd processes. This simplifies the IPC and ensures
the parent is notified of cups errors encountered by the child.
https://bugzilla.samba.org/show_bug.cgi?id=7994
Signed-off-by: Andreas Schneider <asn@samba.org>
|
|
Instead use new header smb_ldap.h where all LDAP API related things are handled,
while smbldap.h only deals with our smbldap_X() API.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 16 10:54:51 CET 2011 on sn-devel-104
|
|
Guenther
|
|
Guenther
|
|
security.h grouping header.
Guenther
|
|
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 08:22:28 CET 2011 on sn-devel-104
|
|
From the bugreport:
I have a folder with ~90 photos: IMG_XXXX.JPG where XXXX is a four digit
number, almost consecutive (photos from camera for one day).
Current implementation gives about 30 different checksums for this set of
files.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 16 01:15:41 CET 2011 on sn-devel-104
|
|
parameter 'printing'"
warning on the buildfarm.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 23:38:43 CET 2011 on sn-devel-104
|
|
Guenther
|
|
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 16:10:17 CET 2011 on sn-devel-104
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_OpenKey.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_CreateKey.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_OpenKey.
|
|
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteKey.
|
|
Question: How shall we allocate those? Something like the rid allocator?
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 15 09:59:55 CET 2011 on sn-devel-104
|
|
|
|
|