Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2010-10-01 | s3:events: Call all ready fd event handlers on each iteration of the main loop | Steven Danneman | 5 | -33/+38 | |
Previously, only one fd handler was being called per main message loop in all smbd child processes. In the case where multiple fds are available for reading the fd corresponding to the event closest to the beginning of the event list would be run. Obviously this is arbitrary and could cause unfairness. Usually, the first event fd is the network socket, meaning heavy load of client requests can starve out other fd events such as oplock or notify upcalls from the kernel. In this patch, I have changed the behavior of run_events() to unset any fd that it has already called a handler function, as well as decrement the number of fds that were returned from select(). This allows the caller of run_events() to iterate it, until all available fds have been handled. I then changed the main loop in smbd child processes to iterate run_events(). This way, all available fds are handled on each wake of select, while still checking for timed or signalled events between each handler function call. I also added an explicit check for EINTR from select(), which previously was masked by the fact that run_events() would handle any signal event before the return code was checked. This required a signature change to run_events() but all other callers should have no change in their behavior. I also fixed a bug in run_events() where it could be called with a selrtn value of -1, doing unecessary looping through the fd_event list when no fds were available. Also, remove the temporary echo handler hack, as all fds should be treated fairly now. | |||||
2010-10-01 | s3-dcerpc: no point for printing NDR twice for internal pipes in log level 10. | Günther Deschner | 1 | -1/+1 | |
Guenther | |||||
2010-10-01 | samba: share readline wrappers among all buildsystems. | Günther Deschner | 9 | -193/+12 | |
Guenther | |||||
2010-10-01 | s3-readline: move cmd_history to smbclient, the only user. | Günther Deschner | 3 | -22/+20 | |
Guenther | |||||
2010-10-01 | samba: share select wrappers. | Günther Deschner | 15 | -217/+17 | |
Guenther | |||||
2010-10-01 | s3-selftest: fix prefix in subunit output. | Jelmer Vernooij | 1 | -3/+3 | |
2010-10-01 | s3: Add subunit-test target. | Jelmer Vernooij | 2 | -1/+7 | |
2010-10-01 | s3-configure: Require at least version 1.2.6 of external TDB, which has | Jelmer Vernooij | 1 | -1/+1 | |
TDB_INCOMPATIBLE_HASH. | |||||
2010-10-01 | s3-spoolss: fix do_drv_upgrade_printer() which must have been broken since the | Günther Deschner | 1 | -3/+6 | |
days we moved away from fstrings. Guenther | |||||
2010-10-01 | s3-net: better handle obscure 0x80070002 error reply when trying to update an | Günther Deschner | 1 | -3/+7 | |
not yet published printer. Guenther | |||||
2010-10-01 | s3-net: make sure we dont crash when publishing a single printer. | Günther Deschner | 1 | -0/+5 | |
Guenther | |||||
2010-10-01 | s3-spoolss: make sure we dont crash on NULL setprinter level2 elements as ↵ | Günther Deschner | 1 | -7/+13 | |
seen from win7. Guenther | |||||
2010-10-01 | s3-spoolss: dont overwrite location change notify. | Günther Deschner | 3 | -3/+19 | |
Guenther | |||||
2010-10-01 | s3-selftest: added samba3.posix_s3.rpc.spoolss.printer to knownfail | Andrew Tridgell | 1 | -0/+1 | |
this fails intermittently on sn-devel. Guenther suggested adding it to knownfail Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Fri Oct 1 04:37:36 UTC 2010 on sn-devel-104 | |||||
2010-09-30 | s3: Add "smbcontrol winbindd ip-dropped <local-ip>" | Volker Lendecke | 6 | -0/+87 | |
This is supposed to improve the winbind reconnect time after an ip address has been moved away from a box. Any kind of HA scenario will benefit from this, because winbindd does not have to wait for the TCP timeout to kick in when a local IP address has been dropped and DC replies are not received anymore. | |||||
2010-09-30 | s3: Re-introduce a procid_self() | Volker Lendecke | 1 | -1/+1 | |
Giving the parent pid to reinit_after_fork is not a good idea.... None of the other callers do this, checked it. | |||||
2010-09-30 | s3: Fix a typo in dump-domain-list smbcontrol usage msg | Volker Lendecke | 1 | -1/+1 | |
2010-09-30 | s3-spoolss: make sure to exit early and with the appropriate error code in | Günther Deschner | 1 | -0/+4 | |
_spoolss_GetPrinterDriver2. Guenther | |||||
2010-09-30 | s3-spoolss: Fix servername/printername handling which turns out to be very ↵ | Günther Deschner | 6 | -141/+189 | |
important to get right. Guenther | |||||
2010-09-29 | s3-waf: add basic make test infrastructure, not able to test yet. | Günther Deschner | 3 | -0/+158 | |
Guenther | |||||
2010-09-29 | s3-waf: clean up socket-wrapper and nss-wrapper a little. | Günther Deschner | 1 | -15/+5 | |
Guenther | |||||
2010-09-29 | s3-waf: add vlp binary. | Günther Deschner | 1 | -0/+5 | |
Guenther | |||||
2010-09-29 | s3-printing: skip metadata entry when traversing printerlist. | Günther Deschner | 1 | -0/+5 | |
We were creating a new printer (with a very broken name) out of the lasttimestamp entry all the time. Simo, please check. Guenther | |||||
2010-09-28 | s3-waf: add in a little hack to deal with the ECHO rpc module for ↵ | Günther Deschner | 1 | -0/+4 | |
non-developer builds. This will be removed once we have the rpc modules subsystem in place. Guenther | |||||
2010-09-28 | waf: we don't need the preprocessor recursion limit any more | Andrew Tridgell | 1 | -3/+0 | |
thanks to ita for this | |||||
2010-09-28 | s3-waf: add AUTH_SCRIPT module to AUTH subsystem (which is build as shared | Günther Deschner | 1 | -0/+7 | |
module by default). Guenther | |||||
2010-09-28 | s3-waf: add vfs_linux_xfs_sgid to the list of default shared modules. | Günther Deschner | 1 | -1/+1 | |
Guenther | |||||
2010-09-28 | s3: Attempt to fix bug 7518 | Volker Lendecke | 1 | -6/+6 | |
If select returns -1, we can't rely on the fd sets. The current code might loop endlessly because when putting an invalid fd (the closed socket?) on the read set, a select implementation might choose not to touch it but directly return with EINVAL. Thus run_events will see the socket readable, which leads to a "return true", and thus a NT_STATUS_RETRY -> same game again. We should never get into this situation, but to me the logfiles given in bug 7518 do not reveal enough information to understand how this can happen. | |||||
2010-09-28 | s3: Increase the debuglevel for connection termination msgs | Volker Lendecke | 1 | -2/+2 | |
2010-09-28 | s3-waf: fix dependencies in most of our module subsystems. | Günther Deschner | 4 | -23/+3 | |
Guenther | |||||
2010-09-28 | s3-waf: add pam_smbpass. | Günther Deschner | 3 | -6/+18 | |
Guenther | |||||
2010-09-28 | s3-auth_util: make sure the system server info actually contains S-1-5-18. | Günther Deschner | 1 | -0/+9 | |
Without this, all security descriptor checks for the winreg spoolss backend fail and make our spoolss system in its current shape basically unusable. Andreas, please check. Guenther | |||||
2010-09-28 | s3-printing: remove unused old structs. | Günther Deschner | 1 | -60/+0 | |
Guenther | |||||
2010-09-28 | s3: Lift smbd_messaging_context() from open_sockets_smbd() | Volker Lendecke | 1 | -16/+14 | |
2010-09-28 | s3: Remove two calls to procid_self() | Volker Lendecke | 1 | -2/+4 | |
2010-09-28 | s3: Remove talloc_autofree_context() from myhostname() | Volker Lendecke | 1 | -3/+1 | |
No destructor needed, so we can as well use the NULL context | |||||
2010-09-28 | s3: Remove some remaining files.c globals to sconn | Volker Lendecke | 3 | -53/+49 | |
2010-09-28 | s3: Remove talloc_autofree_context() from files.c | Volker Lendecke | 3 | -7/+10 | |
2010-09-28 | s3: Lift smbd_server_conn from file_find_fd | Volker Lendecke | 4 | -7/+9 | |
2010-09-28 | s3: Remove smbd_server_conn from file_fsp | Volker Lendecke | 1 | -1/+1 | |
2010-09-28 | s3: Slightly simplify file_fnum | Volker Lendecke | 1 | -2/+15 | |
req==NULL should never happen, see the comment | |||||
2010-09-28 | s3: Remove smbd_server_conn from file_sync_all | Volker Lendecke | 1 | -1/+1 | |
2010-09-28 | s3: Remove smbd_server_conn from file_find_subpath | Volker Lendecke | 1 | -1/+1 | |
2010-09-28 | s3: Lift smbd_server_conn from file_find_di_first | Volker Lendecke | 6 | -10/+15 | |
2010-09-28 | s3: Lift smbd_server_conn from file_find_dif | Volker Lendecke | 5 | -7/+9 | |
2010-09-28 | s3: Remove smbd_server_conn from files_forall | Volker Lendecke | 4 | -9/+12 | |
2010-09-28 | s3: Remove smbd_server_conn from file_close_user | Volker Lendecke | 3 | -4/+4 | |
2010-09-28 | s3: Remove smbd_server_conn from file_close_pid | Volker Lendecke | 3 | -4/+6 | |
2010-09-28 | s3: Remove smbd_server_conn from file_close_conn | Volker Lendecke | 1 | -1/+1 | |
2010-09-28 | s3: Remove smbd_server_conn from file_new and file_free | Volker Lendecke | 1 | -2/+2 | |