Age | Commit message (Collapse) | Author | Files | Lines |
|
Found by Klocwork, ID 653.
Volker
(This used to be commit 4cb8cf221f986b15de3ac608b173310c14248533)
|
|
Jeremy.
(This used to be commit 319f80bbf0455cfaf80eab51313a56db4ed04ac5)
|
|
(This used to be commit b369d0891afe8b777b837eaac317131232568ca7)
|
|
strtok for NULL.
Jeremy.
(This used to be commit 98751e8190317416de56b4a19a489c5f4b7d6bc9)
|
|
(This used to be commit 3a7d01afbebe5c4c36935b6128998e1327c8f856)
|
|
(This used to be commit 963ae5bd144b90e71331a88029698a1a6dc52190)
|
|
Klocwork ID 1773 complained about oldest being dereferenced in line 2275 where
it could be NULL. I think you can construct extreme racy conditions where this
actually could happen.
Volker
(This used to be commit b5602cc4f1d77ed48ddca0f7f42b28706160c923)
|
|
(This used to be commit 1b64f9a48bbb5a88c2029585e208865b41f2f423)
|
|
(pam_winbind users were forced to change a password inappropriately)
Guenther
(This used to be commit 65643d31725a4e3fe157d66e9ecad03a65a484e2)
|
|
Guenther
(This used to be commit dfebcc8e19bee06b7c03f88845314e9cfd6f398a)
|
|
Guenther
(This used to be commit e7d2b84aba2f2f5d844ba6a5fdcce35c3750d0b2)
|
|
Volker
(This used to be commit 7674a4f8361d3f3b649245118b82d8a074a2760e)
|
|
Fix typo in DEBUG()
Jeremy.
(This used to be commit da768bf9c2761884cc97f690133d6897ed353e15)
|
|
Guenther
(This used to be commit aeff1f0c47992ce3941e27e63f9b1516c4918963)
|
|
(This used to be commit 128260527b90d77ca3dfc900e012018ef00ba9e0)
|
|
(This used to be commit 3159bd3a4e3ad70c60fea4cacc892be9f1d71ab9)
|
|
(This used to be commit a1fcacf75683e4c08236bb4cc4164678ea1a1ce4)
|
|
(This used to be commit a18af427d7ea7b5a04d7006d10299d9e43317ae4)
|
|
(This used to be commit 5ffb424641bfc71ce396800a6e426015b11fd6ba)
|
|
(This used to be commit 9be3e07884e7f8121bc64766e7d036495cd94a15)
|
|
Jeremy.
Fix a parsing error that became apparent in 'make test': If we have no
group
rids in the info3 we set the array buffer pointer to "1" but fail to
actually
ship the array.
Volker.
(This used to be commit ee1b9207d3119c2b3e7c1c4e59250dbd323eae6a)
|
|
eDir, we already add 'sn' as required attribute on LDAP add
operations.
When we modify an entry, we need to request 'sn' as well in our
attribute lists, so that we don't try to add it a second time.
Guenther
(This used to be commit e018ea3d1d70e68e6802843f88b3245dc09244c9)
|
|
Guenther
(This used to be commit 322f1664df553d95fcdfc24f19bd7f34ce9b834b)
|
|
We still used the old HOST/* UPN to get e.g. users, now we need
samaccountname$@REA.LM.
Guenther
(This used to be commit f6516a799aec2db819f79b9a1e641637422a9b4c)
|
|
confuse an uninitialised __profile_clock with CLOCK_REALTIME. Flip the
condition argument to SMB_WARN around so that it's correct (though
completely non-intuitive).
(This used to be commit 60b5f9618b77afb397f96c1ff406c8cd3a4648f3)
|
|
(adapt to the new UPN/SPN scheme).
Guenther
(This used to be commit 8fc70d0df0c93c29b49f924bac9ff5d9857cfd9d)
|
|
enabled).
Do not bail out when a group just has 0 members.
Jeremy, please check, this has been removed with r13915.
Guenther
(This used to be commit 3a738a855d335e44e167351e6396bf3fe81a03af)
|
|
of UNIX_BASIC infolevel. Checked client implementations
(cifsfs and libsmb) and they ignore it. Thanks Volker.
Jeremy.
(This used to be commit 6cd1cb5c9deba2aa0d7a3251c8142834cbaba6d1)
|
|
This fixes a problem where the clock definition for clock_gettime() is
present at compile time, but is not available on the running system. In
this case, we fall back to less-preferred clocks until we find one that
we can use.
(This used to be commit fc6ed6a1aa2225ccde04c4ecaf0777dc0de4f1cb)
|
|
Paul
(This used to be commit f5be3e12e2dc42a2092b71c9e4cab6f5d0ef8860)
|
|
Guenther
(This used to be commit 8759a00fedfe5d8d789c8b707c924d8116da1102)
|
|
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
(This used to be commit f3bd1c8c7de93917787e7341f759699c8399f006)
|
|
set the type of 'acl compatibility from string to integer
after the changes in r14207.
(This used to be commit b01f289f1a788fe8f62a213b67a73a9bfee01bb1)
|
|
<Shlomi@exanet.com>.
Jeremy.
(This used to be commit 5cd234a1fff1e9d025eea6600649e56c997eafc2)
|
|
reason but to increase fidelity with W2k3. Tom Bork has raised valid concerns
that Unix scripts might rely on the account names being lower-case, so keep
that. We might later decide to only lower-case the unix name passed to
'add [user|group] script' but keep the passdb entry upper-case. But there are
enough user-visible changes in 3_0 already so that we should push this off to
a later date.
Tom, waiting for more bug reports from you ;-))
Thanks for insisting!
Volker
(This used to be commit bc78cca290559c5ca7623b9f6d9933e32668b9c4)
|
|
'valid users = +unixgroup' failed with smbpasswd if 'unixgroup' has a
(non-algorithmic) group mapping.
Thanks a lot!
People out there listening, please test current code, this release is
**BIG**
:-)
Volker
(This used to be commit 8f9ba5f96c9b506623ef97b7ed3d84f39d914a3c)
|
|
enough of
SetUserInfo level 25 to survive the join method XP uses if the user did not
exist before. For good taste this contains way too much cut&paste, but for a
real fix there is just not enough time.
Up to 3.0.22 we completely ignored that a full level 21 is being sent together
with level 25, but we got away with that because on creation we did not set
the "disabled" flag on the workstation account. Now we correctly follow W2k3
in this regard, and we end up with a disabled workstation after join.
Man, I hate rpc_parse/. The correct fix would be to import PIDL generated samr
parsing, but this is would probably be a bit too much for .23...
Thanks to Tom Bork for finding this one.
Volker
(This used to be commit 5a37aba10551456042266443cc0a92f28f8c3d0d)
|
|
a more specific probe to try and eliminate old, incompatible
DMAPI implementations provided by IRIX 6.4 and AIX 4.3.
(This used to be commit aafd4db457ce8a60c628d54a3ace3b97c8885dca)
|
|
fix this in 3.0 ?
Jeremy.
We had no way to return NT_STATUS_OK from the netlogon serverpwset,
although
we successfully set the machine password...
One thing the samba3 join test found.
Volker
(This used to be commit e5b7acc9b5cb6e8cf3d03c9d392fad06e0d282d9)
|
|
'if' below. Spotted by Aleksey Fedoseev.
(This used to be commit 00eb42791abf3e34dc42a2067f07b8549ea31abb)
|
|
smbclient to
show a prompt again :-)
James, could you check that this is ok? I think this was part of your Revision
15848.
Thanks,
Volker
(This used to be commit 91534146b4718206f0e2a7f456154a0497277dfd)
|
|
metze
(This used to be commit bed220afb816138a3e806c5d20e812667f6994ae)
|
|
and can happen though misconfiguration.
Jeremy.
(This used to be commit 4b9cf399a691ba4a7392caca558d0e98b4d19104)
|
|
on Solaris.
Jeremy.
(This used to be commit b65c6468651282879a39fa8029c190f2d1a91a28)
|
|
cache.
Jeremy.
(This used to be commit da26565a2e85dc36b283f6b81378a706f3ae5f26)
|
|
BIG THANKS to Tom Bork for reporting that Bug!
Volker
(This used to be commit 40339fdcced67d62e449ba6f19329d89c808e139)
|
|
offset correctly when doing info level 1 directory
scans. Thanks to Guenter Kukkukk <Guenter.Kukkukk@kukkukk.com>
for reporting this problem and testing the fix.
Jeremy.
(This used to be commit 65d4dfbd6045a4e3f9eaf520c70ef29ff7ddee82)
|
|
<wb8tyw@qsl.net>.
Jeremy.
(This used to be commit 93dd476a9108adde42de422e1886bbaee75b952b)
|
|
Patch from Bjoern Jacke (Thanks!)
metze
(This used to be commit b9d1440f46f443851607300e31b123d6afa81c06)
|
|
Guenther
(This used to be commit 3c9416c2bedeec7f075e94d45d08f37ae6dd41d1)
|