Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2008-10-24 | Error return is False, not -1 | Derrell Lipman | 1 | -3/+3 | |
- There were a few places in SMBC_getatr() that returned -1 instead of a boolean. -1 was intended to mean error, but that's what False is for, and the usages of this function assume that it returns a boolean with False as the error condition. Derrell | |||||
2008-10-24 | Revert Samba3 back to using its own charset handling code. | Jelmer Vernooij | 1 | -1/+1 | |
2008-10-24 | Remove more uses of global_loadparm. | Jelmer Vernooij | 1 | -1/+1 | |
2008-10-24 | Merge branch 'master' of ssh://git.samba.org/data/git/samba | Jelmer Vernooij | 11 | -95/+280 | |
2008-10-24 | Fix merged build paths. | Jelmer Vernooij | 2 | -2/+2 | |
2008-10-23 | s3: fix simple "incompatible pointer type" build warning | Tim Prouty | 1 | -1/+1 | |
2008-10-23 | Fix "ndr_size_PAC_LOGON_INFO defined but not used" build warning | Tim Prouty | 2 | -6/+1 | |
This patch removes the gensize option from krb5pac.idl because it generates an unused function that has been causing warnings during the s3 build. I re-ran 'make samba3-idl' to update the generated files for s3. For s4 I ran a full build with no problems. | |||||
2008-10-24 | netapi: make sure to always cleanup after testing NetUser calls. | Günther Deschner | 1 | -0/+4 | |
Guenther | |||||
2008-10-24 | netapi: add more group tests to netapitest. | Günther Deschner | 1 | -3/+220 | |
Guenther | |||||
2008-10-24 | s3-samr-server: return NT_STATUS_NOT_SUPPORTED for group rename. | Günther Deschner | 1 | -0/+3 | |
Guenther | |||||
2008-10-24 | s3-samr-server: remove unused historic code. | Günther Deschner | 1 | -60/+0 | |
Guenther | |||||
2008-10-24 | svcctl: move some non-rpc related bits out of rpc_svcctl.h. | Günther Deschner | 3 | -23/+49 | |
Guenther | |||||
2008-10-23 | Fix prototype for set_sockaddr_port. | Jelmer Vernooij | 2 | -2/+2 | |
2008-10-23 | Merge branch 'master' of ssh://git.samba.org/data/git/samba | Jelmer Vernooij | 1 | -1/+0 | |
2008-10-23 | Fix "parameter has incomplete type" build warning. | Tim Prouty | 1 | -1/+0 | |
When libcli-util was moved to the top level (3be0f6ea56ed8e43cd287ed020e942efb675b87b) it introduced a build warning. Since ndr_map_error2ntstatus depends on the definition of enum ndr_err_code and libndr.h can't be easily included in error.h, I moved the definition of enum ndr_err_code to libndr.h. This also eliminates the need for the duplicate definition in proto.h | |||||
2008-10-23 | Move set_sockaddr_port to libutil. | Jelmer Vernooij | 1 | -12/+0 | |
2008-10-23 | Merge branch 'master' of ssh://git.samba.org/data/git/samba | Jelmer Vernooij | 2 | -4/+6 | |
2008-10-23 | Use common net utility code (address and sockaddr manipulation). | Jelmer Vernooij | 9 | -409/+21 | |
2008-10-23 | s3-build: add missing generated svcctl changes. | Günther Deschner | 2 | -4/+6 | |
Guenther | |||||
2008-10-23 | Use sockaddr_storage only where we rely on the size, use sockaddr | Jelmer Vernooij | 17 | -115/+118 | |
otherwise (to clarify we can also pass in structs smaller than sockaddr_storage, such as sockaddr_in). | |||||
2008-10-23 | Merge branch 'master' of ssh://git.samba.org/data/git/samba | Jelmer Vernooij | 2 | -70/+8 | |
2008-10-23 | Use libutil genrand. | Jelmer Vernooij | 4 | -225/+6 | |
2008-10-23 | s3-build: remove duplicate svcctl bits and re-run make samba3-idl. | Günther Deschner | 2 | -70/+8 | |
Guenther | |||||
2008-10-23 | Merge branch 'master' of ssh://git.samba.org/data/git/samba | Jelmer Vernooij | 1 | -0/+3 | |
2008-10-23 | Make use of a large buffer for smbclient put command | Volker Lendecke | 1 | -0/+3 | |
2008-10-23 | Import talloc_stack into util library. | Jelmer Vernooij | 4 | -189/+3 | |
2008-10-23 | Merge branch 'master' of ssh://git.samba.org/data/git/samba | Jelmer Vernooij | 4 | -1/+1 | |
2008-10-23 | Share codepages. | Jelmer Vernooij | 4 | -1/+1 | |
2008-10-23 | Use WERR_FILE_EXISTS which is the equivalent of WERR_ALREADY_EXISTS | Jelmer Vernooij | 6 | -6/+6 | |
previously present in Samba 3. | |||||
2008-10-23 | Use common error definitions. | Jelmer Vernooij | 11 | -999/+8 | |
2008-10-23 | s3-build: fix another build warning with the new ASN1 code. | Günther Deschner | 1 | -2/+5 | |
Guenther | |||||
2008-10-23 | netapi: fix add_GROUP_USERS_INFO_X_buffer. | Günther Deschner | 1 | -4/+12 | |
Guenther | |||||
2008-10-23 | netapi: fix NetUserGetGroups_r returning partial results. | Günther Deschner | 1 | -2/+3 | |
Guenther | |||||
2008-10-23 | s3-samr-server: unify callback convention: _samr_UserSetInfo. | Günther Deschner | 1 | -34/+19 | |
Guenther | |||||
2008-10-23 | s3-samr-server: unify callback convention: _samr_QueryDomainInfo. | Günther Deschner | 1 | -32/+18 | |
Guenther | |||||
2008-10-23 | s3-samr-server: fix return code in _samr_QueryDisplayInformation. | Günther Deschner | 1 | -1/+1 | |
Guenther | |||||
2008-10-23 | Merge branch 'master' of ssh://git.samba.org/data/git/samba | Jelmer Vernooij | 3 | -3/+5 | |
2008-10-23 | Remove unused copy of tables.pl | Jelmer Vernooij | 1 | -89/+0 | |
2008-10-23 | Remove unused copy of ndrdump.c. | Jelmer Vernooij | 1 | -445/+0 | |
2008-10-23 | s3-build: fix some const build warnings. | Günther Deschner | 1 | -2/+2 | |
Guenther | |||||
2008-10-23 | netapi: NetGroupEnum_r needs to handle servers with no groups. | Günther Deschner | 1 | -1/+1 | |
Guenther | |||||
2008-10-23 | s3-samr-server: _samr_DeleteUser needs to wipe out the user_handle on success. | Günther Deschner | 1 | -0/+2 | |
Guenther | |||||
2008-10-22 | s3-samr-server: fix access check in _samr_QuerySecurity(). | Günther Deschner | 1 | -1/+1 | |
Guenther | |||||
2008-10-22 | s3-build: fix the build. | Günther Deschner | 1 | -2/+2 | |
Guenther | |||||
2008-10-22 | Fix net rpc vampire, based on an *amazing* piece of debugging work by ↵ | Jeremy Allison | 5 | -45/+50 | |
"Cooper S. Blake" <the_analogkid@yahoo.com>. "I believe I have found two bugs in the 3.2 code and one bug that carried on to the 3.3 branch. In the 3.2 code, everything is located in the utils/net_rpc_samsync.c file. What I believe is the first problem is that fetch_database() is calling samsync_fix_delta_array() with rid_crypt set to true, which means the password hashes are unencrypted from the RID encryption. However, I believe this call is redundant, and the corresponding call for samdump has rid_crypt set to false. So I think the rid_crypt param should be false in fetch_database(). If you follow the code, it makes its way to sam_account_from_delta() where the password hashes are decrypted a second time by calling sam_pwd_hash(). I believe this is what is scrambling my passwords. These methods were refactored somewhere in the 3.3 branch. Now the net_rpc_samsync.c class calls rpc_vampire_internals, which calls libnet/libnet_samsync.c, which calls samsync_fix_delta_array() with rid_crypt always set to false. I think that's correct. But the second bug has carried through in the sam_account_from_delta() function: 208 if (memcmp(r->ntpassword.hash, zero_buf, 16) != 0) { 209 sam_pwd_hash(r->rid, r->ntpassword.hash, lm_passwd, 0); 210 pdb_set_lanman_passwd(account, lm_passwd, PDB_CHANGED); 211 } 212 213 if (memcmp(r->lmpassword.hash, zero_buf, 16) != 0) { 214 sam_pwd_hash(r->rid, r->lmpassword.hash, nt_passwd, 0); 215 pdb_set_nt_passwd(account, nt_passwd, PDB_CHANGED); If you look closely you'll see that the nt hash is going into the lm_passwd variable and the decrypted value is being set in the lanman hash, and the lanman hash is being decrypted and put into the nt hash field. So the LanMan and NT hashes look like they're being put in the opposite fields." Fix this by removing the rid_crypt parameter. Jeremy. | |||||
2008-10-22 | s3-asn1: make all of s3 asn1 code do a proper asn1_init() first. | Günther Deschner | 7 | -408/+494 | |
Guenther | |||||
2008-10-22 | s3-asn1/spnego: use OIDs including dots. | Günther Deschner | 1 | -4/+4 | |
Guenther | |||||
2008-10-22 | s3: use shared asn1 code. | Günther Deschner | 13 | -743/+57 | |
Guenther | |||||
2008-10-22 | s3-spnego: move spnego defines to spnego.h | Günther Deschner | 2 | -17/+17 | |
Guenther | |||||
2008-10-22 | Slightly simplify reply_sesssetup_blob(): Remove an else branch | Volker Lendecke | 1 | -10/+11 | |