Age | Commit message (Collapse) | Author | Files | Lines |
|
3_0 and
3_0_24 because I was explicitly asked to, although this needs close
review. Jeremy, I'm sure you will check this thoroughly :-)
In reply_open_and_X the separate "size" variable kills the calculation of the
SPARSE flag returned to the client in the attrib field. In getpathinfo we do
it correctly, and RAW-OPEN (correctly) complains about the difference.
Add the "set the write time" to mknew and create.
For trans2open we were missing the "ofun == 0" ->
NT_STATUS_OBJECT_NAME_COLLISION case, and we dropped the status returned in
favor of ACCESS_DENIED once too many.
Last change is a fix to trans2open: We were returning the attributes given by
the client, not the attributes of the new file.
Volker
(This used to be commit 84e6889632c7f98a7cb37036b0acdf538d50d16c)
|
|
(This used to be commit 25c4ebb55f425816e033491138f1216125de6edb)
|
|
the child domain cannot always resolve SIDs in sibling domains.
Windows tries to contact a DC in its own domain and then the root
domain in the forest. This async changes makes winbindd's name2sid()
call do the same.
(This used to be commit 7b2bf0e5a6b8d4119657c7a34aa53c9a0c1d5723)
|
|
(This used to be commit 86e6ae6a9fe2a6fdaeeb503653a312662c7f50e9)
|
|
so apps will know which one to look for,
(This used to be commit d4a5dc3ad5f56a5f741424ecc4fffa0ef39bdc67)
|
|
(This used to be commit cb6c6a49e257d60318101c897e8d2b86de08a846)
|
|
(This used to be commit 471c6e6a2142afbca36163bcdbb5b6fb4e7ac774)
|
|
check_is_at_open==False,
remove that parameter.
Volker
(This used to be commit e51b7648703f3a85b840501dd4199600a5a7e44f)
|
|
(This used to be commit 4f0f917b344743e16e8bacf4e72529a2890590fe)
|
|
The only error path of can_delete() that we're interested in ntcreate&x is the
one of can_delete_file_in_directory(), so call that directly.
The only other one where we might get a NT_STATUS_ACCESS_DENIED is from the
lstat in can_delete, but this is covered later in the open_directory and
open_file_ntcreate calls. open_directory does a stat() in the open case which
also covers the (potential) symlink, and open_file_ntcreate does the open(2)
itself, so this should also work.
This makes can_delete() static to reply.c.
Volker
(This used to be commit d289037fdbc8bd3e0723784888946d5b39ffadef)
|
|
(This used to be commit ff173995cfeac216ab26faef6553be8f7f439347)
|
|
Jeremy, please check this.
Thanks,
Volker
(This used to be commit 2becbb9e5f7d1b04962178e6f0c97c3ccf2b0f88)
|
|
Add lots of TODOs :-)
Volker
(This used to be commit 0e953884a15873b0962ab1ab064d6b3a436726c0)
|
|
metze
(This used to be commit 3260d2116358fc64c40d2cbe8bffed4f3e387323)
|
|
(This used to be commit 19781d71fc5a8146109395cd53c04cf13cc48652)
|
|
survives the
first of the raw-notify subtests, the one-level test_notify_dir without any
flags around yet.
The tricky part was getting the data structures right, I hope the next tests
don't let that fall over.
fsp->notify is now by default NULL, meaning that nobody has issued a
changenotify call. This means nobody is interested in changes for this
directory.
If that has happened, notify_change_buf collects the changes if no current
request is outstanding, and it collects the requests if no change has happened
since the last request.
Happy New Year, somewhere on this planet it's already 2007 :-)
Volker
P.S: Jeremy, there's a question for you in smbd/files.c line 367.
(This used to be commit ce0ad24988075465addcac0b9afc872e909135af)
|
|
(This used to be commit fe122b07fa1712c15067ed385d4408206e9beef4)
|
|
call_nt_transact_notify_change() is now sync if there are changes around.
A notify_message does a direct reply from within the message, so
process_pending_change_notify_queue is not needed anymore for samba-generated
events. Next step is to restructure the kernel-mechanisms to generate
messages.
Volker
(This used to be commit c813f71d0036ec52c99a97e60fe33ee47d0635fa)
|
|
(This used to be commit 22163fee595251d4ea92279d88a1e8525188c620)
|
|
is (effectively) in libc. Convert AC_LIBTESTFUNC to use the mystically
undocumented m4_ifval, which fixes some quoting problems when
providing shell code for the if-true and if-false branches.
(This used to be commit 5e1fbcc403c471ecaaa37e8cd54b719b65dd7495)
|
|
libSystem on Mac OS X.
(This used to be commit 2117904f18869fca0d4770883cf2de5fb00c4f85)
|
|
libSystem on Mac OS X.
(This used to be commit 585ee7f31d2fb169e9dc37fd786faa8049be5e52)
|
|
(This used to be commit 49a463a97a4f800977ed3a657714e7f3b17bbf21)
|
|
for this error code.
Jeremy.
(This used to be commit 71b868611671a6c9275fce153794a0ccc150551f)
|
|
modified). Ensure "hide unXXX" parameters don't
hide MSDFS links. Bug #3319.
Jeremy.
(This used to be commit e5466fffc286a99fafe0fcfbf70e903e33baa7f9)
|
|
As discussed with jerry at the CIFS conf: overriding the
administrator's wishes from the krb5.conf has only every given me
segfaults. We suggest leaving this up to the defaults from the
libraries anyway.
Andrew Bartlett
(This used to be commit 0b72c04906b1c25e80b217a8f34fd3a8e756b9ca)
|
|
(This used to be commit e43aa4e03d8d2d3ffa3a0383b0b0835dd1a51cda)
|
|
Checking in because Jeremy was bugging me. Potentially this becomes quite
intrusive, I'm not sure if I should open a temporary branch for this.
Jeremy, Jerry, do you think 3_0 is the right place for this?
Volker
(This used to be commit bcf5c751cbe203c00814642e26440cf88f300bce)
|
|
(This used to be commit 48798b5e57fcb2ee7debfe9d5178adef37907f92)
|
|
metze
(This used to be commit e5333d5628a585ff00b78d50a0a22b0cf98aa9ff)
|
|
metze
(This used to be commit b2feeee7485f0a1006b38e5abee05c2583923242)
|
|
this is done by libreplace...
this hopefully fixes the build on HPUX 11.00
metze
(This used to be commit eed50e104794d855b204cfea52626f47b6fa3f52)
|
|
only try to find dlfcn.h if the dlopen symbol was found,
it hopefully fixes systems where dlfcn.h but no library with dlopen
metze
(This used to be commit b303e929d1ac6f1d931d0b92bdecdf292e1598cd)
|
|
Jeremy.
(This used to be commit b8d5faac69f3a0c2620a34f9026b4018ebd48bb8)
|
|
wcards. I had forgotten this and had refused to allow
dest to contain wcards. We now pass all the normal
Samba4 smbtorture RAW-RENAME tests.
Jeremy
(This used to be commit 4183c1b49fd5a6107aa87249b7be236af092ed8b)
|
|
from open_file_ntcreate make sure we return it on rename
error.
Jeremy.
(This used to be commit 633f02fb860223585f388e64c1a2d770db52d4f0)
|
|
being returned (false positive). Up debug
level on "open_directory" message.
Jeremy.
(This used to be commit 71a8b8863f8bdcce082c5971d6489a2da3ff4b2c)
|
|
by ensuring we pass in a valid src_len (or zero when appropriate).
Volker is correct in that this is a *horrible* interface and he is
now free to generally clean it up everywhere :-). Go for it Volker !
Jeremy.
(This used to be commit cd991fb839994dd29dc790b655f5597fa1e12843)
|
|
before checking length. Found by Volker.
Jeremy.
(This used to be commit 683c5fce6896236a60145f6d3970566503c39163)
|
|
found by Volker.
Jeremy
(This used to be commit 08d551163c9563bd02acd437bc1a1595e7939cee)
|
|
This involved passing the dirname as argument to a few routines instead of
calling parent_dirname() deep down.
Volker
(This used to be commit 7977fd78652897bb7d4db1c21c5749043428f911)
|
|
(This used to be commit f103c301b18f2eeb5203634cb6b50fa79f57a93b)
|
|
(This used to be commit df6362baa0928616c6934950fb9c1264cb27106e)
|
|
together.
Jeremy, I'm 100% sure you watch me closely here, I count on you :-)
Volker
(This used to be commit 02f85265f21607c950639da33bc8fe5d5ffd3cf9)
|
|
name-based (for
directory opens) routines.
Volker
(This used to be commit 4ca921d9aa90bc68d21d40ccf4b1ca0b1d2cbcb1)
|
|
open_directory
we want to follow symlinks.
Volker
(This used to be commit c20bdd219d16abcc60d67f4a21b4fcd661473835)
|
|
(This used to be commit cce911780fc52ea56dccde1879b0891cdf9ea320)
|
|
(This used to be commit 6dd0886b49969d0edfe16861f19d35275217b2af)
|
|
regarding
error messages: We relied upon a stat that a directory did not exist to later
on then do the mkdir or not. This does the mkdir directly and copes with a
potential error.
The second one is more important: It's possible with Samba 3 to do a
ntcreate&x with NTCREATEX_OPTIONS_DIRECTORY and we happily do a NT_STATUS_OK.
Also move up the use_nt_status() logic a bit. I think this does not belong
into the core routines, the smb server as such should take care of it.
Jeremy, do you think this should go to 3.0.24?
I'll update samba4torture when the build farm has picked up this checkin.
Volker
(This used to be commit 472fb11f4968d30cedc9851215c63acd3132f3db)
|
|
now have
tmp_talloc_ctx().
Volker
(This used to be commit 165d28f03a82a1a07d0f86c0d5de4a785ea5c7f0)
|