Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
This falls out of the removal of security=share, because we now require that
a session setup has been performed before (essentially) all other operations.
Andrew Bartlett
|
|
extensions are enabled
We can't manipulate file_attributes if it's a posix call. I'll look
at adding a test for this asap.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Jun 5 04:26:11 CEST 2012 on sn-devel-104
|
|
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Jun 3 23:37:02 CEST 2012 on sn-devel-104
|
|
metze
|
|
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Jun 3 21:08:19 CEST 2012 on sn-devel-104
|
|
metze
|
|
metze
|
|
In case we have a left-over entry in the share mode entry array,
the SMB_ASSERT(got_tokens) is likely to kick in. It happens when
we are about to delete a file with initial delete on close. We don't
have a delete on close token set in the locking.tdb record. We see
the fsp->initial_delete_on_close set, add the delete_on_close token
to lck. Then "delete_file" is being set to true. Then later on we
do the notify_deferred_opens. This walks the list, also checking
for share_mode_stale_pid. We have already deleted our own share
mode entry, share_mode_stale_pid() sees the left-over entry. It not
also deletes that one but also the delete on close token. This leads
to a different view of "delete_file" a.k.a. "got_tokens" further
down in close_remove_share_mode, leading the SMB_ASSERT to fire.
This patch attempts to fix the issue by keeping around our own share
mode entry for almost the whole routine, preventing share_mode_stale_pid()
from removing the delete tokens.
Pair-Programmed-With: Volker Lendecke <vl@samba.org>
|
|
Without "lck" we don't have much to clean up
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
by introducing a variable simplifying a boolean expression
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
All remaining callers actually want the token
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
Introduce find_delete_on_close_token. Thus is_delete_on_close_set
does not have to call get_delete_on_close_token anymore.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
Remove a level of indentation by more use of "continue;"
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
metze
|
|
metze
|
|
metze
|
|
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Jun 3 16:03:59 CEST 2012 on sn-devel-104
|
|
|
|
This won't work with the new tree structure, and we have the same
output at
https://build.samba.org/lcov/data/coverage/samba_4_0_test/unused-fns.txt
Using the callcatcher framework.
Andrew Bartlett
|
|
The autoconf Samba build will return to over-linking with -lattr on
systems with both the XFS compat API and native xattrs.
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Jun 3 03:56:05 CEST 2012 on sn-devel-104
|
|
This reverts commit 4f6b1e8c81776cf1fa386574e60e54fe6b4fe82e because I
cannot find any use of this configure check, and it is one of the
differences between the WAF and autoconf builds.
Andrew Bartlett
|
|
This may assist in debugging a difference in a configure test on the
build farm.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Jun 2 09:46:09 CEST 2012 on sn-devel-104
|
|
This will hopefully fix the build on SLES8, which does not support 64-bit sendfile.
Andrew Bartlett
|
|
These are on more systems than just linux. If the configure test passes
then assume it is available.
Andrew Bartlett
|
|
This also moves all the still-used configure tests etc. The unused OSF API
is also removed at this time.
Andrew Bartlett
|
|
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Jun 2 02:12:31 CEST 2012 on sn-devel-104
|
|
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jun 1 18:58:30 CEST 2012 on sn-devel-104
|
|
versions
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Jun 1 11:23:21 CEST 2012 on sn-devel-104
|
|
This uses the fact that we have both build systems running at the same time.
The krb5 checks are skipped because we typically are comparing internal Heimdal
with the system krb5, so they do not make sense.
The required checks for krb5 are pretty well understood in any case, as
we have a limited set of supported libraries.
Andrew Bartlett
|
|
#8970 - Possible memory leaks in the samba master process.
|
|
smbd is idle.
Calls to exit_server_cleanly() should be treated as a "clean" shutdown,
and not trigger the master smbd to call cleanup_timeout_fn.
|
|
exit_server_common()
sconn is not available in the parent anymore.
Thanks to Volker Lendecke <vl@samba.org> for finding this!
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu May 31 18:08:06 CEST 2012 on sn-devel-104
|
|
metze
|
|
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu May 31 10:06:56 CEST 2012 on sn-devel-104
|
|
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu May 31 06:36:55 CEST 2012 on sn-devel-104
|
|
|
|
|
|
|
|
readability
|
|
|
|
|
|
|
|
|
|
to remove explicit calls to binpath('wbinfo')
|
|
to remove manual calls to binpath("smbclient3")
|
|
|
|
messages and initiating the cleanup function on every process death.
We now have many sub-processes from smbd that don't serve SMB1/SMB2 requests and
don't register themselves in the serverid.tdb. Only initiate the cleanup
from processes that were explicitly in the child list.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu May 31 04:44:09 CEST 2012 on sn-devel-104
|
|
and miss valid DC IP addresses
Original code incorrectly used a while() instead of a for() loop.
We need to iterate over the entire array here.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 30 23:29:03 CEST 2012 on sn-devel-104
|
|
nbt_getdc() has no timeout.
This code explicitly isn't needed as the tevent code will take
care of this.
|