summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2004-03-13Ensure we don't truncate strcmps to nstring anymore...Jeremy Allison6-11/+16
Jeremy. (This used to be commit b3aff7f214da97925690a5d0a887ea1b336d107a)
2004-03-13Modified fix for bugid #784. Based on a patch from moriyama@miraclelinux.com ↵Jeremy Allison25-176/+197
(MORIYAMA Masayuki). Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name when represented in dos charset (ie. cp932). So go back to using fstrings for these but translate into nstrings (ie. 16 byte length values) for transport on the wire. Jeremy. (This used to be commit 128dec9ae68fd357550de2649d54056ca4fc65cf)
2004-03-13First part of patch from moriyama@miraclelinux.com (MORIYAMA Masayuki) toJeremy Allison5-809/+887
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c so it's readable. Jeremy. (This used to be commit beca3829d1140bf7c2e394993a02dff1f2cf7bbd)
2004-03-12Bug report 1079 and fix both from Bert Driehuis.Christopher R. Hertel1-38/+78
This is an odd corner case having to do with <1C> group names (DC names). <1C> group names are called (by MS) "Internet Special Groups", which means that Microsoft's WINS servers will attempt to handle these names in something approximating an RFC1001/1002 compliant manner. The problem being reported here is this: If an initial registration sent by one of the group members is lost (network error, whatever) then subsequent refreshes from that particular machine will also fail. This only happens if the name is already active (because of other group members). In most cases, we (and MS) handle refreshes as registrations if the name is not in the database. In this situation, we missed the corner case. Bert's fix adds an 'else if' that catches the situation in which a refresh for an unlisted IP of an active <1C> group name is received. The refresh is simply handled as a registration when this happens. [Note: Committing in HEAD. I am writing some tools to do registrations and refreshes so that I can test this. I don't have an NT Domain for testing so I'm going to have to fudge. This fix is small (I cleaned up some Debug messages and comments in addition to the fix) and if you want to test it with 3.0.x you can just copy the HEAD version into your 3.0.x tree and recompile.] (This used to be commit 8e52439f4ae9de84107e2d0e9f33f0d4e3c5945a)
2004-03-12Fix from Robert.Dahlem@gmx.net (Robert Dahlem) for bugid #1048Jeremy Allison1-2/+2
when mangled names are turned off. Jeremy. (This used to be commit 11487e24666c7b3dd4b37f4ef8aec8f8a5bd5a6f)
2004-03-12Fix problems with very long filenames in both smbd and smbclient.Alexander Bokovoy3-48/+56
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there. As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics. (This used to be commit cc70a548f3c48a9503fd54d01896cc2499f5bbcd)
2004-03-12Fix build after Jeremy -- yet another place where convert_string() wasn't ↵Alexander Bokovoy1-2/+2
updated (This used to be commit e117ed1db84b2447793ccea4036e225c4a552e1e)
2004-03-12Fix string overflow due to wrong size calculationAlexander Bokovoy1-1/+1
(This used to be commit cf0285f3ea017d300d94e8c7f7042ae8ccc8f960)
2004-03-12Allow msdfs symlink syntax to be more forgiving (it took me ages to rememberJeremy Allison1-4/+12
what it was :-). Allow msdfs links to now look like UNC paths : eg. sym_link -> msdfs://server/share/path/in/share or : sym_link -> msdfs:\\server\share\path\in\share Jeremy. (This used to be commit 3c89393e2907e4a3318fb3e94a911cd35f16b4c2)
2004-03-11Fix bug introduced by Jim (touche :-) :-) - use new smbldap_get_single_pstringJeremy Allison1-4/+4
call :-). Jeremy. (This used to be commit 3c9fd2bdee097394cb0d0b6683748835c6a2d3a0)
2004-03-11Restore the contract on all convert_stringXX() interfaces. Add a ↵Jeremy Allison10-77/+81
"allow_bad_conv" boolean parameter that allows broken iconv conversions to work. Gets rid of the nasty errno checks in mangle_hash2 and check_path_syntax and allows correct return code checking. Jeremy. (This used to be commit 3b4fca7b7f410cb0f11322e22c8f26a662eff941)
2004-03-11Merge from 3.0. Fix munged dial in pdb_ldapJim McDonough4-48/+60
(This used to be commit 46544e957f00f71e3a49e3d90cd88b4cf1b33408)
2004-03-11add missing #ifdef HAVE_BICONV stuffHerb Lewis1-0/+3
(This used to be commit 5e831f48f0d15a02a3bc406a7dc5249a57ceec4f)
2004-03-11BUG 1088: patch from SATOH Fumiyasu <fumiya@miraclinux.com> -- use ↵Gerald Carter1-29/+19
strchr_m() for query_host (smbclient -L) (This used to be commit e7d2315e45df7e2e4e586a8fc4a32d6880e83e4f)
2004-03-11Ensure we use check_path_syntax() to pull out DFS paths.Jeremy Allison1-7/+2
Jeremy (This used to be commit ebf82e2c14827c0a0edd8ee373ce5200f7b0b3b0)
2004-03-11Fix processing of pathnames with embedded '\\' characters (0x5c) in CP932Jeremy Allison1-5/+23
character set. Because of the allowing of "broken conversions" for people who have broken iconv libraries we can't rely on the return from convert_string() to be valid - we must check errno instead. This is ripe for revisiting at some stage. I prefer adding a bool parameter to all convert_string_XX varients to specify if we will allow broken conversions or not. With "allow_broken_conversions" set to false we could then rely on the return from convert_string rather than checking errno. Jeremy. (This used to be commit 30c30c5ac53ec8f32a44d0b1b39cc99fe9844467)
2004-03-10lsa_enumaccounts lists all SIDs that have been granted privileges. Simo,Volker Lendecke1-22/+8
you should look at this. Change behaviour from listing all groups to listing only BUILTIN\Administrator Volker (This used to be commit 32d196e9bbf203855832da16eff3dee495679928)
2004-03-10Remove expanding sids from smbd, this will be done in winbindd.Volker Lendecke1-25/+0
Volker (This used to be commit 67bb1d2338b0d5ba3f8a4754ff1479cd42cfb051)
2004-03-10Apply some constVolker Lendecke5-14/+14
(This used to be commit e2696b81bb5e4d12281cf99dc50f91844ae51c2e)
2004-03-10Don't pass DOM_SIDs around when pointers are enough.Volker Lendecke2-6/+6
Volker (This used to be commit 27b27c28cd0421be3121e7f03c237df381c7ecb3)
2004-03-10another typeHerb Lewis1-1/+1
(This used to be commit 40634650d0489ebef17e090ef4544b772538b3dc)
2004-03-10Moving towards getting msdfs working again (this looks like it was brokenJeremy Allison1-5/+62
in 3.0.2a actually). We now send a correct referral back, but the client refuses to follow it... Not sure why. Will do more tests.. Maybe unicode character count is wrong (it looks it). Jeremy. (This used to be commit 859529aff348e66281d2ec4d54c5852121aae9e5)
2004-03-10Formatting reformat before I start to change anything here.Jeremy Allison1-273/+258
Jeremy. (This used to be commit e93aeb96771125ef8775a531257e7390217204d0)
2004-03-10fix type for tag in proto fileHerb Lewis1-1/+1
(This used to be commit cd1ed1a23b15002aab3387c6f6316f85574c11e8)
2004-03-09Fix dfs referrals - don't use check_path_syntax. Also use mb char calls inJeremy Allison2-16/+10
dfs code. Jeremy. (This used to be commit 70670841028aaeb72267ac41ca30af8dba412998)
2004-03-09Yet another '\n' termination of debug message.Rafal Szczesniak1-1/+1
rafal (This used to be commit 6c8e39b7ccc1ad8e7f39c2a51fa13423e5d6e227)
2004-03-09Forgot to put some more comments.Rafal Szczesniak1-0/+34
rafal (This used to be commit b3efdcf0aeec5a115c53de8bbedaa9ca8225b689)
2004-03-091) Two new functions to trust passwords interface in passdb:Rafal Szczesniak4-22/+280
settrustpwent, gettrustpwnam 2) Implementation of another couple of these functions in tdbsam: settrustpwent, gettrustpwnam, gettrustpwsid 3) Testing (mostly for now) usage of the interface in pdbedit which is soon to be offline tool back again. This is quite a new code, so many changes will be put in soon. rafal (This used to be commit 2ed23fbce846f9710747d72aa98c20d54894d61e)
2004-03-09Fix to debug message lacking termination with '\n'.Rafal Szczesniak1-14/+14
rafal (This used to be commit 6fdb20f5a7657556a3e4ceb4cab8c1d67e29ea21)
2004-03-09fix build with gcc 2.96 and --with-developerGerald Carter1-1/+1
(This used to be commit 45b2efd60a3c3c9f01b1ccaa828904a70d70d67d)
2004-03-09Commit to HEAD the updates to smb signing code that I was propsing for 3.0.Andrew Bartlett7-62/+101
This code implements 'opportunistic signing' in our client (when the server supports it, we will use it), and correct downgrading on both the client and server for the 'enabled' (rather than required) signing level. This means that we can actually set 'server signing = yes' and not have the world fall apart. We had a number of bugs in that code, and it certainly looks like most of the testing was with the 'requried' setting. While the changes are reasonable, I'm putting this into HEAD rather than 3.0 for the timebeing. SMB signing, like NTLMSSP, tends to have gotchas in it :-) (I also need to give it a workout with more than smbclient before I move it across). Andrew Bartlett (This used to be commit 6bad895462cf076a7e917c909e2a461d1b360bf1)
2004-03-09Merge fixes and tests for jra's broken strstr_m() function from 3.0Andrew Bartlett4-8/+102
STF rules! (Pity we don't use it for more stuff) Andrew Bartlett (This used to be commit a9363b45b0ef652a5fd621915fafb97ada0c7d5e)
2004-03-09Added strstr_m() function. Use in all places where we might run into mbJeremy Allison6-12/+82
(should fix the mb service name problem, can't remember the bugid). Jeremy. (This used to be commit 93c2d50f1adbf257c0c0185b420a1d73d56be2f9)
2004-03-08Fix assumption about following directory sep in check_path_syntax(). WeJeremy Allison1-5/+11
need to try and convert 1 byte, then 2 bytes if that fails. Fixes bug reported by Simo. Jeremy. (This used to be commit 0f84801ff3ed5acfcf8e0c4a825f90b9b4823da5)
2004-03-08Do some checks about data passed to this functionSimo Sorce1-0/+3
(This used to be commit 77142a1ca6853fcae3b806830d077f6f84bebd6d)
2004-03-082 fixes to enhance readability of source code and debug messagesSimo Sorce3-4/+6
1 fix for a memleak (This used to be commit 9f3b0295fe7bd6c0c3a6061e5d00e7b88f702b21)
2004-03-07Get us a little closer to Windows LSA semantics.Volker Lendecke1-10/+1
A windows DC does not reply to DCNAME\\Administrator, only to DOMAIN\\Administrator. Fix that. Without winbind we are wrong as domain members, we should forward the request DOMAIN\\Username to the DC on behalf of the asking client. Winbind fixes that nicely. Volker (This used to be commit c39f698dde98de9b6be40a6c81e669dcd7696b3a)
2004-03-07This might not be used a lot and might not survive for long, but at least itVolker Lendecke2-7/+11
should work as expected :-) Fix wb_delgrpmember. Volker (This used to be commit 2a2b4a159a973678b7279a8d91060c7c27aa22e8)
2004-03-07Fix typo.Tim Potter1-1/+1
(This used to be commit 7798a52d82c46759635e90a7e48ddad4ce48b763)
2004-03-07Enclose use of fchown() with guards. Bugzilla #1155.Tim Potter1-0/+4
(This used to be commit 92f6895dd11189ce966b8b5a3f9ace54f478a375)
2004-03-06tdbdump doesn't need to #include <sys/mman.h>Tim Potter1-1/+0
Bugzilla #1154. (This used to be commit 311bbf41ec50d5caf4388cb4745173739744a049)
2004-03-05Several mb tidyups - getting ready to address the XXX_sub function.Jeremy Allison4-108/+105
Jeremy. (This used to be commit 13edba472a0a5eb56586458a2432d53f495d0129)
2004-03-05BUG 488: fix the 'show client in col 1' button and corrctely enumerate ↵Gerald Carter1-1/+1
active connections (This used to be commit f0e454f6eb3ed25c3210f288d48044b3eed9d129)
2004-03-05fix compiler warningGerald Carter1-1/+1
(This used to be commit 7153cbf8cbb07d4e7a9dc9adc9e0a40c57a6e305)
2004-03-05Add -O (write downloaded files to stdout), based on patch fromJelmer Vernooij1-65/+80
Bas van Sisseren <bas@dnd.utwente.nl> (This used to be commit a90df1c170a168092e0c90f684ea968bd1f6f768)
2004-03-05all_string_sub() is broken as it doesn't handle mb chars correctly (andJeremy Allison2-18/+5
so breaks when substitution '/' and '\'). It's used by unix_clean_name(), which is used by reduce_name, which is used by check_name() (phew!). Now that we know all filenames passed to check_name() are in a "good" format (no double slashes, all '\\' chars translated to '/' etc.) due to the new check_path_syntax() we can avoid calling reduce_name unless widelinks are denied. After this check-in I can fix all_string_sub() to handle mb chars correctly as it won't be in the direct path in the main path handling code. Jeremy. (This used to be commit bce0678331aa4746181389e0f91f11fb2a6dadcb)
2004-03-04Fix my breakage of NT pipes from the previous patch (sorry). Use theJeremy Allison1-4/+1
original srvstr_pull_buf() function to get the pipename not srvstr_get_path(). Jeremy. (This used to be commit ac5e0c4bb686e2aaccc9b70f240f79747fd48cd8)
2004-03-04BUG 1015: patch from jmcd to fix statfs redeclaration of statfs struct on ppcGerald Carter1-1/+3
(This used to be commit d9a9e214a8dd3b79284f4cff6052210b758bbf72)
2004-03-04BUG 1080: fix declaration of SMB_BIG_UINTGerald Carter1-12/+12
(This used to be commit 0b17a4105ecbad26b6bb79ed8148495c02518430)
2004-03-04There's a specific error message NT_STATUS_ALIAS_EXISTS.Volker Lendecke1-1/+1
(This used to be commit 0ad00bce0752373a1ac471f6629a5e64ee5af280)