Age | Commit message (Collapse) | Author | Files | Lines |
|
On Jan 22 13:31, Volker Lendecke wrote:
> On Tue, Jan 22, 2008 at 11:33:17AM +0100, Corinna Vinschen wrote:
> > Right. I changed samba_gitcommitdate from time_t to NTTIME and shortened
> > samba_version_string to 28 bytes. New patch below.
>
> Ok, pushed with some modifications. You might want to review
> that.
Reviewed and tested. Looks good, thank you!
Below you'll find a tiny patch to add the git commit date. It seems
I simply missed its existence in version.h :( Tested on Windows XP.
Thanks,
Corinna
* source/smbd/trans2.c (samba_extended_info_version): Fill out
samba_gitcommitdate member with GIT commit timestamp.
(This used to be commit a33d0797585b5cdd304ac1eb6966b9c7c799bab6)
|
|
This is right now only used there, and in version.c it gave linker errors
because some binaries (e.g. smbmnt) don't link in time.o
(This used to be commit 1f0eaaa5911f893c822465a26fe49ab65afb0730)
|
|
(This used to be commit 85123aacdb13e97c3f44aeded1c80e13af53d83d)
|
|
On Jan 21 16:18, Danilo Almeida wrote:
> Corina wrote:
>
> > + time_t samba_gitcommitdate;
>
> And:
>
> > + SIVAL(pdata,28,extended_info.samba_gitcommitdate);
> > + memcpy(pdata+32,extended_info.samba_version_string,32);
>
> Note that you are dropping bits on a system w/64-bit time_t, and that this has the 2038 problem.
Right. I changed samba_gitcommitdate from time_t to NTTIME and shortened
samba_version_string to 28 bytes. New patch below.
Thanks,
Corinna
(This used to be commit 28aa1c199d3a22cda34afcaab49c0561eeb0abcb)
|
|
(This used to be commit e9bb3d5067b74a29beb778f85687829778e42b5b)
|
|
metze
(This used to be commit 2f460915111066d79f5dc9b4ae4d003918d06852)
|
|
SET_STAT_INVALID only sets nlink, not the other fields
We might consider to change SET_STAT_INVALID to always do ZERO_STRUCT
(This used to be commit 8cf8c5b2034fe093b5db7f069bc6be8d328399bf)
|
|
Found by the IBM checker
(This used to be commit 8741a9b37496e78b28d59d844aaba12f269171e0)
|
|
Found by the IBM checker.
Jeremy, you changed this from 'dirname == 0' which does not make sense at all
in the old code to '!dirname == 0' which from my point of view makes even less
sense, because the precedence of ! is according to Harbison/Steele higher than
the precedence of ==. Please check that the code now actually does what it's
supposed to do.
Thanks!
(This used to be commit c8def5564739c4c754001f84fcfb77f1093b96c3)
|
|
Michael
(This used to be commit 196e4ce8c5dd5aab518aaa7d170eb1fb5d66bcd1)
|
|
Don't print only the last component.
Michael
(This used to be commit 654e96208ec847e32797cbd2442ef9e73c014567)
|
|
Michael
(This used to be commit 4d734106b70b9b6029b537fe11f8b3c1aebd42cf)
|
|
Michael
(This used to be commit bdc49b07cc6de36c9319254a131858c9a7f9dd53)
|
|
Michael
(This used to be commit 35e23368dd4240a3c907b4cee882f51119032527)
|
|
(This used to be commit 5b05e09daf18eaea5e86dfd607c8070228f7571b)
|
|
Fix a bug in my bugfix. Thanks to vl for spotting that one.
(This used to be commit 24f68b90cca111256a7b03f7062cb57c2b08a0d6)
|
|
It turns out that this is a necessary operation, separate from statvfs. statvfs
can fail during tcon, so conn->fs_capabilities would never see that we support
streams on a particular share.
James, can you check that I got the darwin variant right? Thanks!
(This used to be commit 3ad798d803b3b023533bb48e6993885f22b96095)
|
|
-bexpall only exports the names without leading _, so we don't get
_talloc_reallo_array for example.
Thanks a lot to Heinrich Mislik for the hint!
(This used to be commit 74a71f198866ba0a0217e58a6a47bdc858d5df68)
|
|
get_mydnsfullname relied on memcache_add(); memcache_lookup() working.
When run from ntlm_auth, the global_cache variable in memcache is NULL, so
the add and lookup both fail. In that case, just return the result of the
getaddrinfo call.
Jeremy, please check.
(This used to be commit 1db41ff52565e9f336a22fb9ffd80d51677e023b)
|
|
metze
(This used to be commit 0b85f7173d0770f8d9a0bac9e43355eb45bc181f)
|
|
metze
(This used to be commit df08708fc1e8fc8e15b36db29faf35ae5ae64b65)
|
|
This actually is a counterpart to reg_init_full, in that is does
open and initialize the registry too, but only registeres the backends
necessary to access the SMBCONF key.
Michael
(This used to be commit 01bda3ab359fb3868c1dc849044f613bf2bc563e)
|
|
This is actually the dispatcher to the registered registry backends.
Michael
(This used to be commit 39d65d11f8eff0aff998d5bfed8480b0f00655bd)
|
|
Michael
(This used to be commit 4952417fca89f5d797c861cde9fe74050ae02e2f)
|
|
reg_openpath should be used instead of this function (along with the
reg_api interface). Last callers of this function are in services_db.c
Michael
(This used to be commit 0005b88d74fca1ea1410c9911d504b0a636a0472)
|
|
Michael
(This used to be commit c3f695d3b14ee06fc5d517ca094236e885f9e707)
|
|
Michael
(This used to be commit aaf33ae5b8bfaefd2342c9ce6363577ce7c0c4f1)
|
|
Michael
(This used to be commit b85e5ee45075211dd3ab85ac79c2d856187d5e3e)
|
|
Start making naming of source files more systematic
to facilitate understanding of the structures.
Michael
(This used to be commit b3c2fb17a4226559788a47fee968ef19b7fbb6b2)
|
|
Michael
(This used to be commit cf485273f61e3dcd41ab7af756cc82f32131bf08)
|
|
Michael
(This used to be commit 562c3eb37e2ff2b385203be9d556daf37df7d20e)
|
|
This is an effect of the removal of the dynamic registry overlay.
This is the beginning of a restructuring of registry linkage in Makefile.in.
Michael
(This used to be commit 7453e78a8e63aaaff57c1779d6b7cf0ec8fc263f)
|
|
(This used to be commit 4a6dadc5178f4861e9c032321939db3b639734b5)
|
|
Found by a "set but never used" warning. Thanks to talloc_tos() this was not
really a bug, but this way the code becomes much clearer.
(This used to be commit b326f11dc39a8ce20d957aac976be0cf7108ba9d)
|
|
gcolley was right, my nt4 does not blue screen with it
(This used to be commit 9f2b5dc1865ca109e1e34c91548479ad9b26f450)
|
|
(This used to be commit 63ee2ef775b48fcaecccf4dc7ef3601ceb8053c5)
|
|
(This used to be commit d7e6ec2258350c564053371361c8f1d7d0f775b1)
|
|
(This used to be commit 96b9a7b3eb92c9f133a3f43ffc4d57d0212e4ebd)
|
|
This is a hot code path, and if it has a :, the name will be split later on
anyway.
(This used to be commit 9f7f6b812d89decea1456ccdc37978e645d11a63)
|
|
(This used to be commit 023b313d0d4ed3beb8d77177bc8141cadeb86658)
|
|
These bugs haven't shown up when I did my tests with real xattrs, not with the
xattr_tdb backend. It worked because the stream fsp does has the base file as
fd.
(This used to be commit b7022f8f7bf83c9c5e73e98d1477b7da766e8c5f)
|
|
(This used to be commit 8db25aba63b1dffb0dfbc74012c7ebd0ce4d5682)
|
|
(This used to be commit d481dddc81699aba79e48bca79bfb10e586b5cbb)
|
|
This must have been lost somewhere in my patch-mangling
(This used to be commit c1794375d1fa27d72ec32946bb4bd7b9f96e59fc)
|
|
(This used to be commit 3509ee597f0977aadd4c70cfe8830a6aa95cd71f)
|
|
(This used to be commit dac468216e7e103b6897f33ec3608412f77265cf)
|
|
Pointed out by Steven Danneman on irc, thanks!
Jerry, Günther, please check!
(This used to be commit 9e71c89ac648040739ef2161a2e6c4299be1e35b)
|
|
new stream code. (1) In smbd/filename, don't split the name at
':' if we know it's a posix path (this should be parameterized....).
(2). When calling posix_mkdir, we get the flag FILE_FLAG_POSIX_SEMANTICS
passed to open_directory(). I know for a posix client lp_posix_pathnames
should be true (which is checked for in is_ntfs_stream_name() but we
have an explicit flag here, so let's use it.
Jeremy.
(This used to be commit 7bb7a0def6518784befa75e5303289d2b4d36dd4)
|
|
Michael
(This used to be commit 487c43f9284598a3c60b06fc60e5c50844e11b87)
|
|
Michael
(This used to be commit 239aa59cc1b78f7fb82aa66418cdf92517ebc123)
|