Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Simo Sorce <idra@samba.org>
|
|
Guenther
s3:auth do not fail if there are 0 group sids
Signed-off-by: Günther Deschner <gd@samba.org>
|
|
|
|
Some pdb_get_ functions where missing because of previous mis-patching
|
|
When both the echo responder and the 445 socket want to send stuff to the
worker smbd, the select loop is not fair. It always chooses the smaller file
descriptor to work on. This can mean that on a busy system the echo responder
never gets around to feed its stuff to the parent.
This fix chooses the async echo responder socket when both the 445 and the echo
responder socket are readable.
Yes, it is a very hackish fix which is required *now* I think. The proper fix
would be to either assign priorities to fd's in tevent, or the from my point of
view better fix would be to make tevent kindof round-robin.
Round-robin would mean that whenever a fd has been dealt with, it is taken off
the list of interested sockets, and only if no other socket is active, all of
the ones waiting are put back. This is a bit like EPOLL_ONESHOT, which I would
like to use for this in the epoll case. Although, I need to do some research if
maybe epoll already guarantees round-robin, I did not find anything in the docs
yet.
Volker
|
|
While there also cleanup the code a bit.
Signed-off-by: Günther Deschner <gd@samba.org>
|
|
Untangle these functions from smbd specific dependencies so they can be freely
used in multiple servers.
|
|
|
|
Pair-programmed-with: Andreas Schneider <asn@samba.org>
|
|
|
|
Jeremy.
|
|
crashes when
XX_send functions set async to stop interim replies being sent.
Jeremy.
|
|
by modules to crash due to destructors being called (found when using the vfs_aio_fork
module with smb2).
Jeremy.
|
|
|
|
|
|
We used to return NT_STATUS_ACCESS_DENIED, now we just return 0 entries, just
like W2k8 does.
usrmgr.exe was pretty unhappy with the NT_STATUS_ACCESS_DENIED
|
|
|
|
To be run in a debugger, there's no way to inspect the internal tevent_select.c
maxfd calculation
|
|
Karolin
|
|
Karolin
|
|
|
|
called
by both sync and async code.
Jeremy.
|
|
Jeremy.
|
|
called
by both sync and async code.
Jeremy.
|
|
|
|
Thanks to Joachim Schmitz for finding that miscalculation.
|
|
this is just relevant for the very rare systems that don't have the st_blocks
struct member. This is a fixup of the fix for bug 7474.
Thanks to Joachim Schmitz for spotting this!
|
|
acct_ctrl is 32 bit in LOGIN_CACHE, but "w" as a format specifier for
tdb_unpack only writes 16 bits. Okay on x86, not okay on Solaris.
Thanks to Vladimir.Marek@Sun.COM!
Volker
|
|
If a file is closed we must also NULL out all chained_fsp
pointers when the fsp is freed to prevent invalid pointer
access.
Jeremy.
|
|
Based on code from Ira Cooper <samba@ira.wakeful.net>, and also
advice on refactoring the patch into a function call. outbuf vectors
can be reallocated by smb2 processing code, so when returning interim
responses we must not make assumptions about vector size.
Jeremy
|
|
Code for dup_smb2_req() was duplicating the wrong vector (i, instead
of i+2) when returning a non-minimal SMB2 response.
|
|
Not sure they were ever working before.
With this patch, make selftest is down to 4 failures from 259 tests.
(two times LOCK9 from s3 smbtorture, one spoolss notify test and
samba3.posix_s3.unix.info2).
Guenther
|
|
netdomjoin-gui.
Patch from Buchan Milne <bgmilne@mandriva.org>.
Thanks!
Guenther
|
|
This reverts commit 8f1cec5faf4e26de8b9797777059e99f2a66558b.
|
|
This reverts commit 4a7f45b7e1cef13bc28d7ee50dd4b5519bdec397.
|
|
This reverts commit edba46ce94c335411ab337eeb4ef6f88fb3aae80.
Conflicts:
source3/auth/auth_ntlmssp.c
|
|
Guenther
|
|
|
|
|
|
|
|
Let the function abstract out how handles are counted
|
|
|
|
memcpy copies memory unconditionally, we are passing "" in some cases here.
Use strncpy which will stop reading from src if the null byte is found and
will fill with nulls the destination.
|
|
This fixes bug 7474.
|
|
This allows the right hooks to be called in GENSEC when s3compat
implements the auth_ntlmssp interface. Otherwise, we can't do the
signing or sealing as we have not negoitated it's use.
Andrew Bartlett
|
|
It's nicer to have an NTSTATUS return, and in s3compat there may be a
reason other than 'no memory' why this can fail.
Andrew Bartlett
|
|
I hope this helps the next person who needs to debug this.
Andrew Bartlett
|
|
I can't see what would free this, so this should prevent a memory leak.
Andrew Bartlett
|
|
The register_existing_vuid() call will handle both the ntlmssp_end and
vuid invalidation internally, so we don't want to do it again.
Andrew Bartlett
|
|
This is closer to the structure I want for a common struct
auth_usersupplied_info.
Andrew Bartlett
|