summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2011-03-05s3:registry: fix invalid write in iconvert_talloc()Michael Adam1-2/+5
For a non-preallocated dest-string and sourcestring of len < 2, (one or both of the) final two two zero-bytes would be written after the end of the allocated dest-string. The sourcelen did not include the source string terminator. For longer strings, this was not a problem because the dest-string would have been reallocated in the convert-loop. This is fixed now by allocating two extra bytes for the terminating 0-bytes that are needed anyways in the initial allocation. Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
2011-03-05s3:test: correctly react to each failing step in the net registry roundtrip ↵Michael Adam1-0/+29
tests
2011-03-05s3:test: improve logging in the net registry roundtrip test stepsMichael Adam1-1/+7
2011-03-04s3: add two missing vfs disconnect callsDavid Disseldorp1-0/+2
The fix for bug 7976 added a vfs connect call to create_conn_struct. This change adds two further disconnect calls that were missed by the original change. Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Fri Mar 4 16:33:53 CET 2011 on sn-devel-104
2011-03-04s3-printing: fix cups pcap reload with no printersDavid Disseldorp1-12/+27
cups_async_callback() is called to receive new printcap data from a child process which requests the information from cupsd. Newly received printcap information is stored in a temporary printcap cache (tmp_pcap_cache). Once the child process closes the printcap IPC file descriptor, the system printcap cache is replaced with the newly populated tmp_pcap_cache, however this only occurs if tmp_pcap_cache is non null (has at least one printer). If the printcap cache is empty, which is the case when cups is not exporting any printers, the printcap cache is not replaced resulting in stale data. https://bugzilla.samba.org/show_bug.cgi?id=7915 Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-04s3-printing: remove unneeded local_pcap_copy globalDavid Disseldorp1-36/+18
The cups local_pcap_copy global served as a temporary buffer during asynchronous cups printcap cache updates, as well as indicating when the printcap cache had not yet been filled and printcap cache update should block. As smbd printcap reads are now triggered by the parent smbd following printcap cache update, the variable and blocking mechanism are no longer needed. Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-04s3-printing: follow force user/group for driver IODavid Disseldorp3-57/+118
Configuring force user/group settings for the print$ share currently has unexpected results, this is explained by how the driver upload/add process takes place. Consider the following example: [print$] path = /print-drv write list = $DRIVER_UPLOAD_USER force group = ntadmin - the client connects to the [print$] share and uploads all driver files to the /print-drv/W32X86 directory. - This is permitted, as /print-drv/W32X86 is owned by group ntadmin, and the "force group = ntadmin" takes effect for the [print$] session. - Once all files are uploaded, the client connects to the [ipc$] share and issues an AddPrinterDriverEx spoolss request. - In handling this request move_driver_to_download_area() is called, which attempts to create the directory /print-drv/W32X86/3 - The create directory fails, as it is done as the user connected to the [ipc$] share which does not have permission to write to the driver directory. The [print$] "force group = ntadmin" has no effect. This is a regression from previous behaviour prior to the commit: 783ab04 Convert move_driver_to_download_area to use create_conn_struct. https://bugzilla.samba.org/show_bug.cgi?id=7921 Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-04s3-waf: add wildcard commands from main wscript.Günther Deschner1-1/+11
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Fri Mar 4 02:11:11 CET 2011 on sn-devel-104
2011-03-04s3-nterr: use strcasecmp in nt_status_string_to_code().Günther Deschner1-1/+2
Guenther
2011-03-04s3-nterr: within nt_errstr() compare codes using NT_STATUS_V().Günther Deschner1-1/+2
This is to avoid future very special NT_STATUS_EQUAL semantics within s4. Guenther
2011-03-04nterr: make sure both nt_err_desc structs are the same.Günther Deschner1-0/+3
Guenther
2011-03-04nterr: make sure both nt_errs structs are the same.Günther Deschner1-4/+16
Guenther
2011-03-04s3-nterr: make nt_err_desc static const.Günther Deschner1-1/+1
Guenther
2011-03-04nterr: remove space indents (use tabs instead), following coding standards.Günther Deschner1-12/+12
Guenther
2011-03-04nterr: remove trailing whitespace.Günther Deschner1-15/+15
Guenther
2011-03-04s3-waf: add check for SEEKDIR_RETURNS_VOID.Günther Deschner1-0/+5
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Fri Mar 4 01:13:54 CET 2011 on sn-devel-104
2011-03-04s3-waf: add check for HAVE_FUNCTION_ATTRIBUTE_DESTRUCTOR.Günther Deschner1-0/+6
Guenther
2011-03-04libreplace: move "struct timespec" checks into libreplace (where timespec is ↵Günther Deschner3-33/+0
already used). Bjoern, Metze, please check. Guenther
2011-03-03s3: Use dom_sid_string_buf in sid_to_fstringVolker Lendecke1-3/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Thu Mar 3 22:56:57 CET 2011 on sn-devel-104
2011-03-03s3: Use dom_sid_string in _lsa_lookup_sids_internalVolker Lendecke1-4/+1
2011-03-03s3: Remove an obsolete commentVolker Lendecke1-3/+1
2011-03-03s3: Fix some nonempty blank linesVolker Lendecke1-3/+3
2011-03-03lib/util: LIBCRYPTO is in common already, so add it to samba-util-common.Günther Deschner1-1/+1
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Mar 3 18:08:30 CET 2011 on sn-devel-104
2011-03-02s3-includes: remove global include of system/readline.h.Günther Deschner1-1/+0
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 2 23:06:17 CET 2011 on sn-devel-104
2011-03-02s3-proto: fix some inline comments.Günther Deschner1-3/+12
Guenther
2011-03-02s3-libds: use already existing ../libds/common/flag_mapping.h header.Günther Deschner5-9/+4
Guenther
2011-03-02s3: Pass the aio_force operation through vfs_gpfsVolker Lendecke1-0/+7
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 2 19:24:27 CET 2011 on sn-devel-104
2011-03-02s3: Ask GPFS for the IS_OFFLINE operationVolker Lendecke1-0/+31
2011-03-02s3: Announce HSM in the gpfs moduleVolker Lendecke1-0/+23
2011-03-02s3: Pass smb_filename through the set_offline vfs opVolker Lendecke8-12/+36
2011-03-02s3: Pass smb_filename through the is_offline vfs opVolker Lendecke8-14/+53
2011-03-02s3: Fix operation names in vfs_full_audit.cVolker Lendecke1-2/+2
2011-03-02s3: Print all flags in "smbclient allinfo"Volker Lendecke1-1/+25
2011-03-02s3:idmap_cache: remove an leftover wip commentMichael Adam1-1/+1
Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Wed Mar 2 14:55:20 CET 2011 on sn-devel-104
2011-03-02s3: adjust loglevel for idmap_cacheGregor Beck1-10/+10
Signed-off-by: Michael Adam <obnox@samba.org>
2011-03-02s3-sessionid: avoid global include of sessionid.hGünther Deschner9-2/+8
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 2 12:58:12 CET 2011 on sn-devel-104
2011-03-02s3-lanman: talk to srvsvc dcerpc server in api_RNetSessionEnum().Günther Deschner1-10/+63
Guenther
2011-03-02s3-server_id: only include server_id where needed.Günther Deschner12-1/+11
Guenther
2011-03-02s3: GPFS can't deal with mangled namesVolker Lendecke1-0/+7
In getrealfilename, avoid calling the GPFS function
2011-03-02s3-printing: vfs_connect prior to driver/dfs IODavid Disseldorp3-10/+29
samba3.posix_s3.rpc.spoolss.driver fails with the xattr_tdb vfs module loaded as a part of make test. The (now checked) create_directory() call in move_driver_to_download_area() fails, uncovering another bug in the printer driver upload code path. move_driver_to_download_area() creates a new conn_struct for manipulating files in [print$]. The VFS layer is plumbed through with the call to create_conn_struct(), however SMB_VFS_CONNECT() is never called. Many vfs modules expect state stored at connect time with SMB_VFS_HANDLE_SET_DATA() to be available on any IO operation and fail if this is not the case. This fix adds a call to SMB_VFS_CONNECT() in create_conn_struct() prior to IO. https://bugzilla.samba.org/show_bug.cgi?id=7976 Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Mar 2 01:16:30 CET 2011 on sn-devel-104
2011-03-02s3-printing: clean up get_correct_cversion error pathsDavid Disseldorp1-18/+16
Remove an unneeded variable and simplify error paths.
2011-03-02s3-printing: fix move_driver_to_download_area() error pathsDavid Disseldorp3-72/+54
WERR_ACCESS_DENIED errors are mapped to WERR_UNKNOWN_PRINTER_DRIVER, resulting in incorrect error messages on Windows clients. move_driver_to_download_area() returns the same error status values to the caller via the *perr argument as well as the return value. The create_directory() call is not checked for error.
2011-03-02s3: remove superfluous debug messages from msg_idmapGregor Beck1-4/+0
Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Wed Mar 2 00:30:41 CET 2011 on sn-devel-104
2011-03-01s3-auth struct security_unix_token replaces UNIX_USER_TOKENAndrew Bartlett11-36/+29
2011-03-01s3-rpc_server Handle session key as a constant bufferAndrew Bartlett1-28/+4
This way, we don't have to check for memory allocation failures. Andrew Bartlett
2011-03-01lib/util: new merged debug systemAndrew Bartlett9-1410/+5
This is the s3 debug system, with a number of changes to tidy it up for common use. The debug class system is simplified by the removal of the ISSET table, the system no longer attempts to cope with assignment of DEBUGLEVEL, and the full class table is always available (rather than just DEBUGLEVEL_CLASS[DBCG_ALL]) from startup. It is also no longer confusingly described as a hack, but as the initial table. Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Tue Mar 1 04:32:12 CET 2011 on sn-devel-104
2011-03-01s3-debug Always use C99 true/false rather than True and FalseAndrew Bartlett1-29/+29
This will help with the merge into the common code. Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Tue Mar 1 02:58:55 CET 2011 on sn-devel-104
2011-03-01s3-build __FUNCTION__ is always available, always use itAndrew Bartlett3-5/+5
This avoids duplication between FUNCTION_NAME and __FUNCTION__
2011-03-01lib/util/time: Merge time functions from source3/lib/time.cAndrew Bartlett1-63/+0
2011-02-28Fix compiler warning on casting -1 to uint32.Jeremy Allison1-3/+3
generated by cgit (git 2.34.1) at 2024-07-07 16:14:28 +0000