summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2003-03-10Clobber strings with 0xf1f1f1f1 before writing to them to check bufferMartin Pool1-8/+33
lengths are correct. Attempts to pstrcpy into an fstring or allocated string should fail in developer builds. This builds on abartlet's earlier overflow probe for safe_strcpy, but by clobbering the whole string with a nonzero value is more likely to find overflows on the stack. This is only used in -DDEVELOPER mode. Reviewed by abartlet, tpot. (This used to be commit 8d915e266cd8ccc8b27e9c7ea8e9d003d05f8182)
2003-03-10Include valgrind.h if present on the system.Martin Pool1-0/+5
(This used to be commit 65ba78c6bd4c5ab7ec9bf4d15e4410482e82588d)
2003-03-10Check for valgrind.hMartin Pool1-0/+1
(This used to be commit 0ece70d631bf095bf9c8819180b6c59990159cd0)
2003-03-09Try not to clobber the session request.Andrew Bartlett1-3/+15
(This used to be commit 05cffbee56f0556f550b4d14f3111bd7db972621)
2003-03-09Change the way we sign SMB packets, to a function pointer interface.Andrew Bartlett6-153/+346
The intention is to allow for NTLMSSP and kerberos signing of packets, but for now it's just what I call 'simple' signing. (aka SMB signing per the SNIA spec) Andrew Bartlett (This used to be commit b9cf95c3dc04a45de71fb16e85c1bfbae50e6d8f)
2003-03-09Don't fault on error returns (ptr == 0) for this LSA query.Andrew Bartlett1-10/+13
(for example, query to non-dc) Andrew Bartlett (This used to be commit d1dde5f684652f86e63ac6cfa34ff42a680693de)
2003-03-08This is C, not C++Andrew Bartlett1-4/+4
(This used to be commit 25d210b90b6c0377046d89a1dce7a32f94fd7859)
2003-03-08more on idmapSimo Sorce3-78/+207
two layers structure with - local tdb cache - remote idmap repository compiles (This used to be commit 8fb4e210bc7564ed491d121c20d598ba0bfbddff)
2003-03-08Testparm needs the extra arg to set_local_machine_name() too.Andrew Bartlett1-1/+1
(This used to be commit 30ba31e6355b5dfb902e42d2b5edc71630db2923)
2003-03-08Make sure that the 'remote' machine name can only be set once. For some weirdAndrew Bartlett8-19/+39
reason, during a Win2003 installation, when you select 'domain join' it sends one machine name in the name exchange, and litraly 'machinename' during the NTLMSSP login. Also fix up winbindd's logfile handling, so that it matches smbd and nmbd. (This helps me, by seperating the logs by pid). Andrew Bartlett (This used to be commit afe5a3832f79131fb74461577f1db0e5e8bf4b6d)
2003-03-08Make it clear that this is a fstrcpy().Andrew Bartlett1-2/+2
(This used to be commit c2a266b7b661d319e13982bfdbc3a86e8502b8a4)
2003-03-08Fix typo in earlier fix, caught by Ranjit @ HP.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 13ab94fa73dbaf54da0169bbcf4d027d5c07d207)
2003-03-08some more codeSimo Sorce4-0/+474
(not tested yet) (This used to be commit 0d6cec90c13731827abcbc61974efc993e794003)
2003-03-07initial work for the new idmpa interfaceSimo Sorce2-0/+194
(This used to be commit 8338e74ac4e5f31150c96f459a67e52090dc6013)
2003-03-07Use ERROR_NT, not ERROR_DOS as Andrew Bartlett pointed out.Jeremy Allison3-3/+3
Jeremy. (This used to be commit c0930e6d15eb68f06453d9b67142ccd7fb1370a0)
2003-03-07Add early prototype of cifs mount helper for LinuxSteve French1-0/+389
(This used to be commit b20bcf8d336b4b2079eb42342a96d1fe714709de)
2003-03-07Missed parentheses around complex logic.Jeremy Allison1-1/+2
Jeremy. (This used to be commit e81427c2d69be166afad94bc083e750e8f48fba7)
2003-03-07Patch from Michael Steffens. In his own words :Jeremy Allison1-78/+199
------------------------------------------------------------------------- I think there are basically two problem: 1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, and SMB_ACL_OTHER. The function ensure_canon_entry_valid() is prepared for that, but tries to "guess" values from group or other permissions, respectively, otherwise falling back to minimum r-- for the owner. Even if the owner had full permissions before setting ACL. This is the problem with W2k clients. 2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs. This is ok in a take-ownership situation, but must fail if the file is to be given away. This is the problem with XP clients, trying to transfer ownership of the original file to the temp file. The problem with NT4 clients (no ACEs are transferred to the temp file, thus are lost after moving the temp file to the original name) is a client problem. It simply doesn't attempt to. I have played around with that using posic_acls.c from 3.0 merged into 2.2. As a result I can now present two patches, one for each branch. They basically modify: 1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER as "preserve current value" instead of attempting to build one ourself. The original code is still in, but only as fallback in case current values can't be retrieved. 2. Rearrange set_nt_acl() such that chown is only done before setting ACLs if there is either no change of owning user, or change of owning user is towards the current user. Otherwise chown is done after setting ACLs. It now seems to produce reasonable results. (Well, as far as it can. If NT4 doesn't even try to transfer ACEs, only deliberate use of named default ACEs and/or "force group" or the crystal ball can help :) ------------------------------------------------------------------------- Jeremy. (This used to be commit 8ec20cbae7ca7e685b1a4186d8482c7405915dc3)
2003-03-07Some progress towards gums and tdbsam2Simo Sorce10-286/+1166
genparser works fine, and it is a marvelous tool to store objects in tdb :) (This used to be commit 4c6d461a8572f03cd33cba95500cc837638b732c)
2003-03-07Limit the number of SIDs that may be looked up, in line with existing codeAndrew Bartlett1-0/+5
for name->sid. (This used to be commit 0ebccc0dbeecc10d423529909a2563fbc3bf9857)
2003-03-07safe_strcpy() -> fstrcpy() fix, and a cleanup to how rpcclient calls theAndrew Bartlett2-9/+4
IP address resolving code. (This used to be commit 1f605fe77c56ee2a7838c9f87eedf4bb91ebf688)
2003-03-07Fix noticed by Corny.Bondad@hp.com. Ensure we free up memory on error exit.Jeremy Allison1-0/+3
Jeremy. (This used to be commit 1cbd53dc3cd2d56f5e62d42fed5d589efcecb8f8)
2003-03-07Found at Connectathon, .NET RC1 arranges trans/trans2/nttrans parametersJeremy Allison3-69/+227
differently to W2K, cope with this. Jeremy. (This used to be commit 172f415c9eaa4d310a52794e3dc1a6bc92206ce4)
2003-03-06add #define for the max device name length in a DEVICEMODEGerald Carter3-2/+4
(This used to be commit 21ec2b6ba3ddba6964f6ddb53f8494e4a8b48a83)
2003-03-06Make smbtorture use the same cli_full_connection() framework as the rest ofAndrew Bartlett4-865/+842
Samba. This fixes things like not doing *SMBSERVER etc. Andrew Bartlett (This used to be commit 8863ff863c1da42aa6b8718f315c608d9d9067c6)
2003-03-06more off-by-one safe_strcpy()Andrew Bartlett1-3/+3
(This used to be commit d8d2d5e75503ae2b6532a25e4c9bbcdf20cc60af)
2003-03-06More safe_strcpy() off-by-one bug fixes. (mostly moves to pstrcpy()/fstrcpy())Andrew Bartlett4-30/+30
Andrew Bartlett (This used to be commit 42b5514404bc7e33306c11344c6c934a1f83d295)
2003-03-06FIXME about crash on failure case.Martin Pool1-2/+5
(This used to be commit a387c4209735f8e4c826cad7cb10c5349b2041ec)
2003-03-05Add *SMBSERVER fallback code to smbtorture ...Richard Sharpe1-3/+17
(This used to be commit 460339db2246b0213252ee34f507eb8e55ecbecb)
2003-03-05Add code to allow us to specify the port to connect on when performingRichard Sharpe1-6/+14
a test ... (This used to be commit 1128a2fb4c16681e669efe605ff7d7161a2f7acd)
2003-03-05Use new configure test to turn on this automated test for correct stringAndrew Bartlett1-1/+1
function usage. Andrew Bartlett (This used to be commit cdc6139a9646b267a9921fc11fa532640a2e4c7f)
2003-03-05A couple more fixes for fstrcpy() into a malloced region. In this case it'sAndrew Bartlett2-5/+5
all perfectly legit - the region is an fstring in length, but might not always be, and it is the last peice of code to fail my automated test. Andrew Bartlett (This used to be commit 762d61b37d053568b6346e249ba7ef594320153a)
2003-03-05Add a test for a useful property of the compiler - we can get link-timeAndrew Bartlett1-0/+18
failures for some compile-time properties this way. Andrew Bartlett (This used to be commit ce618624b7df797e228f8ef0f19820b318c62ae9)
2003-03-05also ignore the autom4te-2.53.cacheAndrew Bartlett1-1/+1
(This used to be commit 243c9c37a53501b96df6286517e03eb09efcc620)
2003-03-05This file has not been maintained for a while - if we really want thisAndrew Bartlett1-3/+0
behaviour we should seperate -g from --enable-developer, and allow developers to also select --enable-debug if they want. Andrew Bartlett (This used to be commit 96d1449c42597ea22c538a004960b26925c641fc)
2003-03-05lp_string: Add note about dodgy StrnCpy use.Martin Pool1-0/+3
(This used to be commit b32ae2d83fd0b4dd2c313cd0727bd276564cec0c)
2003-03-05Use PRINTER_ALL_ACCESS instead of MAXIMUM_ALLOWED_ACCESS in setprinterTim Potter1-1/+1
command. From Ronan Waide <waider@waider.ie>. (This used to be commit 992b5eb4e05fbf99d91d7235b9a002957533f95b)
2003-03-05More const fixes.Jeremy Allison2-3/+3
Jeremy. (This used to be commit 7b945e10a6c636c0b0aabc841803bf44405cb2ae)
2003-03-05Writable string const fixes.Jeremy Allison3-8/+14
Jeremy. (This used to be commit 60b0cfc8a5b6275d3460ebc6bf17d0f08e25b67e)
2003-03-05Connectathon fix. W2K -> W2K over port 445 doing a tconX does the fullJeremy Allison1-7/+2
\\server\share syntax, not just a "share" tconX syntax. This broke interop with a vendor. Jeremy. (This used to be commit 9d7ea5585c873156ede4b56e43a0d4d75077283a)
2003-03-04Fix another 'off by one' bug with safe_strcpy(). It is unclear if the intentAndrew Bartlett1-2/+2
was to limit the string to 31 or 32 characters (excluding the null term), so I've assumed for now that 32 is fine, as this matches current behaviour (well, current behaviour would crash, but anyway...) Jerry: Can you look at this for me? Andrew Bartlett (This used to be commit 6c43327ea2b50820ea4f623c889dc4525d58baa3)
2003-03-03Another pstrcpy() into malloc()ed buffer fix.Andrew Bartlett1-2/+2
Andrew Bartlett (This used to be commit bd0c84d60b703e89081838a7cfa1eb1b4f45ad0a)
2003-03-03Const warning fixes.Jeremy Allison1-2/+2
Jeremy. (This used to be commit 3ad62ebe26d8c6b82f8618eea11d104b3ab0ec18)
2003-03-03dlsym takes a const char *.Jeremy Allison1-1/+1
Jeremy. (This used to be commit ff3827a62b37342b13fd8b4eafd256d91428c02b)
2003-03-03Fix "might be used uninitialised" warnings.Jeremy Allison1-2/+2
Jeremy. (This used to be commit a670b57c563b220c2ede1dac4ce1e9c71c866498)
2003-03-03Do my janitorial duties to encourage others to do so.Richard Sharpe2-7/+8
Fix lingering large offset problems in smbtar etc. (This used to be commit c416eec2f2a38eebfcda5868999d474628037f1e)
2003-03-03* always report ourselves as a Windows 2000 print server (evenGerald Carter1-8/+29
without ADS support) * add "MinorVersion" print server data key and comment on "OSVersion" (This used to be commit 342734e3de71c7dc8e3d24fd66dae58cf647a569)
2003-03-03* CR1868: only send a change notify message if we have somethingGerald Carter2-2/+14
that changed that the client is monitoring. * couple of comments abnout how we need to validate driver names on SetPrinter() and AddPrinter() * up the debug level on some overly verbose dev mode parsing messages (This used to be commit 7377d671e8a95ac2ab0452f564b18b2a098699cb)
2003-03-03Try the PASSWD environment variable if we don't have one from the command line.Andrew Bartlett1-0/+4
(This used to be commit 14d7d8b22993ca7f1c273a7baaccb09c8fa04ef9)
2003-03-03Fixes to the vfs_fake_perms modules - we only need to specify the VFSAndrew Bartlett1-211/+29
functions that we actually modify. Also a better implementation of the stat() and fstat() functions. Andrew Bartlett (This used to be commit 03e74be11cf76167ed211398016274cbaba5847b)