summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r16663: Fix coverity #301, memleak in error path.Jeremy Allison1-1/+1
Jeremy. (This used to be commit dfdb4ce89155dc1528b455252751616cc2c6708c)
2007-10-10r16661: Fix from jason@ncac.gwu.edu for bug #3875,Jeremy Allison2-1/+7
bad cast warning. Jeremy. (This used to be commit d60e6e0abc17361fe180d6723b970552dc377741)
2007-10-10r16656: Fix #3894 and #3895 reported by jason@ncac.gwu.edu.Jeremy Allison1-3/+3
Jeremy. (This used to be commit ddf35ad69201cf9a0aa45ff25e17eddef60d75ad)
2007-10-10r16654: Fix bug #3893 reported by jason@ncac.gwu.edu.Jeremy Allison1-4/+2
Jeremy. (This used to be commit 787539489897e79d43eb1833db6f5969b130c934)
2007-10-10r16652: Fix bug #3891 reported by jason@ncac.gwu.edu.Jeremy Allison1-4/+1
Jeremy. (This used to be commit 9b0df8d008bc5574526d68628f351eb4dbf98e8a)
2007-10-10r16650: Fix bug #3890 reported by jason@ncac.gwu.edu.Jeremy Allison1-3/+7
Jeremy. (This used to be commit 590b58cb507e5a6e459ff0c975beb9056336f233)
2007-10-10r16648: Fix bug #3889 reported by jason@ncac.gwu.edu.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 2eefe9b6f52e64927c0ae23adce111a42d821206)
2007-10-10r16646: Fix bug #3888 reported by Jason Mader <jason@ncac.gwu.edu>.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 433d7a1bc91ff479934a256ff84e6866e16d1f85)
2007-10-10r16644: Fix bug #3887 reported by jason@ncac.gwu.eduJeremy Allison12-34/+36
by converting the lookup_XX functions to correctly return SID_NAME_TYPE enums. Jeremy. (This used to be commit ee2b2d96b60c668e37592c79e86c2fd851e15f69)
2007-10-10r16642: Fix show-stopper bug #3876. Double-free in winsJeremy Allison1-1/+1
server code. Jerry please merge for 3.0.23. Jeremy. (This used to be commit d354b430ff0473764db8ea492a68d10946dadc23)
2007-10-10r16640: Fix bug #3886 reported by jason@ncac.gwu.edu.Jeremy Allison1-3/+0
Jeremy. (This used to be commit 76cc25a37e145fb48a8a81df37e790690b5dceac)
2007-10-10r16638: Fix bug #3885, reported by jason@ncac.gwu.edu. UseJeremy Allison1-1/+1
the correct enumerated type in the macro. Jeremy. (This used to be commit 63ad19f71c6b9474042f4ea9d5859e2849a73da8)
2007-10-10r16636: Fix bug #3884 reported by jason@ncac.gwu.eduJeremy Allison1-18/+9
Jeremy. (This used to be commit 7580eb947cdeb786be00efa5da727e32b28c99d6)
2007-10-10r16634: Fix bug #3883 reported by jason@ncac.gwu.edu.Jeremy Allison1-2/+1
Jeremy. (This used to be commit d04462f1d8cf009985b9112f093306a64689af64)
2007-10-10r16632: Fix bug #3882 reported by jason@ncac.gwu.edu.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 6b39f53e43572fe29fc037a36328387a0b1bb423)
2007-10-10r16630: Fix bug #3881, reported by jason@ncac.gwu.edu.Jeremy Allison1-3/+0
Jeremy. (This used to be commit ec0a47b94c12b64d351ca8e6bdd467578528f3da)
2007-10-10r16628: Fix bug #3880, reported by jason@ncac.gwu.eduJeremy Allison3-12/+12
by ensuring we return the correct enum for sid type, not a uint32. Jeremy. (This used to be commit 98a5e20ff4ceacda65dcc0ce5498ed4ffde520f8)
2007-10-10r16626: Fix bug #3878. Reported by jason@ncac.gwu.edu.Jeremy Allison1-2/+2
Jeremy. (This used to be commit 4c3019eb99d0a18a33ef1fa90d01b9c99c0b25c3)
2007-10-10r16624: Fix bug #3877, reported by jason@ncac.gwu.eduJeremy Allison1-2/+1
Jeremy. (This used to be commit 1f52b8b40619679242da663f5e5e7836d547f0a2)
2007-10-10r16616: Klocwork #2025. Stop null deref. I actually don'tJeremy Allison1-1/+1
think this can happen in real life but the code is too complicated to be sure.... Jerry please merge this for 3.0.23. Jeremy. (This used to be commit 1e5042d4c0d1a0d0a5cfbcb0d47815e1510ee52a)
2007-10-10r16614: Klocwork #2012. memleak on error path.Jeremy Allison1-0/+1
Jeremy. (This used to be commit 58b9adb849854610e7167e8aa02a02bd15b0bf00)
2007-10-10r16612: Klocwork fix #2011. memleak on error path.Jeremy Allison1-6/+11
Jeremy. (This used to be commit b4e9475d2ac65f72cab0d5c8276da27cf1aeb791)
2007-10-10r16610: Subtle one from Klocwork #2076. If multiple flagsJeremy Allison1-0/+3
are set in a winbindd request it might overwrite existing state->response.extra_data.data values without freeing. Jeremy. (This used to be commit 4e7262c81ad2945048cb8d0789af032a05008988)
2007-10-10r16608: Klocwork #2035. Null deref (bit of a stretch... :-).Jeremy Allison1-2/+4
Jeremy. (This used to be commit 7d7a98208b1b514da60486fcbbb7b6d04df4ffac)
2007-10-10r16606: Klocwork #1990. Malloc the correct size.Jeremy Allison1-2/+12
Jeremy. (This used to be commit d1a1c4e092877a6ea0f98eed2a37a96d42c36323)
2007-10-10r16603: Klockwork #2028. Fix null deref on error path.Jeremy Allison1-12/+38
Jeremy. (This used to be commit 067feef34388e93ded8db7fd3b4a6a4b752a3059)
2007-10-10r16601: Klocwork #2038. Fix memleak on error path.Jeremy Allison1-10/+10
Jeremy. (This used to be commit 934dddb2fa9fb60a87c0b0be81db97f2b59c7cb0)
2007-10-10r16599: Make it clear to Klocwork we're not dereferencing. Issue #2026.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 9402bf0d4cc6d04283ed69a6dedac7767df84626)
2007-10-10r16597: Klocwork #2006. Fix possible null deref.Jeremy Allison1-0/+4
Jeremy. (This used to be commit 9b73385d6b90c7806d8ccfc1f2354ede761fad61)
2007-10-10r16595: Klocwork #2067. Fix possible memleak on error exit.Jeremy Allison1-0/+3
Jeremy. (This used to be commit 1d21a3dec9ea061ce900ad1223f7c2a43c064600)
2007-10-10r16593: Make the invarient explicit to Klocwork. Bug #2023.Jeremy Allison1-0/+1
Jeremy. (This used to be commit 720a9172050beb158a25fbb826676ba19cdcef20)
2007-10-10r16591: Belt and braces approach to shut Klocwork up - bug #2001.Jeremy Allison1-1/+1
Jeremy. (This used to be commit d5c1028498de0346b7a35cc132b8081e04e639cc)
2007-10-10r16589: Fix Klocwork #1999. Although it should be impossible toJeremy Allison1-0/+5
get duplicate OID's returned in the oids_out list it is still good programming practice to clear out a malloc'ed string before re-writing it (especially in a loop). Jeremy (This used to be commit ae02c05bfca46eb6a8ba25b124c18a358a759cb5)
2007-10-10r16587: Fix Klocwork #1987. Memleak on reusing x_dbf.Jeremy Allison2-0/+6
Jeremy. (This used to be commit 16b0617cb0f91fbe1ce53dcb601fe5ed9e51bddf)
2007-10-10r16585: Fix Klocwork #1976. Possible null deref.Jeremy Allison1-0/+1
Jeremy. (This used to be commit a912ef0d9724373966e77f9e8928be462de8df4a)
2007-10-10r16582: Fix Klocwork #1997 and all generic class of problemsJeremy Allison6-6/+62
where we don't correctly check the return from memdup. Jeremy. (This used to be commit ce14daf51c7ee2f9c68c77f7f4674e6f0e35c9ca)
2007-10-10r16581: Fix Klocwork #2017. Possible null deref.Jeremy Allison1-0/+5
Jeremy. (This used to be commit 6967fd4cefa84a7b7b5e14467bfa8152907d55c9)
2007-10-10r16579: Fix Klocwork #2016. Possible null deref.Jeremy Allison1-1/+1
Jeremy. (This used to be commit f6d5bae4a105eee1b1d5b1aaa70a675705345d9e)
2007-10-10r16576: Fix Klocwork #2015. Possible null deref.Jeremy Allison1-0/+5
Jeremy. (This used to be commit 9cbfaf62a3c4bb7d2e594e412449506ab0af4063)
2007-10-10r16570: Corrected the copyright notice. I had requested and received permissionChristopher R. Hertel1-3/+3
from my management at the University to release under my own copyright. My mistake for entering the wrong info. (This used to be commit c65ebeb02810fb4039555c55779ec62a4a8de564)
2007-10-10r16554: Sorry, just had to change this. Don't use int whenJeremy Allison1-3/+5
you're passing a BOOL parameter, don't use "clever" code in while statement - make things easier and clearer to understand when triggering something with an if. Jeremy. (This used to be commit b1fc2d8b99e0402c0e8fe954d9f9563dc4dc2812)
2007-10-10r16552: Fix bug 3849.Derrell Lipman2-10/+38
Added a next_token_no_ltrim() function which does not strip leading separator characters. The new function is used only where really necessary, even though it could reasonably be used in many more places, to avoid superfluous code changes. Derrell (This used to be commit d90061aa933f7d8c81973918657dd72cbc88bab5)
2007-10-10r16550: Fix bug 3866. Thanks for the report!Derrell Lipman2-7/+42
Although I've never met a computer or compiler that produced pointers to functions which are a different size than pointers to data, I suppose they probably exist. Assigning a pointer to a function is technically illegal in C anyway. Change casts of the option_value based on the option_name to use of variable argument lists. For binary compatibility, I've maintained but deprecated the old behavior of debug_stderr (which expected to be passed a NULL or non-NULL pointer) and added a new option debug_to_stderr which properly expects a boolean (int) parameter. Derrell (This used to be commit c1b4c510530ca3118d1eccb9615a8cad732c7373)
2007-10-10r16548: Fix bug #3867 reported by jason@ncac.gwu.edu.Jeremy Allison2-16/+17
Jeremy. (This used to be commit 2b8d72f09c6d79d5d41421545b538da573adcd9d)
2007-10-10r16546: Fix bug #3865 reported by jason@ncac.gwu.edu.Jeremy Allison1-10/+10
Jeremy. (This used to be commit be888a3cda637149c3183418c6e721c6fef1b652)
2007-10-10r16544: Fix bug #3864 reported by jason@ncac.gwu.edu.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 16e42b446bea171c3ad848aefaa92c7404aade42)
2007-10-10r16542: Fix #3863, reported by jason@ncac.gwu.eduJeremy Allison2-2/+6
Jeremy. (This used to be commit cde8323fdc4d4ddaa30e8c59bec89dc130fe26a6)
2007-10-10r16541: Fix #3862 reported by jason@ncac.gwu.edu.Jeremy Allison1-3/+0
Jeremy. (This used to be commit 09e11dcb2304eec9656e76c24921c82f4a870914)
2007-10-10r16537: Fix for bug #3858, all files in a directory notJeremy Allison1-6/+7
being deleted when hide unreadable set to true. Here's the scoop. This one is really interesting. The pattern of deleting a directory is to do a findfirst to get the first part of the list, then for each name returned it does a open/set delete on close/close -> thus deleting the file. Then it does a findnext with the last file name THAT IT JUST DELETED ! Now we can handle this in the findnext in the case where hide unreadable is set to false as we look back in our cache of names and just seek to the right point. The bug is actually fixed in the first hunk of this patch - the one that removes the is_visible_file() check after SearchDir returns false. We don't actually need it and in this case it's causing the delete to be aborted because it can't find the name (doh ! it was just deleted). We don't need it as SearchDir is only ever called from findnext, and findnext should only ever be returning names we gave it. The rest of the patch are the debugs I used to find the problem but they're generically useful. Phew - that one took a while to track down..... Jerry, please merge for 3.0.23 final. Jeremy. (This used to be commit cd048cb775f0a8525fc19aa463db07c477521f5b)
2007-10-10r16528: Self-confidence is plummeting. How could one person goofGerald Carter1-1/+1
the same change 3 times...... Fix pam_winbind compilation again. (This used to be commit f3d2bbf0d222794bbb39b51a0f19167c6e8add1a)