Age | Commit message (Collapse) | Author | Files | Lines |
|
assumption that we have one socket everywhere
while doing so I discovered a few bugs!
1) the clientgen session retarget code if used from smbd or nmbd would
cause a crash as it called close_sockets() which closed our main
socket! fixed by removing close_sockets() completely - it is unnecessary
2) the caching in client_addr() and client_name() was bogus - it could
easily get fooled and give the wrong result. fixed.
3) the retarget could could recurse, allowing an easy denial of
service attack on nmbd. fixed.
(This used to be commit 5937ab14d222696e40a3fc6f0e6a536f2d7305d3)
|
|
TNG
out unicode string handling functions need a lot of work
(This used to be commit 707401fc1e697362cdaadcfaac4edc964b80b1a0)
|
|
putmsg() inside their send() doesn't kill swat and the scond is to open /dev/null to replace stdin after we close that
(This used to be commit d35bbe56bc9e3e5896b2ebdf33ff6468a0432e1f)
|
|
it doesn't work, the getprinter level 0 reply is wrong...
J.F.
(This used to be commit a7b09e3e11dc66779ee50524ebe1f6687ec744c6)
|
|
Norbert Püschel <Pueschel.Norbert@Walzbarren-VAW.ne.uunet.de>
Jeremy.
(This used to be commit 5480ecf24bc7c97f25a5a6aee7e24eba7e87a458)
|
|
(This used to be commit 5257ff5d67632922a64266ad2ce5d5a38c701cbc)
|
|
(This used to be commit d9130377b297a7a12e953e11bf5d484d48e772e0)
|
|
handling to printing/printing.c
most of this was just replacing things like fsp->fd_ptr->fd with fsp->fd
the changes in open.c are quite dramatic. Most of it is removing all
the functions that handled the fd multiplexing
(This used to be commit d1827a3648009fd0a0d165055015d9aeda7a1037)
|
|
it in print_open_file()
that removes a lot of special cases in open.c and makes the print
handling code much easier to understand.
there is still lots to do in printing.c, but this at least gets
printing separated from the mainline code
(This used to be commit e064422af335cd791752a2b54a17a13467ace041)
|
|
element in the fsp
pretty mechanical stuff, but it affects lots of files.
(This used to be commit 368b0bc1b122ece18d11854c1506517816a01a82)
|
|
With the new br_lock() code we no longer need the fd multiplexing,
which is great because it was really horrible :)
Moved the dev, inode and delete_on_close elements into the fsp.
A nice side effect is that this has greatly simplified open.c
(This used to be commit c3b61b33272e7b164d3b3ac4777036848c262e93)
|
|
idea is fundamentally flawed anyway and it has been disabled for a
long time.
(This used to be commit 08de67ced40d563ee468f40faa81a88f12a1ecc1)
|
|
printing/lpq_parse.c
getting ready for the new printing backend
(This used to be commit 0ec1072e0143952139be64e8001582eadcc9f60e)
|
|
(This used to be commit 64a3fd2bc5d84494a4aba044dc73ece4ef82dcd5)
|
|
(This used to be commit c0562a02c345c3eb7d9a26b85bef454355023ba3)
|
|
so that errors are returned on memory allocation failure.
Jeremy.
(This used to be commit 9a118cd4a2b03146b341eeffb62144a2d29b574c)
|
|
fixed GetJob.
J.F.
(This used to be commit 3fea49e1d896987c54187cb326607284810fcb0d)
|
|
Went through and fixed up all failure possibilities. If something (malloc,
file open etc.) fails, then this code goes through and cleans up all allocated
resources on exit. This is the equivalent of a C++ destuctor for the allocated
structures. We need code to be written like this to pass purify tests.
Jeremy.
(This used to be commit b260ef7cb1fb2b1e4661cc54eab403eb01fbfc35)
|
|
J.F.
(This used to be commit cef44398f90f670358f2ad430056371d394c7f91)
|
|
wrong in the spoolss case.
fxed a bug in the job notify code (that's the polite answer), the truth is
different: there is a bug in the NT spooler service, including SP6a and
NT2K.
changed the default lpcommand in the LPRNG case.
J.F.
(This used to be commit 396f73c11b29a47650b3243fef0825252a3cef9b)
|
|
problems.
Jeremy.
(This used to be commit a25891f52491a3aed89302704ba24df832aedf0b)
|
|
Jeremy.
(This used to be commit 6c442d68afae4140e28b770343a900b5ce510b4a)
|
|
from returning '.' and '..' in a top level listing of a trans2 directory
scan. NT does return these entries.
Jeremy.
(This used to be commit 7325059a0940909ddd98b32d62423700545ef87e)
|
|
(This used to be commit f249dc041f3f3bdb1adaa41271236ffdb2447475)
|
|
functions that need to access the vuid, it can be obtained from the
current_user global.
Did some whitespace cleanup.
(This used to be commit 738b307bd7053ede369431da7b1349befaa523d9)
|
|
jeremy.
(This used to be commit 58a16e2718e6400fe9f20d61990818f2d146042f)
|
|
Jeremy.
(This used to be commit efbb327ff94aeb4ee18a73b169007dfe8a139b02)
|
|
Jeremy.
(This used to be commit 33aa541e89ebe2e6a7c1808cea6dc7128bdb0587)
|
|
Jeremy.
(This used to be commit 715fa7ea8cf00d72c868bed420c28a29011f53a1)
|
|
(This used to be commit 351b25727e69864f06f363c1fce1ab04f3f2ca77)
|
|
Jeremy.
(This used to be commit 3a39acd3535647b0f28f51eea29573d5cb1eb9be)
|
|
Jeremy.
(This used to be commit c4c06650dd2407919213e5393ae501815a10c4f5)
|
|
(This used to be commit b912fb7dd239ce18a9b2e4ffaf1785d32899dc9f)
|
|
clean or in other situations. That then screws up options I pass to
configure and is generally annoying.
Instead the Makefile now emits a warning if configure needs
rerunning, but doesn't actually run it.
don't re-enable the auto running of configure on pain of death :)
(This used to be commit ea769a280fa85b09463f6bb6e5fc9eaba5641a62)
|
|
to allow successful build.
Jeremy.
(This used to be commit 567713a07c089ab3ebb4c9b96087777de154b601)
|
|
was small enough to pass the SMBtrans max data test we weren't setting the
"more data needed" error. I was fogetting the RPC_HEADER_LEN.... I now
check the correct length (current pdu staging area length). More printer
spool enum stuff works now. This bug does not affect TNG.
Jeremy.
(This used to be commit 1c9d2c016a78b0ed11dc68adeabb709903444837)
|
|
list. This is done by default when interfaces are probed, but if someone
explicitly adds 127.0.0.1 to the interfaces line for smbd, then nmbd would
start to try and register names on it. This was not good :-(.
Jeremy.
(This used to be commit cc3ad825214686ad03dd4176d0c55290d1de6221)
|
|
coredump.
J.F.
(This used to be commit aea47dee7d85310f35309ecfa91d0b87e632a33f)
|
|
files.
A number of memleak fixed
some error return values fixed.
J.F.
(This used to be commit c212fbe009fe556d5329b5d7106159cf21402d82)
|
|
Tomoki AONO <aono@cc.osaka-kyoiku.ac.jp>
(This used to be commit a9b628ebaa90e464366d0284226753f31439af9f)
|
|
(This used to be commit 1ac46c40118fce9443141ce19506d124a873b73d)
|
|
Jeremy.
(This used to be commit 676db02f1cd7cb81c58cbbdd3bc94da17dad5227)
|
|
statement into main function code path.
Jeremy.
(This used to be commit f15ca0d9273d718534ba2fdd2ccd14ab90a95c8b)
|
|
Jeremy.
(This used to be commit 26963f2f8ec923991efecf6ac177fb17e7a924b0)
|
|
the previous definition could result is us overflowing a buffer. The
null termination was always added yet the size returned did not
include the null termination.
the new function takes a BOOL null_terminate, and always returns the
total number of bytes consumed by the string.
(This used to be commit 426c90433396a95033eefcc4af97603abc934221)
|
|
GETDC stuff sorted out
(This used to be commit f6b56ae93e47a54317f2711533ec8208d5cbc8a9)
|
|
nmbd. It does NOT follow the rule that packets to the wins server have
rec_des set (I know that we have postulated this in the past). Please
don't screw with this unless you do careful testing from WinXX
clients.
Luke and I spent a couple of hours today getting this right (it was
wrong in both TNG and HEAD)
(This used to be commit 9eda2e27b74d95975e481d92930ef87de7006919)
|
|
(This used to be commit 1b9077a1d5295bc8522b83ebed2d41d5dbd28a27)
|
|
it clashes with other reload_services definitions.
(This used to be commit affaf9c5411e533a77621574d356e886eea93465)
|
|
multihomed registration we were sending the packet to the wrong host!
We sent it to the person trying to register rather than to the person
who currently holds the name. That means we were not secure and we
could allow two people to register the same name.
Jeremy, you may wish to merge this change into 2.0.X
(This used to be commit 94ca1d1250d12918311a402cc689050ba1d06e24)
|