summaryrefslogtreecommitdiff
path: root/source3
AgeCommit message (Collapse)AuthorFilesLines
2012-04-30passdb: Do not panic in initialize_password_dbChristof Schmitt1-17/+17
A call to initialize_password_db leads to smb_panic in case the backend returns an error. All callers to initialize_password_db check the return value, so this code path should return the status instead of calling smb_panic. Move the call to smb_panic from pdb_get_methods_reload pdb_get_methods to get it out of the initialize code path. This allows printing the proper error message for 'net getlocalsid' which is much nicer than printing the panic stack trace.
2012-04-30s3-auth_samba4: use new_server_id_task() to allocate server id valuesAndrew Bartlett1-6/+27
This is rather than just picking a random number out of the air. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Mon Apr 30 11:29:34 CEST 2012 on sn-devel-104
2012-04-30s3-lib Add a way to allocate the task_id value in server_idAndrew Bartlett3-2/+44
This safely allocates the task_id so that when we have multiple event contexts, they can each have their own messaging context, particularly for the imessaging subsystem under source4. Andrew Bartlett
2012-04-30s4-messaging: Fill in the whole server_id in all use casesAndrew Bartlett1-3/+0
This started per https://bugzilla.samba.org/show_bug.cgi?id=8872#c4 and avoids any possible collision with a different process. We also need to ensure that across a Samba installation on a single node that id.vnn is the same. Samba4 previously used 0, while Samba3 used NONCLUSTER_VNN. When a message is sent between these 'different' nodes, the error NT_STATUS_INVALID_DEVICE_REQUEST is raised. Andrew Bartlett
2012-04-28s3: Remove a SMB_ASSERTVolker Lendecke1-1/+5
Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Sat Apr 28 23:38:45 CEST 2012 on sn-devel-104
2012-04-28s3: Fix bug 8904 -- wbinfo --lookup-sids "" crashes winbindVolker Lendecke1-5/+5
Much of the code further down and up the call chain expects the structures wb_lookupsids returns to be allocated. Do that despite we have nothing to look up.
2012-04-28Add an audit file VFS routine so we can handle auditing with SACLs.Richard Sharpe4-0/+35
Autobuild-User: Richard Sharpe <sharpe@samba.org> Autobuild-Date: Sat Apr 28 08:05:00 CEST 2012 on sn-devel-104
2012-04-27selftest: Add test to ensure that bug #8872 does not come backAndrew Bartlett1-0/+3
The raw.composite test checks that we handle mutliple concurrent connections. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Fri Apr 27 16:25:37 CEST 2012 on sn-devel-104
2012-04-27selftest: Remove silly space before unit test nameAndrew Bartlett1-1/+5
When we have no description, there is no need for a leading space here Andrew Bartlett
2012-04-27s3:winbindd: also try SMB2 when connecting to "IPC$"Stefan Metzmacher1-7/+20
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Apr 27 13:10:15 CEST 2012 on sn-devel-104
2012-04-27s3:libsmb/cli_np_tstream: add support for SMB2Stefan Metzmacher1-41/+190
metze
2012-04-27s3:libsmb/cli_np_tstream: remove unused tstream_cli_np_existing()Stefan Metzmacher2-34/+0
metze
2012-04-27s3:libsmb: add smb2cli_ioctl*Stefan Metzmacher4-0/+360
metze
2012-04-26s3: oplock_timeout is a talloc child of fspVolker Lendecke1-3/+0
Jeremy, I know you like it explicit, but I stumbled across this explicit TALLOC_FREE and asked myself about a potentially wrong talloc hierarchy. Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Thu Apr 26 23:00:03 CEST 2012 on sn-devel-104
2012-04-26s3: Remove code TALLOC_FREE already doesVolker Lendecke1-5/+1
2012-04-26s3: Remove an unused variableVolker Lendecke1-1/+0
Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Thu Apr 26 12:17:14 CEST 2012 on sn-devel-104
2012-04-26selftest: push --target selection into plansmbtorturetestsuiteAndrew Bartlett1-3/+4
2012-04-25s3:registry: replace call to reg_openkey() in reg_createkey() by accesscheck.Michael Adam1-8/+10
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: remove a superfluous fill_subkey_cache() in reg_createkey()Michael Adam1-5/+0
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: use fill_subkey_cache to check exsistence in ↵Michael Adam1-11/+2
regkey_open_onelevel(). Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: let fill_subkey_cache return WERR_BADFILE when the subkey list ↵Michael Adam1-1/+1
could not be loaded WERR_NO_MORE_ITEMS seems inappropriate. Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: convert reg_openkey() to use talloc instead of SMB_STRDUP etcMichael Adam1-15/+12
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry untangle an assignment from the check in regkey_open_onelevel()Michael Adam1-1/+2
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: untangle assignment from check in regkey_open_onelevel()Michael Adam1-1/+2
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: fix seqnum race in regdb_fetch_keys_internalMichael Adam1-3/+22
This prevents race between fetching seqnum and key content. Because there is currently no way to atomically fetch the record along with the seqnum, I use a loop. This is far from optimal and should should ideally be done differently. But for now it fixes the race. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: fix seqnum race in fetch_values_internalMichael Adam1-3/+21
This prevents race between fetching seqnum and key content. Because there is currently no way to atomically fetch the record along with the seqnum, I use a loop. This is far from optimal and should should ideally be done differently. But for now it fixes the race. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: update the seqnum in the subkey cache at the end of ↵Michael Adam1-1/+5
regval_store_keys The purpose is to prevent next reads from going to disk. Note that this will currently only be effective with local tdbs, not with ctdb: For tdb, store and delete bump the seqnum while transaction commit does not. For ctdb, transaction commit bumps the seqnum, while store and delete don't... This needs fixing (in ctdb). Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry:db: update the value container seqnum after storing/deleting to ↵Michael Adam1-1/+22
prevent next read from going to disk if possible Note that this will currently only be effective in the local TDB implementation. For CTDB, this wont work since seqnum currently works differently there (needs fixing): For tdb, store and delete operations bump the db seqnum, while transaction commits don't. For ctdb, the seqnum is bumped by the transaction commit but not by store and delete operations. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: wrap reg_deletekey() into a transactionMichael Adam1-2/+25
This is wrong layering but fixes a race condition. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: wrap reg_createkey() in a transactionMichael Adam1-6/+30
This is wrong layering (calling into regdb_transaction* in the reg_api code) but fixes a potential race. It makes the multi-step create procedure atomic. This should completely be done in the backend. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: untangle assignments from checks in reg_createkey()Michael Adam1-2/+6
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: wrap reg_deletevalue() in a transactionMichael Adam1-4/+30
This is at the wrong layer, but if fixes a race potentially causing data corruption by concurrent access. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: untangle assignment from check in reg_deletevalue()Michael Adam1-1/+2
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: fix race in reg_setvalue that could lead to data corruptionMichael Adam1-6/+33
(there was no lock around fetching the values and storing them) The layering is wrong in that it uses regdb transactions in reg_api Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: untangle assignment from check and add a debugmessage in ↵Michael Adam1-1/+3
reg_setvalue() Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: don't leak the old contents when updating the value cacheMichael Adam1-0/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: fix debug message in regdb_store_values_internal()Michael Adam1-1/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: improve log message in regdb_unpack_values()Michael Adam1-1/+2
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: fix a debug message typoMichael Adam1-1/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: add a new function regval_ctr_value_byname()Michael Adam2-0/+20
This is like regval_ctr_key_exists() but does not return bool, but the regval_blob instead, if found, and NULL if not found. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: rename regval_ctr_key_exists() to regval_ctr_value_exists()Michael Adam3-4/+4
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry:reg_api: fix reg_queryvalue to not fail when values are modified ↵Michael Adam1-1/+45
while it runs Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: make regdb_values_need_update() staticMichael Adam2-2/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: make regdb_subkeys_need_update() staticMichael Adam2-2/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: make regdb_store_values() staticMichael Adam2-2/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: make regdb_fetch_values() staticMichael Adam2-2/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: make regdb_fetch_keys() staticMichael Adam2-2/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: make regdb_store_keys() staticMichael Adam2-2/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: printing backend: use regdb options via ops struct, not directlyMichael Adam1-9/+10
just like the other backends. This is in preparation of making the backend functions private Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: remove usage of reg_objects from net_rpc_printer.cGregor Beck1-131/+71
Signed-off-by: Andreas Schneider <asn@samba.org>